Turns out my first version of D238048 was actually correct. We seem to
get "command" events even for commands not defined in <commandset
id="sourceEditorCommands">.
Differential Revision: https://phabricator.services.mozilla.com/D242692
Ideally we'd get the other builds too, but this is a good starting point for
catching most of the problems that turn up in our builds.
Differential Revision: https://phabricator.services.mozilla.com/D242725
The UI test was intermittently failing when trying to verify the about:compat page content. (repeated engineView checks being done, repeatedly registering and unregistering the sessionLoadedIdlingResource)
- I've restored the **verifyPageContent** function to the original implementation.
- Created separate functions to verify and interact with the web compat page items.
The UI test successfully passed 100x on Firebase ✅
Differential Revision: https://phabricator.services.mozilla.com/D242717
For top-level sites the partitionKey in use differs depending on the
component:
* network cache always uses the partitionedPrincipal having a non-empty
partitionKey even on top-level loads
* cookies and other components use the empty partitionKey for
top-level-loads.
With this patch each component is cleaned with the correct partitionKey
for the component.
Differential Revision: https://phabricator.services.mozilla.com/D239760
This is not easy to test because this doesn't have any effect on
windows, and only startup is affected (so any ui.* pref that I could
tweak to write a reftest will "fix it").
I initially removed it to move it to nsXPLookAndFeel (thus making the
"refresh" and "init" code-paths more similar), but I think I forgot to
add it there, and it's not like it makes a big difference, so just put
it back where it was.
Differential Revision: https://phabricator.services.mozilla.com/D242746
It should be safer to use `onStatusChange` than continuously poll `statuspanel-label`, which is prone to intermittent failures and can be fragile.
Differential Revision: https://phabricator.services.mozilla.com/D242561
In addition to wiring up the progress bar indicator to the task list, the patch also reuses the completedTasks and totalTasks pair to set progress subtitle for the Group, as well as adding the remove checklist button.
Differential Revision: https://phabricator.services.mozilla.com/D242262
The input element wasn't rendered anymore ("Flattening unsafe node"), so build
a document fragment instead of constructing the string for the prompt element.
Instead of adding inline style, we put CSS classes on the elements
for which we add rules in mozilla.css.
The styles are slightly tweaked so we use the colors from the DevTools theme,
and show proper focus indicator.
Differential Revision: https://phabricator.services.mozilla.com/D242525
Instead use the class that are set on the elements to add CSS rules in mozilla.css.
The classes are renamed to make it clear they're for CodeMirror 5.
The style of the element is slightly tweaked to use our theme variables, and we
set proper focus indicator on the search/replace input.
Differential Revision: https://phabricator.services.mozilla.com/D242513
holy smokes so many macOS failures 😭
Looks like we're probably doing something fundamental and wrong on that
platform, and I bet it's easy to fix.
Differential Revision: https://phabricator.services.mozilla.com/D242393
nsXULAlerts already has ClearOnShutdown and calling nsXULAlerts::GetInstance again only makes it immediately freed with nullptr being returned.
Differential Revision: https://phabricator.services.mozilla.com/D242691
This code will soon deal with both scroll anchoring and position anchoring.
Renaming the existing scroll anchoring variable to avoid confusion.
Differential Revision: https://phabricator.services.mozilla.com/D242004
