Commit Graph

1246 Commits

Author SHA1 Message Date
Chris H-C
4f0806c847 Bug 1795136 - Correct sponsoredness detection for top story impressions, clicks r=nanj,thecount
I forgot to transmit the information from the content.

Differential Revision: https://phabricator.services.mozilla.com/D159406
2022-10-14 18:45:45 +00:00
Shane Hughes
3bca8029f7 Bug 1792535 - Responsive position for AboutWelcome top CTA. r=pdahiya
The Sign In button on about:welcome is currently hidden when it would
overlap with the screen. This patch changes the CSS so that instead of
hiding it, we reposition it when it would overlap, aligning it to the
top right of the screen.

Differential Revision: https://phabricator.services.mozilla.com/D158207
2022-10-11 23:55:20 +00:00
Shane Hughes
b3b7aa5626 Bug 1794585 - Fix non-MR top CTA text color. r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D159040
2022-10-11 22:45:57 +00:00
Meg Viar
c349d50364 Bug 1793660 - Allow feature callout to point to elements that are above and to its end r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D158610
2022-10-11 13:25:44 +00:00
Shane Hughes
5f5e071c9e Bug 1792263 - Consolidate prefers-contrast queries in aboutwelcome. r=pdahiya
Also define explicit HCM color rules for headings in the secondary section of
split screens to fulfill minimum contrast guidelines.

Differential Revision: https://phabricator.services.mozilla.com/D158512
2022-10-10 10:44:18 +00:00
Gavin Suntop
f8b59c716a Bug 1790667 - Design tweaks for STP button r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D157505
2022-10-07 17:04:27 +00:00
Shane Hughes
1edb47da1d Bug 1792100 - Increase the top margin on the language mismatch screen. r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D158525
2022-10-06 19:11:43 +00:00
Shane Hughes
f5ac0b9d15 Bug 1792823 - Give MR Onboarding Colorway descriptions a min height. r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D158516
2022-10-05 23:58:59 +00:00
scott
26d7902675 Bug 1793487 - Pocket newtab fixing placeholder images for recent saves r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D158531
2022-10-05 20:20:02 +00:00
Csoregi Natalia
ca10cb1d71 Backed out changeset 39dd7976006b (bug 1793487) for causing newtab failures. CLOSED TREE 2022-10-05 21:07:56 +03:00
scott
c0bd2e12f8 Bug 1793487 - Pocket newtab fixing placeholder images for recent saves r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D158531
2022-10-05 17:23:23 +00:00
negin
1ef998703b Bug 1793401 - [Windows] [New users] The background of the images from the "about:welcome" page is not visible if the "High Contrast Mode" is enabled r=emcminn
Previously using a hard coded value for the background color of the image was not being applied on Windows OS HCM as it was not a system color. Using the same method found [here](https://phabricator.services.mozilla.com/D156719#5142958) to circumvent this so the background color is applied on a Windows OS.

Differential Revision: https://phabricator.services.mozilla.com/D158530
2022-10-05 14:29:02 +00:00
Norisz Fay
ad1ab8d622 Backed out changeset b65e99ab62ad (bug 1790667) for causing node newtab failure CLOSED TREE 2022-10-04 21:34:07 +03:00
Gavin Suntop
d1027148f6 Bug 1790667 - Design tweaks for STP button r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D157505
2022-10-04 18:00:17 +00:00
negin
124dd1b1a1 Bug 1791010 - The backgrounds of the images from the "about:welcome" page are not visible if the "High Contrast Mode" is active r=emcminn
Added high contrast rule for mr background images.

To test this in macOS enable the following:

{F4178464}

and enable a dark theme for firefox

Differential Revision: https://phabricator.services.mozilla.com/D158264
2022-09-28 20:08:33 +00:00
Mark Banner
92309dcd01 Bug 1792344 - Add targeting in ASRouter for distributions. r=Mardak,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D158088
2022-09-27 18:58:57 +00:00
Cristian Tuns
379cbd0e59 Backed out changeset cd3ab0559b8a (bug 1792344) for causing node failures CLOSED TREE 2022-09-27 14:44:13 -04:00
Mark Banner
87cee1d460 Bug 1792344 - Add targeting in ASRouter for distributions. r=Mardak,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D158088
2022-09-27 18:06:46 +00:00
Emily McMinn
26f512bf05 Bug 1790396 - Fixup Feature Callout button CSS for HCM r=aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D158036
2022-09-23 23:59:14 +00:00
negin
bc59648a83 Bug 1791669 - tab pickup onboarding flyout has a ui misalignment r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D157964
2022-09-22 21:29:17 +00:00
Yoen Zhang
e800a9ab3f Bug 1787809 - Secondary button arrow should be inline so responsive shows it more centered r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D156886
2022-09-22 14:46:43 +00:00
scott
554aaaaf6b Bug 1791614 - Pocket newtab adding reader mode links to recent saves. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D157749
2022-09-20 20:08:51 +00:00
Emily McMinn
0763ca6c8b Bug 1790487 - Change Colorways tooltip and aria-label r=aminomancer,fluent-reviewers
I'll wait to land this until next week, so that we're not putting in new strings right at the end of Nightly.

I've tested this with MacOS VoiceOver & NVDA on windows and the behaviour is pretty good. VoiceOver will repeat the colorway group & name a few times which is annoying, but it's an existing problem we haven't found a tidy solution for yet.

Differential Revision: https://phabricator.services.mozilla.com/D157369
2022-09-20 15:12:18 +00:00
Shane Hughes
75546a2dcb Bug 1790655 - Include screen list in AboutWelcome telemetry ping message IDs. r=Mardak
Add a list of screen initials to the message ID strings sent with
AboutWelcomeTelemetry impression pings. Each screen's message ID will
include a string representing the screen ID of each screen in the
message, in addition to information about the screen itself (for
example, `PLSICMG` represents AW_PIN_FIREFOX, AW_LANGUAGE_MISMATCH,
etc). This will support, for example, comparisons of user engagement
between messages with many screens versus messages with few screens.
Also change the screen ID for one screen that was adjacent to another
screen with the same initial, in order to disambiguate them (since both
screens can potentially be removed, currently).

Differential Revision: https://phabricator.services.mozilla.com/D157581
2022-09-17 18:08:52 +00:00
Ed Lee
655ad8b48c Bug 1782944 - The marketplace buttons from the “Get Firefox Klar” modal no longer redirect to the Firefox Klar on App Store/Google Play using de locale and region r=pdahiya
Remove image_overrides custom replacing the QR code for FOCUS message and instead use a separate message for de locale that also configures the links correctly like the KLAR message.

Differential Revision: https://phabricator.services.mozilla.com/D157518
2022-09-16 05:26:14 +00:00
Shane Hughes
2fade3c4d3 Bug 1791088 - Constrain aboutwelcome styles to onboarding-specific elements. r=Mardak
Fix a bug where rules in aboutwelcome.css were applying to Firefox View.

Differential Revision: https://phabricator.services.mozilla.com/D157536
2022-09-16 03:39:05 +00:00
Shane Hughes
2afc0dde2a Bug 1790895 - Make multistage Spotlight dialog background transparent in HCM. r=pdahiya
Fix a bug where a rule for about:welcome was causing the background for
the multistage spotlight dialog to be white in HCM.

Differential Revision: https://phabricator.services.mozilla.com/D157367
2022-09-16 02:00:16 +00:00
Emily McMinn
fd387bec24 Bug 1790594 - Update button label colors for HCM r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D157246
2022-09-16 00:48:31 +00:00
Ed Lee
221b28954c Bug 1790462 - Restore responsive layout to 550px total height r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D157524
2022-09-15 22:24:42 +00:00
Punam Dahiya
e22374b3fb Bug 1790072 - Existing user onboarding colorways screen should select user existing theme intensity r=Mardak
Configure upgrade spotlight with dark variation to persist variation as bold when starting with a dark theme.

Differential Revision: https://phabricator.services.mozilla.com/D157161
2022-09-15 02:42:02 +00:00
scott
ca1c4058a5 Bug 1790856 - Fixing Pocket recent saves id for telemetry. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D157353
2022-09-14 21:35:25 +00:00
Shane Hughes
0eb8741c0b Bug 1790315 - Remove normalize.scss from aboutwelcome.scss. r=emcminn
Just remove the import of normalize.scss from aboutwelcome.scss, without
removing the file itself. Add styles needed to maintain the current
appearance and remove styles that were only necessary because of
normalize.scss.

Differential Revision: https://phabricator.services.mozilla.com/D157224
2022-09-14 20:23:17 +00:00
Nick Alexander
e0bf9e65d7 Bug 1790444 - Allow to localize action title in Toast Notification actions messages. r=barret
Differential Revision: https://phabricator.services.mozilla.com/D157165
2022-09-14 17:47:24 +00:00
negin
bd9a96ff47 Bug 1790474 - Onboarding progress bar: aria-valuetext starts with "step 0 out of %aria-valuemax%" r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D157254
2022-09-14 17:33:09 +00:00
Emily McMinn
e1c346b911 Bug 1787123 - Switch to em instead of px on secondary CTA to maintain text size r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D156575
2022-09-13 17:11:39 +00:00
Barret Rennie
6b4a7f9717 Bug 1784101 - Add targeting for detecting MR2022 holdback study r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D156215
2022-09-12 20:37:17 +00:00
Shane Hughes
3deb6aea98 Bug 1786509 - Fix Spotlight modal overflow scroll behavior. r=pdahiya
Make the dialog frame for Spotlight modal dialogs cover the full window,
prevent the fixed sizing in SubDialog for these dialogs, and vertically
center the dialog relative to its frame. Make the scrollport accommodate
the full Spotlight so it can be scrolled, without wasting any scroll
distance on margins. So, the top margin will shrink with the window,
like the other margins do.

Differential Revision: https://phabricator.services.mozilla.com/D156127
2022-09-10 07:40:14 +00:00
criss
f0ee3574ff Backed out changeset d1823131fc19 (bug 1786509) for causing mochitest failures on browser_modal_resize.js . CLOSED TREE 2022-09-10 08:12:55 +03:00
Shane Hughes
165c9d04bd Bug 1786509 - Fix Spotlight modal overflow scroll behavior. r=pdahiya
Make the dialog frame for Spotlight modal dialogs cover the full window,
prevent the fixed sizing in SubDialog for these dialogs, and vertically
center the dialog relative to its frame. Make the scrollport accommodate
the full Spotlight so it can be scrolled, without wasting any scroll
distance on margins. So, the top margin will shrink with the window,
like the other margins do.

Differential Revision: https://phabricator.services.mozilla.com/D156127
2022-09-10 03:50:16 +00:00
Jason Prickett
d76e44a172 Bug 1786347 - Adding continuous onboarding colorways reminder to firefox view feature callout r=mviar,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D156700
2022-09-09 22:38:11 +00:00
Gavin Suntop
a456fc19a1 Bug 1787521 - Adjust button for newtab save to pocket action r=thecount,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D155995
2022-09-09 17:13:26 +00:00
Chris H-C
03ec4b9f67 Bug 1786612 - Instrument Pocket interactions with events r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D155756
2022-09-07 17:28:36 +00:00
Shane Hughes
652e75d5a7 Bug 1788286 - Fix aboutwelcome secondary CTA appearance in HCM. r=pdahiya
The secondary CTA in Spotlight and AboutWelcome lacks a rule to set a
hover color (probably because outside of HCM, the hover color should be
the same as the base color). This patch adds the needed styles.

Differential Revision: https://phabricator.services.mozilla.com/D156223
2022-09-07 08:04:49 +00:00
hanna alemu
b5e8c2736d Bug 1785926 - MR onboarding colorways screen is always displayed with a random colorway r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D156132
2022-09-02 16:03:12 +00:00
Nick Alexander
665fecfa56 Bug 1787962 - Add launch_url to ToastNotification message surface. r=barret
Everything here is Windows-only for now, since that's the immediate
use case and these implementation details are specific to Windows
native notifications relaunching Firefox when it is not running --
functionality not supported by the other system alert backends at this
time.

This commit adds a `launch_url` parameter to `ToastNotification`.
This should be viewed as the simplest possible "action" that a toast
notification can take when it is clicked, namely navigating to the
given URL.  In the future, we might generalize this to describe more
of the existing actions (like opening settings, snoozing or dismissing
the toast, etc), but for now, this handles my use case.

In addition, this uses `content.tag` as the alert `name`, allowing to
replace existing toast notifications.

Differential Revision: https://phabricator.services.mozilla.com/D155912
2022-09-01 22:48:22 +00:00
scott
0bca9c36bf Bug 1787522 - Pocket newtab limit save to Pocket card hover button to specific regions. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D155771
2022-08-31 21:45:18 +00:00
Meg Viar
248755e275 Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D155524
2022-08-31 16:09:26 +00:00
Emily McMinn
70ed34842d Bug 1776689 - Add assets for MR new user onboarding 50-50 template designs r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D155757
2022-08-31 01:20:27 +00:00
Butkovits Atila
a2ff884367 Backed out changeset 9256826198bb (bug 1776689) for causing failures at browser_parsable_css.js. CLOSED TREE 2022-08-31 03:25:08 +03:00
Emily McMinn
5cc8cd7862 Bug 1776689 - Add assets for MR new user onboarding 50-50 template designs r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D155757
2022-08-30 23:32:33 +00:00