corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
787,250 Commits 1 Branch 0 Tags
81c86b200c45e4f33d42602f849d692458eb872a
Commit Graph

1246 Commits

Author SHA1 Message Date
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
negin
5a8e8520ab Bug 1832855 - Fix up hover styles for text links throughout onboarding & spotlights r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D178237
 2023-05-19 21:22:49 +00:00
Shane Hughes
bac2c296d0 Bug 1833986 - Adjust aboutwelcome multi select transition styles. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D178493
 2023-05-19 16:52:02 +00:00
Shane Hughes
d779f112c6 Bug 1818249 - Add a message property to allow CFRs in Private Browsing. r=omc-reviewers,pdahiya 
Also, because the data collection policy now allows Category 1 and 2
data collection in Private Browsing Mode, these CFRs will record
telemetry in PBM according to the existing CFR policy, which allows
Cat1-3 data for pre-release builds and experiments, and Cat1-2 data for
release builds. PBM windows will be treated in the same way that release
builds treat normal windows. When not enrolled in a CFR experiment, the
PBM window will only collect Cat1-2 data. When enrolled in a CFR
experiment, the PBM window may collect Cat3 data. This patch also adds a
new option to PopupNotifications that allows its usual interaction
probes to be recorded in PBM. That means, outside of an experiment,
pings from a PBM window will look just like pings from a release build
non-PBM window. And inside an experiment, pings from a PBM window will
look just like pings from a non-PBM window in any build. This ensures
that the PBM pings do not intrinsically confer any identifying
information, since their privateness cannot be known with certainty.

Differential Revision: https://phabricator.services.mozilla.com/D174200
 2023-05-18 16:26:49 +00:00
scottdowne
f53be495f8 Bug 1832789 - Pocket newtab card context menu buttons don't show if card is focused. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D178350
 2023-05-17 17:42:23 +00:00
scottdowne
823afcbb67 Bug 1833125 - Pocket newtab onboarding experience dialog small fixes for high contrast modes. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D178094
 2023-05-15 18:36:19 +00:00
scottdowne
272067742c Bug 1832507 - Pocket newtab fixng new markets onboarding dialog telemetry from firing in offscreen preloaded tabs r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D177935
 2023-05-15 13:46:01 +00:00
Barret Rennie
935952aa19 Bug 1832827 - Improve Experimenter error messages for FxMS schemas r=aminomancer 
Previously, when a `TemplatedMessage` was missing a required field, the error
on Experimenter would be that the message's template field was expected to be
`multi`. This happens because the `oneOf` doesn't match `TemplatedMessage` due
to required fields missing, so it infers it must be a `MultiMessage`.

Now instead of using a `oneOf` to match against either a `MultiMessage` or a
`TemplatedMessage`, we use an `if`/`then`/`else`, predicated by the `template`
key so that if `template != "multi"`, the errors will come form the
`TemplatedMessage` definition.

Differential Revision: https://phabricator.services.mozilla.com/D177914
 2023-05-12 15:20:47 +00:00
scottdowne
4b6221125c Bug 1832178 - Pocket newtab international onboarding experience alignment issue r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D177641
 2023-05-10 18:33:07 +00:00
negin
ba615fe519 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-10 13:08:59 +00:00
Narcis Beleuzu
6d06f48e1a Backed out changeset 86f74f61adc0 (bug 1829039) for newtab failure on aboutwelcome.scss 2023-05-10 00:43:26 +03:00
negin
4ca699875e Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 20:22:09 +00:00
Cosmin Sabou
191135a322 Backed out changeset f1e19e0fa144 (bug 1829039) as requested by aminomancer. CLOSED TREE 2023-05-09 20:05:34 +03:00
negin
952dfbc88c Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 16:41:53 +00:00
Mark Banner
0fadbc1ec4 Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D176336
 2023-05-09 16:14:51 +00:00
Shane Hughes
da6cbc353b Bug 1619842 - Remove longhand rule from newtab stylelint config. r=CosminS 
CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D177522
 2023-05-09 16:39:07 +00:00
Shane Hughes
268b8b6c64 Bug 1619842 - Migrate from sass-lint to stylelint. r=omc-reviewers,thecount,emcminn 
Fix a bug where VS Code's eslint integration does not work for the
newtab project because of a conflict caused by sass-lint's eslint
dependency. Switching over to stylelint eliminates that dependency and
generally modernizes our SCSS linting. stylelint doesn't have a 1 to 1
replacement for every sass-lint rule, so a few rules have been changed.

Differential Revision: https://phabricator.services.mozilla.com/D173605
 2023-05-09 15:37:15 +00:00
Norisz Fay
32ae2d7897 Backed out changeset 67d785ab3cb3 (bug 1829039) for causing node-newtab failure on aboutwelcome.scss CLOSED TREE 2023-05-09 17:35:44 +03:00
negin
dd6b50d41e Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 13:46:13 +00:00
Shane Hughes
2c1e31da7b Bug 1829043 - Add actions for AboutWelcome embedded migration wizard. r=pdahiya,mconley 
Add some properties to the migration wizard screen JSON to specify what
action to perform when CTAs inside the embedded migration wizard are
clicked. This lets us advance screens when the cancel or finish button
is clicked, and send telemetry when the start button is clicked. In
theory we could perform any special message actions too, but for now we
only need telemetry and screen navigation.

Differential Revision: https://phabricator.services.mozilla.com/D176358
 2023-05-08 18:23:47 +00:00
Katherine Patenio
f2226c4d20 Bug 1828433 - restore underlines for links in new tab page. r=amy 
This patch restores link underlines in the new tab page, particularly the settings page and discovery stream (top sites, pocket tiles, and recent activity). Only links that had underlines on hover were updated. `text-decoration: none` is added for cards to maintain original styling.

Differential Revision: https://phabricator.services.mozilla.com/D176819
 2023-05-08 16:28:50 +00:00
Cristian Tuns
05c7ba7f52 Backed out changeset 743c4f059b79 (bug 1829039) for causing bc failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE 2023-05-05 19:50:02 -04:00
negin
087c181c62 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-05 19:30:31 +00:00
Stanca Serban
8fc4f98984 Backed out changeset 72f882230f63 (bug 1829039) for causing mochitests failures in browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-05 04:28:52 +03:00
negin
c514f3673d Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
This patch fixes the font size inconsistencies, extra whitespace above title, and lack of transition animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-04 23:32:12 +00:00
Cosmin Sabou
5eecdbf11c Backed out changeset cdaa6a0312f0 (bug 1829039) for causing increase in failures on browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-03 19:40:03 +03:00
negin
717bd31e75 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-03 13:46:47 +00:00
hanna alemu
2ac6135d00 Bug 1816511 - Allow messaging about:welcome users by screen usage r=omc-reviewers,pdahiya,jprickett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D172836
 2023-05-02 13:53:07 +00:00
Punam Dahiya
daa96c9a8e Bug 1823779 - Evaluate screen targeting and update screen state on index change r=Mardak,omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D174044
 2023-04-29 20:10:42 +00:00
Mike Conley
4d8e83d0c3 Bug 1830178 - Rename FXA_SIGNIN_TAB_FLOW message to FXA_SIGNIN_FLOW and allow for signing in via a new window. r=aminomancer,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D176684
 2023-04-28 15:38:24 +00:00
Mike Conley
143026f39c Bug 1829426 - Add a 'welcome back' screen to onboarding for users going through the device migration flow. r=Mardak,fluent-reviewers,flod 
Significant portions of this were written by Shane Hughes <shughes@mozilla.com> -
specifically the parts that move the Firefox Account sign-in flow for tabs into
a SpecialMessageAction, and making AboutWelcomeUtils.handleUserAction return
a Promise.

Differential Revision: https://phabricator.services.mozilla.com/D176453
 2023-04-28 15:38:24 +00:00
Noemi Erli
b2042001fc Backed out 2 changesets (bug 1830178, bug 1829426) for causing failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE 
Backed out changeset 917f6a2ef432 (bug 1830178)
Backed out changeset 47704fa0c047 (bug 1829426)
 2023-04-28 08:19:22 +03:00
Mike Conley
e3bd3985bf Bug 1830178 - Rename FXA_SIGNIN_TAB_FLOW message to FXA_SIGNIN_FLOW and allow for signing in via a new window. r=aminomancer,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D176684
 2023-04-28 03:17:28 +00:00
Mike Conley
a0043ccde6 Bug 1829426 - Add a 'welcome back' screen to onboarding for users going through the device migration flow. r=Mardak,fluent-reviewers,flod 
Significant portions of this were written by Shane Hughes <shughes@mozilla.com> -
specifically the parts that move the Firefox Account sign-in flow for tabs into
a SpecialMessageAction, and making AboutWelcomeUtils.handleUserAction return
a Promise.

Differential Revision: https://phabricator.services.mozilla.com/D176453
 2023-04-28 03:17:28 +00:00
scottdowne
4b486920aa Bug 1812690 - Pocket newtab enabling onboarding experience for new users seeing the Pocket section for the first time. r=gvn,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D174710
 2023-04-25 16:49:25 +00:00
Mike Conley
b0e076cb45 Bug 1828117 - Add a convenient ASRouterTargeting attribute for clients installed via guided device migration from SUMO. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D176185
 2023-04-24 15:38:41 +00:00
Barret Rennie
473c313805 Bug 1823777 - Add checked and unchecked checkbox actions to about:welcome checkboxes r=omc-reviewers,pdahiya 
about:welcome checkboxes can now set an `checkedAction` and an
`uncheckedAction`, which will occur when the checkbox is checked or unchecked,
respectively, and the primary button is clicked.

The old `action` parameter is still supported for backwards compatability, but
`checkedAction` takes precedence.

Differential Revision: https://phabricator.services.mozilla.com/D174192
 2023-04-22 04:40:13 +00:00
scottdowne
de18d8fccf Bug 1812689 - Pocket newtab new regions implementation r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D173853
 2023-04-21 17:57:28 +00:00
Mike Conley
711b1c4d9a Bug 1820640 - Add a card to about:welcome that embeds the Migration Wizard if configured to do so. r=pdahiya,omc-reviewers 
This adds a card to the about:welcome defaults that embeds the new Migration Wizard
if  browser.migrate.content-modal.about-welcome-behavior is set to "embedded".

This requires adding a useEmbeddedMigrationWizard targeting attribute to
ASRouterTargeting.

Differential Revision: https://phabricator.services.mozilla.com/D175945
 2023-04-21 03:18:12 +00:00
Dão Gottwald
995349acbb Bug 1828440 - BuiltInThemes cleanup: remove obsolete findActiveColorwayCollection, isColorwayFromCurrentCollection, isMonochromaticTheme, monochromaticSortIndices. r=amy,willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D175647
 2023-04-19 11:05:28 +00:00
Punam Dahiya
36013464e6 Bug 1827572 - Telemetry impression pings should wait for filtered screens r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D175293
 2023-04-19 06:59:35 +00:00
Cristian Tuns
3b4b9be6e5 Backed out changeset 96f01a59fe31 (bug 1827572) for causing bc failures in /browser_aboutwelcome_multistage_mr.js CLOSED TREE 2023-04-18 09:28:45 -04:00
Punam Dahiya
c646894134 Bug 1827572 - Telemetry impression pings should wait for filtered screens r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D175293
 2023-04-18 05:49:54 +00:00
hanna alemu
306343134d Bug 1825658 - Modify "addon_recommendation" CFR template to support Facebook container experiment r=jprickett,barret 
Differential Revision: https://phabricator.services.mozilla.com/D174844
 2023-04-14 15:36:39 +00:00
William Durand
ad508fc1aa Bug 1828074 - Add new targeting attribute for RTAMO in ASRouter. r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D175463
 2023-04-14 14:11:36 +00:00
Noemi Erli
100160f533 Backed out changeset e054b7d5f984 (bug 1825658) for causing newtab failures CLOSED TREE 2023-04-13 18:36:23 +03:00
hanna alemu
f004fa7c10 Bug 1825658 - Modify "addon_recommendation" CFR template to support Facebook container experiment r=jprickett,barret 
Differential Revision: https://phabricator.services.mozilla.com/D174844
 2023-04-13 15:03:33 +00:00
Emily McMinn
d2fc230432 Bug 1827283 - Wrap image alt-text in Localized r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D175070
 2023-04-11 23:16:44 +00:00
Russell Chan
b653cce8ee Bug 1825063 - Add ability to hide the arrow from the feature callout r=fxview-reviewers,omc-reviewers,aminomancer,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D174342
 2023-04-11 14:01:03 +00:00