corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
787,250 Commits 1 Branch 0 Tags
81c86b200c45e4f33d42602f849d692458eb872a
Commit Graph

315 Commits

Author SHA1 Message Date
Angel_V129
e3be76313a Bug 1788756 - [Themes] Convert browser/theme JSM modules to ESMs. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D157037
 2022-10-04 19:02:24 +00:00
Jason Prickett
b899f0a12e Bug 1788996 - Add telemetry call when feature callout parent doesn't exist r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D157750
 2022-10-04 18:37:02 +00:00
Shane Hughes
a8178cd2f3 Bug 1790819 - Feature callouts: more overflow protection. r=mviar 
Try to keep feature callouts within the viewport if possible. Make some
changes to fix a bug where callouts could overflow ~10px over the
available space before being repositioned, and also fix a minor typo
issue. Choose the backup position with the greatest available space
instead of based on the position's order in the `positions` object.

Differential Revision: https://phabricator.services.mozilla.com/D157688
 2022-10-04 07:56:34 +00:00
Csoregi Natalia
d301388c8f Backed out changeset d91a621a39be (bug 1785853) for multiple failures e.g.browser_setup_state.js CLOSED TREE 2022-10-03 19:48:44 +03:00
Sarah Clements
f13f2edf01 Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster 
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
 2022-10-03 16:07:54 +00:00
Dão Gottwald
474fd7d31f Bug 1792814 - Don't load the home page in hidden tabs such as Firefox View. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D158396
 2022-09-30 20:04:37 +00:00
Shane Hughes
1577034f2f Bug 1791770 - Prevent add-ons from showing Fx View tab. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D158009
 2022-09-26 19:33:52 +00:00
Dan Mosedale
d86e156394 Bug 1791873 - fix FxView sync-setup-container kbd access,r=Gijs 
Backout tabIndex changes that caused the problem and add an integration test.

Differential Revision: https://phabricator.services.mozilla.com/D157988
 2022-09-26 18:43:31 +00:00
Shane Hughes
2e20c34814 Bug 1791649 - Add tests for Firefox View Spotlight promo. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D157756
 2022-09-23 01:32:49 +00:00
Kelly Cochrane
6a3fd20663 Bug 1791707 - Check for tablets when showing Fx View mobile promo r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D157936
 2022-09-22 18:45:53 +00:00
Sam Foster
c222a61eb4 Bug 1791652 - Wait for setup to be hidden before checking for tabs container properties in test. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D157859
 2022-09-21 22:59:24 +00:00
Punam Dahiya
a223d61beb Bug 1790835 - Add Intro Spotlight Modal Screen to Feature Tour r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D157691
 2022-09-20 20:31:36 +00:00
hanna alemu
c326560584 Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D156588
 2022-09-20 19:39:02 +00:00
Sam Foster
51a14bac68 Bug 1787619 - Handle primary password and sync login errors. r=Gijs,markh 
* Show the error state when the Primary Password is locked and the user is signed-in
* Trigger a tab sync when the  user clicks the "try again" button from the setup error step.
  This will also result in an unlock prompt if the primary password is locked.

Differential Revision: https://phabricator.services.mozilla.com/D156360
 2022-09-20 17:58:08 +00:00
Noemi Erli
9a3ab27e92 Backed out changeset 9239a20afb93 (bug 1787619) for causing failures in browser_setup_errors.js CLOSED TREE 2022-09-20 20:07:29 +03:00
Sam Foster
bb6c2d9701 Bug 1787619 - Handle primary password and sync login errors. r=Gijs,markh 
* Show the error state when the Primary Password is locked and the user is signed-in
* Trigger a tab sync when the  user clicks the "try again" button from the setup error step.
  This will also result in an unlock prompt if the primary password is locked.

Differential Revision: https://phabricator.services.mozilla.com/D156360
 2022-09-20 15:49:45 +00:00
Dão Gottwald
308590ef34 Bug 1789022 - Insert tabs opened from Firefox View at the beginning of the tab strip. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D157724
 2022-09-20 13:50:34 +00:00
Cosmin Sabou
4d2a07b5af Backed out changeset 4eed140eab3f (bug 1783684) for causing several bc failures. CLOSED TREE 2022-09-18 20:04:16 +03:00
hanna alemu
bd65360b11 Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D156588
 2022-09-18 16:01:11 +00:00
Sam Foster
a78fec7c03 Bug 1789885 - Show the loading message only when we have no recent synced tabs data and no tab sync has completed yet r=Gijs,markh 
* Remove the synced-tabs-not-ready state and instead make a waitingForTabs boolean the container can check when updating
* Refactor around the maybeUpdateUI so we either pass in a force-update param, or conditionally send
  the notification if the state changes
* Observe 'services.sync.tabs.changed' instead of the pref which gets updated as a side-effect of a
  tab sync
* Check recent tabs via SyncedTabs.jsm in TabsSetupFlowManager and queue up SyncedTabs.syncTabs() and refreshDevices() calls when the user signs in.

Differential Revision: https://phabricator.services.mozilla.com/D156997
 2022-09-15 21:58:43 +00:00
Dan Mosedale
39c12bfdc2 Bug 1790651 - place focus better on feature callout close, r=ayeddi,emcminn 
When the user moves focus outside of a callout popup while it's open, this patch tracks and saves the most recently focused element until the focus moves back to the popup. Once the user exits the callout series, the focus is (visibly) placed back where the user last left it.

Differential Revision: https://phabricator.services.mozilla.com/D157398
 2022-09-15 19:11:19 +00:00
Meg Viar
0096bcb2fa Bug 1790321 - Ensure that the Firefox View feature tour is displayed when users already have tab sync enabled r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D157163
 2022-09-14 21:33:29 +00:00
Shane Hughes
5b7b6ec7d7 Bug 1788754 - Add a primary CTA to the tab pickup message. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D157066
 2022-09-14 19:54:38 +00:00
Jared Hirsch
0ca0f19c16 Bug 1779384 - Persist collapsed state of Firefox View lists r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D156754
 2022-09-14 17:18:35 +00:00
Sarah Clements
e04c7ffb66 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 15:20:01 +00:00
Marian-Vasile Laza
2e7d3531bc Backed out changeset 9bf0a16672ec (bug 1787979) for causing bc failures on browser_sma_click_element.js. CLOSED TREE 2022-09-14 16:45:04 +03:00
Sarah Clements
26d455d485 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 11:24:58 +00:00
Gijs Kruitbosch
d4092a7277 Bug 1790074 - default to showing warning logs only for fxview tabs-setup-manager, r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D157255
 2022-09-14 09:50:59 +00:00
Sandor Molnar
e5de5b30e6 Backed out changeset dd71b6e79551 (bug 1779384) for causing browser-chrome failures in browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js CLOSED TREE 2022-09-14 04:59:04 +03:00
Jared Hirsch
e2d8d3f927 Bug 1779384 - Persist collapsed state of Firefox View lists r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D156754
 2022-09-13 23:18:34 +00:00
Dão Gottwald
662ecc18a6 Bug 1788257 - Hide collection expiry date when a colorway is selected. r=bigiri 
Differential Revision: https://phabricator.services.mozilla.com/D157208
 2022-09-13 19:51:56 +00:00
Niklas Baumgardner
6d0b8eb558 Bug 1789641 - Telemetry enchancements for Firefox View. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D156728
 2022-09-12 20:37:52 +00:00
Emily McMinn
5cf7cfb2e6 Bug 1779427 - Turn on Firefox View feature tour by default r=mviar 
Split out position tests to simplify re-enabling bulk of tests. Fix preference getter leak with weakDoc.

Differential Revision: https://phabricator.services.mozilla.com/D155482
 2022-09-11 15:59:15 +00:00
Shane Hughes
7deb89ce64 Bug 1788764 - Suppress Feature Callouts when feature recommendations are disabled by pref. r=mviar 
Only show Feature Callout messages when the user preference
`browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features`
is enabled (it's enabled by default). This corresponds to the setting
labeled "Recommend features as you browse" in about:preferences.

Differential Revision: https://phabricator.services.mozilla.com/D156357
 2022-09-10 20:35:12 +00:00
negin
07953d5d61 Bug 1786341 - Continous Onboarding - Firefox View: Tab pick up r=mviar,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D155994
 2022-09-09 22:52:53 +00:00
Jason Prickett
d76e44a172 Bug 1786347 - Adding continuous onboarding colorways reminder to firefox view feature callout r=mviar,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D156700
 2022-09-09 22:38:11 +00:00
Mike Conley
ae11f3c9d0 Bug 1785282 - Open 'Choose what to sync' dialog when users click 'Turn sync on in settings' in Firefox View. r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D156578
 2022-09-09 14:26:50 +00:00
Meg Viar
2a8638fb36 Bug 1788231 - Add ability to trigger a button on parent page from Feature Callout CTA and implement for Firefox View: Tab pick up message r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D156203
 2022-09-08 21:50:37 +00:00
Sam Foster
6f44add480 Bug 1784676 - Extract the setup error and sync-disabled tests into their own test files. r=niklas,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D156730
 2022-09-08 19:40:42 +00:00
Mike Conley
1b1c5a94b2 Bug 1786565 - Re-enable testNotificationDotOnMultipleWindows test in browser_notification_dot.js. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D156579
 2022-09-07 12:58:40 +00:00
Dão Gottwald
5709bd7bd4 Bug 1787797 - Let the Firefox View menu item re-add the button to the tabs toolbar if it got previously removed. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D156412
 2022-09-07 12:21:25 +00:00
Andreea Pavel
eb1398daa7 Bug 1784343 - disable browser_feature_callout.js to reduce failure rate r=intermittent-reviewers,MasterWayZ DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D156496
 2022-09-06 00:45:30 +00:00
Gijs Kruitbosch
d38c0659ad Bug 1788813 - do not report spurious telemetry events for the toggling of the recently closed or tab pickup lists as a result of pageload, r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D156370
 2022-09-05 10:39:07 +00:00
Gijs Kruitbosch
6e20818109 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements 
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
 2022-09-04 08:04:09 +00:00
Sandor Molnar
ed37cce0b5 Backed out changeset 08105e2d612c (bug 1785734) for causing browser-chrome failures in browser_keyboard_focus.js CLOSED TREE 2022-09-04 02:27:23 +03:00
Niklas Baumgardner
3141273c56 Bug 1785734 - Add test for keyboard focus in Firefox View. r=ayeddi,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D155253
 2022-09-03 21:42:02 +00:00
Iulian Moraru
5282da4259 Backed out changeset b63ab5a39b53 (bug 1787565) for causing bc failures on browser_recently_closed_tabs.js. CLOSED TREE 2022-09-03 14:09:15 +03:00
Gijs Kruitbosch
8f8fa020b4 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements 
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
 2022-09-03 09:53:55 +00:00
Sam Foster
1bbdf0032f Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r=Gijs 
* Both CEs now extend HTMLDetailsElement
* Keep the title string on the twisty/toggle element
* The whole summary element gets the focus highlight, and is clickable to collapse/expand the associated content
* Maintain the hover behavior on the twisty button to provide a visual cue for collapsibility
* The setup cards will be collapsible in all states, bug 1779384 will ensure we ignore a persisted closed state during sync setup so this content is always initially visible in a new session

Differential Revision: https://phabricator.services.mozilla.com/D155508
 2022-09-02 18:53:21 +00:00
Dão Gottwald
02c7a85d0a Bug 1787973 - Colorway closet entrypoint in Firefox View should show the "new colorways soon" null state if colorway closet nimbus variable is disabled. r=bigiri 
Differential Revision: https://phabricator.services.mozilla.com/D156188
 2022-09-02 14:39:24 +00:00