* Create a sharable module for the core Firefox-View test helpers
* Adjust firefoxview's tests (head.js) to use the helper module
* Adjust messaging-system tests to use the helper module where these helpers were temporarily duplicated
* Adjust newtab tests to use the helper module
Differential Revision: https://phabricator.services.mozilla.com/D167589
Unify the values of "source" and "page" as used in FeatureCallout.sys.mjs:
- Explicitly pass in a value for "page" when instantiating a Feature Callout and use this for the value of "page" when sending Feature Callout telemetry and as the "source" when making calls to `sendTriggerMessage`. This avoids the risk of including non-about: page URLs or PDF file extensions in our telemetry.
- Set the value of "page" in an HTML data attribute that can be accessed for use in about:welcome telemetry for Spotlight and Feature Callouts.
- Update references to the page value previously used as the page/source for telemetry from `about:firefoxview` Feature Callouts from "firefoxview" to "about:firefoxview"
- Pass the token "chrome" when creating a callout from the browser chrome and update references to the source in PDF.js messages' targeting
- Update the page value expected in automated tests as needed
Differential Revision: https://phabricator.services.mozilla.com/D165910
Updated the tab closing prompt logic to use the number of visible tabs open to determine if the prompt should show in Windows and Linux.
Differential Revision: https://phabricator.services.mozilla.com/D162627
* Adds a promise that resolves when the tab-pickup-list is ready
* Use that promise to trigger tab data request for the list when we enter the setup-complete state
* Remove the workarounds for overlapping setup and tabs requests
Differential Revision: https://phabricator.services.mozilla.com/D163750
From what I can tell switching to `withFirefoxView` and opening a new window to run these tests in + closing that window before disabling the theme messed with the timing of these tests in such a way that we started getting that vsync error shown in the logs. I've switched to running all these tests in the same window, which looks good from a couple of try pushes:
https://treeherder.mozilla.org/jobs?repo=try&revision=9a5f379ecc48bda08eab67210278b547f558f856https://treeherder.mozilla.org/jobs?repo=try&revision=76b909924455fda54165ffeaa00b3654b4decd09
I'll file a follow up bug to change the default behaviour of `withFirefoxView` is to run tests in the same window, as this has come up before.
Also worth noting that even if this patch lands and fixes the new frequent intermittent we will likely still see the less frequent intermittents that happened prior to the change for Bug 1780441.
Differential Revision: https://phabricator.services.mozilla.com/D162617
The switch to using `withFirefoxView` caused another onboarding prompt to show. After the fx view tabstrip button has been clicked for the 3rd time we display a new message. This wasn't happening before because the pref that controls this is tied to that button click, so didn't get incremented when we were opening about:firefoxview in a new tab.
Differential Revision: https://phabricator.services.mozilla.com/D162427
Changed the aria role from tab to button to fix the VO announcement so that it correctly reports when the Fx View tab is actually selected.
Differential Revision: https://phabricator.services.mozilla.com/D159887
This commit moves the test_keyboard_accessibility task into the
firefoxview_accessibility test file.
Additionally, a shared variable and a cleanup function are moved to
head.js.
The cleanup function is renamed for clarity.
Differential Revision: https://phabricator.services.mozilla.com/D160961
This commit moves the "feature_callout_is_accessible" task to the
"browser_firefoxview_feature_callout_a11y" test.
This change required some additional refactoring as well, moving some
shared selectors and functions to head.js.
The waitForCalloutScreen function was refactored to take full string IDs
as there were multiple implementations of this function that conflicted
with each other.
This waitForCalloutScreen change also caused these tests to use an
explicit ID such as "FEATURE_CALLOUT_1" or
"FIREFOX_VIEW_COLORWAYS_REMINDER".
Differential Revision: https://phabricator.services.mozilla.com/D160957
