Commit Graph

366 Commits

Author SHA1 Message Date
Ava Katushka ava8katushka
688250a426 Bug 1711053 - Open file after download if user clicked on downloading file. r=mtigley,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D118328
2021-07-07 09:13:28 +00:00
Alexandru Michis
fbed18af9a Backed out changeset c204c9f05b2e (bug 1711053) for causing failures in browser_download_opens_on_click.js
CLOSED TREE
2021-07-05 19:22:36 +03:00
Ava Katushka ava8katushka
70dd2b3156 Bug 1709129 - Open downloads panel when new download starts. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D118186
2021-07-05 14:51:03 +00:00
Ava Katushka ava8katushka
8dd4aee5b2 Bug 1711053 - Open file after download if user clicked on downloading file. r=mtigley,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D118328
2021-07-05 14:32:01 +00:00
Harry Twyford
7280cae96e Bug 1705103 - Make browser_image_mimetype_issues.js work with native context menus. r=mac-reviewers,bradwerth
Requesting review from mac-reviewers because these are just boilerplate changes.

Depends on D112039

Differential Revision: https://phabricator.services.mozilla.com/D112040
2021-04-14 17:03:27 +00:00
Molly Howell
73eb6e0897 Bug 1698377 - Treat button-and-view widgets as being in a panel when they overflow off the toolbar. r=Gijs
When a toolbar button overflows out of the toolbar and into the overflow menu,
CustomizableUI continues to report the widget's type as "toolbar". This means
that whether the widget is currently overflowed must be considered in addition
to the widget's type when the panel and toolbar states need different handling.

Differential Revision: https://phabricator.services.mozilla.com/D110718
2021-04-05 18:26:18 +00:00
Mark Striemer
19b80939ec Bug 1694817 - Fix tests that fail with browser.proton.toolbar.enabled r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D107294
2021-03-12 20:01:04 +00:00
Noemi Erli
fb4a7117e5 Backed out changeset 8dd76087ff2b (bug 1694817) for causing failures in browser_UITour.js 2021-03-11 21:56:07 +02:00
Mark Striemer
50f7267722 Bug 1694817 - Fix tests that fail with browser.proton.toolbar.enabled r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D107294
2021-03-11 15:09:21 +00:00
Gijs Kruitbosch
5260727ea1 Bug 1696793 - improve close and multiple dialog handling for window-modal dialogs, r=mtigley
The html:dialog event can respond to [esc] keypresses itself. In that case,
we need to close the embedded dialog ourselves, or the UI ends up broken.

We also need to make sure that if e.g. the opening multiple pages from bookmarks warning is up,
and then the user tries to quit or in some other way opens another dialog, things don't break.
This also applies to tests that repeatedly invoke dialogs, where we need to wait for both
the SubDialog instance and the wrapping html:dialog element to agree on their state.

Differential Revision: https://phabricator.services.mozilla.com/D107463
2021-03-11 11:34:35 +00:00
Marco Bonardo
d78c66268b Bug 1693436 - RequestLongerTimeout in browser_pdfjs_preview.js to avoid failing in ccov. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D106512
2021-02-25 20:37:47 +00:00
Daisuke Akatsuka
46c5bd7203 Bug 1678618: Apply page-removed event. r=mak
Depends on D101114

Differential Revision: https://phabricator.services.mozilla.com/D101115
2021-02-15 08:04:15 +00:00
Csoregi Natalia
9ef5ee3b2c Backed out 4 changesets (bug 1678618) for node failures. CLOSED TREE
Backed out changeset e714440f6c0d (bug 1678618)
Backed out changeset ae83fda183dd (bug 1678618)
Backed out changeset bef0ea72ded8 (bug 1678618)
Backed out changeset ec96259a3f81 (bug 1678618)
2021-02-15 05:49:54 +02:00
Daisuke Akatsuka
62240408ac Bug 1678618: Apply page-removed event. r=mak
Depends on D101114

Differential Revision: https://phabricator.services.mozilla.com/D101115
2021-02-15 02:47:38 +00:00
Gijs Kruitbosch
c8446f7798 Bug 1685313 - fix tests to pass with either the new or old window modal dialogs, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D104703
2021-02-12 22:41:54 +00:00
Andreea Pavel
dc95e4ea51 Backed out 3 changesets (bug 1685313) for failing test_prompt.html on a CLOSED TREE
Backed out changeset 7bdcbdc2d57f (bug 1685313)
Backed out changeset 319bc4d7bc0d (bug 1685313)
Backed out changeset 713de42fe3b4 (bug 1685313)
2021-02-12 06:50:58 +02:00
Gijs Kruitbosch
761b707985 Bug 1685313 - fix tests to pass with either the new or old window modal dialogs, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D104703
2021-02-11 23:57:58 +00:00
Yura Zenevich
7c41815519 Bug 1689445 - revert EventUtils.sendMouseEvent back to being sync. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D104127
2021-02-09 01:30:08 +00:00
Mihai Alexandru Michis
b6dbc3ce92 Backed out 2 changesets (bug 1689445) for causing bc failures in browser_search.js
Backed out changeset 2b1ec882c4c1 (bug 1689445)
Backed out changeset bcb4ba398ee0 (bug 1689445)
2021-02-06 05:33:02 +02:00
Yura Zenevich
8ad4b058e3 Bug 1689445 - revert EventUtils.sendMouseEvent back to being sync. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D104127
2021-02-05 21:26:54 +00:00
Yura Zenevich
572aa816e4 Bug 1667998 - converted calls to EventUtils.sendMouseEvent to be async. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D97323
2021-01-15 18:20:44 +00:00
Noemi Erli
df38f3c75c Backed out 5 changesets (bug 1667998) for breaking a11y checks CLOSED TREE
Backed out changeset 633dda979b22 (bug 1667998)
Backed out changeset c9838cdb1303 (bug 1667998)
Backed out changeset 501c54cf59be (bug 1667998)
Backed out changeset 615b74c822ec (bug 1667998)
Backed out changeset 6d187c01fcb3 (bug 1667998)
2021-01-15 20:16:06 +02:00
Yura Zenevich
0b56491817 Bug 1667998 - converted calls to EventUtils.sendMouseEvent to be async. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D97323
2021-01-15 16:53:43 +00:00
tanner drake
4edddefa63 Bug 1673129: Prevent all downloads view from scrolling when toggling download resume pause state. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D101766
2021-01-15 15:08:58 +00:00
Marco Bonardo
ab463ebaa5 Bug 1684524 - Selecting all downloads after a search should not select excluded downloads. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D101447
2021-01-13 10:57:35 +00:00
Gijs Kruitbosch
abd038ef9f Bug 1684006 - use the temp dir for downloads in uriloader tests, r=mak
This ensures that we don't leave downloads behind in race conditions, and that that
doesn't break future tests.

Differential Revision: https://phabricator.services.mozilla.com/D101041
2021-01-08 17:47:37 +00:00
Csoregi Natalia
33e32a990e Backed out changeset ac1a9dda65ed (bug 1684006) for xpcshell failures on downloads. CLOSED TREE 2021-01-08 18:31:07 +02:00
Gijs Kruitbosch
9d053ac4b1 Bug 1684006 - use the temp dir for downloads in uriloader tests, r=mak
This ensures that we don't leave downloads behind in race conditions, and that that
doesn't break future tests.

Differential Revision: https://phabricator.services.mozilla.com/D101041
2021-01-08 14:30:50 +00:00
Tom Schuster
0bb3affbe3 Bug 1683581 - Don't overwrite valid alternative image file-extensions. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D100235
2020-12-21 12:47:55 +00:00
Sebastian Streich
ef9e395b00 Bug 1676221 - Add UX nits to unblock UI r=ckerschb,Gijs
Show save dialogue
***
Automaticly show Panel On Block
***
Keep Open/Save Dialogue with open panel
***
Keep User choise in downloadsView
***
Add Unblock option to Unblock panel
***
lint
***
add test

Differential Revision: https://phabricator.services.mozilla.com/D96448
2020-12-18 15:30:33 +00:00
Butkovits Atila
8480457d60 Backed out changeset 234ae5cb0ff8 (bug 1676221) for causing leaks. CLOSED TREE 2020-12-17 10:54:31 +02:00
Sebastian Streich
0515cda67b Bug 1676221 - Add UX nits to unblock UI r=ckerschb,Gijs
Show save dialogue
***
Automaticly show Panel On Block
***
Keep Open/Save Dialogue with open panel
***
Keep User choise in downloadsView
***
Add Unblock option to Unblock panel
***
lint
***
add test

Differential Revision: https://phabricator.services.mozilla.com/D96448
2020-12-16 22:55:12 +00:00
Gijs Kruitbosch
5c4c731f32 Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
This changes two bits of Firefox that, together with the mime service, end up
very confused over webp + jpeg.

1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image
mimetype as the content type, it should ignore the URL. It doesn't have full channel
info so it can't really do better anyway. This fixes the context menu's "save image as..."
case.
2) it changes the external helper app service to do a few things slightly differently:
a. If we're told not to get an extension out of a URL, really don't. Don't just get the
   filename and then get it from there anyway...
b. If we've got a suggested filename, and a primary extension for the mimetype,
   and the extension on the file is not one of the known extensions for the mimetype,
   replace it with the primary extension.
This fixes the link case.

It also adds tests for both of these mechanisms as well as "save image as."

Differential Revision: https://phabricator.services.mozilla.com/D92306
2020-10-20 20:35:26 +00:00
Csoregi Natalia
e1f31bf2cf Backed out changeset ff2ad4b3e863 (bug 1667787) for failures on test_nullCharFile.xhtml. CLOSED TREE 2020-10-20 19:24:50 +03:00
Gijs Kruitbosch
993ebad789 Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
This changes two bits of Firefox that, together with the mime service, end up
very confused over webp + jpeg.

1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image
mimetype as the content type, it should ignore the URL. It doesn't have full channel
info so it can't really do better anyway. This fixes the context menu's "save image as..."
case.
2) it changes the external helper app service to do a few things slightly differently:
a. If we're told not to get an extension out of a URL, really don't. Don't just get the
   filename and then get it from there anyway...
b. If we've got a suggested filename, and a primary extension for the mimetype,
   and the extension on the file is not one of the known extensions for the mimetype,
   replace it with the primary extension.
This fixes the link case.

It also adds tests for both of these mechanisms as well as "save image as."

Differential Revision: https://phabricator.services.mozilla.com/D92306
2020-10-20 12:05:10 +00:00
Narcis Beleuzu
b0a4fed533 Backed out changeset 19f174844357 (bug 1667787) for bc failure on browser_bug676619.js . CLOSED TREE 2020-10-20 00:11:01 +03:00
Gijs Kruitbosch
304c70a46b Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
This changes two bits of Firefox that, together with the mime service, end up
very confused over webp + jpeg.

1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image
mimetype as the content type, it should ignore the URL. It doesn't have full channel
info so it can't really do better anyway. This fixes the context menu's "save image as..."
case.
2) it changes the external helper app service to do a few things slightly differently:
a. If we're told not to get an extension out of a URL, really don't. Don't just get the
   filename and then get it from there anyway...
b. If we've got a suggested filename, and a primary extension for the mimetype,
   and the extension on the file is not one of the known extensions for the mimetype,
   replace it with the primary extension.
This fixes the link case.

It also adds tests for both of these mechanisms as well as "save image as."

Differential Revision: https://phabricator.services.mozilla.com/D92306
2020-10-19 16:14:13 +00:00
Narcis Beleuzu
11b143f3d3 Backed out changeset fc8c5c66f081 (bug 1667787) for mochitest failure test_invalidCharFileExtension.xhtml . CLOSED TREE 2020-10-13 17:56:47 +03:00
Gijs Kruitbosch
7096e0a9bd Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
This changes two bits of Firefox that, together with the mime service, end up
very confused over webp + jpeg.

1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image
mimetype as the content type, it should ignore the URL. It doesn't have full channel
info so it can't really do better anyway. This fixes the context menu's "save image as..."
case.
2) it changes the external helper app service to do a few things slightly differently:
a. If we're told not to get an extension out of a URL, really don't. Don't just get the
   filename and then get it from there anyway...
b. If we've got a suggested filename, and a primary extension for the mimetype,
   and the extension on the file is not one of the known extensions for the mimetype,
   replace it with the primary extension.
This fixes the link case.

It also adds tests for both of these mechanisms as well as "save image as."

Differential Revision: https://phabricator.services.mozilla.com/D92306
2020-10-13 14:00:41 +00:00
Denis Palmeiro
013feabc78 Bug 1652126: Re-enable browser_pdfjs_preview.js for asan builds. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D89804
2020-09-11 15:28:20 +00:00
Keefer Rourke
2dfa4ef9d6 Bug 1660015: Add IOUtils to privileged eslint environment configuration r=barret,zombie
This change makes eslint aware of the global IOUtils interface, such that it
may be used without having to access it from the window or otherwise declaring
the global in a special comment on a file-by-file basis.

Differential Revision: https://phabricator.services.mozilla.com/D87612
2020-08-26 15:31:24 +00:00
Razvan Maries
5ae4f53ef9 Backed out 12 changesets (bug 1660328, bug 1660015, bug 1649595, bug 1649596, bug 1649593, bug 1659176, bug 1659839, bug 1659838, bug 1657663, bug 1657647, bug 1655460) for xpcshell perma failures. CLOSED TREE
Backed out changeset ff95badf90e3 (bug 1660328)
Backed out changeset a92f8525ab6f (bug 1659176)
Backed out changeset 8ca05470a0d5 (bug 1659839)
Backed out changeset 5de389b735d3 (bug 1649596)
Backed out changeset 73bdddd96664 (bug 1649595)
Backed out changeset 59800d609b55 (bug 1659838)
Backed out changeset 8aca41723313 (bug 1649593)
Backed out changeset dc0d90b3e135 (bug 1657647)
Backed out changeset e3dd5b6b4fbd (bug 1657663)
Backed out changeset f9c823fa14ba (bug 1657663)
Backed out changeset a5aecc7a6469 (bug 1655460)
Backed out changeset 21b64ef30e12 (bug 1660015)
2020-08-26 06:35:20 +03:00
Keefer Rourke
a2885b953b Bug 1660015: Add IOUtils to privileged eslint environment configuration r=barret,zombie
This change makes eslint aware of the global IOUtils interface, such that it
may be used without having to access it from the window or otherwise declaring
the global in a special comment on a file-by-file basis.

Differential Revision: https://phabricator.services.mozilla.com/D87612
2020-08-24 16:13:01 +00:00
Sebastian Streich
ab0ade1b55 Bug 1656296 - Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs
***

***
Added Better Testing

Differential Revision: https://phabricator.services.mozilla.com/D85439
2020-08-24 15:29:23 +00:00
Cosmin Sabou
91b9b823f3 Backed out changeset 388c153da388 (bug 1656296) for causing default process leaks. CLOSED TREE 2020-08-19 21:58:03 +03:00
Sebastian Streich
e4d6eb9fbd Bug 1656296 - Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs
***

***
Added Better Testing

Differential Revision: https://phabricator.services.mozilla.com/D85439
2020-08-19 17:58:57 +00:00
Narcis Beleuzu
54eb459a55 Backed out changeset 1b7eb33c8ec9 (bug 1656296) for bc failure on browser_test_mixed_content_download.js . CLOSED TREE 2020-08-19 16:39:33 +03:00
Sebastian Streich
8fbbb0aa80 Bug 1656296 - Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs
***

***
Added Better Testing

Differential Revision: https://phabricator.services.mozilla.com/D85439
2020-08-19 12:45:55 +00:00
Adam Gashlin
bed79f9a0a Bug 1639067 part 1 - Open more downloaded file types internally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D86650
2020-08-17 21:24:52 +00:00
Dorel Luca
431b3e2a3a Backed out 4 changesets (bug 1639067) for XPCshell failures in tests/unit/test_getMIMEInfo_pdf.js. CLOSED TREE
Backed out changeset 1e400fafd80b (bug 1639067)
Backed out changeset 7bb3c2ec5c7a (bug 1639067)
Backed out changeset 755fd5771648 (bug 1639067)
Backed out changeset 951e10b7354f (bug 1639067)
2020-08-18 00:18:32 +03:00