Commit Graph

366 Commits

Author SHA1 Message Date
Sebastian Hengst
343879329a Bug 1747478 - Temporarily disable browser_downloads_keynav.js on macOS 11. DONTBUILD
The test started to fail permanently on macOS 11 after the changes in
bug 1742530. Disable the testt until the issue can be resolved after the
holidays.

Differential Revision: https://phabricator.services.mozilla.com/D134687
2021-12-25 22:58:09 +00:00
Neil Deakin
2449372add Bug 1742530, support key and tab navigation within the downloads panel list, r=mak,desktop-theme-reviewers,dao
Cursor up and down navigate between items and the footer, and tab navigates between the list itself, the button for the selected item, and the footer

Differential Revision: https://phabricator.services.mozilla.com/D133433
2021-12-23 17:24:08 +00:00
Cristian Tuns
f85e32fa1c Bug 1743263 - disable browser_download_spam_protection.js on linux64 opt r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D134390
2021-12-23 06:15:08 +00:00
Katherine Patenio
ed0b6f975d Bug 1743226 - improve downloads user experience r=mhowell,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D133805
2021-12-21 16:58:35 +00:00
Anny Gakhokidze
4e73a84e63 Bug 1721217 - Part 3: Fix tests that try to open URIs for download, r=nika,preferences-reviewers
Previously, the tests were waiting for the load event, which was being emitted
for the initial about:blank. With the pref enabled, this event is no longer
propagated/fired to the content process. Instead of notifying the content
process that it needs to emit a load event for about:blank, we can instead make
the tests wait for a STATE_STOP event.

Differential Revision: https://phabricator.services.mozilla.com/D126843
2021-12-16 22:27:16 +00:00
Molly Howell
de8bdb4b40 Bug 1741441 - When the download panel is opened, focus the first item. r=Gijs
As suggested by :jamie, this patch causes focus to move to the item at the top of the list whenever the download panel is shown. In the event that the download panel is opened automatically because a new download has been started, this will have the effect of always bringing the new download directly to the attention of accessibility tools (because the panel itself also receives focus).

Differential Revision: https://phabricator.services.mozilla.com/D133160
2021-12-14 17:48:06 +00:00
Barret Rennie
63f941e34d Bug 1745349 - Remove OS getter from browser/components/downloads tests r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D133461
2021-12-10 13:23:54 +00:00
Bernard Igiri
5099419211 Bug 1733621 - Verify that user preferences are honored when improvements_to_download_panel is set r=Gijs
Added unit tests to verify that various file types and header configurations follow the mime preferredAction settings correctly when improvements_to_download_panel is set.

Differential Revision: https://phabricator.services.mozilla.com/D127759
2021-12-09 14:47:17 +00:00
Katherine Patenio
7e91fcdaf6 Bug 1740840 - use mimeinfo content type to fix downloads intermittent alwaysOpenSimilarFiles. r=Gijs,mtigley
Patch addresses intermittent issue with the context menu item alwaysOpenSimilarFiles for the Downloads Panel by using the content type provided by MimeService, rather than relying on download instance. Not only does this ensure that content type exists, but it happens to also have the benefit of making alwaysOpenSimilarFiles available to more file types that can be supported. browser_downloads_panel_context_menu.js was modified to register mimeInfo and add more test cases for visibility with application/octet-stream.

Differential Revision: https://phabricator.services.mozilla.com/D131881
2021-12-01 17:40:00 +00:00
Narcis Beleuzu
6e9d812757 Backed out 12 changesets (bug 1721217) for bc failures on browser_TopLevelNavigationDelegate.js
Backed out changeset 5fe3c617d521 (bug 1721217)
Backed out changeset c131e4a6d9d5 (bug 1721217)
Backed out changeset a59210a5b400 (bug 1721217)
Backed out changeset 74362b0c39c0 (bug 1721217)
Backed out changeset c8075b91d660 (bug 1721217)
Backed out changeset 46512deaf0e5 (bug 1721217)
Backed out changeset b38bc569d227 (bug 1721217)
Backed out changeset ee9bd012fda8 (bug 1721217)
Backed out changeset 7aa2726a0982 (bug 1721217)
Backed out changeset 885ced5f4bb4 (bug 1721217)
Backed out changeset 7d3f99ca3f44 (bug 1721217)
Backed out changeset 2f5a0164679a (bug 1721217)
2021-12-01 03:38:10 +02:00
Anny Gakhokidze
ca0f41d831 Bug 1721217 - Part 3: Fix tests that try to open URIs for download, r=nika,preferences-reviewers
Previously, the tests were waiting for the load event, which was being emitted
for the initial about:blank. With the pref enabled, this event is no longer
propagated/fired to the content process. Instead of notifying the content
process that it needs to emit a load event for about:blank, we can instead make
the tests wait for a STATE_STOP event.

Differential Revision: https://phabricator.services.mozilla.com/D126843
2021-11-30 16:31:35 +00:00
Micah Tigley
d3f7dd0517 Bug 1739145 - Create the DownloadSpamProtection module when needed. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D132178
2021-11-26 22:58:01 +00:00
Butkovits Atila
b29a00171e Backed out changeset 0b1c2e4169ab (bug 1739145) for causing failures at browser_download_spam_protection.js. CLOSED TREE 2021-11-26 19:10:38 +02:00
Micah Tigley
31a8b06dc7 Bug 1739145 - Create the DownloadSpamProtection module when needed. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D132178
2021-11-26 16:35:11 +00:00
Narcis Beleuzu
96c4882d22 Backed out 11 changesets (bug 1721217) for bc failures on browser_scrollPositions.js . CLOSED TREE
Backed out changeset 750f4a84b30e (bug 1721217)
Backed out changeset c4eb4ad769ad (bug 1721217)
Backed out changeset 81af11d67439 (bug 1721217)
Backed out changeset 548f2441b7c6 (bug 1721217)
Backed out changeset cd584129321a (bug 1721217)
Backed out changeset f5f5291d1da8 (bug 1721217)
Backed out changeset 9ad66ceec1e2 (bug 1721217)
Backed out changeset 10b53a21bb23 (bug 1721217)
Backed out changeset 3755cfbe22fe (bug 1721217)
Backed out changeset 71436dc6c4c4 (bug 1721217)
Backed out changeset ecf33b73ae60 (bug 1721217)
2021-11-26 01:51:03 +02:00
Anny Gakhokidze
e7c848eda4 Bug 1721217 - Part 3: Fix tests that try to open URIs for download, r=nika,preferences-reviewers
Previously, the tests were waiting for the load event, which was being emitted
for the initial about:blank. With the pref enabled, this event is no longer
propagated/fired to the content process. Instead of notifying the content
process that it needs to emit a load event for about:blank, we can instead make
the tests wait for a STATE_STOP event.

Differential Revision: https://phabricator.services.mozilla.com/D126843
2021-11-25 20:40:57 +00:00
Ava Katushka ava8katushka
69c0056122 Bug 1725354 - Download panel shows blocked download item. r=mtigley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D123943
2021-11-23 17:13:39 +00:00
Molly Howell
a9d0247475 Bug 1738372 - Add a pref to control whether the downloads panel opens on every new download. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D130931
2021-11-17 00:17:40 +00:00
Marian-Vasile Laza
7a330a71ce Backed out changeset 50ad5f64e5ba (bug 1738372) for causing bc failures on browser_downloads_panel_opens.js. 2021-11-16 02:50:05 +02:00
Molly Howell
dae847d8b3 Bug 1738372 - Add a pref to control whether the downloads panel opens on every new download. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D130931
2021-11-16 00:03:27 +00:00
Narcis Beleuzu
b8863df7b0 Backed out changeset a9a15832f816 (bug 1725354) for bc failures on browser_download_privatebrowsing.js 2021-11-05 23:22:42 +02:00
Ava Katushka ava8katushka
cc523e31bb Bug 1725354 - Download panel shows blocked download item. r=mtigley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D123943
2021-11-05 20:12:43 +00:00
raquelvargas
5fa50e2698 Bug 1738245 - Remove OS.File usage from various browser/ tests. r=Standard8,robwu
Differential Revision: https://phabricator.services.mozilla.com/D129972
2021-11-05 16:49:48 +00:00
Cristian Tuns
a4c3a9bab0 Backed out changeset b855af57f71a (bug 1725354) for causing mochitest failures on test_third_party_iframes.html CLOSED TREE 2021-11-03 12:45:48 -04:00
Ava Katushka ava8katushka
3ed44717ab Bug 1725354 - Download panel shows blocked download item. r=mtigley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D123943
2021-11-03 15:31:13 +00:00
Marian-Vasile Laza
88c0f2b93d Backed out changeset a045ce98e572 (bug 1738245) for causing xpcshell failures on test_MigrationUtils_timedRetry.js. CLOSED TREE 2021-11-03 17:17:12 +02:00
raquelvargas
92388a5506 Bug 1738245 - Remove OS.File usage from various browser/ tests. r=Standard8,robwu
Differential Revision: https://phabricator.services.mozilla.com/D129972
2021-11-03 08:05:31 +00:00
Miriam Onuoha
b163f7bf3c Bug 1737306 - Remove osfile.jsm usage from browser/components/downloads/test/. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D129580
2021-10-27 18:53:14 +00:00
Katherine Patenio
78d2b57bcc Bug 1731086 - Add a new context menu item for setting the mimetype entry from about:preferences. r=mtigley,fluent-reviewers,jaws,flod
Differential Revision: https://phabricator.services.mozilla.com/D127592
2021-10-21 16:28:42 +00:00
Joel Maher
f72bcee13e Bug 1727943 - turn on mochitest* tests that were skipped on win10-ccov and now pass. r=MasterWayZ
Differential Revision: https://phabricator.services.mozilla.com/D128817
2021-10-19 20:01:29 +00:00
Michelle Goossens
575ccf89a0 Bug 1727943 - Part 2: Migrate mochitest, reftest and crashtest Windows 10 ccov suites from AWS to Azure r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D125350
2021-09-28 15:27:39 +00:00
Micah Tigley
e12184f7cd Bug 1724319 - Fix remaining failing tests in browser/components/downloads/test/browser. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D125294
2021-09-15 17:36:14 +00:00
Katherine Patenio
6896f31bb1 Bug 1724319 - Fix tests in toolkit/mozapps/downloads/test + browser_first_download_panel.js when download pref enabled. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D125214
2021-09-14 19:45:17 +00:00
criss
40999080b5 Backed out 2 changesets (bug 1724319) for causing failures on browser_download_overwrite.js. CLOSED TREE
Backed out changeset 75a253b872d4 (bug 1724319)
Backed out changeset d0926e8e7148 (bug 1724319)
2021-09-14 18:11:00 +03:00
Micah Tigley
98f5a76f04 Bug 1724319 - Fix remaining failing tests in browser/components/downloads/test/browser. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D125294
2021-09-14 13:50:27 +00:00
Katherine Patenio
1a41c80132 Bug 1724319 - Fix tests in toolkit/mozapps/downloads/test + browser_first_download_panel.js when download pref enabled. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D125214
2021-09-14 13:50:27 +00:00
Geoff Brown
a00c449c2d Bug 1730213 - Explicitly skip tests under browser/ on android; r=ahal
These tests are excluded from android test runs in moz.build. Including
an explicit annotation in each manifest avoids scheduling confusion.
browser-chrome and plain-chrome tests in browser/ are of no concern,
since those test types are never scheduled on android.

Differential Revision: https://phabricator.services.mozilla.com/D125266
2021-09-13 15:22:27 +00:00
Michelle Goossens
5137ce4f5f Bug 1727925 - Part 3: Migrate six more windows10-32 test suites from AWS to Azure r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D124192
2021-09-10 11:51:00 +00:00
Gijs Kruitbosch
4d8cc3825a Bug 1715001 - rehash downloads markup and tighten up spacing inside downloads item, r=mhowell
This addresses a few things:

- it doesn't really make sense to have 2 different badge implementations
  for the library and the panel. Just use the panel one for the library.
- remove the old badge itself
- remove a bunch of old CSS to do with the old badge
- rename the 'new' badge now it isn't new anymore
- share the badge styling between the 'all downloads' view (about:downloads
  and the library) and the downloads panel
- use the downloadMainArea for hover styling of the non-button bit, and
  update the JS to set the downloadHoveringButton class appropriately for
  this new reality.
- tighten up hover styles so we don't get a weird double hover for the
  blocked download case
- tighten up margins of the button, badge and progress meter (see also
  https://bugzilla.mozilla.org/show_bug.cgi?id=1725837). This is also
  helped by the fact that the renaming means we now properly hide the
  badge image when the download isn't blocked; the CSS at
  https://searchfox.org/mozilla-central/rev/a1ab92e0b16631465a946b300493e75be0eacc37/browser/components/downloads/content/downloads.css#44-47
  didn't apply to this badge pre-patch.

Differential Revision: https://phabricator.services.mozilla.com/D123169
2021-09-02 09:18:12 +00:00
Andreea Pavel
815e7fcff8 Bug 1719949 - disable browser_downloads_panel_context_menu.js on win10 not debug r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D123905
2021-09-02 06:07:10 +00:00
Bernard Igiri
791aae885d Bug 1708866 - Adjust padding and minimum size in Download Panel r=desktop-theme-reviewers,dao,jaws
Changed the margin and padding to match the figma mock up. Updated broken test.

Differential Revision: https://phabricator.services.mozilla.com/D123009
2021-08-24 17:53:58 +00:00
Michelle Goossens
cde15eb082 Bug 1723574 - Enable mochitest-browser-chrome tests that no longer fail r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D123247
2021-08-23 12:45:31 +00:00
Michelle Goossens
015f8eeba2 Bug 1723574 - Migrate Windows 10 mochitest-browser-chrome suite from AWS to Azure r=jmaher,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D122511
2021-08-20 20:55:02 +00:00
Ava Katushka ava8katushka
effc31c293 Bug 1718782 - Add telemetry for clicking an in-progress download. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D121857
2021-08-09 20:12:27 +00:00
Sebastian Streich
2a06fcd277 Bug 1722286 - Show Right message on insecure downloads r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121185
2021-07-30 13:16:10 +00:00
Christoph Kerschbaumer
5ee0a6a910 Bug 1719272: Annotate failing browser/ tests to potentially enable https-first mode in Nightly r=webcompat-reviewers,denschub,webdriver-reviewers,preferences-reviewers,Gijs,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D119177
2021-07-28 19:16:16 +00:00
Sandor Molnar
5e383dfda4 Backed out changeset 7eb8945dd8e3 (bug 1719272) for causing bustages in gecko decision task. CLOSED TREE 2021-07-28 19:47:06 +03:00
Christoph Kerschbaumer
8fef13ba13 Bug 1719272: Annotate failing browser/ tests to potentially enable https-first mode in Nightly r=webcompat-reviewers,denschub,webdriver-reviewers,preferences-reviewers,Gijs,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D119177
2021-07-28 16:08:07 +00:00
Ava Katushka ava8katushka
f034da9cb3 Bug 1711053 - Open file after download if user clicked on downloading file. r=mtigley,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D118328
2021-07-09 13:20:29 +00:00
Csoregi Natalia
4db31d3804 Backed out changeset a81a827f54fb (bug 1711053) for failures on browser_download_opens_on_click.js. CLOSED TREE 2021-07-07 13:20:05 +03:00