Commit Graph

600 Commits

Author SHA1 Message Date
Blake Winton
c88c363e3b Bug 1388167 - Unify doorhanger footer styles. ui-r=abenson r=johannh
MozReview-Commit-ID: GGd9sHa2Ga0
2017-08-21 15:49:32 -04:00
Gijs Kruitbosch
32c4aa5540 Bug 1399490 - fix unhiding the downloads button in customize mode if it was moved to the palette, r=nhnt11
MozReview-Commit-ID: 7Q8yPzBVxim
2017-09-13 16:24:13 +01:00
Gijs Kruitbosch
6d7a67d2e5 Bug 1397447 - add UI and automatic toggles to make the auto-hide functionality more seamless, r=mak
MozReview-Commit-ID: 9xN3N4aLwfv
2017-09-11 18:54:48 +01:00
Gijs Kruitbosch
d48e2eaf65 Bug 1397447 - make downloads button autohide by default, r=mak
MozReview-Commit-ID: E9izQpa4fFZ
2017-09-08 14:16:36 +01:00
Zibi Braniecki
424682e3b6 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN
2017-09-09 22:17:19 -07:00
Sebastian Hengst
3a807c09ee Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
8c25be70ea Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN
2017-09-09 22:17:19 -07:00
Sebastian Hengst
1197f950f9 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JSRVc5yW6Kx
2017-09-07 12:39:12 +02:00
Paolo Amadini
7c101fe117 Bug 1387416 - Place the search bar in the customization palette for new profiles. r=Gijs
MozReview-Commit-ID: Tq8YrZWG6P
2017-09-06 13:09:27 +01:00
Zibi Braniecki
58ed110740 Bug 1395871 - Open toolbar menus on mousedown, rather than oncommand.
MozReview-Commit-ID: A3P4QBBgcB8
2017-09-01 01:54:34 -07:00
Mike de Boer
0ba9d2ea57 Bug 1354532 - Part 2 - To facilitate the DownloadsSubview, add a 'LimitedHistoryDownloadsData' and 'LimitedPrivateHistoryDownloadData' dataview. r=Paolo
MozReview-Commit-ID: Jkyj2SQ7F00
2017-09-06 17:16:02 +02:00
Mike de Boer
bc72a05e37 Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl
2017-09-06 16:23:00 +02:00
Sebastian Hengst
2b4cc8b55c Backed out changeset f1d18c741b2c (bug 1354532) for eslint failure at browser/components/downloads/DownloadsCommon.jsm:671: Expected property shorthand. r=backout 2017-09-06 16:48:00 +02:00
Sebastian Hengst
eb87dfe3a7 Backed out changeset 63909748b3ce (bug 1354532) 2017-09-06 16:47:12 +02:00
Mike de Boer
d4875abbf5 Bug 1354532 - Part 2 - To facilitate the DownloadsSubview, add a 'LimitedHistoryDownloadsData' and 'LimitedPrivateHistoryDownloadData' dataview. r=Paolo
MozReview-Commit-ID: Jkyj2SQ7F00
2017-09-06 16:23:06 +02:00
Mike de Boer
6cb3ed2016 Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl
2017-09-06 16:23:00 +02:00
Wes Kocher
08356deb1c Merge m-c to autoland, a=merge
MozReview-Commit-ID: LEKykpTAKjv
2017-08-25 17:32:33 -07:00
Johann Hofmann
5a64d26ebe Bug 1139913 - Downloads with partial data should still keep the placeholder on disk. r=mak
This prevents naming conflicts if a paused or blocked download is retried from the original page.

MozReview-Commit-ID: 4rFZ5rP8saJ
2017-08-25 16:42:45 +01:00
Gijs Kruitbosch
663af591de Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo
MozReview-Commit-ID: FTvFDV5nuG6
2017-08-25 13:32:47 +01:00
Blake Winton
cbe7a23f74 Bug 1384692 - Update the download doorhanger style. ui-r=amylee, r=Paolo.
MozReview-Commit-ID: 4pY9JxnLNYk
2017-08-01 09:18:11 -04:00
Paolo Amadini
f5f47cca11 Bug 1393418 - Fix initialization of the Downloads Indicator on startup. r=mak
MozReview-Commit-ID: GEQZoak5MFl
2017-08-24 13:34:08 +01:00
Gijs Kruitbosch
89a0e2f431 Bug 1371765 - make downloads button non-customizable, r=jaws,Paolo
MozReview-Commit-ID: E9izQpa4fFZ
2017-08-16 15:54:36 +01:00
Paolo Amadini
03576258d2 Bug 1296554 - Show a static progress bar for downloads of unknown size. r=jaws
MozReview-Commit-ID: HgRl7vlTp3Z
2017-08-21 14:52:33 +01:00
Sam Foster
188cda4801 Bug 1388183 - Queue and play the last download notification instead of truncating/aborting it. r=Paolo
* Maintain a _nextNotificationType LIFO "queue" of one, to play overlapping events in series
* _showNotification assumes everything could have changed since it was last called
* Signature of showEventNotification is unchanged, but most of its work is now done in _showNotification

MozReview-Commit-ID: 8sv4DZoZU65
2017-08-11 16:06:02 -07:00
Sebastian Hengst
d73ac6aebe Backed out changeset bf522e33426e (bug 1388183) for eslint failure browser/components/downloads/content/indicator.js. r=backout on a CLOSED TREE 2017-08-17 22:04:54 +02:00
Sam Foster
0d626d6698 Bug 1388183 - Queue and play the last download notification instead of truncating/aborting it. r=Paolo
* Maintain a _nextNotificationType LIFO "queue" of one, to play overlapping events in series
* _showNotification assumes everything could have changed since it was last called
* Signature of showEventNotification is unchanged, but most of its work is now done in _showNotification

MozReview-Commit-ID: 8sv4DZoZU65
2017-08-11 16:06:02 -07:00
Andrew Halberstadt
1ecb0adc26 Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw
2017-08-10 14:48:21 -04:00
Phil Ringnalda
5e91797776 Backed out changeset 6896f93a2327 (bug 1385352) for not making it to m-c before the next violation of its new linting rule merged to autoland
MozReview-Commit-ID: 3HDE2C3wSU0
2017-08-10 20:21:19 -07:00
Wes Kocher
d292002f8c Merge m-c to autoland, a=merge
MozReview-Commit-ID: 2YvHbITn9w3
2017-08-10 18:25:34 -07:00
Kris Maglione
0fb6b2e73c Bug 1388215: Part 3 - Use JIT-friendly defineLazy*Getters methods when defining many lazy imports. r=florian
MozReview-Commit-ID: APoFwUhDFdj
2017-08-09 13:03:36 -07:00
Andrew Halberstadt
6c60ffa524 Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw
2017-08-10 14:48:21 -04:00
Jared Wein
d016c13ec8 Bug 1385913 - Remove MOZ_PHOTON_ANIMATIONS ifdef. r=Gijs
MozReview-Commit-ID: 40TP43EKPCU
2017-08-07 12:37:34 -04:00
Masatoshi Kimura
29a4322fe8 Bug 389565 - Remove nsIExternalProtocolService::LoadUrl. r=Paolo
MozReview-Commit-ID: lMq06cPWYB
2017-08-06 11:25:42 +09:00
Paolo Amadini
d1e1b518d1 Bug 1381411 - Implement the DownloadHistoryList object. r=mak
This also changes the Library window to use the newly added back-end object. The only user-visible change should be how the selection behaves when retrying downloads.

MozReview-Commit-ID: 7CQr1m21rcB
2017-08-04 14:48:53 +01:00
Sam Foster
09681512db Bug 1376519 - Photon download notifications. r=Paolo
* Filmstrip style svg animation for start download notification, vertically centered to allow for variable-height toolbar buttons
* Simultaneous identifer "dip" animation on the icon for download start
* Identifier icon bounce animation for download finish (no notification animation in the #downloads-animation-container)
* Always measure the anchor element as toolbarheight may change in a session (e.g. switching to compact mode)
* Conditionally include the start/finish pngs for non-Photon builds
* Have #downloads-notification-anchor hidden by default, and show it before measuring for placement. This avoids the interference with scrolling/APZ when the notifier element is tall enough to overlap the tabbrowser element

MozReview-Commit-ID: LJF6iV9HiJi
2017-07-31 09:36:27 -07:00
Paolo Amadini
f26759a7e8 Bug 830415 - Part 2 - Move the front-end code that stores download metadata in history to the DownloadHistory module. r=mak
Regression tests will be added in bug 1381411 when methods to retrieve the metadata will be available.

MozReview-Commit-ID: I3MgwM0EOty
2017-07-26 16:12:57 +01:00
Marco Bonardo
40d62d0387 Bug 1275878 - Part 1: move back clear history operations to History.clear(). r=adw
MozReview-Commit-ID: DbEJgKbTxd7
2016-05-17 09:35:45 +02:00
Florian Quèze
e62545f7be Bug 1381853 - lazy load downloads scripts into the browser window, r=mconley. 2017-07-23 00:18:00 +02:00
Paolo Amadini
22d5def704 Bug 1354568 - Show the final file size in the Downloads Panel. r=mak
MozReview-Commit-ID: I9D2yaYpwHD
2017-07-18 15:00:19 +01:00
Paolo Amadini
1a2766e349 Bug 1381409 - Part 3 - Use DownloadList notifications directly in front-end download views. r=mak
The DownloadList object now provides batch notifications directly, in preparation for linking front-end views to other types of download lists without having to use the DownloadsData indirection.

MozReview-Commit-ID: FOTz1YwGRE1
2017-07-17 12:05:12 +01:00
Paolo Amadini
81fd3d7bde Bug 1381409 - Part 2 - Let each view keep the state of downloads relevant to it. r=mak
The front-end download views now maintain the old download state themselves, instead of relying on the DownloadsData object dispatching the onDownloadStateChanged notification.

This allows each view to keep only the state relevant to it, for example the Downloads Panel already keeps the state only for the visible items. This also makes it possible for each view to use a different hash than the one provided by the legacy stateOfDownload method, and allows bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 2D1ixsZCkCa
2017-07-17 12:07:17 +01:00
Paolo Amadini
1907d28bdd Bug 1381409 - Part 1 - Always add Download objects in their original order. r=mak
When a new front-end view is added to the DownloadsData object, the Download objects it contains are loaded into the view starting with the newest, which is the opposite of the order used by the underlying DownloadList.

This was originally implemented as an optimization for the Downloads Panel, at a time when the full list of completed downloads was persisted in the same SQLite database as session downloads. This difference is now unnecessary given the low number of session downloads, and can be removed in preparation for bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 5EBkqvyXFq4
2017-07-16 17:36:00 +01:00
Paolo Amadini
0943598d9f Bug 1357915 - Fix download commands operating on multiple items in the Library window. r=Standard8
This was regressed by bug 1264206 while removing legacy array comprehensions, because selectedItems is a NodeList and not an Array.

MozReview-Commit-ID: 61GG3SiiWwS
2017-07-18 10:19:48 +01:00
Gijs Kruitbosch
2a9b14d9e7 Bug 1369729 - use descriptionheightworkaround for sync panel, r=mconley,Paolo
MozReview-Commit-ID: LQg6NEgCqz2
2017-06-28 17:50:43 +01:00
Sam Foster
cbfdf2d63d Bug 1375309 - Implement Photon download progressbar r=Paolo
* Split out the arrow and progressbar in the indicatorOverlay for individual animation.
* Group icon and progressbar parts into addressable elements in a single download-icons.svg

MozReview-Commit-ID: KAn0gFqjKjc
2017-06-28 15:03:52 -07:00
Blake Kaplan
5ffe1ce19c Bug 1375710 - Remove CPOWs from browser_iframe_gone_mid_download.js. r=Gijs
MozReview-Commit-ID: JUF8Vdx0vsy
2017-05-16 18:58:28 -07:00
Florian Quèze
c0468168f5 Bug 1368456 - remove Promise.jsm imports in tests, r=mconley. 2017-06-23 11:25:52 +02:00
Florian Quèze
b622c2b081 Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Paolo Amadini
7afba17088 Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P
2017-06-19 11:32:37 +01:00
Mark Striemer
afce04b9ce Bug 1369771 - Confirm launch of executables other than .exe on Windows r=Paolo
MozReview-Commit-ID: 2TbLbdMc3d3
2017-05-29 16:38:54 -05:00