Commit Graph

600 Commits

Author SHA1 Message Date
Paolo Amadini
f08ea56f7b Bug 1472635 - Prevent suppressing executable warnings using the "don't ask me this again" checkbox. r=Gijs
A hidden preference matching "browser.download.manager.alertOnEXEOpen" is kept, but is renamed in order to recover cases where the checkbox was used accidentally.

This also cleans up duplicate unused strings in the "browser" folder.

MozReview-Commit-ID: GyccRiyoVGs
2018-07-02 15:42:58 +01:00
Oriol Brufau
2789d3a111 Bug 1452970 - Add auto-hide option to Download toolbar icon context menu r=Gijs
MozReview-Commit-ID: VVPQesdzJ6
2018-04-14 11:26:03 +02:00
shindli
382510a517 Backed out changeset b12b76bbe1c6 (bug 1452970) for TV failures in browser/components/downloads/test/browser/browser_downloads_autohide.js on a CLOSED TREE 2018-05-09 15:16:40 +03:00
Oriol Brufau
cbfb159c61 Bug 1452970 - Add auto-hide option to Download toolbar icon context menu r=Gijs
MozReview-Commit-ID: VVPQesdzJ6
2018-04-14 11:26:03 +02:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Kris Maglione
b3990a2d91 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW
2018-04-24 20:18:09 -07:00
Mike de Boer
15e60d9e71 Bug 1034036 - Part 2: Rename and shorten getMostRecentBrowserWindow to getTopWindow and modernize the style used in BrowserWindowTracker.jsm. r=dao
MozReview-Commit-ID: EvgAhq4uR3a
2018-04-11 12:05:59 +02:00
Mike de Boer
2271d50b55 Bug 1034036 - Part 1: Merge RecentWindow.jsm and UpdateTopLevelContentWindowIDHelper.jsm into one module called 'BrowserWindowTracker.jsm'. r=dao
MozReview-Commit-ID: 9qzq1aGvjDu
2018-04-11 12:05:56 +02:00
Florian Quèze
97f9a1fe21 Bug 854464 - round the percentComplete value of the download indicator before setting it to set it at most 100 times, r=paolo. 2018-04-16 14:27:13 +02:00
Marco Castelluccio
7cd550a10b Bug 1423667 - Reenable some tests that were disabled because of a Clang update. r=jmaher 2018-04-05 09:20:47 +01:00
Brendan Dahl
3930802738 Bug 1443971 - Remove allDownloadsViewOverlay.xul. r=Paolo
This overlay was used in two places: places.xul and
contentAreaDownloadsView.xul. Move the commandset, menuppop and
downloadsRichListBox into include files. Inline the scripts and
DTDs.

MozReview-Commit-ID: LroiQlRTE2T
2018-03-19 16:21:50 -07:00
Ursula Sarracini
42bc55ef72 Bug 1448143 - Factor out a size getter from DownloadsViewUI.jsm so other consumers can access it r=Mardak
MozReview-Commit-ID: EgyfXz1ntys
2018-03-23 14:21:48 -04:00
Michael Webster
3788634df5 Bug 1418749 - Add a TaskbarProgress implementation for gtk3/x11. r=paolo,karlt
This adds support for download progress reporting via the XApp
method currently used in the Cinnamon desktop, by establishing a new
X11 window property to be supported/read by the window manager.

See https://github.com/linuxmint/xapps/blob/master/libxapp/xapp-gtk-window.c,
as well as https://github.com/linuxmint/muffin/commit/39045da0ea06f
for more details.

The property-setting code lives in nsWindow - it's a small and stable
enough chunk that it made more sense to do this than actually depend on
another external library.  As nsWindow is already using x11 calls, this
seemed the safest place for it, without affecting the build.

The TaskbarProgress instance is initialized via the DownloadsTaskbar
js module, and is handed a pointer to the current main window to call
SetProgress on.  Most of the javascript side of this is in line with
how the other platforms are handled.

Without a supporting window manager/desktop environment (currently just
Cinnamon/Muffin 3.6,) the simplest way to observe working behavior is
by calling 'xprop -spy' on the browser window being testing and watching
for updates during a download.
2018-03-08 18:43:00 +02:00
Mark Banner
ec9360ee83 Bug 1434446 - Enable no-unused-vars for global scope on jsm files in browser/. r=mossop
MozReview-Commit-ID: ERT1Fili25d
2018-03-01 20:06:06 +00:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Sebastian Hengst
b120b7fb67 merge mozilla-inbound to mozilla-central. a=merge 2018-02-28 12:54:12 +02:00
Tooru Fujisawa
fbc75c930b Bug 1435910 - Part 0.2: Add BrowserTestUtils.{promiseAlertDialogOpen,promiseAlertDialog}. r=Gijs 2018-02-28 10:36:42 +09:00
Brendan Dahl
10bb02704a Bug 1439766 - Replace editMenuOverlay.xul by inlining and preprocessing. r=Gijs
The overlay elements with children of editMenuOverlay.xul are moved into
include files (editMenuCommands.inc.xul and editMenuKeys.inc.xul). For
the other single elements in the overlay, the attributes are inlined
wherever they are used.

MozReview-Commit-ID: 792cuzUvQxT
2018-02-22 15:48:24 -08:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Ciure Andrei
642bbf1d1c Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2018-02-23 02:06:26 +02:00
Paolo Amadini
f7c87a1ab1 Bug 1439358 - Part 2 - Don't use the "current" property when restoring focus from the blocked downloads subview. r=Gijs
MozReview-Commit-ID: ASmmdQMctr5
2018-02-22 12:20:53 +00:00
Brendan Dahl
08481d480b Bug 1434077 - Inline indicators overlay. r=Paolo
This is part of the work to remove XUL overlays. The overlay was originally
created to help startup performance, but inlining the overlay seems to
no longer have detrimental effects to performance and is more straightforward.

MozReview-Commit-ID: 7sfVel6qvgv
2018-02-14 12:20:58 -08:00
Brendan Dahl
e5f0a48b9a Bug 1434077 - Inline downloads overlay. r=Paolo
This is part of the work to remove XUL overlays. The overlay was originally
created to help startup performance, but using a hidden panel instead seems to
have no detrimental effects to performance and is more straightforward.

MozReview-Commit-ID: JlWcZEhPXyH
2018-02-06 15:55:50 -08:00
Boris Zbarsky
4fd6e65c55 Bug 1436508 part 10. Remove use of nsIDOMKeyEvent in JS. r=masayuki
MozReview-Commit-ID: GGciORX62Yh
2018-02-09 11:17:09 -05:00
Paolo Amadini
ff1ddd6adf Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs
MozReview-Commit-ID: 3VzoxJ3Ociy
2018-02-06 09:02:27 +00:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Paolo Amadini
1b1da3067b Bug 1424469 - The Downloads view in the Library window doesn't get focus when opened. r=mak
We have to keep track of the focused element while we remove the richlistbox element temporarily.

MozReview-Commit-ID: AePydUyyUS7
2018-01-30 14:38:25 +00:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Paolo Amadini
f708b42b64 Bug 1425736 - Don't show the attention badge for download failures on the application menu button. r=Gijs
MozReview-Commit-ID: A882hXl5o0
2018-01-09 15:51:19 +00:00
Ryan VanderMeulen
6f96d4a01d Bug 1423667 - Disable some tests that fail on Windows Code Coverage builds with clang-cl r317840. rs=marco 2017-12-06 20:40:46 -05:00
Paolo Amadini
a0748c6a8a Bug 1419005 - Remove the "download-toolbarbutton" binding. r=mak
MozReview-Commit-ID: Al6jXNz4jjM
2017-11-20 14:20:29 +00:00
Paolo Amadini
192bb221a0 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs
MozReview-Commit-ID: IjvSZZUHUMt
2017-11-21 14:21:32 +00:00
Paolo Amadini
dd90b8e727 Bug 1414244 - Part 5 - Remove the "panel-mainview" container. r=Gijs
MozReview-Commit-ID: 3NDGiy3Mwtq
2017-11-11 22:56:15 +00:00
Mark Banner
4de85b3d5b Bug 1230373 - Enable mozilla/use-services for browser/components/ r=mossop
MozReview-Commit-ID: 9m9iss3jUJJ
2017-10-11 15:43:51 +01:00
Erica Wright
942200ccac Bug 1033395 - Panels Should Be Anchored from the Same Height on the Toolbar. r=johannh
MozReview-Commit-ID: 6bhlfeD1esE
2017-09-13 15:49:32 -04:00
Phil Ringnalda
6f4d37fc42 Backed out changeset 5b9d2ebcf44e (bug 1033395) for failures in browser_overflow_anchor.js
MozReview-Commit-ID: LfhmJLydnaF
2017-10-16 22:01:54 -07:00
Erica Wright
fa263f98ba Bug 1033395 - Panels Should Be Anchored from the Same Height on the Toolbar. r=johannh
MozReview-Commit-ID: 6bhlfeD1esE
2017-09-13 15:49:32 -04:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Erica Wright
495e08000d Bug 1390313 - Item added to the overflow menu should scale down and fade out. ui-r=epang r=Gijs
MozReview-Commit-ID: 5PxydbSfhpz
2017-09-18 16:15:24 -04:00
Mike de Boer
48292377c5 Bug 1398346 - Follow up patch to correct one of the selectors to be more precise and avoid potential issues. rs=Paolo
MozReview-Commit-ID: 4nZ16XB7xQA
2017-09-29 15:54:14 +02:00
Mike de Boer
1129eb942f Bug 1398346 - Hide the 'Open File' status label for failed downloads and/ or downloads where the file went missing for items in the Downloads subview in the Library panel. r=Paolo
MozReview-Commit-ID: 1j9tkqydyVZ
2017-09-29 14:18:10 +02:00
Mike de Boer
e84ec0c0a6 Bug 1395615 - Implement the "file moved or missing" check for download items in the Library Downloads subview. r=Paolo
MozReview-Commit-ID: 62VJbzJwxVW
2017-09-26 17:55:18 +02:00
Mike de Boer
a6deaaa841 Bug 1401930 - Correct query selectors in DownloadsSubview code. r=Paolo
MozReview-Commit-ID: FDl7k7QkMv2
2017-09-21 14:01:37 +02:00
Mike de Boer
a4093e9f4e Bug 1398106 - Check the disabled state for each menuitem in the context menu for a Download in the Library subview. r=Paolo
The 'cmd_delete' command was clashing with another controller which keeps
disabling the menuitem, so it's been renamed to 'downloadsCmd_delete' instead.

MozReview-Commit-ID: IiWEVMt0dfW
2017-09-21 13:49:34 +02:00
Boris Zbarsky
c4de48a0e8 Bug 1400898 part 1. Remove the one script use of nsIDOMChromeWindow. r=farre
MozReview-Commit-ID: I31eceiJP55
2017-09-19 10:13:22 -04:00