Commit Graph

181 Commits

Author SHA1 Message Date
Ryan VanderMeulen
c297ca2ae5 Backed out changesets 7be34fd75378 and a2edd07d05dd (bug 1354078) for browser_photon_customization_context_menus.js failures on a CLOSED TREE. 2017-05-26 13:29:10 -04:00
Gijs Kruitbosch
ce62942c89 Bug 1354078 - update panel/toolbar context menus to move items to the right place, with tests, r=bgrins
MozReview-Commit-ID: DpQdvE25iqU
2017-05-19 17:27:11 +01:00
Gijs Kruitbosch
b6620c9af2 Bug 1354126 - use checkbox for titlebar toggle in customize mode, r=mikedeboer
MozReview-Commit-ID: 9bdf8uAlWCM
2017-05-22 11:17:11 +01:00
Gijs Kruitbosch
6e964ed266 Bug 1354126 - allow footer to wrap underneath the panel and add a 'done' button, r=mikedeboer
MozReview-Commit-ID: 1LbwmhfGp49
2017-05-22 19:34:04 +01:00
Gijs Kruitbosch
d26133a073 Bug 1365294 - swap position of the fixed overflow list, r=mikedeboer
MozReview-Commit-ID: 9LlTxRLuOkx
2017-05-17 15:05:36 +01:00
Florian Quèze
50b8c6608d Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
b2499a4c57 Bug 1353542 - smaller script-generated patch converting remaining generators that are likely tasks (actual generators were identified by hand and whitelisted), r=Mossop. 2017-05-12 14:45:01 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Gijs
dea6f4a52b Bug 1354094 - show the overflow button when there are items in the permanent overflow menu, r=mikedeboer
This also disables the menu button and overflow button correctly in
customize mode, and fixes an issues where the overflow button state
would stay 'open' when closing the panel by clicking the button
a second time.

MozReview-Commit-ID: BNTkE6zvv9Q
2017-05-10 12:36:05 -04:00
Gijs Kruitbosch
a140e98983 Bug 1354082 - part 2: make overflow panel show up in customize mode and make dragging work correctly, r=mikedeboer
This reuses the logic we have for toolbar dragging and uses it for the photon panel (ie overflow panel)
to do vertical space-making animations.

It explicitly doesn't address the styling or permanently showing the overflow button (for which we have other bugs on file).


MozReview-Commit-ID: 4qrWC0H30xi
2017-05-05 19:26:55 +01:00
Florian Queze
6cc0b6e992 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Florian Queze
ddf0cda8da Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
4cd95d4a02 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
35cd8ba883 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Mike Conley
5869c46a45 Bug 1347514 - Tear down customize mode in a background tab if the users sends it to a different page. r=dao
MozReview-Commit-ID: HQ39mwAhQjS
2017-03-20 11:08:48 -04:00
Florian Quèze
49d8db6821 Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop. 2017-03-16 19:26:01 +01:00
Florian Quèze
73074c2660 Bug 1344711 - hand cleanup of remaining useless try blocks around get*Pref calls identified by eslint, r=jaws. 2017-03-07 15:29:48 +01:00
Florian Quèze
c7eae86054 Bug 1344711 - script-generated patch to remove try blocks around get*Pref calls, r=jaws. 2017-03-07 15:29:48 +01:00
Jared Wein
796ea77fd8 Bug 864562 - Fix the tests and move more logic from JS to CSS now that the values exist as CSS Variables. r=mikedeboer
MozReview-Commit-ID: BuJdjtVBnin
2017-02-28 12:15:04 -05:00
Jared Wein
1d1bd99868 Bug 864562 - CustomizeMode should use CSS variables for setting LWT properties. r=mikedeboer
MozReview-Commit-ID: 5ZLJ0HNbJ9w
2017-02-22 15:50:41 -05:00
Sebastian Hengst
2635de4bed Backed out changeset 028a63d5008c (bug 864562) 2017-02-23 19:33:26 +01:00
Jared Wein
fd523ac0f8 Bug 864562 - CustomizeMode should use CSS variables for setting LWT properties. r=mikedeboer
MozReview-Commit-ID: 5ZLJ0HNbJ9w
2017-02-22 15:50:41 -05:00
Florian Quèze
0a4ee94a29 Bug 1334199 - script-generated patch to omit getComputedStyle's second argument when it's falsy, r=jaws. 2017-01-27 10:51:02 +01:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Florian Quèze
b36a8b8f42 Bug 1330147 - automatic removal of the third boolean parameter in removeObserver calls, r=jaws. 2017-01-11 22:27:42 +01:00
Jared Wein
7f63d76499 Bug 1327560 - Always place the current lwtheme at the beginning of the list of recent lightweight themes to prevent it from getting truncated out. r=Gijs
MozReview-Commit-ID: b3O3MnpmjG
2017-01-03 17:24:49 -05:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Jared Wein
ef8b1e86ca Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Mark Banner
0dc78b7964 Bug 1314918 - Fix most of the remaining no-unused-vars issues for local scope in browser/. r=mossop
MozReview-Commit-ID: LdoXLniNeT7
2016-11-03 11:51:48 +00:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Dão Gottwald
9be9ed37a9 Bug 1306584 - In customize mode, properly update the lightweight theme button icon and Restore Defaults button disabled state when selecting a theme. r=jaws 2016-10-06 18:45:29 +02:00
Dão Gottwald
a270faf6a3 Bug 1306264 - Move chrome://browser/skin/theme-switcher-icon.png reference from CustomizeMode.jsm to theme code. r=jaws 2016-09-30 09:39:27 +02:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Pushpankar
77a14e357c Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao 2016-07-16 10:20:04 +02:00
Katie Broida
153908ff5b Bug 1061747 - Restore Defaults should reset the current theme. r=jaws
MozReview-Commit-ID: CRmJiOE4uYr
2016-05-24 13:06:25 -04:00
Jared Wein
89fad52044 Bug 1260596 - Themes panel is empty when all default-shipped lightweight themes (lwts) are removed. r=gijs
MozReview-Commit-ID: L1s3yxoxU33
2016-05-18 11:36:14 -04:00
Katie Broida
00000163a8 Bug 1260595 - Clear the lightweight themes menu in popupshowing instead of popuphidden to prevent duplicates in certain scenarios. r=jaws 2016-05-10 08:49:00 -04:00
Katie Broida
0e4852d420 Bug 1093750 - Add tooltips to icons in Customize mode. r=jaws
MozReview-Commit-ID: HYgprjtoOcE
2016-05-02 11:33:07 -04:00
Gijs Kruitbosch
57d75956ab Backed out changeset c7544b24989d (bug 1260595) for perma-oranging browser_1007336_lwthemes_in_customize_mode.js on linux with crashes
MozReview-Commit-ID: 2GqsGs7yw9u
2016-04-22 11:31:58 +01:00
Katie Broida
271bf8f78a Bug 1260595 - Clear the lightweight themes menu in popupshowing instead of popuphidden to prevent duplicates in certain scenarios. r=jaws
MozReview-Commit-ID: 8wejtWMx3sd
2016-04-21 18:59:43 -07:00
gasolin
65e42a066d Bug 1263557 - Use plain promise in CustomizeMode.jsm. r=Gijs
MozReview-Commit-ID: 5K98xC88dXb
2016-04-07 10:53:50 +08:00
Gijs Kruitbosch
58be856b45 Bug 1258344 - fix customizemode re-entering issues when switching tabs, r=jaws
MozReview-Commit-ID: 3KONzSxf8g9
2016-03-22 14:32:32 +00:00
Sebastian Hengst
cb2183e28a Backed out changeset 12ff599ce0e2 (bug 1258344) for leaks in OS X 10.10 debug browser-chrome tests. r=backout on a CLOSED TREE 2016-03-31 21:43:23 +02:00
Gijs Kruitbosch
8fda60a161 Bug 1258344 - fix customizemode re-entering issues when switching tabs, r=jaws
MozReview-Commit-ID: 3KONzSxf8g9
2016-03-22 14:32:32 +00:00