Commit Graph

181 Commits

Author SHA1 Message Date
Gijs Kruitbosch
fb7e11d8a5 Bug 1463708 - only reset previews when leaving the panel, r=johannh
MozReview-Commit-ID: 1KVseuWlEPU
2018-06-19 21:44:00 +01:00
Mark Banner
efb967ef3e Bug 1453667 - Remove BrowserUITelemetry from other parts of browser/ r=Gijs
MozReview-Commit-ID: FG1PiVPBY5U
2018-06-06 19:42:19 +01:00
Kris Maglione
0847e8227e Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8
MozReview-Commit-ID: 9APGewiDDYB
2018-05-25 17:02:29 -07:00
Paolo Amadini
c766d617b5 Bug 1450816 - Combine the "toolbarpaletteitem" bindings in the "browser" folder. r=Gijs
MozReview-Commit-ID: BW4kDvP13Tj
2018-05-22 14:04:45 +01:00
Tim Nguyen
9698f93bd0 Bug 1372694 - Stop making the default theme a heavyweight theme. r=kmag,aswan
MozReview-Commit-ID: 30wMauuc9oo
2018-04-01 13:53:31 +02:00
Kris Maglione
d3bbf87c83 Bug 1454202: Part 1 - Update legacy callers to use Promise-based AddonManager APIs. r=aswan
***
Bug 1454202: Part 1a - Auto-replace uses of callback-based AddonManager APIs with Promise-based versions. r=aswan

This was done using the following script:

4cd5ae9597/processors/aom-api-generators.jsm

MozReview-Commit-ID: 8hobLz15a66
***
Bug 1454202: Part 1b - Manually fix eslint errors after auto-rewrite. r=aswan

This also deletes an obsolete test whose xpcshell variant was already deleted.

MozReview-Commit-ID: DM9W9Q2SVIE
***
Bug 1454202: Part 1c - Manually fix non-eslint issues after auto-rewrite. r=aswan

MozReview-Commit-ID: DtMscWZuExc
2018-04-14 19:38:18 -07:00
Jonathan Kingston
9b880fdc20 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja
2018-02-21 14:28:48 +00:00
ui.manish
dcc9b395af Bug 1451242 - Use this.$ instead of this.document.getElementById in CustomizeMode.jsm r=Gijs 2018-04-05 10:48:04 +02:00
Dão Gottwald
0a8e016dc7 Bug 1450279 - Replace CAN_DRAW_IN_TITLEBAR with a run-time check. r=Gijs
MozReview-Commit-ID: Iedpcu5K74m
2018-03-30 17:36:01 +02:00
Kris Maglione
3f0e557c02 Bug 1448221: Part 2 - Remove support for non-default legacy themes. r=aswan
MozReview-Commit-ID: 1v0aGG3mv3U
2018-03-26 16:19:04 -07:00
Mark Banner
ec9360ee83 Bug 1434446 - Enable no-unused-vars for global scope on jsm files in browser/. r=mossop
MozReview-Commit-ID: ERT1Fili25d
2018-03-01 20:06:06 +00:00
Mike Conley
a50309145a Bug 1434376 - Switch over all uses of BrowserUtils.promiseLayoutFlushed to window.promiseDocumentFlushed. r=Paolo
window.promiseDocumentFlushed will call a callback as soon as a style or layout
flush is not required for the document (which might be immediately). This is a
new ChromeOnly API introduced in an earlier patch in this series.

This patch also removes the now-unneeded BrowserUtils.promiseLayoutFlushed and
BrowserUtils.promiseReflowed methods and infrastructure.

MozReview-Commit-ID: Jv7KoxBXhHG
2018-02-11 20:15:11 -05:00
Andreea Pavel
f77494f37a Backed out 3 changesets (bug 1434376)for failing browser chrome at browser/base/content/test/performance/browser_urlbar_search_reflows.js on a CLOSED TREE
Backed out changeset b636251b75ab (bug 1434376)
Backed out changeset fccbba9cb959 (bug 1434376)
Backed out changeset b5128504011c (bug 1434376)
2018-02-25 12:44:28 +02:00
Mike Conley
7a9538a35f Bug 1434376 - Switch over all uses of BrowserUtils.promiseLayoutFlushed to window.promiseDocumentFlushed. r=Paolo
window.promiseDocumentFlushed will call a callback as soon as a style or layout
flush is not required for the document (which might be immediately). This is a
new ChromeOnly API introduced in an earlier patch in this series.

This patch also removes the now-unneeded BrowserUtils.promiseLayoutFlushed and
BrowserUtils.promiseReflowed methods and infrastructure.

MozReview-Commit-ID: Jv7KoxBXhHG
2018-02-11 20:15:11 -05:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Dão Gottwald
310b23880b Bug 1430747 - Stop setting unused customization-lwtheme attribute and --toolbox-rect-height, --toolbox-rect-height-with-unit CSS variables. r=mikedeboer
MozReview-Commit-ID: HpdE3I7ZeDY
2018-01-16 12:38:41 +01:00
Gijs Kruitbosch
494c89092f Bug 1426250 - make tests actually pass valid mouse coordinates when testing Customize Mode, r=jaws
MozReview-Commit-ID: IglKedBqrWQ
2018-01-05 21:35:27 +00:00
Tim Nguyen
e0347f3526 Bug 1428938 - Remove legacy toolbar customization code. r=Gijs
MozReview-Commit-ID: 1ppfxI7yYJW
2018-01-11 16:35:17 +00:00
Gijs Kruitbosch
447d01f074 Bug 1424452 - stop having 2 different values for the 'panel' area type, r=jaws
MozReview-Commit-ID: 3spDhRhlOTF
2017-12-09 12:37:20 +00:00
Gijs Kruitbosch
53164a15e5 Bug 1415056 - re-enable animations in the palette in customize mode, r=jaws
MozReview-Commit-ID: DXYBPCdXMBG
2017-12-04 12:15:10 +00:00
Xidorn Quan
9188d10b2f Bug 1417600 - Wait for another frame before setting animation out to ensure start of the animation. r=jaws
MozReview-Commit-ID: 96nGBDgdr05
2017-11-16 10:33:04 -08:00
Andreea Pavel
98b8a395ea Backed out 1 changesets (bug 1417600) for failing browser/components/customizableui/test/browser_972267_customizationchange_events.js r=backout on a CLOSED TREE
Backed out changeset 04dac3301ecd (bug 1417600)
2017-11-17 12:51:12 +02:00
Xidorn Quan
c1164dd90d Bug 1417600 - Wait for a style flush before setting animation out to ensure start of the animation. r=jaws
MozReview-Commit-ID: IhnmZ0L9yx
2017-11-16 10:33:04 -08:00
Johann Hofmann
b0efce87bd Bug 1362065 - Add the touchdownstartsdrag attribute to selected tabs on Windows. r=dao
This allows dragging them via touch gestures.

I'm not adding this attribute to all tabs (so that you need
to select a tab before dragging it), because the tab
strip can also be scrolled with touch gestures and
the two touch move actions would easily conflict
otherwise. It would also make it easier to accidentally
mess up your tabs when touching your window somehow.

MozReview-Commit-ID: IVWQtVGFE9j
2017-11-10 12:06:50 +01:00
Gijs Kruitbosch
fd9bc93522 Bug 1388029 - remove notion of 'wide' widget and panel columns from the tree, r=jaws
MozReview-Commit-ID: IrCB3zn1BIT
2017-11-07 12:00:18 +00:00
Jared Wein
515520cdb5 Bug 1415054 - Handle RTL in empty customize mode better. r=gijs
MozReview-Commit-ID: HjqvOM1n14G
2017-11-08 15:32:21 -05:00
Johann Hofmann
d6bb5fea68 Bug 1299286 - Add the touchdownstartsdrag attribute to customize mode elements. r=jaws
MozReview-Commit-ID: LziDBjACA0
2017-11-03 13:12:10 +01:00
Jared Wein
f9d4685ed9 Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH
2017-10-31 14:38:15 -04:00
Coroiu Cristina
a1006bed59 Backed out changeset b558ad2372bf (bug 1410666) for failing the browser-chrome on browser_all_files_referenced.js and browser_switch_to_customize_mode.js r=backout on a CLOSED TREE
Backed out changeset b558ad2372bf (bug 1410666)
2017-11-02 01:02:12 +02:00
Jared Wein
36471c65ad Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH
2017-10-31 14:38:15 -04:00
Jared Wein
d0b4218d06 Bug 1413030 - Polish up a few conditions when the customization palette is mostly empty. r=mconley
MozReview-Commit-ID: Gr4sXTZo7pG
2017-10-24 17:23:22 -04:00
Jared Wein
d6f301d618 Bug 1409463 - Handle customization mode when only the Spacer is left. r=mconley
mconley helped with the initial setup here and they were reviewed by myself (jaws). His changes have been folded in to this patch since they didn't work as a standalone changeset.

MozReview-Commit-ID: E7U1ZciJl4D
2017-10-15 14:11:57 -04:00
Erica Wright
a25284c228 Bug 1407754 - exiting customize mode quickly after adding a toolbar item to toolbar properly adds it to the toolbar. r=jaws
MozReview-Commit-ID: C7uvVVWoIeB
2017-10-13 09:27:48 -04:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Erica Wright
2c973487b6 Bug 1407435 - After animating out from the toolbar, the widget no longer remains invisible. r=jaws
MozReview-Commit-ID: 5WmcIFWqBYi
2017-10-11 15:12:21 -04:00
Erica Wright
495e08000d Bug 1390313 - Item added to the overflow menu should scale down and fade out. ui-r=epang r=Gijs
MozReview-Commit-ID: 5PxydbSfhpz
2017-09-18 16:15:24 -04:00
Gijs Kruitbosch
a70af3db06 Bug 1405720 - ensure only 1 theme is ever shown as selected in customize mode, r=jaws,johannh
The previous code here always set the `isActive` property on all themes. When writing the
patch for bug 1402981 I ran into issues because the default theme has an `isActive` property
anyway (it's a different type of object). So I tried to avoid setting `isActive` if it was
already present. Unfortunately, the result was that `isActive` values, once set, weren't
correctly updated. Worse, these values are (and were, prior to bug 1402981) persisted in
some cases.

There's no point persisting these values, all that will happen is that they'll start
mismatching the 'real' state of the world (LightweightThemeManager.currentTheme). So instead,
let's just not set the `isActive` property at all, and rely solely on the ID of the current
theme (or the default theme's ID, now that we no longer support non-lightweight-themes) to
establish whether any of the themes should appear selected or not.

MozReview-Commit-ID: 7rajS71FoQR
2017-10-05 15:17:12 +01:00
Jared Wein
9d371eb04e Bug 1403382 - Dragging the back button out of the toolbar in customize mode shouldn't affect the toolbar height. r=Gijs
MozReview-Commit-ID: JOsb2y2pzqz
2017-10-02 23:30:29 -04:00
Gijs Kruitbosch
5acc1e4c34 Bug 1402929 - try to make overflow panel in customize mode easier to understand, r=mikedeboer
This moves the explanatory text from a pseudoelement to a real element,
and keeps only the image in a pseudoelement. It then uses a transitioned
opacity to fade that image in and out.

Because we need to fade this based on dragging items over the panel when
it's empty, it adds/removes a 'draggingover' attribute to handle the fade.

To cope with the extra element in the drag/drop container in customize mode,
this also makes the following changes:
- bail out of _onDragStart if there's no actual selected item.
- pick the fixed list in the panelHolder more reliably
- add a max-width to avoid the description making the panel wider

MozReview-Commit-ID: 9PEJSoJJ0Rp
2017-09-29 17:55:50 +01:00
Maya Messinger
f63e9fdbe4 Bug 1396953 - fix flexible space widget disappearing when adding to toolbar r=Gijs
MozReview-Commit-ID: BuYzvBX439p
2017-09-30 18:42:24 -04:00
Gijs Kruitbosch
21beddb96d Bug 1396423 - make it possible to drop items in what visually looks like the palette but isn't, r=mikedeboer
MozReview-Commit-ID: AqBwn9ovTjT
2017-09-29 15:40:48 +01:00
Gijs Kruitbosch
bec818f3cb Bug 1402981 - add light and dark themes to the list of themes in customize mode by default, r=jaws
MozReview-Commit-ID: 4GxPEm119Yc
2017-09-27 22:37:19 +01:00
Erica Wright
c684d54fd9 Bug 1401152 - Disable 'add to overflow menu' in the customize mode *palette* context menu for flexible space. r=Gijs
MozReview-Commit-ID: 5sQPsxVaVYz
2017-09-21 18:15:02 -04:00