corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
766,165 Commits 1 Branch 0 Tags
739b51aee122798f1d049575ff9f0747ca1fdea5
Commit Graph

381 Commits

Author SHA1 Message Date
Neil Deakin
4674aa45e8 Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs 
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm

This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.

Differential Revision: https://phabricator.services.mozilla.com/D149285
 2022-06-29 12:38:30 +00:00
Marian-Vasile Laza
3dee1242d8 Backed out 2 changesets (bug 1682621) for causing bc failures on browser_ext_browserAction_click_types.js. 
Backed out changeset 31a6b027b4e7 (bug 1682621)
Backed out changeset 782fd4871c5f (bug 1682621)
 2022-06-28 20:27:15 +03:00
Neil Deakin
27e54692b9 Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs 
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm

This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.

Differential Revision: https://phabricator.services.mozilla.com/D149285
 2022-06-28 16:02:37 +00:00
Tooru Fujisawa
9ac8a72331 Bug 1772100 - Part 3: Use plain object for lazy getter in browser/components/customizableui/. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D148013
 2022-06-10 19:42:59 +00:00
Tooru Fujisawa
b4e5ad26c8 Bug 1765319 - Part 1: Do not use global this in CustomizableUI.jsm. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D144130
 2022-05-13 20:12:25 +00:00
Dão Gottwald
365511d874 Bug 1766896 - Redirect attempts to load something else in the Firefox View tab to new tabs. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D145613
 2022-05-10 22:16:45 +00:00
Dão Gottwald
e4a09e1f3f Bug 1762903 - Implement Firefox View toolbar button. r=fluent-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D144735
 2022-05-04 16:25:54 +00:00
Kagami Sascha Rosylight
d6ec873f16 Bug 1703953 - Part 2: Apply mozilla/use-isInstance rules for .jsm files r=webdriver-reviewers,pip-reviewers,mhowell,Gijs,whimboo 
This replaces all `instanceof` uses for DOM interfaces, since the operator in priviliged context works same as .isInstance().

Differential Revision: https://phabricator.services.mozilla.com/D141785
 2022-04-06 11:57:57 +00:00
criss
0038e58f1f Backed out 3 changesets (bug 1703953) for causing multiple failures. CLOSED TREE 
Backed out changeset 871a1fac289e (bug 1703953)
Backed out changeset 8151244bda18 (bug 1703953)
Backed out changeset eaf6d4c353be (bug 1703953)
 2022-03-29 17:01:58 +03:00
Kagami Sascha Rosylight
f3126104f8 Bug 1703953 - Part 2: Apply mozilla/use-isInstance rules for .jsm files r=webdriver-reviewers,pip-reviewers,mhowell,Gijs,whimboo 
This replaces all `instanceof` uses for DOM interfaces, since the operator in priviliged context works same as .isInstance().

Differential Revision: https://phabricator.services.mozilla.com/D141785
 2022-03-29 13:11:00 +00:00
Mark Banner
d22663f0f9 Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D140518
 2022-03-17 22:13:08 +00:00
Cristian Tuns
a180c6cba3 Backed out changeset 528295e7cb0c (bug 1758476) for causing tabswitch failures CLOSED TREE 2022-03-14 12:27:48 -04:00
Mark Banner
beed912c8e Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D140518
 2022-03-14 10:19:40 +00:00
Gijs Kruitbosch
b17d515fe6 Bug 1745810 - remove use of ChromeUtils.import(..., null) from CustomizableUI tests, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D139477
 2022-02-25 22:18:32 +00:00
Mike Conley
abe9b18fc5 Bug 1748907 - Check the value rather than the presence of 'overflowable' when tearing down a CUI window. r=harry 
Differential Revision: https://phabricator.services.mozilla.com/D135254
 2022-01-06 20:12:28 +00:00
Emilio Cobos Álvarez
1a62d9d1e2 Bug 1747609 - Don't auto-hide panel on click inside a menupopup. r=Gijs 
This matches the current macOS behavior with native context menus.

The issue is that closing the panels causes the destruction of the
menupopup while the activate event hasn't run yet, see comment 9.

Executing the command event synchronously like we do for <button>s is
probably worth it to some extent, though note that on macOS with
non-native menus it'd still need to be async because of the
blinking-before-activation that menuitems have. Gnarly :-(

Of course we always use native menus for context menus so it's not a big
deal, but it still affects the content <select> dropdown, I believe.

So this is the less-invasive change.

Differential Revision: https://phabricator.services.mozilla.com/D134777
 2021-12-31 18:33:59 +00:00
criss
4315b33d67 Backed out changeset 309f9ab93b03 (bug 1747609) for causing failures on browser_popup-record-capture-view.js. CLOSED TREE 2021-12-30 05:09:51 +02:00
Emilio Cobos Álvarez
4105547bed Bug 1747609 - Don't auto-hide panel on click inside a menupopup. r=Gijs 
This matches the current macOS behavior with native context menus.

The issue is that closing the panels causes the destruction of the
menupopup while the activate event hasn't run yet, see comment 9.

Executing the command event synchronously like we do for <button>s is
probably worth it to some extent, though note that on macOS with
non-native menus it'd still need to be async because of the
blinking-before-activation that menuitems have. Gnarly :-(

Of course we always use native menus for context menus so it's not a big
deal, but it still affects the content <select> dropdown, I believe.

So this is the less-invasive change.

Differential Revision: https://phabricator.services.mozilla.com/D134777
 2021-12-30 00:30:38 +00:00
Mike Conley
aeb6969fe7 Bug 1746670 - Make it possible to register CUI areas with overflowable: false. r=harry 
Differential Revision: https://phabricator.services.mozilla.com/D134196
 2021-12-17 21:52:46 +00:00
Emilio Cobos Álvarez
92f83cf19e Bug 1739539 - Rename titlebar pref and add migration from old pref. r=mconley 
Something like this ought to do?

Differential Revision: https://phabricator.services.mozilla.com/D130858
 2021-11-10 21:17:32 +00:00
Julien Wajsberg
146e0feb81 Bug 1738871 - [CustomizableUI] Support the button-and-view custom widget type in the overflow menu when Fluent is used r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D130365
 2021-11-08 19:26:35 +00:00
Emilio Cobos Álvarez
d37eb95bc7 Bug 1736518 - Make browser.tabs.drawInTitlebar a tri-state. r=stransky,Gijs 
To more properly support Linux having a different default at runtime.

Expose the resolved value in appinfo for convenience, and use it in the
front-end as needed.

Differential Revision: https://phabricator.services.mozilla.com/D129004
 2021-10-21 09:07:12 +00:00
Michael Kohler
87790d1825 Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref from browser/customizableui/places r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D127588
 2021-10-14 07:51:14 +00:00
Niklas Baumgardner
6c474b08c8 Bug 1635553 - Migrate navigator-toolbox to Fluent. r=emalysz,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D125222
 2021-09-15 19:31:56 +00:00
Butkovits Atila
b0a146c434 Backed out changeset b9b49ff4fca0 (bug 1635553) for causing failures complaining about menupopup. CLOSED TREE 2021-09-15 21:43:25 +03:00
Niklas Baumgardner
9089ede997 Bug 1635553 - Migrate navigator-toolbox to Fluent. r=emalysz,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D125222
 2021-09-15 16:21:09 +00:00
Mark Banner
f321dfd6b1 Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D124838
 2021-09-10 12:09:49 +00:00
Noemi Erli
20dee875a7 Backed out 2 changesets (bug 1729460) for causing newtab failures CLOSED TREE 
Backed out changeset 5617839462be (bug 1729460)
Backed out changeset 6d52fde3ee0e (bug 1729460)
 2021-09-10 13:14:12 +03:00
Mark Banner
6a5ffbcc55 Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D124838
 2021-09-10 09:38:42 +00:00
Scott
016ff65279 Bug 1724668 - Ensure Pocket panel closes if location changes with locationSpecific CustomizableUI prop. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D122278
 2021-08-25 00:46:01 +00:00
Marian-Vasile Laza
3cf60904a9 Backed out changeset 6ba2b54d02f6 (bug 1724668) for causing bc failures on browser_panel_locationSpecific.js. CLOSED TREE 2021-08-20 20:52:53 +03:00
Scott
6b8ab0fe63 Bug 1724668 - Ensure Pocket panel closes if location changes with locationSpecific CustomizableUI prop. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D122278
 2021-08-20 16:54:00 +00:00
Gijs Kruitbosch
b8ee6453fe Bug 1711508 - remove protonToolbarEnabled property from CustomizableUI, r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D119274
 2021-07-07 22:15:50 +00:00
Mike Conley
cd24256568 Bug 1682022 - Clone the Extensions for Developers string for sentence-casing when in the AppMenu / panels. r=mtigley,fluent-reviewers,flod 
Depends on D117067

Differential Revision: https://phabricator.services.mozilla.com/D117070
 2021-06-09 18:01:24 +00:00
Butkovits Atila
12d0c53554 Backed out 3 changesets (bug 1682022) for causing failures on browser_sync.js. CLOSED TREE 
Backed out changeset 9ec189804055 (bug 1682022)
Backed out changeset 3a93fa0ba8ce (bug 1682022)
Backed out changeset 2fca4f56df6f (bug 1682022)
 2021-06-09 19:54:44 +03:00
Mike Conley
69f7bbe25e Bug 1682022 - Clone the Extensions for Developers string for sentence-casing when in the AppMenu / panels. r=mtigley,fluent-reviewers,flod 
Depends on D117067

Differential Revision: https://phabricator.services.mozilla.com/D117070
 2021-06-09 13:37:13 +00:00
Scott
1885730844 Bug 1701883 - Fix Pocket button default placement if pref is false. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D112653
 2021-04-27 00:21:34 +00:00
Mark Striemer
dc20804a27 Bug 1706219 - Handle gSavedSate without placements in proton toolbar migration r=Gijs 
Depends on D113423

Differential Revision: https://phabricator.services.mozilla.com/D113432
 2021-04-26 23:50:36 +00:00
Mark Striemer
1195a2aae2 Bug 1706219 - Handle empty placements in proton toolbar migration r=emalysz,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D113423
 2021-04-26 23:40:32 +00:00
Markus Stange
4b2c5e6c55 Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D111955
 2021-04-20 17:44:16 +00:00
Narcis Beleuzu
2fd43d5a0b Backed out 7 changesets (bug 1704948, bug 1704879) for bc failures on browser_ext_menus_capture_secondary_click.js 
Backed out changeset 02705918c4bf (bug 1704879)
Backed out changeset 79945b876a1d (bug 1704879)
Backed out changeset eb725de20b11 (bug 1704948)
Backed out changeset 454597ac2ba3 (bug 1704948)
Backed out changeset a43a8ef206ea (bug 1704948)
Backed out changeset 2369e321069e (bug 1704948)
Backed out changeset bdf396edd692 (bug 1704948)
 2021-04-15 03:30:52 +03:00
Markus Stange
7f0c1757af Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D111955
 2021-04-14 21:23:27 +00:00
Michael Kohler
1be16968ee Bug 1701990 - Remove Drag Space r=desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D111011
 2021-04-11 11:42:57 +00:00
Molly Howell
73eb6e0897 Bug 1698377 - Treat button-and-view widgets as being in a panel when they overflow off the toolbar. r=Gijs 
When a toolbar button overflows out of the toolbar and into the overflow menu,
CustomizableUI continues to report the widget's type as "toolbar". This means
that whether the widget is currently overflowed must be considered in addition
to the widget's type when the panel and toolbar states need different handling.

Differential Revision: https://phabricator.services.mozilla.com/D110718
 2021-04-05 18:26:18 +00:00
Scott
c0662d72a7 Bug 1702195 - Properly re add widget view and hide events if toggled off and on. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D110452
 2021-04-01 21:02:27 +00:00
Scott
7d50c41836 Bug 1693376 - Move save to Pocket to the toolbar. r=Gijs,fluent-reviewers,gvn,flod 
Differential Revision: https://phabricator.services.mozilla.com/D107744
 2021-03-23 20:06:03 +00:00
Mike Kaply
33db4189e4 Bug 1691551 - Add enterprise policy for showing the home button. r=emalysz,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D108963
 2021-03-19 22:07:05 +00:00
Mark Striemer
3dae475081 Bug 1696253 - Graduate toolbar to browser.proton.enabled r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D107952
 2021-03-15 23:20:56 +00:00
Alexandru Michis
671fe22e57 Backed out changeset c5b7d3456ec9 (bug 1696253) for causing bc failures in browser_HomePage_add_button.js 
CLOSED TREE
 2021-03-15 06:54:42 +02:00
Mark Striemer
ec2f0516c4 Bug 1696253 - Graduate toolbar to browser.proton.enabled r=jaws 
Depends on D107294

Differential Revision: https://phabricator.services.mozilla.com/D107952
 2021-03-15 03:12:18 +00:00