Commit Graph

381 Commits

Author SHA1 Message Date
Gijs Kruitbosch
447d01f074 Bug 1424452 - stop having 2 different values for the 'panel' area type, r=jaws
MozReview-Commit-ID: 3spDhRhlOTF
2017-12-09 12:37:20 +00:00
Paolo Amadini
ea9b09c38d Bug 1414244 - Part 7 - Remove unused code paths from PanelMultiview.jsm. r=Gijs
MozReview-Commit-ID: 9cwaAZXqDGO
2017-11-23 15:18:14 +00:00
Paolo Amadini
192bb221a0 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs
MozReview-Commit-ID: IjvSZZUHUMt
2017-11-21 14:21:32 +00:00
Gijs Kruitbosch
f4281f60f4 Bug 1388029 - remove the remaining uses of AREA_PANEL, r=jaws
MozReview-Commit-ID: L017kRfHfOv
2017-11-07 12:15:18 +00:00
Gijs Kruitbosch
fd9bc93522 Bug 1388029 - remove notion of 'wide' widget and panel columns from the tree, r=jaws
MozReview-Commit-ID: IrCB3zn1BIT
2017-11-07 12:00:18 +00:00
Gijs Kruitbosch
e64b940f37 Bug 1388029 - remove useless param from PanelUI.showSubView, r=jaws
MozReview-Commit-ID: 9hkYtLxAOtQ
2017-11-07 11:54:47 +00:00
Gijs Kruitbosch
5a30f740d7 Bug 1411011 - stop offering context menu (re)move options on skipintoolbarset items, r=jaws
Giving all these nodes ids doesn't seem like the right fix. `buildArea` already ignores skipintoolbarset
items before doing anything else with nodes, so bailing out early seemed like the right solution here.

MozReview-Commit-ID: H3EyqoospNR
2017-11-06 14:49:37 +00:00
Johann Hofmann
8fea5f8aa7 Bug 1410352 - Make the overflow menu adhere to touchmode sizing. r=nhnt11
MozReview-Commit-ID: JhMIp65wuaq
2017-10-25 13:07:46 +02:00
Sebastian Hengst
009b9b29b1 Backed out changeset cc55d4e3d13d (bug 1410352) for eslint failure at browser/components/customizableui/CustomizableUI.jsm:4339: 'aEvent' is already declared in the upper scope. r=backout 2017-10-25 16:53:27 +02:00
Johann Hofmann
bb08d8718f Bug 1410352 - Make the overflow menu adhere to touchmode sizing. r=nhnt11
MozReview-Commit-ID: JhMIp65wuaq
2017-10-25 13:07:46 +02:00
Felipe Gomes
0f344c77d4 Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 2qNWebBpsMY
2017-10-17 13:39:50 -02:00
Ryan VanderMeulen
99112e9931 Backed out 5 changesets (bug 1407351) for causing bug 1409395 and breaking nightlies.
Backed out changeset e6ee25ad6a9f (bug 1407351)
Backed out changeset 8e04412824b5 (bug 1407351)
Backed out changeset effeee94316e (bug 1407351)
Backed out changeset a53f34a45f9b (bug 1407351)
Backed out changeset 86a360e12b8a (bug 1407351)
2017-10-17 10:07:55 -04:00
Felipe Gomes
3f29526da6 Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 8wbjdYIC3gb
2017-10-16 14:00:30 -02:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Gijs Kruitbosch
d7b6a1a48c Bug 1406738 - do not set the 'overflowing' attribute if the overflow menu only contains 'special' widgets (like flexible spaces), r=jaws
MozReview-Commit-ID: 1C5XaTCIUKA
2017-10-11 12:05:15 +01:00
Dão Gottwald
d09618162c Bug 1406625 - Remove leftover code and styling for <toolbarbutton type="menu-button"> r=mikedeboer
MozReview-Commit-ID: 8wBsluIMZHq
2017-10-07 20:10:24 +02:00
Sam Foster
e75b24280f Bug 1395674 - Adding subviewbutton-nav class to menu-type toolbarbuttons and display the '>' in the overflow list. r=Gijs
MozReview-Commit-ID: I1pGXA3ecxT
2017-09-25 19:29:04 -07:00
Gijs Kruitbosch
8281aeeff3 Bug 1399517 - remove CustomizableUI placements for old buttons to avoid saved state corruption, r=mikedeboer
MozReview-Commit-ID: 3XKPuz9KwlD
2017-09-18 17:34:50 +01:00
Gijs Kruitbosch
4d8b290d17 Bug 1399517 - CustomizableUI shouldn't try to insert items next to nodes that aren't in the right container, r=mikedeboer
MozReview-Commit-ID: H9KY7YQwmlQ
2017-09-18 16:36:46 +01:00
Mike de Boer
8e58f24a71 Bug 1388180 - Update the overflow panel styling in Customize Mode and show the overflow button as in the opened state, but with a disabled looking icon. r=Gijs
MozReview-Commit-ID: 387PZ2jp1SS
2017-09-13 19:28:45 +02:00
Johann Hofmann
28991ef174 Bug 1349552 - Part 2 - Add an extra drag space setting to customize mode. r=nhnt11
MozReview-Commit-ID: IWxdOeRwDeu
2017-09-10 20:38:19 +02:00
Gijs Kruitbosch
89bf690512 Bug 1397447 - ensure the button is in the navbar by default, r=mak
MozReview-Commit-ID: H6r3dAEg4r1
2017-09-08 14:07:05 +01:00
Gijs Kruitbosch
d48e2eaf65 Bug 1397447 - make downloads button autohide by default, r=mak
MozReview-Commit-ID: E9izQpa4fFZ
2017-09-08 14:16:36 +01:00
Kris Maglione
d7f8583c5a Bug 1391707: Follow-up: Skip idle in more places that incorrectly expect strict timing. r=me CLOSED TREE
MozReview-Commit-ID: BbMB5qk4F4e
2017-09-11 21:26:04 -07:00
Zibi Braniecki
424682e3b6 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN
2017-09-09 22:17:19 -07:00
Sebastian Hengst
3a807c09ee Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
8c25be70ea Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN
2017-09-09 22:17:19 -07:00
Sebastian Hengst
1197f950f9 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JSRVc5yW6Kx
2017-09-07 12:39:12 +02:00
Paolo Amadini
7c101fe117 Bug 1387416 - Place the search bar in the customization palette for new profiles. r=Gijs
MozReview-Commit-ID: Tq8YrZWG6P
2017-09-06 13:09:27 +01:00
Zibi Braniecki
58ed110740 Bug 1395871 - Open toolbar menus on mousedown, rather than oncommand.
MozReview-Commit-ID: A3P4QBBgcB8
2017-09-01 01:54:34 -07:00
Gijs Kruitbosch
7bcdebbdbc Bug 1393574 - fix flexible spacers not being removable in some circumstances, r=jaws
The goal of this patch is to ensure that:
- in default placements, specials have no unique ids
- in actual placements as stored by CUI, they do
- we reset the counter for those unique ids on reset.
- we re-number specials when building an area (like on startup, or when resetting),
  ensuring that the actual nodes always match the placements for a given area.
- we force saves after resetting, to ensure that the gNewElementCount is always persisted correctly.

This last part will also fix bug 1393661

MozReview-Commit-ID: HAS5J5ZSgB5
2017-09-06 10:02:44 +01:00
Steve Armand
b03be0d87e Bug 1368967 - Enable the ESLint generator-star-spacing rule across mozilla-central. r=standard8
MozReview-Commit-ID: 5do3eoCEAMR
2017-09-04 00:49:32 -04:00
Gijs Kruitbosch
663af591de Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo
MozReview-Commit-ID: FTvFDV5nuG6
2017-08-25 13:32:47 +01:00
Gijs Kruitbosch
d9e1a75d3c Bug 1385042 - hide spacers and separators added by CUI in popup windows, r=nhnt11
MozReview-Commit-ID: BB1j6j1QdxU
2017-08-23 13:12:21 +01:00
Gijs Kruitbosch
2a2b2aa719 Bug 1383913 - fix popuphiding listener for overflow panel to only 'count' the panel itself hiding, r=mixedpuppy
MozReview-Commit-ID: K2nvSimItyx
2017-08-23 14:42:57 +01:00
Gijs Kruitbosch
89a0e2f431 Bug 1371765 - make downloads button non-customizable, r=jaws,Paolo
MozReview-Commit-ID: E9izQpa4fFZ
2017-08-16 15:54:36 +01:00
Gijs Kruitbosch
6ffac91d02 Bug 1391616 - make migration of existing hamburger panel contents actually work, r=jaws
MozReview-Commit-ID: 4YC4BWI10YW
2017-08-18 13:59:32 +01:00
Drew Willcoxon
062e2f296c Bug 1385418 - Remove disabled pocket code for the toolbar button now that it's been replaced by the item in the page action panel. r=Gijs
MozReview-Commit-ID: 1wANxaD3QaV
2017-08-16 10:13:15 -07:00
Mike Taylor
4692c73d4d Bug 1373650. Unteach CustomizableUI about the Report Site Issue button. r=Gijs
MozReview-Commit-ID: BCXVJChZ0mt
2017-08-04 15:35:18 -05:00
Wes Kocher
d292002f8c Merge m-c to autoland, a=merge
MozReview-Commit-ID: 2YvHbITn9w3
2017-08-10 18:25:34 -07:00
Wes Kocher
b6c157e8cd Merge inbound to m-c a=merge
MozReview-Commit-ID: KRQeIGmhAPA
2017-08-10 18:14:34 -07:00
Dão Gottwald
8e9d7061d2 Bug 956731 - Remove legacy add-on bar and statusbar shims. r=Gijs
MozReview-Commit-ID: 2deeujcHYUM
2017-08-10 09:17:48 +02:00
Kris Maglione
0fb6b2e73c Bug 1388215: Part 3 - Use JIT-friendly defineLazy*Getters methods when defining many lazy imports. r=florian
MozReview-Commit-ID: APoFwUhDFdj
2017-08-09 13:03:36 -07:00
Gijs Kruitbosch
eb2cc9876d Bug 1383009 - add flexible spacers and library button to the navbar by default, r=jaws
Because we generate IDs for special nodes, we should update the inDefaultState getter to actually consider
these nodes to match even when the ids differ. This wasn't an issue before because specials weren't in the
default set for any nodes.

MozReview-Commit-ID: AI85yt2LuJD
2017-08-07 19:10:40 +01:00
Kris Maglione
fa416b7835 Bug 1387902: Don't attempt to localize browserAction widget properties. r=Gijs
We spend a lot of time at startup generating exception objects while trying to
retrieve nonexistent localized properties from string bundles. Since extension
widget values will never be localized this way, we should skip the string
bundle lookup entirely.

MozReview-Commit-ID: L9r59bf2Dgf
2017-08-06 16:34:31 -07:00
Gijs Kruitbosch
a659b10191 Bug 1354117 - remove old panel code from CustomizableUI, add migration, r=jaws
MozReview-Commit-ID: 8kTETHR1P7X
2017-08-01 12:56:48 +01:00
Gijs Kruitbosch
5a6c52f6a7 Bug 1354117 - only dispatch view events once, and fix synced tabs button test, r=jaws
Prior to this patch, both CustomizableUI itself and the PanelMultiView module
tried to ensure that onViewShowing/Shown/Hiding/Hidden listeners were invoked
when the relevant DOM events fired.

PanelMultiView was doing this manually because CUI was only adding listeners
once the corresponding widget was created. Now that the relevant views can be
accessed without the corresponding widgets (via the fixed appMenu), there was
no guarantee that the listeners would be attached, and this caused empty
subviews.

Unfortunately, if the widget *was* present, it caused events to fire more than
once, which understandably broke consumers like the sync remote tabs widget,
which broke the test we're fixing up here. For other views, even if they were
not completely broken it at least did busy-work.

This patch removes the manual event invocation, and delegates the event
listener work to CUI from the PanelMultiView side. This ensures events fire,
and fire only once.

MozReview-Commit-ID: 94GhcrdcBuB
2017-08-01 12:45:55 +01:00
UK992
4725c98c0b Bug 1363485 - Add migration to new navbar layout r=Gijs
MozReview-Commit-ID: HIPq5rKgtlA
2017-06-29 19:09:43 +02:00
UK992
d474ac2448 Bug 1363485 - Move the Back, Forward, Reload and Stop buttons outside of the location bar container to the start of the toolbar along with the Home button r=Gijs
MozReview-Commit-ID: 2GxcXMxdbjW
2017-06-29 01:09:05 +02:00
Sebastian Hengst
6415681153 Backed out changeset 1e6aea26ec16 (bug 1363485) for failing browser_urlbar_search_reflows.js on OSX debug with e10s and Windows. r=backout 2017-08-02 16:26:03 +02:00