This code didn't handle the missing optional rangeIndex parameter correctly.
Probably because all tests for highlightResults used a rangeIndex.
Differential Revision: https://phabricator.services.mozilla.com/D64906
This patch uses the favicons as actually served by the sites. I tried to get 32x32 versions where possible, but a few are smaller and larger. There's also a mix of .ico and .png. I think the inconsistency is acceptable, and even desirable, seeing as these are the actual icons that would appear in the UrlbarView should they appear in the user's frecency results.
Differential Revision: https://phabricator.services.mozilla.com/D60421
There is no guarantee that a tab has finished loading when the test
resumes. As a result, it is possible for the page action's visibility
state to reset (to invisible) between calling `pageAction.show()` and
`pageAction.isShown()`. To prevent that from happening, wait until the
tab has finished loading before resuming the test.
Differential Revision: https://phabricator.services.mozilla.com/D61125
This patch uses the favicons as actually served by the sites. I tried to get 32x32 versions where possible, but a few are smaller and larger. There's also a mix of .ico and .png. I think the inconsistency is acceptable, and even desirable, seeing as these are the actual icons that would appear in the UrlbarView should they appear in the user's frecency results.
Differential Revision: https://phabricator.services.mozilla.com/D60421
- Allow empty string ("") as a value for "shortcut" in the
commands.update API.
- Use an empty string instead of null for an unset shortcut in
`commands.getAll`, to match the documented behavior (and for
consistency with Chrome).
Differential Revision: https://phabricator.services.mozilla.com/D48994
The openContextMenu test helper uses a default selector parameter that doesn't actually exist in the
test page used (which is about:robots) and so the test was getting stuck because the context menu
was not being opened.
This change is unrelated to the issue fixed in this bugzilla issue, but the timeout failure was
preventing to run all the menus test successfully in a local linux build and so it did seem
worth to look into where the test was getting stuck and ensure that it does pass consistently.
Depends on D60493
Differential Revision: https://phabricator.services.mozilla.com/D60656
Replace `isRestricting` with `getPriority` -- i.e., replace the binary restricting system with a general priority system. Instead of choosing restricting providers, the providers manager chooses the highest-priority providers.
Differential Revision: https://phabricator.services.mozilla.com/D60093
Replace `isRestricting` with `getPriority` -- i.e., replace the binary restricting system with a general priority system. Instead of choosing restricting providers, the providers manager chooses the highest-priority providers.
Differential Revision: https://phabricator.services.mozilla.com/D60093
This both allows proper CSS sizing (it respects max-width), and allows for hidden overflow for long badges.
Using xul:label with textContent fixes the former but doesn't support the latter, so an html:label is used instead.
Differential Revision: https://phabricator.services.mozilla.com/D57652
This API is no longer needed, seeing as the Top Sites experiment is over. Dao suggested in bug 1605958 comment 1 that it be removed.
Differential Revision: https://phabricator.services.mozilla.com/D58375
Content scripts are allowed to run on file:-URLs, but other forms of
file access from extensions are not allowed. This has been the behavior
for a while, but there were no tests. This commit adds tests to ensure
that the functionality continues to work as intended.
Differential Revision: https://phabricator.services.mozilla.com/D54541
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.
Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.
Differential Revision: https://phabricator.services.mozilla.com/D53744
