Commit Graph

2190 Commits

Author SHA1 Message Date
Kris Maglione
7b2657b231 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741
2019-12-13 20:36:24 +00:00
Kris Maglione
8c0d38f33d Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-13 20:36:16 +00:00
Shane Caraveo
b7031396e4 Bug 1586612 properly handle tab events that happen prior to firing tabs.onCreated r=rpl,Gijs
Ensure that our delay in firing the onCreated (TabOpen) event does not result
in other events happening prior to onCreated.

Differential Revision: https://phabricator.services.mozilla.com/D55865
2019-12-13 20:17:39 +00:00
Mark Banner
90cfceb6be Bug 1601681 - Switch recently added files with Windows line endings to Unix. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D55990
2019-12-11 08:12:49 +00:00
shindli
0aa47af90e Backed out 9 changesets (bug 1596918) for causing mochitest permafailures in toolkit/content/tests/chrome/test_findbar_events.xhtml CLOSED TREE
Backed out changeset 45a1c42118f2 (bug 1596918)
Backed out changeset db09910ffa56 (bug 1596918)
Backed out changeset 5c9d9f141c10 (bug 1596918)
Backed out changeset 6a135670d603 (bug 1596918)
Backed out changeset 3a0184e0df72 (bug 1596918)
Backed out changeset 2f0036486823 (bug 1596918)
Backed out changeset a770c6d08d52 (bug 1596918)
Backed out changeset ef062eb7a6ee (bug 1596918)
Backed out changeset a6ea596e98db (bug 1596918)
2019-12-11 03:09:26 +02:00
Kris Maglione
c87948a206 Bug 1596918: Part 4g - Misc cleanup/fixes. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53748
2019-12-10 23:07:41 +00:00
Kris Maglione
40ceb887f2 Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53745
2019-12-10 23:07:34 +00:00
Kris Maglione
af77c00e7a Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744
2019-12-10 23:07:22 +00:00
Kris Maglione
eb68f8b548 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741
2019-12-10 23:07:21 +00:00
Kris Maglione
ad3537fc50 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-10 23:07:13 +00:00
Mélanie Chauvel (ariasuni)
76cfe57b43 Bug 1453355 - Add sidebarAction.toggle() to WebExtensions API r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D54005
2019-12-09 14:52:45 +00:00
Emilio Cobos Álvarez
043ef46657 Bug 1601624 - Write an automated test for this. r=tnikkel
The existing tests changed both width and height, not triggering the bug.

Differential Revision: https://phabricator.services.mozilla.com/D56304
2019-12-08 21:26:08 +00:00
Noemi Erli
21eec8658f Backed out 9 changesets (bug 1596918) for causing multiple browser-chrome failures
Backed out changeset 415007efd8c9 (bug 1596918)
Backed out changeset 011eb5ce927b (bug 1596918)
Backed out changeset e5fd3ee22ea1 (bug 1596918)
Backed out changeset 0bca4de31d40 (bug 1596918)
Backed out changeset 11ec4393f23d (bug 1596918)
Backed out changeset c5404a7c286d (bug 1596918)
Backed out changeset 7e9304405a46 (bug 1596918)
Backed out changeset fa0f0aeabf99 (bug 1596918)
Backed out changeset de196b077000 (bug 1596918)
2019-12-07 22:26:43 +02:00
Kris Maglione
038e9efbd4 Bug 1596918: Part 4g - Misc cleanup/fixes. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53748
2019-12-07 18:44:35 +00:00
Kris Maglione
f1231dcf6a Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53745
2019-12-07 18:44:35 +00:00
Kris Maglione
b442dbf855 Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744
2019-12-07 18:44:34 +00:00
Kris Maglione
6fb2c35351 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741
2019-12-07 18:44:34 +00:00
Kris Maglione
88fbf261f8 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-07 19:11:58 +00:00
Daniel Varga
85f263a4c2 Backed out 17 changesets (bug 1596918) for multiple browser-chrome and dev-tools failures. On a CLOSED TREE
Backed out changeset ab87d2c1afae (bug 1596918)
Backed out changeset 775f3b06a687 (bug 1596918)
Backed out changeset 67cc63ef5d7f (bug 1596918)
Backed out changeset 7d290bcd2067 (bug 1596918)
Backed out changeset 048db9f4db7c (bug 1596918)
Backed out changeset 96a79d2ba614 (bug 1596918)
Backed out changeset be770d112dd8 (bug 1596918)
Backed out changeset 302c8ab8391c (bug 1596918)
Backed out changeset 44ef8f20732e (bug 1596918)
Backed out changeset 38c11ebfb8ff (bug 1596918)
Backed out changeset b586fc081374 (bug 1596918)
Backed out changeset 12283166716f (bug 1596918)
Backed out changeset 99b0421015d8 (bug 1596918)
Backed out changeset 97ec49dbbbf3 (bug 1596918)
Backed out changeset ec79478f58f1 (bug 1596918)
Backed out changeset c6d356833bb8 (bug 1596918)
Backed out changeset 5ef6026806c8 (bug 1596918)
2019-12-07 03:12:07 +02:00
Kris Maglione
d446581341 Bug 1596918: Part 4g - Misc cleanup/fixes. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53748
2019-12-06 22:14:43 +00:00
Kris Maglione
1353082784 Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53745
2019-12-06 22:15:27 +00:00
Kris Maglione
3850c6a060 Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744
2019-12-06 22:15:25 +00:00
Kris Maglione
487c4fe9c7 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741
2019-12-06 22:14:22 +00:00
Kris Maglione
e59706f08a Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-06 22:14:14 +00:00
Luca Greco
15869025c6 Bug 1598079 - Turn abuseReport.openDialog on by default on all channels. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D54026
2019-11-25 17:35:48 +00:00
Marco Bonardo
9918983f83 Bug 1599839 - Merge sources and acceptableSources in UrlbarQueryContext. r=adw,mixedpuppy
Rename acceptableSources to just sources, merge it with the existing sources property.

Differential Revision: https://phabricator.services.mozilla.com/D55082
2019-12-02 17:20:39 +00:00
Shane Caraveo
82889634a5 Bug 1578513 make disable/enable during safe mode update extension settings r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D44595
2019-11-27 20:00:08 +00:00
Shane Caraveo
f559d8e729 Bug 1578513 make uninstall during safemode remove extension settings r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D44594
2019-11-27 22:19:15 +00:00
Shane Caraveo
4e7733502e Bug 1599708 fix setting newtab when setting is updated r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D55022
2019-11-27 21:51:51 +00:00
Drew Willcoxon
9e15f780fb Bug 1599406 - Fix permafailing browser/components/extensions/test/browser/browser_ext_urlbar.js on beta r=mixedpuppy
The `onEngagement` task fails on beta due to how the mock extension is created with `useAddonManager: "temporary"`, which prevents the extension from being able to use `browser.urlbar`. That's the only task in the file that does that. I think I copied it from another test file. Not sure why I just didn't use the pattern in this file.

This also removes `incognitoOverride: "spanning"`. It's not necessary and none of the other tasks do that either.

Differential Revision: https://phabricator.services.mozilla.com/D54795
2019-11-26 19:38:41 +00:00
Harry Twyford
b44681bd25 Bug 1599123 - Rename instances of "search icon" to "search button". r=mak
Differential Revision: https://phabricator.services.mozilla.com/D54539
2019-11-26 09:38:02 +00:00
Harry Twyford
46e835b4a6 Bug 1597698 - Move all megabar prefs under a urlbar.update1 branch. r=mak,dao
Differential Revision: https://phabricator.services.mozilla.com/D54146
2019-11-26 17:15:31 +00:00
Drew Willcoxon
411091c60b Bug 1597610 - Add browser.urlbar.onEngagement WebExtensions API. r=mak,mixedpuppy
Adds a `browser.urlbar.onEngagement` event. Listeners are passed the current engagement state: start, engagement, abandonment, or discard. The extension could use this to record its own parallel telemetry (scalars, event telemetry, etc.) per engagement.

Differential Revision: https://phabricator.services.mozilla.com/D53897
2019-11-25 23:52:56 +00:00
Zibi Braniecki
d441077c48 Bug 1591328 - Migrate the window title to Fluent. r=fluent-reviewers,Gijs,mixedpuppy
Depends on D53775

Differential Revision: https://phabricator.services.mozilla.com/D53776
2019-11-21 19:16:15 +00:00
Matthew Noorenberghe
109be48583 Bug 1595656 - Only clear user-facing passwords with the browsingData API. r=rpl
FxA/Sync stores a credential in login storage but this is no longer user-facing so users shouldn't expect it to be cleared. Users can still diconnect Sync properly from about:preferences.

Differential Revision: https://phabricator.services.mozilla.com/D53834
2019-11-21 14:42:57 +00:00
Narcis Beleuzu
3793f89eb9 Backed out 2 changesets (bug 1595656) for xpcshell failures on test_load_all_api_modules.js . CLOSED TREE
Backed out changeset 061c92c4b95c (bug 1595656)
Backed out changeset ef8d5090979a (bug 1595656)
2019-11-21 03:22:06 +02:00
Matthew Noorenberghe
d09f92f3c0 Bug 1595656 - Only clear user-facing passwords with the browsingData API. r=rpl
FxA/Sync stores a credential in login storage but this is no longer user-facing so users shouldn't expect it to be cleared. Users can still diconnect Sync properly from about:preferences.

Differential Revision: https://phabricator.services.mozilla.com/D53834
2019-11-20 15:07:32 +00:00
Tomislav Jovanovic
aeeaab99c2 Bug 1577498 - Part 1: ExtensionsActor and Conduits design for Fission IPC r=rpl,kmag
Differential Revision: https://phabricator.services.mozilla.com/D44368
2019-11-17 10:18:34 +00:00
Mihai Alexandru Michis
5cfcf0c8ac Bug 1597673 - Revert expectations for browser_ext_devtools_network.js r=kashav
Differential Revision: https://phabricator.services.mozilla.com/D53821
2019-11-19 15:41:39 +00:00
Kashav Madan
2f131c9366 Bug 1595183 - Unskip tests that are failing cleanly or no longer timing out, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D53090
2019-11-19 03:44:07 +00:00
Luca Greco
e5073385d7 Bug 1596542 - Skip test_browserData_should_not_remove_extension_data if LSNG is disabled. r=mixedpuppy
When LSNG is disabled, the browsingData API does clear the localStorage data by notify a "extension:purge-localStorage"
message over the observer service, when the browserData API call doesn't specify a list of specific origins to clear,
the code that handles "extension:purge-localStorage" will clear all the localStorage data, including the one stored by extensions:

- https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/browser/components/extensions/parent/ext-browsingData.js#172
- https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/dom/storage/StorageObserver.cpp#292-295,323,326

Differential Revision: https://phabricator.services.mozilla.com/D53071
2019-11-18 16:14:20 +00:00
Myeongjun Go
eeae9f2f52 Bug 1571110 - Change chrome_settings_overrides.search_provider.favicon_url from "url" to "relativeUrl" r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D52782
2019-11-15 16:30:08 +00:00
Drew Willcoxon
b675728c2a Bug 1595985 - Add browser.urlbar.closeView webextension API. r=mak,mixedpuppy
This is based on D52612

Differential Revision: https://phabricator.services.mozilla.com/D52792
2019-11-13 17:59:08 +00:00
Drew Willcoxon
2c8f573e0c Bug 1595641 - Add a focus option to browser.urlbar.search and add a browser.urlbar.focus function. r=mak,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D52612
2019-11-13 14:36:56 +00:00
Drew Willcoxon
4565a3926d Bug 1594622 - Quantumbar: Remove the context.preselected property and rely on result.heuristic instead r=mak
Please see bug 1594622 for a description.

Differential Revision: https://phabricator.services.mozilla.com/D52120
2019-11-08 18:50:00 +00:00
Drew Willcoxon
530a3a5400 Bug 1590461 - Add browser.urlbar.search() to the webextensions API r=mak,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D52127
2019-11-08 09:39:54 +00:00
Luca Greco
b07dbb8b0c Bug 1575891 - browsingData API should not clear nextGen localStorage data stored by browser components and extensions. r=mixedpuppy,asuth,johannh
Differential Revision: https://phabricator.services.mozilla.com/D48535
2019-11-07 17:00:42 +00:00
Andrew McCreight
dd81732c5b Bug 1580212, part 2 - Make dom.ipc.keepProcessesAlive.webIsolated work for Fission content processes. r=kmag
Also, enable it for the extensions test directory. Without this pref,
it gets frequent intermittent leaks and shutdown hangs when Fission is
enabled.

Differential Revision: https://phabricator.services.mozilla.com/D51752
2019-11-06 23:14:27 +00:00
Mélanie Chauvel (ariasuni)
356c32df7b Bug 1563380 - Fix tabs.duplicate() having a different behavior than duplicate in UI r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D48471
2019-11-05 23:41:56 +00:00
Brendan Dahl
ef30c33394 Bug 1470510 - Rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow. r=smaug
nsXULWindow is no longer XUL specific and is somewhat confusing name.

Differential Revision: https://phabricator.services.mozilla.com/D51486
2019-11-05 17:56:28 +00:00