corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
982,685 Commits 1 Branch 0 Tags
6614ff9a2f912c67726633971880e1d0d7d033a5
Commit Graph

101 Commits

Author SHA1 Message Date
Shane Hughes
ca7244fbbc Bug 1892402 - Make newtab feature callouts handle old themes more gracefully. r=omc-reviewers,negin 
The newtab page is styled according to a `lwt-newtab-brighttext`
attribute, which until now is only present in the newtab page, and not
exposed to the chrome. This is a problem for elements like feature
callouts, which we want to fit in with the newtab content, even though
they exist in the chrome. That's okay in many cases, because the
callouts also use theme properties, and there's usually a concordance
between `lwt-newtab-brighttext` and the content color scheme. But in a
few older (but very popular) themes, there are missing theme properties,
and it's possible for the newtab page to be very dark even though
prefers-color-scheme is not dark.

This patch resolves the issue by exposing `lwt-newtab-brighttext` to the
chrome, and using that attribute to theme newtab callouts.

Differential Revision: https://phabricator.services.mozilla.com/D208256
 2024-04-24 20:54:02 +00:00
Emily McMinn
17efb5e7e2 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D205344
 2024-03-28 16:26:14 +00:00
Cristina Horotan
55e65e2992 Backed out changeset 4577a311fab7 (bug 1886856) for causing newtab failures at asrouter CLOSED TREE 2024-03-27 23:21:01 +02:00
Emily McMinn
ecc39fdb91 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D205344
 2024-03-27 20:00:04 +00:00
Norisz Fay
f3d83af181 Backed out changeset 66d93ead16c4 (bug 1886856) for causing node newtab failure in bundles CLOSED TREE 2024-03-27 21:08:57 +02:00
Emily McMinn
6817fbac59 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D205344
 2024-03-27 17:19:10 +00:00
Jason Prickett
bb433baf3f Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D201902
 2024-03-25 23:05:05 +00:00
Emily McMinn
e2a3a80e3e Bug 1887066 - Reformat schema files in ASRouter r=barret,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D205470
 2024-03-25 15:07:52 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201867
 2024-03-21 22:05:28 +00:00
Mark Banner
1ad86cf71a Bug 1881816 - Rename ActorConstants.sys.mjs to ActorConstants.mjs. r=amy,omc-reviewers,aminomancer 
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203401
 2024-03-19 17:01:38 +00:00
Mark Banner
fb8a38fb26 Bug 1881816 - Rename Actions.sys.mjs to Actions.mjs. r=amy,omc-reviewers,aminomancer 
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203400
 2024-03-19 17:01:37 +00:00
Natalia Csoregi
4bf66df843 Backed out changeset 4707e617d389 (bug 1876173) for causing newtab failures on aboutwelcome. CLOSED TREE 2024-03-14 00:38:01 +02:00
Jason Prickett
faeefc390a Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D201902
 2024-03-13 21:28:06 +00:00
Natalia Csoregi
a6b8803582 Backed out changeset d488b0a57d95 (bug 1876173) for causing fxms failures. CLOSED TREE 2024-03-13 21:17:52 +02:00
Jason Prickett
9f76e777a7 Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D201902
 2024-03-13 18:23:44 +00:00
Punam Dahiya
bda9f1263a Bug 1877210 - Remove unused asrouter components r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D204122
 2024-03-08 23:06:14 +00:00
Dave Townsend
35c104ff31 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D202950
 2024-03-03 09:09:08 +00:00
Punam Dahiya
d3035fa703 Bug 1879638 - Update Old references to asrouter and aboutwelcome files r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D203330
 2024-03-02 02:36:24 +00:00
negin
601a737f68 Bug 1877557 - Extra configurations for LinkParagraph component for about:welcome r=omc-reviewers,emcminn,pdahiya 
Adds styling for legal copy and updates above_button_config so it renders after tiles/MultiSelect but before action buttons.

Differential Revision: https://phabricator.services.mozilla.com/D200078
 2024-03-01 21:03:23 +00:00
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE 
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
 2024-03-01 18:25:05 +02:00
Dave Townsend
20b5d8c60f Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D202950
 2024-03-01 15:20:17 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE 
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
 2024-03-01 12:58:03 +02:00
Dave Townsend
d5beece355 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D202950
 2024-03-01 10:10:08 +00:00
Shane Hughes
9c7d018917 Bug 1879655 - Fix microsurvey group structure, a11y, and randomization. r=omc-reviewers,emcminn 
Change how microsurveys are structured. This ensures that screen readers
perceive a single logical collection, which contains all the radio
buttons and is labeled by the question, which is no longer defined by
subtitle but by tiles.label. This also changes how survey randomization
works. Instead of randomizing the entire set, we randomize specific
items. Any adjacent items with randomize will be randomized in-place. So
if there are 4 items with randomize, followed by 1 nonrandom item, the 4
will be randomized but the 5th will stay at the bottom. Finally, this
patch saves the randomized order so that it persists between back and
forward navigation on about:welcome. That should avoid some jank if we
show surveys in about:welcome.

Differential Revision: https://phabricator.services.mozilla.com/D202513
 2024-02-27 03:29:29 +00:00
Mark Banner
55dda230bd Bug 1881817 - Move all asrouter/content-src/*.js files which are modules to use .mjs extensions. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D202622
 2024-02-24 10:00:59 +00:00
Mike Conley
0cd6316b40 Bug 1878731 - Convert CFRPageActions to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201126
 2024-02-12 18:49:35 +00:00
Mike Conley
d322adbf27 Bug 1878731 - Convert OnboardingMessageProvider to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201125
 2024-02-12 18:49:35 +00:00
Shane Hughes
d26f937678 Bug 1879220 - Adjust feature callout surface to handle panel surveys. r=jprickett,omc-reviewers 
Fix feature callout teardown while a tour is still ongoing.
Add an option to space out the CTA buttons.
Add dynamic disabling of secondary_button.
Add randomization for the MultiSelect component, mainly for surveys.
Improve test coverage.
Add documentation for the above changes plus some missing things.

Differential Revision: https://phabricator.services.mozilla.com/D201027
 2024-02-08 22:48:27 +00:00
pstanciu
e5fa393947 Backed out changeset 7aee47be18bf (bug 1879220) for causing node newtab failures at aboutwelcome. CLOSED TREE 2024-02-08 17:55:42 +02:00
Shane Hughes
ebe66ac58f Bug 1879220 - Adjust feature callout surface to handle panel surveys. r=jprickett,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201027
 2024-02-08 12:30:25 +00:00
Mark Banner
b3b56aa2eb Bug 1878556 - Remove unused asrouter/content-src/template-utils.js. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200591
 2024-02-07 08:55:33 +00:00
Mark Banner
12a8012f22 Bug 1878556 - Move addUtmParams.js to aboutwelcome and rename to .mjs. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200590
 2024-02-07 08:55:32 +00:00
Mark Banner
257b6d2dc7 Bug 1878554 - Simplify react/jsx-no-bind definition for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200585
 2024-02-07 08:55:30 +00:00
Cristian Tuns
8829a8d6c5 Backed out 11 changesets (bug 1878554, bug 1878553, bug 1878556) for causing node failures in aboutwelcome CLOSED TREE 
Backed out changeset 425f70fa7e5a (bug 1878556)
Backed out changeset 2ab3a28f5c04 (bug 1878556)
Backed out changeset fb2e02682c8c (bug 1878556)
Backed out changeset 2fc5e630568e (bug 1878554)
Backed out changeset 78839d5841b4 (bug 1878554)
Backed out changeset e0ab31d2de1b (bug 1878554)
Backed out changeset 4eb59e4ebafa (bug 1878554)
Backed out changeset ab1e077d3f84 (bug 1878554)
Backed out changeset ef999f293e3e (bug 1878553)
Backed out changeset cf49920cb1ad (bug 1878553)
Backed out changeset 95f0fce63726 (bug 1878553)
 2024-02-07 01:26:39 -05:00
Mark Banner
f15c9c508b Bug 1878556 - Remove unused asrouter/content-src/template-utils.js. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200591
 2024-02-06 22:32:55 +00:00
Mark Banner
ed1bb292be Bug 1878556 - Move addUtmParams.js to aboutwelcome and rename to .mjs. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200590
 2024-02-06 22:32:54 +00:00
Mark Banner
617d0bb8f5 Bug 1878554 - Simplify react/jsx-no-bind definition for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200585
 2024-02-06 22:32:52 +00:00
Mike Conley
65ab386408 Bug 1877196 - Move FeatureCallout modules and styles to browser/components/asrouter. r=fxview-reviewers,omc-reviewers,sclements,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200514
 2024-02-05 22:03:16 +00:00
Mike Conley
02fbf941fd Bug 1877196 - Move ActorConstants.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers 
We import the ActorConstants into the ASRouter unit-entry.js script because
ASRouterChild.sys.mjs loads ActorConstants.sys.mjs, and the ResourceUriPlugin
that does the rewriting for the Karma tests doesn't understand how to do
remapping outside of the newtab folder.

So instead of trying to hack that capability into ResourceUriPlugin, we
just import the ActorConstants into the Karma global scope.

Differential Revision: https://phabricator.services.mozilla.com/D200087
 2024-02-05 22:03:15 +00:00
Mike Conley
c5da337999 Bug 1877202 - Move ModalOverlay back over to browser/components/newtab. r=thecount 
This originally got moved as part of bug 1868838 because it was under
browser/components/newtab/content-src/asrouter/components - however,
pdahiya points out that this component was actually only ever used
by newtab, so it makes more sense living over there.

Differential Revision: https://phabricator.services.mozilla.com/D200391
 2024-02-01 23:35:23 +00:00
Mike Conley
378c760146 Bug 1868838 - Move PanelTestProvider to browser/components/asrouter/modules. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198999
 2024-01-29 18:52:28 +00:00
Mike Conley
ab18bd7d99 Bug 1868838 - Move OnboardingMessageProvider to browser/components/asrouter/modules. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198997
 2024-01-29 18:52:28 +00:00
Mike Conley
523d9e2457 Bug 1868838 - Move messaging schemas into browser/components/asrouter. r=pdahiya,barret 
Differential Revision: https://phabricator.services.mozilla.com/D198955
 2024-01-29 18:52:27 +00:00
Mike Conley
7fc079d515 Bug 1868838 - Move template-utils into browser/components/asrouter. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198890
 2024-01-29 18:52:24 +00:00
Mike Conley
efe999860a Bug 1868838 - Move ImpressionsWrapper and ConditionalWrapper into browser/components/asrouter. r=pdahiya 
These don't appear to be used anywhere, but moving them anyways.

Differential Revision: https://phabricator.services.mozilla.com/D198889
 2024-01-29 18:52:24 +00:00
Mike Conley
ef3fd292cf Bug 1868838 - Move asrouter-utils into browser/components/asrouter. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198883
 2024-01-29 18:52:23 +00:00
Mike Conley
6dc4814bc3 Bug 1868838 - Move Button into into browser/components/asrouter. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198882
 2024-01-29 18:52:23 +00:00
Mike Conley
0ae871c74e Bug 1868838 - Move ModalOverlay into browser/components/asrouter. r=pdahiya 
Previous patches in the stack had used asroutermodules as an alias to get
at browser/components/asrouter/modules. This patch, however, required adding
an alias to get at asrouter/content-src/components, so asroutermodules was
replaced with a top-level asrouter alias.

Differential Revision: https://phabricator.services.mozilla.com/D198881
 2024-01-29 18:52:22 +00:00
Mike Conley
fe5402f48c Bug 1866802 - Move ASRouterAdmin tool to about:asrouter and its own component folder. r=pdahiya,Gijs,desktop-theme-reviewers,dao 
This tries to maintain stylistic continuity, while also trying to decouple from
newtab as much as possible. This is a first foray, and future patches will
further this decoupling.

This also modifies about:asrouter to show an error message if the ASRouter devtools
pref is not set to true.

Differential Revision: https://phabricator.services.mozilla.com/D194811
 2023-12-14 18:46:55 +00:00
Butkovits Atila
e9b8149367 Backed out 5 changesets (bug 1866802) for causing failures at test_TopSitesFeed.js. CLOSED TREE 
Backed out changeset af9fbbc9ae50 (bug 1866802)
Backed out changeset 81d5b7de7178 (bug 1866802)
Backed out changeset e4d0863ed222 (bug 1866802)
Backed out changeset c0deb681b193 (bug 1866802)
Backed out changeset dda3e5e39f8c (bug 1866802)
 2023-12-14 03:22:48 +02:00