corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
982,685 Commits 1 Branch 0 Tags
6614ff9a2f912c67726633971880e1d0d7d033a5
Commit Graph

101 Commits

Author SHA1 Message Date
negin
e157e3e2ed Bug 1968335 - Add ability to configure infobar buttons to not dismiss the infobar on click a=dmeehan 
Original Revision: https://phabricator.services.mozilla.com/D251068

Differential Revision: https://phabricator.services.mozilla.com/D251187
 2025-05-27 18:48:35 +00:00
Rebecca King
5a894ba744 Bug 1964836 - Clean up AboutWelcomeShopping and Shopping messages - r=shopping-reviewers,omc-reviewers,emcminn,fchasen 
Differential Revision: https://phabricator.services.mozilla.com/D248957
 2025-05-22 18:04:34 +00:00
isaac
34664bd6e0 Bug 1959517 - [themes] Replace all instances of font-weight: 590 with the --font-weight-bold token. r=hjones,desktop-theme-reviewers,omc-reviewers,urlbar-reviewers,mimi,jteow,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D246064
 2025-05-06 00:37:08 +00:00
Meg Viar
d42d78e05a Bug 1964116 - Update infobar schema to reflect that 'text' can be an array r=jprickett,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D247646
 2025-05-05 09:43:25 +00:00
Meg Viar
81929eb72f Bug 1960078 - Add universal type to InfoBar to show notification across all current and new windows r=omc-reviewers,mimi 
Differential Revision: https://phabricator.services.mozilla.com/D245309
 2025-04-23 20:58:27 +00:00
negin
05fbc8e569 Bug 1930250 - Adds AppMenu configuration and styling for 'row' layout r=omc-reviewers,mconley,emcminn 
Adds configuration for row layout design that we'd like to eventually rollout. See [figma](https://www.figma.com/design/qe9yX8x51jjbt6DJYgayg2/Device-Migration--Account-and-Multi-Device-Adoption-?node-id=8208-4895&m=dev)

{F19072665}

{F19072664}

{F19072663}

Differential Revision: https://phabricator.services.mozilla.com/D246145
 2025-04-23 19:50:32 +00:00
Meg Viar
0c85630592 Bug 1958972 - Add dismissable property configurable for infobars r=reusable-components-reviewers,omc-reviewers,emcminn,hanna_a,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D244668
 2025-04-09 14:22:08 +00:00
Nathan Barrett
3df69e20a2 Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer,maxx 
Differential Revision: https://phabricator.services.mozilla.com/D240175
 2025-03-25 14:34:05 +00:00
Stanca Serban
92c3bbb32a Backed out 4 changesets (bug 1954848, bug 1951426, bug 1951782, bug 1953632) for causing xpcshell failures in test_NewTabMessaging.js. CLOSED TREE 
Backed out changeset b2ee50813323 (bug 1954848)
Backed out changeset 211563f87799 (bug 1953632)
Backed out changeset 5003a2a06685 (bug 1951782)
Backed out changeset 4a882623c86d (bug 1951426)
 2025-03-24 20:46:17 +02:00
Nathan Barrett
84c498dc3b Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer,maxx 
Differential Revision: https://phabricator.services.mozilla.com/D240175
 2025-03-24 17:42:04 +00:00
Goloman Adrian
ac2cd44a24 Backed out 4 changesets (bug 1953632, bug 1951782, bug 1951426, bug 1954848) for causing build bustages. CLOSED TREE 
Backed out changeset 6825e2911771 (bug 1954848)
Backed out changeset 56f68e9e9ab5 (bug 1953632)
Backed out changeset bda4413155d7 (bug 1951782)
Backed out changeset 04623acb0ff2 (bug 1951426)
 2025-03-21 20:38:15 +02:00
Nathan Barrett
3957775da8 Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D240175
 2025-03-21 15:26:34 +00:00
Stanca Serban
4380403c09 Backed out 4 changesets (bug 1951426, bug 1954848, bug 1953632, bug 1951782) for causing Node tests failures. CLOSED TREE 
Backed out changeset 2a8c811ce373 (bug 1954848)
Backed out changeset 04b8c4b9620a (bug 1953632)
Backed out changeset b51759b5f846 (bug 1951782)
Backed out changeset fc971f683077 (bug 1951426)
 2025-03-20 23:36:40 +02:00
Nathan Barrett
9e01a2ba3e Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D240175
 2025-03-20 14:12:21 +00:00
negin
e4a5516610 Bug 1895755 - Updates default min-height for feature callout ctas to 24px r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D238832
 2025-03-06 21:14:52 +00:00
Emily McMinn
c4129a5ba8 Bug 1945700 - Add a boolean background property to dismiss buttons that enables contrasting colours r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D237640
 2025-02-28 23:12:17 +00:00
Shane Hughes
e9c7fc6d9f Bug 1950189 - Allow callouts to be dismissed by Esc even if they're not focused. r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D239402
 2025-02-27 08:31:42 +00:00
Emilio Cobos Álvarez
1ed7833723 Back out bug 1950189 because I pushed it accidentally. 
MANUAL PUSH: Back out CLOSED TREE
 2025-02-27 01:16:22 +01:00
Shane Hughes
cbe67161c2 Bug 1950189 - Allow callouts to be dismissed by Esc even if they're not focused. r=#omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239402
 2025-02-27 01:00:36 +01:00
Rebecca King
b3a22ac978 Bug 1938253 - Implement Callout 3 for integrated version of Review Checker - r=kpatenio,shopping-reviewers,fluent-reviewers,settings-reviewers,omc-reviewers,aminomancer,bolsson,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D233053
 2025-02-24 18:15:36 +00:00
kpatenio
4f78e49bfd Bug 1925408 - add illustrations for opt-in UI. r=shopping-reviewers,fluent-reviewers,omc-reviewers,bolsson,fchasen,pdahiya 
- Adds new illustrations and copy
- Shows a variant using emptyStateB for supported sites and PDPs
- Shows a variant using emptyStateC for unsupported sites
- To test the feature, set browser.shopping.experience2023.integratedSidebar=true, browser.shopping.experience2023.shoppingSidebar=true. Also set browser.shopping.experience2023.optedIn=0.
- To see the variant with emptyStateB, go to any page within amazon.com, bestbuy.com or walmart.com.
- To see the variant with emptyStateC, go to any page that's not amazon, bestbuy or walmart.
- Added tests to distinguish between empty state variants for the opt-in screen

Differential Revision: https://phabricator.services.mozilla.com/D226075
 2025-01-17 01:52:35 +00:00
Meg Viar
984098dbc2 Bug 1933221 - Add ability to disable closing Spotlight via ESC keypress via message JSON configuration r=omc-reviewers,hanna_a,jprickett 
To support an upcoming experiment (details linked in Jira ticket referenced in bug), we want to add the ability to disable closing Spotlight with an ESC keypress via a message JSON configuration.

Differential Revision: https://phabricator.services.mozilla.com/D230170
 2024-12-13 16:34:50 +00:00
Emilio Cobos Álvarez
ebe0ec0cbc Bug 1388910 - Remove -moz-user-modify property. r=dshin 
We successfully unshipped it in bug 1920118.

Differential Revision: https://phabricator.services.mozilla.com/D229530
 2024-11-19 19:35:35 +00:00
Emily McMinn
803813abef Bug 1903708 - Enable about:messagepreview to preview private browsing messages r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D220289
 2024-10-30 22:10:37 +00:00
Punam Dahiya
8d7c4d95e6 Bug 1927878 - Make Attribution parameters in devtools editable r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D227263
 2024-10-29 23:26:31 +00:00
Rebecca King
d7e1907648 Bug 1916815 - Replace --in-content-accent-color variable with the --color-accent-primary token r=desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D224509
 2024-10-21 14:50:46 +00:00
Hanna Jones
99fc51fda2 Bug 1921088 - Upgrade Stylelint and related libraries to the latest version r=Standard8,devtools-reviewers,omc-reviewers,home-newtab-reviewers,nchevobbe,thecount,desktop-theme-reviewers,dao,aminomancer 
In addition to upgrding our Stylelint packages, this patch also introduces the @stylistic/stylelint-plugin to preserve a number of rules that were completely removed in v16. It also migrates the code for the custom plugin introduced in bug 1838298 to ES Modules.

Differential Revision: https://phabricator.services.mozilla.com/D224250
 2024-10-15 19:39:46 +00:00
Mike Conley
dd4373aecb Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett 
Developing tests in a later patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D223409
 2024-10-15 16:15:09 +00:00
jabram
32769d20ee Bug 1865371 - Replace --in-content-box-background with --background-color-box r=cmkm,desktop-theme-reviewers,credential-management-reviewers,omc-reviewers,aminomancer,dao,issammani 
Differential Revision: https://phabricator.services.mozilla.com/D222674
 2024-10-07 20:15:01 +00:00
Shane Hughes
e919464011 Bug 1922147 - Use only textareas for ASRouterAdmin targeting editors. r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D224270
 2024-10-03 17:16:22 +00:00
Jason Prickett
2817fb56a2 Bug 1901617 - Create onboarding checklist r=mviar,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D221538
 2024-09-26 17:54:01 +00:00
kpatenio
f4e025a957 Bug 1916016 - update opt-in card for migration to Firefox sidebar r=fluent-reviewers,omc-reviewers,shopping-reviewers,fchasen,pdahiya 
- Updated `AboutWelcomeChild.sys.mjs` to a new opt-in card `FS_OPT_IN_SIDEBAR_VARIANT` that is rendered only if `browser.shopping.experience2023.integratedSidebar`
- Updated styling for the integrated RC in `aboutwelcome.css`
- Added non-exposed strings to `shopping.ftl`
- Updated tests to work for both integrated and non-integrated versions

Differential Revision: https://phabricator.services.mozilla.com/D221396
 2024-09-18 20:51:03 +00:00
Sandor Molnar
446bc20f4d Backed out changeset cf3a30d74dec (bug 1916016) for causing xpc failures @ test_sorted_alphabetically.js CLOSED TREE 2024-09-19 01:08:05 +03:00
kpatenio
9e138be518 Bug 1916016 - update opt-in card for migration to Firefox sidebar r=fluent-reviewers,omc-reviewers,shopping-reviewers,fchasen,pdahiya 
- Updated `AboutWelcomeChild.sys.mjs` to a new opt-in card `FS_OPT_IN_SIDEBAR_VARIANT` that is rendered only if `browser.shopping.experience2023.integratedSidebar`
- Updated styling for the integrated RC in `aboutwelcome.css`
- Added non-exposed strings to `shopping.ftl`
- Updated tests to work for both integrated and non-integrated versions

Differential Revision: https://phabricator.services.mozilla.com/D221396
 2024-09-18 20:51:03 +00:00
Mark Banner
aabcf18c26 Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221443
 2024-09-12 21:08:44 +00:00
Sandor Molnar
b59809ee6a Backed out 8 changesets (bug 1917532, bug 1575506, bug 1917530) for causing node newtab failures CLOSED TREE 
Backed out changeset 8d6f7bc74d08 (bug 1917532)
Backed out changeset 7c963e72cf06 (bug 1575506)
Backed out changeset d5e110187781 (bug 1917530)
Backed out changeset 1d2325ffded6 (bug 1917530)
Backed out changeset 8a361e37e32c (bug 1917530)
Backed out changeset c4011d92c7f7 (bug 1917530)
Backed out changeset 1a45047dfb3c (bug 1917530)
Backed out changeset ed6b35444c45 (bug 1917530)
 2024-09-12 20:45:28 +03:00
Mark Banner
e3981e1099 Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221443
 2024-09-12 16:41:58 +00:00
hanna alemu
698a6834b4 Bug 1901261 - Create a remotely configurable bookmarks bar button messaging surface r=mviar,desktop-theme-reviewers,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D215252
 2024-07-31 15:09:21 +00:00
Tamas Szentpeteri
03b8b4ec2d Backed out changeset 8e5aa4b063cc (bug 1901261) for causing py3 failures on make-schemas.py. CLOSED TREE 2024-07-31 17:13:20 +03:00
hanna alemu
f04c2799bc Bug 1901261 - Create a remotely configurable bookmarks bar button messaging surface r=mviar,desktop-theme-reviewers,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D215252
 2024-07-31 13:21:47 +00:00
Shane Hughes
080905839f Bug 1905119 - Fix feature callout RTL display. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D216597
 2024-07-16 02:11:32 +00:00
negin
33463aa315 Bug 1903841 - Remove ghost shadow on feature callout r=omc-reviewers,aminomancer,mviar 
Removes additional 'ghost' shadow around the feature callout container when the feature callout repositions.

Before:
{F7346454}

After:
{F7346458}

Differential Revision: https://phabricator.services.mozilla.com/D215117
 2024-06-28 14:36:21 +00:00
Shane Hughes
8ce2ea1d0f Bug 1903697 - Slightly improve ASRouter Admin styles. r=emcminn,omc-reviewers 
- Give all bordered tables 100% width.
- Show which view is active in the sidebar by highlighting the active
  tab in blue. Adjust the sidebar styles to match about:preferences.
- Increase the space between filter columns.

Differential Revision: https://phabricator.services.mozilla.com/D214353
 2024-06-24 19:52:53 +00:00
Shane Hughes
259507acf6 Bug 1861248 - Overhaul ASRouter admin and remove its dependency on newtab. r=omc-reviewers,emcminn 
For starters, replace all newtab styles and functions. Since we're
removing these styles, I conformed the asrouter admin to the reusable
components team's design tokens. So, it now uses global system page
styles. This is a pretty general overhaul since there are so many styles
to replace. In addition to the style changes, I've added a new Filters
UI and moved the groups table to the General tab. This allows us to
remove the Message Groups tab since that functionality is now rolled
into the Filters UI. The same with the Private Browsing tab: when you
hit Show on a pb_newtab message, it will open a PB window and override
the message. And you can filter by template now, so you can view only PB
messages on the General tab. I also fixed spellchecking. Instead of
spellchecking, which only works for natural languages, we just validate
that the text is valid JSON. If it's not valid, we show a red border on
the textarea. That way messages won't just mysteriously fail to show. I
also moved a few elements around to conserve space. Now, everything
should be able to fit on the screen of a default window size of 1500px.
Finally, I removed some old cruft that was left over from when the admin
interface was part of the newtab page.

Differential Revision: https://phabricator.services.mozilla.com/D213865
 2024-06-19 19:45:03 +00:00
Shane Hughes
e458f3a38a Bug 1899030 - Part 1: Remove ASRouterUserEvent from Actions.mjs. r=mconley,omc-reviewers,home-newtab-reviewers,negin,firefox-desktop-core-reviewers ,pdahiya,thecount 
Also remove unused action types and the unused ASRouter reducer.

Differential Revision: https://phabricator.services.mozilla.com/D211669
 2024-06-19 19:45:01 +00:00
Shane Hughes
47a7dce369 Bug 1900511 - Fix RC survey background, shadow, and transitions. r=omc-reviewers,pdahiya,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D212499
 2024-06-18 16:58:32 +00:00
negin
ea70e6fdc9 Bug 1900984 - Fix Ghost shadow on feature callout arrow when flip=slide makes the arrow disappear r=omc-reviewers,mviar 
Before:
{F7308121}

After:
{F7308122}

Notice the lack of the arrow's shadow on mac OS.

Differential Revision: https://phabricator.services.mozilla.com/D213675
 2024-06-18 15:06:03 +00:00
Emilio Cobos Álvarez
76dfae476f Bug 1902896 - Use system-ui font-family when appropriate. r=desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,dao,aminomancer,thecount 
This is shorter, and has the advantage that it behaves properly on Linux (not
just ubuntu). Also, it is more future-proof.

Differential Revision: https://phabricator.services.mozilla.com/D213880
 2024-06-17 14:53:04 +00:00
Shane Hughes
64ab25b51e Bug 1898346 - Fix feature callout incompatibility with transparent theme variables. r=negin,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D211275
 2024-05-28 17:59:47 +00:00
Sarah Chung
9a286a1dc8 Bug 1877512 - change feature-callout dismiss-button background color to transparent r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D209302
 2024-05-03 15:48:26 +00:00