Commit Graph

335 Commits

Author SHA1 Message Date
Adam Vandolder
2d308415a4 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-11-25 23:18:32 +00:00
Sebastian Hengst
4d78eba78c Bug 1922355 - adjust mochitest expectations for macOS 14.70 x86-64. r=jmaher,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D229944
2024-11-25 16:28:39 +00:00
Stephen Thompson
19712400f0 Bug 1932670: Add restore tab group API to session r=dao,sessionstore-reviewers,tabbrowser-reviewers
Adds `restoreTabGroup` to SessionStore, enabling a closed tab group or saved tab group to come back into the tab strip.

Includes more robust functionality for forgetting a saved tab group or closed tab group.

Differential Revision: https://phabricator.services.mozilla.com/D230011
2024-11-25 02:44:50 +00:00
DJ
7da91bc6c5 Bug 1923652 - enable save & close for tab groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D229721
2024-11-22 16:46:19 +00:00
Dão Gottwald
304c11a239 Bug 1923653 - tab group UI: enable "delete group". r=tabbrowser-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D229507
2024-11-21 11:56:31 +00:00
Cosmin Sabou
48f9c79723 Backed out changeset ffc3435411be (bug 1923653) for causing mass test failures. 2024-11-20 20:32:20 +02:00
Dão Gottwald
05669b79ee Bug 1923653 - tab group UI: enable "delete group". r=tabbrowser-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D229507
2024-11-20 16:51:30 +00:00
Dave Townsend
b3cc842b7b Bug 1931412: Don't hold test windows alive for cleanup. r=Standard8
browser_scroll_size_determination.js is occasionally leaking browser windows. My theory is that this
is happening because `BrowserTestUtils.overflowTabs` keeps them alive in order to reset the
scrollbox attribute that it changed and then there is not enough time after cleanup for the windows
to get fully collected. Given that these windows are closed anyway there is no need to actually do
this cleanup step so this allows us to skip it.

Differential Revision: https://phabricator.services.mozilla.com/D229587
2024-11-20 15:12:16 +00:00
Stephen Thompson
841ffe9813 Bug 1921830 - move active tab left/right into/out of tab groups r=dao
Adds tab group contexts to the functionality behind keyboard shortcuts for moving the active tab left/right in the tab strip

Differential Revision: https://phabricator.services.mozilla.com/D227253
2024-11-19 19:40:21 +00:00
Sebastian Hengst
8424c52dc1 Bug 1922355 - macOS 14.70: adjust expectations for mochitests and xpcshell tests. r=jmaher,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228118
2024-11-19 17:19:24 +00:00
Greg Stoll
5bad86a2d5 Bug 1926390 part 2 - add telemetry and tests for explicit tab unloading r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D229141
2024-11-18 15:02:41 +00:00
codesuki
95975f82f7 Bug 655445 - Add setting to control position of tabs opened from pinned tabs. r=dao,tabbrowser-reviewers
This patch introduces `browser.tabs.insertAfterCurrentExceptPinned`.
Setting it to `true` open links from pinned tabs at the end of the tabbar.

Differential Revision: https://phabricator.services.mozilla.com/D69489
2024-11-15 11:51:17 +00:00
Dão Gottwald
ddc5737e8c Bug 1928166 - Maintain tab order when ungrouping. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228990
2024-11-14 19:52:58 +00:00
Gijs Kruitbosch
a50c45946e Bug 1927094 - optimize lineScrollAmount so it doesn't iterate over all tabs, r=mconley,dao
Differential Revision: https://phabricator.services.mozilla.com/D226907
2024-11-14 17:14:50 +00:00
Jeremy Swinarton
8a3c3e1e4c Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-12 16:34:19 +00:00
Dão Gottwald
b567a0990b Bug 1926371 - Make "Remove from group" not move the tab into another group. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228636
2024-11-12 14:09:52 +00:00
Stephen Thompson
b25e5f9796 Bug 1929384 - do not close window if there are still collapsed tab groups r=dao,tabbrowser-reviewers
When closing the last visible tab, if there are any collapsed tab groups, make one of the tabs in a tab group active. Based on pre-existing behavior, activating a tab in a collapsed tab group causes the tab group to expand.

Currently, if you close the last visible tab while you still have collapsed tab groups present on the tab bar, the browser window will close. This is surprising and sad behavior for users.

Differential Revision: https://phabricator.services.mozilla.com/D228274
2024-11-11 10:39:11 +00:00
Butkovits Atila
85eb562171 Backed out changeset 307c830b0d2b (bug 1908422) for causing failures at browser_tab_groups.js. CLOSED TREE 2024-11-08 21:50:37 +02:00
Jeremy Swinarton
f5892027d4 Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-08 17:29:38 +00:00
Alexandru Marc
f7c8138cf9 Backed out changeset 9e5edf53c876 (bug 1908422) for causing bc failures @ browser_tab_groups_a11y.js 2024-11-08 16:57:36 +02:00
Jeremy Swinarton
62d713d116 Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-08 13:53:19 +00:00
Stephen Thompson
120dd5317f Bug 1922268: inserting tabs behaves with adjacent tab groups r=dao,tabbrowser-reviewers
Fixes a number of edge cases where tabs created/inserted in the tab strip were incorrectly being placed inside of an adjacent tab group or incorrectly being placed outside of the intended tab group

Differential Revision: https://phabricator.services.mozilla.com/D226705
2024-11-05 17:57:09 +00:00
Stephen Thompson
8e4dfe1e0e Bug 1921814 - add keyboard focus for tab group labels r=dao,dwalker,desktop-theme-reviewers,tabbrowser-reviewers
This patch makes tab group labels "focusable" using the keyboard when the tab strip contains both tabs and tab groups.

Differential Revision: https://phabricator.services.mozilla.com/D226154
2024-11-05 16:52:19 +00:00
DJ
3b0844e1e4 Bug 1922276 - addTabGroup: add showCreateUI option and don't show post-create UI by default. r=dao,jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226957
2024-11-05 15:59:01 +00:00
Norisz Fay
a327d3221e Backed out changeset 9515be9963ea (bug 1927094) for causing bc failures on browser_hide_sidebar_on_popup.js CLOSED TREE 2024-11-05 13:53:00 +02:00
Gijs Kruitbosch
ea7dda1742 Bug 1927094 - optimize lineScrollAmount so it doesn't iterate over all tabs, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D226907
2024-11-05 10:03:35 +00:00
Iulian Moraru
ba826d51af Backed out changeset 068e6a4704bf (bug 1922276) for causing bc failures on browser_tab_groups.js. 2024-11-05 01:45:16 +02:00
DJ
0de1e8d91b Bug 1922276 - addTabGroup: add showCreateUI option and don't show post-create UI by default. r=dao,jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226957
2024-11-04 16:31:09 +00:00
Greg Stoll
1a7c0be524 Bug 1926055 part 2 - add tests for "Unload Tab" context menu r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D226347
2024-11-04 12:20:09 +00:00
DJ
181219c0f1 Bug 1923651 - implement "move group to new window" in tabgroup edit menu. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226325
2024-10-31 15:01:07 +00:00
Joel Maher
4e8be13107 Bug 1920294 - disable browser_tab_groups.js on linux for high failure rate. r=aryx,tabbrowser-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D227055
2024-10-29 14:47:33 +00:00
Norisz Fay
7c7d41d846 Backed out changeset 5b4cea7ea948 (bug 1924861) for causing mochitest failures on test_ext_tabs_goBack_goForward.html, test_bug1300461.html CLOSED TREE 2024-10-29 04:57:43 +02:00
Adam Vandolder
b0355ca479 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-10-29 00:27:19 +00:00
DJ
079c3f85da Bug 1926293 - handle moving tabs into groups across windows. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226729
2024-10-28 14:15:58 +00:00
Brian Grinstead
f6bb34aa25 Bug 1925724 - Use page wireframe for tab hover preview as a fallback when a normal thumnail is not available;r=mconley,sessionstore-reviewers,tabbrowser-reviewers,farre
This will only work when the pref is enabled (browser.history.collectWireframes), and is being landed primarily
to allow some expanded testing to see if it's worth cleaning this up further and turning it on.

Differential Revision: https://phabricator.services.mozilla.com/D226080
2024-10-24 03:34:40 +00:00
Tooru Fujisawa
c12ea81355 Bug 1923593 - Ignore the active tab when handling drag and drop for the tab list. r=mak,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D225723
2024-10-23 07:24:39 +00:00
Dão Gottwald
387c997901 Bug 1926248 - Opening the tab group create or edit panel should focus the name field, and Enter should close the panel. r=sthompson,jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226455
2024-10-22 15:50:24 +00:00
Sandor Molnar
d6591f5235 Backed out 2 changesets (bug 1926055) for causing bc failures @ browser_multiselect_tabs_unload_with_beforeunload.js CLOSED TREE
Backed out changeset 85a555f31920 (bug 1926055)
Backed out changeset db41b497b1be (bug 1926055)
2024-10-22 06:14:17 +03:00
Greg Stoll
4942290677 Bug 1926055 part 2 - add tests for "Unload Tab" context menu r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D226347
2024-10-22 01:34:34 +00:00
Dão Gottwald
f049ccd8d8 Bug 1925842 - Rename _numPinnedTabs to pinnedTabCount. r=tabbrowser-reviewers,jswinarton,dwalker
Also move getDuplicateTabsToClose and getAllDuplicateTabsToClose away from essentials at the top, closer to related methods.

Differential Revision: https://phabricator.services.mozilla.com/D226279
2024-10-21 14:35:06 +00:00
Jeremy Swinarton
548e49013a Bug 1922655: New tab groups are positioned in the tab strip based on TabContextMenu.contextTab r=dao,sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D225071
2024-10-16 20:04:07 +00:00
Jeremy Swinarton
0323d4afe9 Bug 1918712: Context menu to remove tab from group r=dao,fluent-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D224480
2024-10-16 15:18:21 +00:00
Dão Gottwald
23219d1d28 Bug 1924532 - Move tabMediaIndicator tests to browser/components/tabbrowser/. r=tabbrowser-reviewers,frontend-codestyle-reviewers,dwalker,mossop
Differential Revision: https://phabricator.services.mozilla.com/D225516
2024-10-15 16:04:13 +00:00
DJ
d43a8cef11 Bug 1923865 - revise call signature for addTabGroup. r=jswinarton,sessionstore-reviewers,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D225386
2024-10-15 14:10:39 +00:00
Dão Gottwald
190385db86 Bug 1924105 - Move tab tests from browser/base/ to browser/components/tabbrowser/. r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D225356
2024-10-14 14:22:00 +00:00
Noemi Erli
b46f4395ab Backed out changeset 01b405611664 (bug 1924105) for causing failures in browser_new_file_whitelisted_http_tab.js 2024-10-12 06:49:39 +03:00
Dão Gottwald
d0520687fb Bug 1924105 - Move tab tests from browser/base/ to browser/components/tabbrowser/. r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D225356
2024-10-11 20:50:10 +00:00
Dão Gottwald
b6f07a6c23 Bug 1924036 - Remove obsolete showOnlyTheseTabs API and reimplement in BrowserTestUtils. r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D225323
2024-10-11 14:25:13 +00:00
DJ
44408879b4 Bug 1918687 - addTabGroup: select unused color if no color specified. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D225102
2024-10-10 20:00:23 +00:00
Jeremy Swinarton
0026e1e3bc Bug 1922262: Tab group context menu chicklet uses correct styling r=dao,desktop-theme-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D224547
2024-10-10 15:00:02 +00:00