Commit Graph

335 Commits

Author SHA1 Message Date
Sandor Molnar
91a3d57c8b Backed out changeset eef63d507b52 (bug 1942375) for causing mochitest with vertical tabs enabled perma failures. CLOSED TREE 2025-02-07 12:07:00 +02:00
DJ
32a6b12a0a Bug 1942375 - Keep tab group manager UI in sync with browser state. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236944
2025-02-07 09:01:40 +00:00
Dão Gottwald
fda9eb5278 Bug 1945264 - Let related new tabs inherit the current tab group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236731
2025-02-04 23:32:36 +00:00
Dão Gottwald
de0ae0ca64 Bug 1943589 - Allow adoptTab to adopt tabs into a tab group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236722
2025-02-04 19:32:43 +00:00
DJ
7a91af273e Bug 1942347 - Disable 'move group to new window' if group is only thing in window. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236717
2025-02-04 16:57:19 +00:00
DJ
b8dcc05a73 Bug 1944733 - fix caller window for open-tab-group-context-menu_moveToNewWindow. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236087
2025-02-03 15:41:48 +00:00
Dão Gottwald
bc676fe35e Bug 1943971 - Let moving tabs to start/end not keep or put them in groups. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236318
2025-02-03 10:15:25 +00:00
Dão Gottwald
4d47d13ad1 Bug 1943885 - Pinning first tab should ungroup it. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236212
2025-01-30 17:01:11 +00:00
Butkovits Atila
47e8c80ae0 Backed out changeset 2e12f5d5b652 (bug 1944733) for causing failures at browser_tab_manager_groups.js. CLOSED TREE 2025-01-30 18:13:15 +02:00
DJ
cf0f30d512 Bug 1944733 - fix caller window for open-tab-group-context-menu_moveToNewWindow. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236087
2025-01-30 13:06:56 +00:00
Dão Gottwald
b377e92246 Bug 1944643 - Dispatch event when saving and closing a group. r=dwalker,tabbrowser-reviewers,omc-reviewers,emcminn
Note that in order to support the callout, we want to dispatch this only when picking "save and close" from the menu.

Differential Revision: https://phabricator.services.mozilla.com/D236020
2025-01-29 19:09:19 +00:00
Dão Gottwald
a49bb76e1e Bug 1932489: Drag/drop based on "element index" instead of tab index. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D234804
2025-01-29 18:37:29 +00:00
DJ
8d61f15c5c Bug 1943032 - Localize tabgroup aria-label and description. r=dao,fluent-reviewers,tabbrowser-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D235640
2025-01-28 14:51:28 +00:00
Dão Gottwald
5e253e3ce8 Bug 1944083 - Clicking outside the tab group create panel should keep the new group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235667
2025-01-28 11:39:14 +00:00
Dão Gottwald
6f30f874cf Bug 1940269 - Place a "Show more" button in tab overflow menu in tab groups section if there's more than 6 tab groups. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D235422
2025-01-25 00:49:15 +00:00
Stanca Serban
149deaac25 Backed out 3 changesets (bug 1325876) for causing Linux related puppeteer failures. CLOSED TREE
Backed out changeset 2dcbd388c95f (bug 1325876)
Backed out changeset ba3a433729a6 (bug 1325876)
Backed out changeset 42f5ed6abce5 (bug 1325876)
2025-01-24 03:47:23 +02:00
Sean
5f0c924ed3 Bug 1325876 - Add a pref for showing error page for HTTP responses with error codes and Content-Length: 0 r=necko-reviewers,valentin,credential-management-reviewers,tabbrowser-reviewers,dimi,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D232429
2025-01-23 21:57:38 +00:00
DJ
6c42b70610 Bug 1940981 - fix permafail in browser_tab_manager_groups.js. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235318
2025-01-23 15:28:30 +00:00
Dão Gottwald
c4a94bbaa7 Bug 1942176 - Handle context menu key for tab group labels, r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D234668
2025-01-20 15:25:23 +00:00
DJ
857429c48c Bug 1937856 - prevent saving tab groups with only discarded tabs. r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234505
2025-01-17 14:46:24 +00:00
Shane Hughes
65116b6a5c Bug 1941391 - Check for popups before opening tab preview panel. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234085
2025-01-17 14:32:44 +00:00
Joel Maher
bcc50efbeb Bug 1940980 - Green up win11-64 opt/debug/asan/ccov. r=aryx,media-playback-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,urlbar-reviewers,aosmond,mconley,ochameau,dimi,jteow,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D233862
2025-01-16 23:02:48 +00:00
Greg Stoll
96e0daa1a5 Bug 1926396 - when unloading current tab, don't switch to an unloaded tab r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D234569
2025-01-16 19:53:09 +00:00
Alexandru Marc
3f4b115f67 Bug 1903733 - Disable browser_tab_manager_keyboard_access.js on linux1804 opt for frequent failures r=intermittent-reviewers,tabbrowser-reviewers,jmaher,dao DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D234400
2025-01-16 12:50:32 +00:00
Kelly Cochrane
f9046ef713 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-16 01:40:47 +00:00
Alexandru Marc
402a01520a Backed out changeset 2821188eb89d (bug 1921060) for causing multiple failures 2025-01-16 02:25:14 +02:00
Kelly Cochrane
a876cd0373 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-15 23:07:45 +00:00
DJ
41d6122076 Bug 1939535 - TOM indicates collapsed groups and hides their tabs. r=sthompson,dao,desktop-theme-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233417
2025-01-14 17:24:19 +00:00
Dão Gottwald
027c8b5a85 Bug 1927927 - Make moving a tab to a group via the tab context menu activate the group's window. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234173
2025-01-14 15:55:47 +00:00
Stanca Serban
9e9507fcbb Backed out changeset d448ac7b0d9e (bug 1921060) for causing mochitests failures in browser_audioTabIcon.js. 2025-01-13 21:35:03 +02:00
Kelly Cochrane
50f355f8ec Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-13 17:55:32 +00:00
Stephen Thompson
86ccb78df7 Bug 1939503 - create context menus for tab groups in tab overflow menu r=dao,fluent-reviewers,tabbrowser-reviewers
Saved groups, open groups in other windows, and open groups in the current window all have `command` handlers defined in the tab overflow menu (TOM) to perform an action when clicked. However, the tab groups spec shows additional actions that should be available when right-clicking on those tab groups in the TOM. This patch adds those context menus and wires up their functionality:
- opening in current window
- opening in, or moving to, a new window
- deleting an open group
- forgetting a saved group

Differential Revision: https://phabricator.services.mozilla.com/D233129
2025-01-09 20:07:00 +00:00
Dão Gottwald
83741f2f76 Bug 1940740 - Dispatch event when accepting the tab group creation panel. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233663
2025-01-09 14:58:03 +00:00
Cosmin Sabou
2d51d552df Bug 1928146 - Disable browser_tab_groups.js on windows for frequent failures. r=intermittent-reviewers,dwalker,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D232155
2025-01-08 09:06:43 +02:00
Butkovits Atila
d7afe8c2aa Backed out changeset 0edde29b2e70 (bug 1939503) for causing failures at browser_tab_manager_groups.js. CLOSED TREE 2025-01-08 05:43:29 +02:00
Stephen Thompson
607c9a5cec Bug 1939503 - create context menus for tab groups in tab overflow menu r=dao,fluent-reviewers,tabbrowser-reviewers
Saved groups, open groups in other windows, and open groups in the current window all have `command` handlers defined in the tab overflow menu (TOM) to perform an action when clicked. However, the tab groups spec shows additional actions that should be available when right-clicking on those tab groups in the TOM. This patch adds those context menus and wires up their functionality:
- opening in current window
- opening in, or moving to, a new window
- deleting an open group
- forgetting a saved group

Differential Revision: https://phabricator.services.mozilla.com/D233129
2025-01-08 02:47:03 +00:00
Joel Maher
248157ee22 Bug 1938960 - additional greening up of win11 24h2, carry forward existing annotations. r=aryx,webdriver-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,nchevobbe,dimi,whimboo,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D233026
2025-01-07 19:51:49 +00:00
Stephen Thompson
b41097f455 Bug 1933309 - arrow keys should select tabs and tab group labels in the tab strip r=dao,tabbrowser-reviewers
Currently, when the tab strip is in focus, pressing the arrow keys currently switches the active tab only. With this change, pressing the arrow keys will continue to switch the active tab when the adjacent item in the tab strip is a tab, but tab group labels will also receive keyboard focus if they happen to the adjacent items in the tab strip. Now, pressing left/right allows the user to "select" each tab or tab group label in the tab strip.

Differential Revision: https://phabricator.services.mozilla.com/D233016
2025-01-06 17:08:03 +00:00
Joel Maher
aec9b5a5d9 Bug 1939738 - move most remaining mochtests (a11y, devtools, browser-media) from macosx 10.15 -> 14.70. r=aryx
Differential Revision: https://phabricator.services.mozilla.com/D233108
2025-01-03 18:44:22 +00:00
Dão Gottwald
e9e9d3a05a Bug 1926254 - Esc key should cancel rather than accept the tab group create panel. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233185
2025-01-03 17:15:50 +00:00
Goloman Adrian
d33f45c6a2 Backed out changeset 333ccf52cb65 (bug 1939738) for causing mda failures @GMPServiceChild.cpp. CLOSED TREE 2025-01-03 19:29:25 +02:00
Joel Maher
63d0466126 Bug 1939738 - move most remaining mochtests (a11y, devtools, browser-media) from macosx 10.15 -> 14.70. r=aryx
Differential Revision: https://phabricator.services.mozilla.com/D233108
2025-01-03 15:24:26 +00:00
Jeremy Swinarton
82d7acff7a Bug 1936015: Groups can be deleted after switching between horizontal and vertical tabs r=dao,sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232925
2025-01-03 13:37:41 +00:00
Stephen Thompson
4076f2c38a Bug 1936752 - unlock tab sizes in collapsed tab groups r=jswinarton,tabbrowser-reviewers
In certain cases when closing a tab(s), we temporarily lock the width of the tabs instead of letting them grow/shrink. If you close a tab and then quickly collapse a tab group right afterwards, you can end up with the tab group label going into the collapsed state correctly but the tabs in the tab group are still visible.

The issue is that we lock tab sizes on visible tabs using `max-width: ... !important` and we are hiding tabs in collapsed tab groups by using a CSS rule of `max-width: 0`. When we unlock the tab sizes, we only unlock visible tabs, but the tabs inside of the collapsed tab group are no longer considered visible.

This fix removes the tab lock size `max-width: ... !important` rule on all tabs regardless of tab visibility.

Differential Revision: https://phabricator.services.mozilla.com/D233022
2024-12-31 20:03:05 +00:00
Sandor Molnar
70055345d6 Bug 1928146 - Disable 'browser_window_open_modifiers.js' on macOS for permafailing under vertical tab config. r=intermittent-reviewers,jmaher DONTBUILD 2024-12-28 15:26:44 +02:00
Cosmin Sabou
f99dd35df8 Bug 1928146 - Disable several tests on macOS that are permafailing under vertical tab config. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D232905
2024-12-28 10:21:33 +00:00
Goloman Adrian
b719cd2c84 Bug 1938525 - disable browser_tabReorder_overflow.js for perma failures on macOS. r=intermittent-reviewers,tabbrowser-reviewers,jmaher,dao DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D232801
2024-12-26 17:56:17 +00:00
Daisuke Akatsuka
abd3414bd9 Bug 1937363: Show/Focus Unified Search Button when P&S icon group gets focus r=desktop-theme-reviewers,urlbar-reviewers,dao,tabbrowser-reviewers,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D232160
2024-12-24 04:02:25 +00:00
Alexandru Marc
d3a6a84fb2 Backed out 4 changesets (bug 1325876) for causing wd failures @ navigation.spec.js CLOSED TREE
Backed out changeset b29ef3f14bf7 (bug 1325876)
Backed out changeset f8add6e2ef93 (bug 1325876)
Backed out changeset 41cc884f84c1 (bug 1325876)
Backed out changeset 014c9c77393a (bug 1325876)
2024-12-21 04:41:41 +02:00
Sean
b926b49e9e Bug 1325876 - Add a pref for showing error page for HTTP responses with error codes and Content-Length: 0 r=necko-reviewers,valentin,credential-management-reviewers,tabbrowser-reviewers,dimi,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D232429
2024-12-20 22:12:11 +00:00