Commit Graph

247 Commits

Author SHA1 Message Date
prathiksha
a46aaa0259 Bug 1463547 - Hide the edit link in the pickers when no options are selected. r=MattN
MozReview-Commit-ID: DcTcmV2v6N1
2018-08-02 17:21:44 -04:00
Jared Wein
133cd95906 Bug 1477114 - Add an asterisk to the required fields of the credit card form as well as the CVV placeholder. r=sfoster
MozReview-Commit-ID: 2zg5HOZVtxN
2018-07-30 17:52:24 -04:00
Brindusan Cristian
46820164b1 Backed out changeset d402c7b803c6 (bug 1477114) as requested by jaws. 2018-08-02 23:18:53 +03:00
Jared Wein
704b82dea4 Bug 1477114 - Add an asterisk to the required fields of the credit card form as well as the CVV placeholder. r=sfoster
MozReview-Commit-ID: 2zg5HOZVtxN
2018-07-30 17:52:24 -04:00
Sam Foster
16895060f1 Bug 1477106 - Use a pref to set default checkedness for "Save card to Firefox" and "Save address to Firefox" checkboxes. r=jaws
* Get default checkedness for the card persist checkbox from a new pref: dom.payments.defaults.saveCreditCard
* Get default checkedness for the address persist checkbox from a new pref: dom.payments.defaults.saveAddress
* Remember checked state from card page (only) so it doesnt change back when returning from add/edit address page
* Fix up card form tests to verify behavior in private/not-private windows, pref value, user opt-in for persisting the card
* Fix up address form tests to not conflate private/not-private windows with expected address persisting behaviour

MozReview-Commit-ID: GXMjqStlnlu
2018-07-26 15:36:07 -07:00
Andreea Pavel
9639ad59da Backed out changeset d69e19bad6c1 (bug 1477106) for eslint failure at builds/worker/checkouts/gecko/browser/components/payments/content/paymentDialogFrameScript.js 2018-08-02 02:11:57 +03:00
Sam Foster
b82c918c0f Bug 1477106 - Use a pref to set default checkedness for "Save card to Firefox" and "Save address to Firefox" checkboxes. r=jaws
* Get default checkedness for the card persist checkbox from a new pref: dom.payments.defaults.saveCreditCard
* Get default checkedness for the address persist checkbox from a new pref: dom.payments.defaults.saveAddress
* Remember checked state from card page (only) so it doesnt change back when returning from add/edit address page
* Fix up card form tests to verify behavior in private/not-private windows, pref value, user opt-in for persisting the card
* Fix up address form tests to not conflate private/not-private windows with expected address persisting behaviour

MozReview-Commit-ID: GXMjqStlnlu
2018-07-26 15:36:07 -07:00
Jared Wein
f91a633c7e Bug 1468153 - Update the edit strings (Add/Update) and the failure strings to use the hostname. r=sfoster
MozReview-Commit-ID: HcOMsP5zWBg
2018-07-30 14:22:52 -04:00
Sam Foster
257d2156ac Bug 1470584 - Send PAYMENT_REJECTED response if window is unexpectedly closed. r=MattN
* Use onWindowClose to spot closing windows associated with live payment requests and send a reject response
* Test to verify expected show() promise rejection behavior when closing the PR dialog

MozReview-Commit-ID: 2TJYN5NMrE6
2018-07-16 17:21:51 -07:00
Jared Wein
e0c3e5b688 Bug 1475521 - Payments shouldn't be processed without selecting a shipping address. r=MattN
MozReview-Commit-ID: CXxqYB3iOy
2018-07-27 12:03:46 -04:00
Matthew Noorenberghe
7165681397 Bug 1478321 - Fix the 'TypeError: docShell is null' exception to the Payments console listener. r=sfoster
`errorMessage` only contains 'TypeError: docShell is null' whereas `message` contains the file path and line.

MozReview-Commit-ID: 7Tuqph1b3lV
2018-07-26 16:11:24 -07:00
Matthew Noorenberghe
ef8f325b1c Bug 1476204 - Handle autofill record update state changes in the unpriv. PR forms. r=jaws
This is easier to understand as we don't have to round-trip the whole success and error states to the privileged wrapper which could potentially lead to stale state changes.
This is also much simpler for the basic-card-form as it doesn't need a lot of the complexity of the previous implementation.

* Move selectedStateKey from page to address-page since it doesn't apply to basic-card-page

MozReview-Commit-ID: B4kiZNWElGI
2018-07-25 12:37:51 -07:00
Matthew Noorenberghe
8ef03fea38 Bug 1476204 - Implement the payment summary error bar. r=jaws
MozReview-Commit-ID: 3Rc9ljfMCW3
2018-07-23 21:49:05 -07:00
Matthew Noorenberghe
730a3a6580 Bug 1476204 - Replace duplicate #error-text with .page-error. r=jaws
MozReview-Commit-ID: 2FOx9dpTpAs
2018-07-23 20:34:40 -07:00
Matthew Noorenberghe
5df3a9f472 Bug 1476204 - Check Luhn algorithm in the basic-card-form and in storage and disable save button when invalid. r=jaws
* Provide an cc-exp-year option to match cc-exp-month
* Make cc-number and cc-name required in the basic-card-form
* Disable the basic-card-page save button when the form is invalid.

MozReview-Commit-ID: LjzsnAKJp6R
2018-07-26 13:40:22 -07:00
prathiksha
df8bfa39dd Bug 1476571 - Auto-select selectedShippingAddress as billing address when it is not null. r=MattN
MozReview-Commit-ID: 8qPIbHn7cKk
2018-07-24 15:50:54 -07:00
Cosmin Sabou
4d1b71eee6 Backed out 5 changesets (bug 1476204) for browser chrome failures on browser_editCreditCardDialog. CLOSED TREE
Backed out changeset 10f3d1014592 (bug 1476204)
Backed out changeset a88879ea32e8 (bug 1476204)
Backed out changeset 001f13f2dd21 (bug 1476204)
Backed out changeset f0f464e3c27c (bug 1476204)
Backed out changeset ed92000eca20 (bug 1476204)
2018-07-26 04:12:56 +03:00
Matthew Noorenberghe
9e3276d213 Bug 1476204 - Handle autofill record update state changes in the unpriv. PR forms. r=jaws
This is easier to understand as we don't have to round-trip the whole success and error states to the privileged wrapper which could potentially lead to stale state changes.
This is also much simpler for the basic-card-form as it doesn't need a lot of the complexity of the previous implementation.

* Move selectedStateKey from page to address-page since it doesn't apply to basic-card-page

MozReview-Commit-ID: B4kiZNWElGI
2018-07-25 12:37:51 -07:00
Matthew Noorenberghe
8e85abc48e Bug 1476204 - Implement the payment summary error bar. r=jaws
MozReview-Commit-ID: 3Rc9ljfMCW3
2018-07-23 21:49:05 -07:00
Matthew Noorenberghe
5ef6fd17d6 Bug 1476204 - Replace duplicate #error-text with .page-error. r=jaws
MozReview-Commit-ID: 2FOx9dpTpAs
2018-07-23 20:34:40 -07:00
Matthew Noorenberghe
1ba778c9a8 Bug 1476204 - Check Luhn algorithm in the basic-card-form and in storage and disable save button when invalid. r=jaws
* Provide an cc-exp-year option to match cc-exp-month
* Make cc-number and cc-name required in the basic-card-form
* Disable the basic-card-page save button when the form is invalid.

MozReview-Commit-ID: LjzsnAKJp6R
2018-07-25 16:38:25 -07:00
Sebastian Hengst
b4efb2668b Merge mozilla-inbound to mozilla-central. a=merge 2018-07-25 17:16:53 +03:00
Matthew Noorenberghe
1405f1081f Bug 1463538 - Fix previously uncaught errors in PaymentReqest UI tests. r=jaws
MozReview-Commit-ID: JUu3ljLLDLO
2018-07-23 11:38:47 -07:00
Matthew Noorenberghe
7e19a51fdf Bug 1463538 - Fail PaymentRequest UI tests upon console errors. r=jaws
MozReview-Commit-ID: 2IzUaENZjfl
2018-07-24 19:24:29 -07:00
Matthew Noorenberghe
b5efc53363 Bug 1463538 - Make all <input> in the PaymentRequest debug panel live. r=sfoster
MozReview-Commit-ID: 4nutxHpmnlc
2018-07-23 20:01:19 -07:00
Boris Zbarsky
e98236cf07 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Sam Foster
b0eaf62f75 Bug 1447777 - Add completion fail and timeout error pages. r=MattN
* A new CompletionErrorPage / completion-error-page element which represents the content of the completion error
* Leave the dialog open when complete() results in a 'fail' or 'timeout'.
* The 'done' button on the fail & timeout error page closes the dialog by sending a message up to the paymentDialogWrapper.
* Rewrite the pay button rendering logic to ensure it is disabled when it should be
* Retry handling and UI not addressed here. Will need a new bug when the DOM support has landed.
* Extend completeStatus support in debugging.html and group like actions to tidy up a bit

MozReview-Commit-ID: GDhJqrj14uT

* Add tests to verify that the dialog stays open when completion fails or times out
* Add tests to verify that complete() throws after the timeout
* Rework completeStatus mochitest for PaymentDialog

MozReview-Commit-ID: 4ZNVEYMp7h5
2018-07-20 15:51:52 -07:00
Sam Foster
e1130d7c9a Bug 1447777 - Move state.completionState to state.request.completeStatus. r=MattN
* Spot-fix order details test to clone request before modifying it

MozReview-Commit-ID: AXjI1veRSk9
2018-07-19 19:45:58 -07:00
Cosmin Sabou
94d7df46ab Merge mozilla-inbound to mozilla-central. a=merge 2018-07-21 00:42:01 +03:00
Sam Foster
0e15cd355e Bug 1468644 - cc-numbers are always masked in dialog content; tests to verify this and card details in the payment response. r=jaws
MozReview-Commit-ID: 34MkjyRBth7
2018-07-18 12:45:45 -07:00
prathiksha
109c049ded Bug 1475080 - Clean up the pickers on the payment summary page to match the spec. r=MattN
MozReview-Commit-ID: FOyD7DkwjHk
2018-07-20 11:13:43 -07:00
Gurzau Raul
7bbe193f73 Backed out 4 changesets (bug 1463538) for failing on /payments/test/browser/browser_payments_onboarding_wizard.js
Backed out changeset 1c945ede0071 (bug 1463538)
Backed out changeset 8ccd9f4b230d (bug 1463538)
Backed out changeset e078fb39875e (bug 1463538)
Backed out changeset 798bf0d7928c (bug 1463538)
2018-07-24 11:16:21 +03:00
Matthew Noorenberghe
d06f3079e4 Bug 1463538 - Fix previously uncaught errors in PaymentReqest UI tests. r=jaws
MozReview-Commit-ID: JUu3ljLLDLO
2018-07-23 11:38:47 -07:00
Matthew Noorenberghe
720eb84fdb Bug 1463538 - Fail PaymentRequest UI tests upon console errors. r=jaws
MozReview-Commit-ID: 2IzUaENZjfl
2018-07-22 02:07:16 -07:00
Matthew Noorenberghe
d8912866dc Bug 1463538 - Make all <input> in the PaymentRequest debug panel live. r=sfoster
MozReview-Commit-ID: 4nutxHpmnlc
2018-07-23 20:01:19 -07:00
prathiksha
17978c87a1 Bug 1463554 - Fix the tests that are broken due to change in the internal structure of rich-select.r=MattN
MozReview-Commit-ID: BTHw9JHZoud
2018-06-27 17:32:54 -07:00
Matthew Noorenberghe
ad055f054f Bug 1469464 - Consistent PaymentRequest footer positioning with <payment-request-page>. r=sfoster
MozReview-Commit-ID: Oq06q6xF0e
2018-07-12 09:52:30 -07:00
Matthew Noorenberghe
3ea8717627 Bug 1469464 - Display the currency code with the total. r=sfoster
MozReview-Commit-ID: JJIbFBAYC9U
2018-07-07 23:23:43 -07:00
Matthew Noorenberghe
0e35e78e3c Bug 1469464 - Always hide View All, remove summary heading, add 'Pay to'. r=sfoster
MozReview-Commit-ID: 5XQNH97o65T
2018-07-11 23:16:12 -07:00
Coroiu Cristina
03b5354741 Backed out 6 changesets (bug 1469464) for browser-chrome failures at browser/base/content/test/static/browser_parsable_css.js on a CLOSED TREE
Backed out changeset f9d4885e8956 (bug 1469464)
Backed out changeset 59c418929764 (bug 1469464)
Backed out changeset 58c1a79fb661 (bug 1469464)
Backed out changeset 90654d5df81a (bug 1469464)
Backed out changeset 9453814beada (bug 1469464)
Backed out changeset 4b86bde79c91 (bug 1469464)
2018-07-12 10:52:02 +03:00
Matthew Noorenberghe
ba605f2926 Bug 1469464 - Fix eslint missing semicolon in test_payment_dialog.html. r=MattN
MozReview-Commit-ID: 1X0Oj9AU2lo
2018-07-11 23:52:13 -07:00
Matthew Noorenberghe
b91a35cee8 Bug 1469464 - Consistent PaymentRequest footer positioning with <payment-request-page>. r=sfoster
MozReview-Commit-ID: Oq06q6xF0e
2018-07-11 23:43:27 -07:00
Matthew Noorenberghe
c6d6c5d254 Bug 1469464 - Display the currency code with the total. r=sfoster
MozReview-Commit-ID: JJIbFBAYC9U
2018-07-07 23:23:43 -07:00
Matthew Noorenberghe
70982a8d17 Bug 1469464 - Always hide View All, remove summary heading, add 'Pay to'. r=sfoster
MozReview-Commit-ID: 5XQNH97o65T
2018-07-11 23:16:12 -07:00
Jared Wein
c653c8c236 Bug 1427961 - Put the asterisk next to required fields. r=MattN
MozReview-Commit-ID: 9KMFB9bS9hD
2018-06-20 19:06:38 -04:00
Jared Wein
e0f9bc267b Bug 1427961 - Regular expression validation for zip/postal codes. r=MattN
MozReview-Commit-ID: 208vx9SBcrq
2018-06-20 17:46:05 -04:00
Jared Wein
2b1c2b5e37 Bug 1427961 - Basic shipping address validation for state/province and zip/postal code. r=MattN
MozReview-Commit-ID: DCjr13QxP5Z
2018-06-07 17:02:42 -04:00
Sam Foster
cd93abfd0b Bug 1471263 - Unbork and un-skip the test_show_field_specific_error_on_addresschange test. r=jaws,MattN
MozReview-Commit-ID: BNvWDBF5HDH
2018-06-26 16:56:20 -07:00
Sam Foster
f704ec5021 Bug 1463608 - Expose FormAutofill computeFields methods, use them for temporary records in payments. r=MattN
* Test helpers for cards
* Refactor the test_add_link test to test in private & non-private window

MozReview-Commit-ID: AeVJOkSwQps
2018-05-30 16:56:25 -07:00
Sam Foster
d696f5cfdd Bug 1463608 - Add test helpers for payment address and cards. r=jaws
* addSampleAddressesAndBasicCard now accepts arrays of addresses and card, but with no args defaults to its original behavior
* addAddressRecord and addCardRecord helpers
* New helpers for each step in the sequence of clicking through to add a new address

MozReview-Commit-ID: Dto5MSekJTV
2018-06-04 09:36:21 -07:00