Commit Graph

247 Commits

Author SHA1 Message Date
Jared Wein
728adc0e4d Bug 1490077 - Reflect DOM validation messages on the error popup on the address and basic-card form. r=MattN
Contributions by Matthew Noorenberghe <mozilla@noorenberghe.ca>

Differential Revision: https://phabricator.services.mozilla.com/D6420
2018-09-21 00:15:56 -07:00
Gurzau Raul
ea96f77588 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-09-21 07:17:03 +03:00
Jared Wein
ab1ea5cf55 Bug 1478880 - payments/test/browser/head.js: fillInCardForm reliability fixes. r=MattN
* Blur before focus to reset timer for filtering <select>
* Wait for field to get focus before sending keys to it.
* Compare unpadded strings

Differential Revision: https://phabricator.services.mozilla.com/D6338
2018-09-20 20:44:03 -07:00
Matthew Noorenberghe
1b007d8fd1 Bug 1463545 - Use text-overflow:ellipsis; on <shipping-option>. r=sfoster
Depends on D5186

Differential Revision: https://phabricator.services.mozilla.com/D6332
2018-09-20 21:07:28 +00:00
Matthew Noorenberghe
538c456013 Bug 1463545 - Replace grid layout of <address-option> with a new two line design. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5186
2018-09-20 21:07:20 +00:00
Matthew Noorenberghe
b6446774ef Bug 1463545 - Update the <basic-card-option> layout to match the UI spec. r=sfoster
Depends on D6330

Differential Revision: https://phabricator.services.mozilla.com/D6331
2018-09-20 21:07:18 +00:00
Matthew Noorenberghe
d295d0a46a Bug 1463545 - Overlay the selected <rich-option> on top of the native <select>. r=sfoster
* We get the shared colours (including hover) and dropmarker.
* Makes it harder to regress the clickable area of the <rich-select> since the problem will be visible.
* Hides the text for the closed state of the <select> so the <rich-option> text can be presented.

Differential Revision: https://phabricator.services.mozilla.com/D6330
2018-09-20 21:07:09 +00:00
Matthew Noorenberghe
d4a84fcc29 Bug 1463545 - Copy stylesheets from the payment dialog into mochitests. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D6233
2018-09-20 21:07:07 +00:00
Jared Wein
27234ecc8b Bug 1491791 - Update the Save button state after the 'change' event. r=MattN
The validity of the cc-number field is only updated to a failure state after the 'change' event in the EditCreditCard class, but there was no code within basic-card-form.js to update the Save button enabled state after the 'change' event had been handled by EditCreditCard.

Differential Revision: https://phabricator.services.mozilla.com/D6282
2018-09-20 17:13:26 +00:00
Sam Foster
6ddf9e9404 Bug 1491065 - Use 'Next' as label for the save buttons during onboarding. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D6318
2018-09-19 22:10:50 +00:00
Sam Foster
97e02f994e Bug 1470183 - Add 3rd suggestion to failure page directing users to merchant for more info. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D6322
2018-09-19 20:57:26 +00:00
Matthew Noorenberghe
6641bc6bef Bug 1429181 - Make test_payment_method_picker.html work with cc-type. r=sfoster
synthesizeKey requires the prefix of the label which would be whitespace without cc-type so add a cc-type

Depends on D6231

Differential Revision: https://phabricator.services.mozilla.com/D6232
2018-09-19 17:06:47 +00:00
Matthew Noorenberghe
59ccc3632f Bug 1429181 - Fix test_payment_dialog_required_top_level_items.html with cc-type. r=sfoster
a) We have two names starting with the same prefix: "Mrs." which causes problem when typing on a <select> to filter, especially if the desired option is already selected.
b) The prefix of the payment method option would start with whitespace if cc-type is "".
c) There would be no state change for the shipping option picker when we're requesting to select the option that's already selected.

Depends on D6230

Differential Revision: https://phabricator.services.mozilla.com/D6231
2018-09-19 17:12:18 +00:00
Matthew Noorenberghe
492a4ff3c6 Bug 1429181 - Fix PaymentTestUtil.DialogContentTasks.select* to work with repeated calls. r=sfoster
Also fix test_basic_card_form.html and browser_show_dialog.js

Differential Revision: https://phabricator.services.mozilla.com/D6230
2018-09-19 17:05:09 +00:00
Sam Foster
4b5fb70b7e Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
* A new accepted-cards element to represent the labeled list of card icons
* Add the accepted cards section to the summary and card add/edit page
* mochitest for the accepted-cards element
* Make cc-type a required field and validate it against the list of supported networks
* Add verification of the pay button disabling when card network is not supported

Depends on D5823

Differential Revision: https://phabricator.services.mozilla.com/D5824
2018-09-19 18:15:11 +00:00
Bogdan Tara
c104128b3d Backed out changeset 7351a4c8d1a1 (bug 1429181) for multiple payment-related failures CLOSED TREE 2018-09-15 00:58:48 +03:00
Sam Foster
579931d05b Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
* A new accepted-cards element to represent the labeled list of card icons
* Add the accepted cards section to the summary and card add/edit page
* mochitest for the accepted-cards element
* Make cc-type a required field and validate it against the list of supported networks
* Add verification of the pay button disabling when card network is not supported

Depends on D5823

Differential Revision: https://phabricator.services.mozilla.com/D5824
2018-09-14 20:28:41 +00:00
Sam Foster
7906b3732a Bug 1429181 - Fix serialization of payment method data. r=MattN
* Includes a workaround to explicitly cloneInto the paymentMethods data when we create the PaymentRequest object in the content window in tests.

MozReview-Commit-ID: LFy0h3fIXXA

Differential Revision: https://phabricator.services.mozilla.com/D5823
2018-09-14 20:24:08 +00:00
Jared Wein
dc4a70252a Bug 1489629 - Adjust the size of the error images, sizing and position of text, and add footer branding to the error pages. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5320
2018-09-10 18:16:55 +00:00
Jared Wein
243b5fdc36 Bug 1482808 - Clear the field-specific merchant error invalid state when the field has been edited. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5081
2018-09-07 23:15:09 +00:00
Jared Wein
5ce5be7ff8 Bug 1487395 - Update strings on error pages, as well as convert apostrophes to use 'smart-quotes'. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5068
2018-09-06 19:43:19 +00:00
Timothy Guan-tin Chien
67e3dcd7aa Bug 1399367 - Remove MasterPassword.{encrypt|decrypt}Sync() methods r=MattN
This also makes various AutofillRecords methods async, with the exception of
remove() and removeAll().

Noted that I didn't implement any kind of "lock" for FormAutofillStorage --
please do not call these methods concurrently -- if you must please |await|
for the last call to resolve. This most likely would happen in tests, and
shouldn't happen in the real world, given that all user actions happen on
macrotasks, and probably not at the next tick, unless Quicksilver is a
Firefox user.

FormAutofillStorage can be improved if there are complex use cases for it.

Differential Revision: https://phabricator.services.mozilla.com/D4420
2018-09-05 17:54:48 +00:00
Csoregi Natalia
a34cf6da92 Backed out changeset 56aa054d4cc0 (bug 1399367) for browser/extensions/formautofill/test/unit/test_activeStatus.js failures. CLOSED TREE 2018-09-05 05:47:21 +03:00
Timothy Guan-tin Chien
6071bf1543 Bug 1399367 - Remove MasterPassword.{encrypt|decrypt}Sync() methods r=MattN
This also makes various AutofillRecords methods async, with the exception of
remove() and removeAll().

Noted that I didn't implement any kind of "lock" for FormAutofillStorage --
please do not call these methods concurrently -- if you must please |await|
for the last call to resolve. This most likely would happen in tests, and
shouldn't happen in the real world, given that all user actions happen on
macrotasks, and probably not at the next tick, unless Quicksilver is a
Firefox user.

FormAutofillStorage can be improved if there are complex use cases for it.

Differential Revision: https://phabricator.services.mozilla.com/D4420
2018-09-05 00:32:57 +00:00
Ciure Andrei
83a0320124 Merge inbound to mozilla-central. a=merge 2018-09-01 01:40:48 +03:00
Jared Wein
face3aae9c Bug 1484721 - Update the save button disabled state after changing the country select dropdown in the address-form. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D4470
2018-08-31 16:15:51 +00:00
Jared Wein
ac0511b6cc Bug 1480719 - Require credit card expiration month and year before saving credit cards. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D4485
2018-08-31 16:36:34 +00:00
Marcos Cáceres
3a73997f97 Bug 1485881 - Drop support for PaymentAddress.languageCode r=smaug 2018-08-27 16:30:00 +03:00
Sam Foster
0366c879b7 Bug 1477105 - Support cc-type as valid field for credit cards in form autofill. r=MattN
* Add cc-type as a valid field for credit card forms
* Add a select menu and new string for designating a card type in the add/edit form
* Enforce matching of cc-type to one of the list of supported network ids for Basic Card
* Expose the network ids list as CreditCard.SUPPORTED_TYPES
* Populate the cc-type options using a getCreditCardTypes util method passed into the EditCreditCard constructor

* Web Payment tests: verify cc-type picker is presented, populated as expected and selections received in the response

MozReview-Commit-ID: 9QyU1UwTRay

Differential Revision: https://phabricator.services.mozilla.com/D3830
2018-08-28 15:59:57 -07:00
Kris Maglione
a1876c600d Bug 1486130: Fix reporting of unhandled DOMException rejection values. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D4264
2018-08-23 14:01:04 -07:00
Matthew Noorenberghe
bba9406216 Bug 1485473 - Combine the borders of the name fields on the address form. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D4031
2018-08-24 23:21:30 +00:00
Kris Maglione
f6a4413b4c Bug 1484496: Part 5a - Convert browser/ nsISimpleEnumerator users to use JS iteration. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3729
2018-08-18 19:27:33 -07:00
Margareta Eliza Balazs
0fc8f9feae Backed out changeset 3fcc7597cd8d (bug 1429198) for ES lint failure in builds/worker/checkouts/gecko/browser/components/payments/res/paymentRequest.js. CLOSED TREE 2018-12-18 15:50:33 +02:00
Diego Pino Garcia
28e3196dab Bug 1429198 - Account for supportedNetworks in payment modifiers. r=MattN 2018-12-17 22:15:00 +02:00
Matthew Noorenberghe
7abe2e1b64 Bug 1482220 - Listen for the autofill edit forms being appended for localization. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D3846
2018-08-22 02:58:38 +00:00
prathiksha
5b411643f7 Bug 1475760 - Take address-fields into account for payer/contact picker dropdown labels. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D2831
2018-08-20 13:23:43 -07:00
Matthew Noorenberghe
05b80bce31 Bug 1477100 - Scroll the country picker into view to fix browser_dropdowns.js. r=me
This new layout caused it to require scrolling to be clicked.
2018-08-17 20:27:33 -07:00
Matthew Noorenberghe
f05f773232 Bug 1478029 - Follow-up to fix test_address_form.html default country. r=me 2018-08-17 17:40:04 -07:00
Matthew Noorenberghe
dc50337285 Bug 1478029 - Don't select a shipping option by default for the user. r=sfoster
Honour the .selected value provided by the merchant.

Differential Revision: https://phabricator.services.mozilla.com/D3668
2018-08-17 17:03:29 -07:00
Jared Wein
96dfeffbdd Bug 1477100 - Show the labels as placeholders inside of the fields. r=MattN
Show the labels as placeholders inside of the fields.

Differential Revision: https://phabricator.services.mozilla.com/D2955
2018-08-17 16:25:46 -07:00
Matthew Noorenberghe
989cf42294 Bug 1483425 - Don't mark form fields as invalid/dirty on load in an 'add' form. r=sfoster
When editing an existing record, invalid fields should be indicated on load.

Differential Revision: https://phabricator.services.mozilla.com/D3397

MozReview-Commit-ID: CbrqEyCUoyC
2018-08-17 16:27:21 -07:00
Matthew Noorenberghe
983071a66b Bug 1465673 - Disable browser_card_edit.js on linux debug builds. r=me 2018-08-15 14:21:18 -07:00
Matthew Noorenberghe
740d3ceb28 Bug 1476345 - Only enable relevant fields in address forms and update tests. r=jaws
MozReview-Commit-ID: KuPMHrF6jaM
2018-08-15 12:19:55 -07:00
Matthew Noorenberghe
070b80faab Bug 1476345 - Disable the address form save button when the form is invalid. r=jaws
Tests for this are in the next commit (e.g. test_address_form.html) because this can't be tested properly due to existing tests not filling fields in ways that fire input/change events.

MozReview-Commit-ID: 62CckFP6Ou3
2018-08-15 12:07:55 -07:00
Matthew Noorenberghe
89fcaa7f8f Bug 1476345 - Fix console listener to not spew when .message doesn't exist. r=jaws
Sometimes .errorMessage exists without .message

MozReview-Commit-ID: D4zBJKxfJba
2018-08-14 16:26:36 -07:00
Jared Wein
46b7ce906e Bug 1476348 - Show missing field validation errors on the summary page. r=MattN
MozReview-Commit-ID: 5dOzxWH0pWp
2018-08-03 18:51:31 -04:00
Sam Foster
b1db4c8170 Bug 1480023 - Ensure input event is handled in the correct order by waiting for EditAutofillForm constructor before adding BasicCardForm's input & change handlers. r=MattN
MozReview-Commit-ID: F9hzp54hZxX
2018-08-02 17:46:56 -07:00
Jared Wein
97ca8b6dd2 Bug 1477699 - Show a generic error message when a merchant-supplied error message isn't present. r=MattN
MozReview-Commit-ID: Dn4mnvzunVd
2018-07-31 15:09:58 -04:00
Bogdan Tara
ed871660f1 Merge inbound to mozilla-central. a=merge 2018-08-03 13:16:27 +03:00
Jared Wein
f7aa111f10 Bug 1472278 - Localize the required form asterisk on the address-form, basic-card-form, and CVV entry field. r=MattN
MozReview-Commit-ID: 7VN1VY7QziT
2018-07-30 21:13:36 -04:00