Reopen panel if one was open when toggling revamp and still available. This avoids race condition of trying to open chatbot and flip revamp at the same time.
Differential Revision: https://phabricator.services.mozilla.com/D245367
* Remove some of the overloading of SidebarState.updateVisibility
* Remove the no-longer-used #previousLauncherExpanded property
* SidebarController.hide() just hides the panel (same as legacy/original API)
* Skip the browser_toolbarKeyNav.js test when sidebar.revamp=true, this should have been failing all along.
Differential Revision: https://phabricator.services.mozilla.com/D242240
Adds the integratedSidebar pref to the `shopping2023` Nimbus feature and separates the enabling prefs for the migrated Review Checker in the main sidebar and the Shopping sidebar.
- Updates `browser.shopping.experience2023.integratedSidebar` to be the only enabling pref for the migrated Review Checker sidebar.
- Prevents `browser.shopping.experience2023.enabled` from disabling the migrate sidebar and uses it as the pref for the ShoppingSidebar actors.
- Removes the `browser.shopping.experience2023.shoppingSidebar` pref as it is no longer needed.
- Updates any tests the used these prefs to the new use.
- Init's the two sidebar differently in `ShoppingUtils` based on the Nimbus prefs.
- Unset the `SidebarController._state.command` when a sidebar tool pref sets it to `visible=false` otherwise it will try to re-open when the sidebar is opened again.
Differential Revision: https://phabricator.services.mozilla.com/D242053
* Remove some of the overloading of SidebarState.updateVisibility
* Remove the no-longer-used #previousLauncherExpanded property
* SidebarController.hide() just hides the panel (same as legacy/original API)
Differential Revision: https://phabricator.services.mozilla.com/D242240
* Update sidebar.main.tools default values and include a migration
* Modify updateDefaultTools in SidebarManager
* Update tests
Differential Revision: https://phabricator.services.mozilla.com/D240903
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done
Differential Revision: https://phabricator.services.mozilla.com/D234773
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done
Differential Revision: https://phabricator.services.mozilla.com/D234773
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done
Differential Revision: https://phabricator.services.mozilla.com/D234773
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done
Differential Revision: https://phabricator.services.mozilla.com/D234773
- Remove flushTaskQueue() from head.js and its usages. Reduce arbitrary waits as much as possible.
- Replace _waitForOngoingAnimations() with a generic function to await all UI updates, which can be used in tests as well.
- Create a helper method to reliably wait for a repaint for cases where it's truly necessary.
Differential Revision: https://phabricator.services.mozilla.com/D238042
- Allow both prefs to update before handling sidebar.visibility changes as we need an up-to-date
verticalTabs value
- Call updateToolbarButton at the completion of initializeUIState rather than as
a sideeffect of one of the state property changes
- And same idea with handleToolbarButtonClick
Differential Revision: https://phabricator.services.mozilla.com/D237680
- Remove flushTaskQueue() from head.js and its usages. Reduce arbitrary waits as much as possible.
- Replace _waitForOngoingAnimations() with a generic function to await all UI updates, which can be used in tests as well.
- Create a helper method to reliably wait for a repaint for cases where it's truly necessary.
Differential Revision: https://phabricator.services.mozilla.com/D238042
* Make sure we don't overwrite a user's choice to hide-sidebars in vertical tabs at startup
* Roll in a fix to bug 1947257 and ensure the launcher is initially expanded when enabling vertical tabs
Differential Revision: https://phabricator.services.mozilla.com/D237849
