corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
904,867 Commits 1 Branch 0 Tags
44634783bdc494322c95ae0dc9c5fb06b7d0db1d
Commit Graph

274 Commits

Author SHA1 Message Date
Ryan Safaeian
3b015b140d Bug 1946830 - [contextual-password-manager] Add new probe for when CPM is toggled in sidebar. r=mtigley,sidebar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237931
 2025-02-13 21:03:21 +00:00
Nikki Sharpley
94a85bdc4f Bug 1944910 - Hide sidebar main element when "hide-sidebar" is selected in vertical tabs mode.r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236605
 2025-02-11 16:29:47 +00:00
Jonathan Sudiaman
5e9cd630a5 Bug 1945927 - Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236933
 2025-02-11 00:05:12 +00:00
Norisz Fay
322845f56e Backed out changeset 022da00de2e7 (bug 1944910) for causing failures on browser_vertical_tabs.js CLOSED TREE 2025-02-11 05:34:20 +02:00
Nikki Sharpley
3b00c42254 Bug 1944910 - Hide sidebar main element when "hide-sidebar" is selected in vertical tabs mode.r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236605
 2025-02-10 14:32:23 +00:00
Alexandru Marc
88bcc4fdba Backed out 2 changesets (bug 1946188, bug 1945927) for causing bc failures @ browser_sidebar_max_width.js 
Backed out changeset 12f92dcdff8d (bug 1946188)
Backed out changeset b71374a4ec8d (bug 1945927)
 2025-02-10 16:59:42 +02:00
Jonathan Sudiaman
fa275b3b28 Bug 1945927 - Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236933
 2025-02-10 13:31:32 +00:00
Alexandru Marc
f43ff8bcd9 Backed out changeset 24d23a09f65c (bug 1944910) for causing bc failures @ browser_newtabButton.js CLOSED TREE 2025-02-08 15:17:08 +02:00
Nikki Sharpley
88603ffd0e Bug 1944910 - Hide sidebar main element when "hide-sidebar" is selected in vertical tabs mode.r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236605
 2025-02-07 22:03:50 +00:00
Kelly Cochrane
6fd7168076 Bug 1946675 - Fix for sidebar animations after recent changes for expand on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D237233
 2025-02-07 19:36:03 +00:00
Butkovits Atila
d45f0bd128 Backed out changeset e38f4befbd26 (bug 1946675) for causing failures at browser_parsable_css.js. CLOSED TREE 2025-02-07 21:14:51 +02:00
Kelly Cochrane
b5ee7175f0 Bug 1946675 - Fix for sidebar animations after recent changes for expand on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D237233
 2025-02-07 17:57:42 +00:00
Kelly Cochrane
9430fe2dd3 Bug 1946532 - Temporarily remove expand on hover styles/listeners if toolbar button is used to expand the sidebar in expand on hover mode r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D237101
 2025-02-07 15:14:54 +00:00
Sam Foster
3212d879b7 Bug 1944931 - Ensure sidebar.visibility gets set when vertical tabs are enabled. r=sidebar-reviewers,sclements,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D236447
 2025-02-07 00:33:29 +00:00
Stanca Serban
35dcb51890 Backed out changeset e1b44a36cc7b (bug 1944931) for causing mochitests failures in browser_toolbarKeyNav.js. CLOSED TREE 2025-02-06 23:07:09 +02:00
Sam Foster
9e30d4a3f1 Bug 1944931 - Ensure sidebar.visibility gets set when vertical tabs are enabled. r=sidebar-reviewers,sclements,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D236447
 2025-02-06 19:24:32 +00:00
Goloman Adrian
d2c88036c2 Backed out changeset ff0ae341ed38 (bug 1945927) for causing bc failures @browser_customize_sidebar.js. CLOSED TREE 2025-02-06 18:52:47 +02:00
Jonathan Sudiaman
094417d2bf Bug 1945927 - Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236933
 2025-02-06 15:27:35 +00:00
Alexandru Marc
b68ad3585c Backed out changeset cef2da85ff94 (bug 1945927) for causing bc failures @ browser_glean_sidebar.js CLOSED TREE 2025-02-06 03:34:55 +02:00
Jonathan Sudiaman
56a6d4edfc Bug 1945927 - Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236933
 2025-02-05 23:28:14 +00:00
Kelly Cochrane
cae199c0f2 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao 
Differential Revision: https://phabricator.services.mozilla.com/D233098
 2025-02-05 18:04:20 +00:00
Stanca Serban
0efa589b90 Backed out changeset 1be8354cedcd (bug 1930201) for causing mochitests failures. CLOSED TREE 2025-02-05 19:11:28 +02:00
Kelly Cochrane
03c6b75a99 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao 
Differential Revision: https://phabricator.services.mozilla.com/D233098
 2025-02-05 14:05:08 +00:00
Goloman Adrian
29382f98d1 Backed out changeset 0923d9bb2550 (bug 1944931) for causing bc failures @browser_reviewchecker_sidebar.js. CLOSED TREE 2025-02-05 02:17:40 +02:00
Sam Foster
ba5b624404 Bug 1944931 - Ensure sidebar.visibility gets set when vertical tabs are enabled. r=sidebar-reviewers,sclements,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D236447
 2025-02-04 19:08:22 +00:00
Sam Foster
c32900b41c Bug 1942314 - Avoid showing sidebars and responding to sidebar events in popup windows. r=sidebar-reviewers,sessionstore-reviewers,jsudiaman,sclements 
- Guard the main entry-points in SidebarController to handle the window being a popup
- Amend the test to also try the shortcut to show a sidebar in a popup window

Differential Revision: https://phabricator.services.mozilla.com/D236292
 2025-02-04 07:43:21 +00:00
Gijs Kruitbosch
37d1770eaf Bug 1944627 - update sidebar button checked state for non-revamped sidebar cases, r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236419
 2025-02-01 14:34:59 +00:00
Nikki Sharpley
3a0cdaac95 Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones 
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
 2025-01-31 17:20:04 +00:00
Goloman Adrian
93e9d720c3 Backed out changeset 85ef05d78aa4 (bug 1944842) for causing bc failures @browser_resize_sidebar.js. 2025-01-30 23:28:35 +02:00
Goloman Adrian
076b72e294 Backed out changeset bcb4fe8937d9 (bug 1939917) for causing bc failures @browser_toolbar_sidebar_button.js. 2025-01-30 23:12:08 +02:00
Nikki Sharpley
90377aaee3 Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones 
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
 2025-01-30 19:51:57 +00:00
Jonathan Sudiaman
1294445e6e Bug 1944842 - Sidebar can get into scenario where it's expanded but vertical tabs aren't showing labels r=sidebar-reviewers,sfoster 
Disabling revamp means that we also set expanded to false. However, since revamp is disabled, these changes are not reflected back to sidebar-main, resulting in a weird mismatch between SidebarState and what the launcher sees.

This was partially fixed by the lines in initializeState(), which updates the tab container, but not the launcher. This generalizes the solution to ensure that *all* components are kept up to date.

Differential Revision: https://phabricator.services.mozilla.com/D236240
 2025-01-30 19:25:30 +00:00
Goloman Adrian
a2f88b27ce Backed out changeset fd1a85f26bc5 (bug 1939917) for causing bc failures @browser_all_files_referenced.js. 2025-01-30 21:14:06 +02:00
Nikki Sharpley
a205e140f0 Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones 
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
 2025-01-30 16:52:11 +00:00
Sandor Molnar
cc838f6396 Backed out changeset 97ac16a67945 (bug 1939917) for causing bc failures @ browser_customize_sidebar.js CLOSED TREE 2025-01-30 01:58:33 +02:00
Jonathan Sudiaman
70919ebe73 Bug 1944016 - Add new strings to tab context menu for switching to/from vertical tabs r=sidebar-reviewers,fluent-reviewers,tabbrowser-reviewers,dao,bolsson,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D236035
 2025-01-29 23:29:40 +00:00
Nikki Sharpley
c3ae33f79c Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones 
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
 2025-01-29 23:02:52 +00:00
Sandor Molnar
289ab282d7 Backed out changeset 1ddeda5cc40a (bug 1939917) for causing sidebar related failures CLOSED TREE 2025-01-30 00:23:19 +02:00
Nikki Sharpley
89a42ee5df Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones 
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
 2025-01-29 20:59:31 +00:00
Nikki Sharpley
551f8d2aaa Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane,sessionstore-reviewers 
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
 2025-01-28 00:51:28 +00:00
Butkovits Atila
a375e8316f Backed out changeset ead9919b0da6 (bug 1938249) for causing failures at test_restore_sidebar.py. CLOSED TREE 2025-01-27 23:43:36 +02:00
Nikki Sharpley
5d44461250 Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane 
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
 2025-01-27 18:19:26 +00:00
Goloman Adrian
7dc18d7e06 Backed out changeset 2e8e6c3c9ad8 (bug 1938249) for causing bc failures @browser_glean_sidebar.js. CLOSED TREE 2025-01-27 18:50:28 +02:00
Nikki Sharpley
e80180f302 Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane 
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
 2025-01-27 15:52:05 +00:00
Sandor Molnar
0e23de4f07 Backed out changeset 125d12cc3cdb (bug 1938249) for causing bc failures @ browser_sidebar_keys.js CLOSED TREE 2025-01-25 01:11:14 +02:00
Nikki Sharpley
463d047cea Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane 
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
 2025-01-24 21:34:33 +00:00
kpatenio
9463115662 Bug 1941047 - Add new probe for tracking whenever RC is loaded/unloaded in the sidebar. r=sidebar-reviewers,shopping-reviewers,rking 
Differential Revision: https://phabricator.services.mozilla.com/D235052
 2025-01-24 18:16:41 +00:00
Jonathan Sudiaman
28e3caf8b0 Bug 1940163 - Add telemetry probe to distinguish between panel toggles coming from the old and new sidebar r=sidebar-reviewers,firefox-ai-ml-reviewers,nsharpley,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D233882
 2025-01-16 18:04:24 +00:00
Jonathan Sudiaman
9372222c8c Bug 1935482 - Replace legacy properties with SidebarState properties r=sidebar-reviewers,sessionstore-reviewers,nsharpley,sfoster 
- Move resize observer (setting max width) logic over to SidebarState.
- Add `command` property to SidebarState.
- Handle receiving legacy session restore data.
- Add unit tests along with mocking structures to get a better idea of state/controller coupling (which we should ultimately reduce).

Differential Revision: https://phabricator.services.mozilla.com/D232730
 2025-01-08 23:06:42 +00:00
Gijs Kruitbosch
c462bad48a Bug 1939639 - don't try to access this.toolbarButton before it's available, r=kcochrane,sidebar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D233068
 2025-01-02 14:27:46 +00:00