corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
890,588 Commits 1 Branch 0 Tags
34caedb5e06d01b718ee88c54aaa73e65e5596d9
Commit Graph

319 Commits

Author SHA1 Message Date
Mark Banner
97359cbfd0 Bug 1878554 - Remove ESLint rule for-direction reference from aboutwelcome/asrouter/newtab configs. r=aminomancer,omc-reviewers 
It is already enabled as a recommended rule.

Differential Revision: https://phabricator.services.mozilla.com/D200586
 2024-02-07 08:55:31 +00:00
Mark Banner
257b6d2dc7 Bug 1878554 - Simplify react/jsx-no-bind definition for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200585
 2024-02-07 08:55:30 +00:00
Mark Banner
120bc96610 Bug 1878554 - Remove now unnecessary jsx features setting for ESLint for aboutwelcome/asrouter/newtab. r=aminomancer,omc-reviewers 
The parser option was added globally for jsx files in bug 1878009.

Differential Revision: https://phabricator.services.mozilla.com/D200584
 2024-02-07 08:55:30 +00:00
Mark Banner
c4f2b2d3ac Bug 1878553 - Define *.config.(m)js files as node based for ESLint. r=mossop,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200582
 2024-02-07 08:55:29 +00:00
Mark Banner
b516bcb516 Bug 1878553 - For ESLint, expect all jsx files to be ES modules. r=mossop,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200581
 2024-02-07 08:55:29 +00:00
Cristian Tuns
8829a8d6c5 Backed out 11 changesets (bug 1878554, bug 1878553, bug 1878556) for causing node failures in aboutwelcome CLOSED TREE 
Backed out changeset 425f70fa7e5a (bug 1878556)
Backed out changeset 2ab3a28f5c04 (bug 1878556)
Backed out changeset fb2e02682c8c (bug 1878556)
Backed out changeset 2fc5e630568e (bug 1878554)
Backed out changeset 78839d5841b4 (bug 1878554)
Backed out changeset e0ab31d2de1b (bug 1878554)
Backed out changeset 4eb59e4ebafa (bug 1878554)
Backed out changeset ab1e077d3f84 (bug 1878554)
Backed out changeset ef999f293e3e (bug 1878553)
Backed out changeset cf49920cb1ad (bug 1878553)
Backed out changeset 95f0fce63726 (bug 1878553)
 2024-02-07 01:26:39 -05:00
Mark Banner
f15c9c508b Bug 1878556 - Remove unused asrouter/content-src/template-utils.js. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200591
 2024-02-06 22:32:55 +00:00
Mark Banner
ed1bb292be Bug 1878556 - Move addUtmParams.js to aboutwelcome and rename to .mjs. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200590
 2024-02-06 22:32:54 +00:00
Mark Banner
c19488bd61 Bug 1878554 - Remove deprecated ESLint rules from aboutwelcome/asrouter/newtab configs. r=aminomancer,omc-reviewers 
These rules are node specific and not really useful in mozilla central:
handle-callback-err, no-buffer-constructor, no-path-concat, no-process-exit
These rules are not useful as require is only used in configurations:
no-new-require, no-mixed-requires
Prettier already enforces max-statements-per-line
lines-between-class-members isn't handled separately, but if we want to do that we should decide on it globally.

Differential Revision: https://phabricator.services.mozilla.com/D200588
 2024-02-06 22:32:53 +00:00
Mark Banner
41bdb28228 Bug 1878554 - Remove ESLint rule require-await for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers 
We decided not to use the rule in bug 1381030.

Differential Revision: https://phabricator.services.mozilla.com/D200587
 2024-02-06 22:32:53 +00:00
Mark Banner
f68e745450 Bug 1878554 - Remove ESLint rule for-direction reference from aboutwelcome/asrouter/newtab configs. r=aminomancer,omc-reviewers 
It is already enabled as a recommended rule.

Differential Revision: https://phabricator.services.mozilla.com/D200586
 2024-02-06 22:32:52 +00:00
Mark Banner
617d0bb8f5 Bug 1878554 - Simplify react/jsx-no-bind definition for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200585
 2024-02-06 22:32:52 +00:00
Mark Banner
b5d681b88e Bug 1878554 - Remove now unnecessary jsx features setting for ESLint for aboutwelcome/asrouter/newtab. r=aminomancer,omc-reviewers 
The parser option was added globally for jsx files in bug 1878009.

Differential Revision: https://phabricator.services.mozilla.com/D200584
 2024-02-06 22:32:52 +00:00
Mark Banner
7fdf48bc1f Bug 1878553 - Define *.config.(m)js files as node based for ESLint. r=mossop,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200582
 2024-02-06 22:32:51 +00:00
Mark Banner
832805759a Bug 1878553 - For ESLint, expect all jsx files to be ES modules. r=mossop,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200581
 2024-02-06 22:32:50 +00:00
Mike Conley
b27d0377c8 Bug 1877196 - Move PageEventManager.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200515
 2024-02-05 22:03:16 +00:00
Mike Conley
65ab386408 Bug 1877196 - Move FeatureCallout modules and styles to browser/components/asrouter. r=fxview-reviewers,omc-reviewers,sclements,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200514
 2024-02-05 22:03:16 +00:00
Mike Conley
02fbf941fd Bug 1877196 - Move ActorConstants.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers 
We import the ActorConstants into the ASRouter unit-entry.js script because
ASRouterChild.sys.mjs loads ActorConstants.sys.mjs, and the ResourceUriPlugin
that does the rewriting for the Karma tests doesn't understand how to do
remapping outside of the newtab folder.

So instead of trying to hack that capability into ResourceUriPlugin, we
just import the ActorConstants into the Karma global scope.

Differential Revision: https://phabricator.services.mozilla.com/D200087
 2024-02-05 22:03:15 +00:00
Mike Conley
12a99679c5 Bug 1877196 - Move browser_asrouter tests to browser/components/asrouter. r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200086
 2024-02-05 22:03:15 +00:00
Mike Conley
77ec143b58 Bug 1877196 - Move InflightAssetsMessageProvider.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200085
 2024-02-05 22:03:15 +00:00
Mike Conley
8721b41d40 Bug 1877196 - Move InfoBar.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200084
 2024-02-05 22:03:14 +00:00
Mike Conley
00c7162ee1 Bug 1877196 - Move MomentsPageHub.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200083
 2024-02-05 22:03:14 +00:00
Mike Conley
19a6e40b11 Bug 1877196 - Move ToolbarPanelHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200082
 2024-02-05 22:03:13 +00:00
Mike Conley
6779808f9c Bug 1877196 - Move ToolbarBadgeHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200081
 2024-02-05 22:03:13 +00:00
Mike Conley
5ef0671ecd Bug 1877196 - Move ToastNotification.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200080
 2024-02-05 22:03:13 +00:00
Mike Conley
f8fd7026c8 Bug 1877196 - Move Spotlight.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200079
 2024-02-05 22:03:12 +00:00
negin
8b95c517d5 Bug 1867822 - Drop maximum code coverages in Karma to (at most) 80% r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D199646
 2024-02-02 16:18:37 +00:00
Mike Conley
2d464c57d2 Bug 1876104 - Convert ToastNotification.jsm to an ESM. r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D199424
 2024-02-02 00:53:21 +00:00
Mike Conley
19be4cce46 Bug 1876104 - Convert Spotlight.jsm to an ESM. r=amy,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D199421
 2024-02-02 00:53:20 +00:00
Mike Conley
b9b51a5c5b Bug 1876104 - Convert MomentsPageHub.jsm to an ESM. r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D199413
 2024-02-02 00:53:17 +00:00
Mike Conley
2e36a2d107 Bug 1876104 - Convert InfoBar.jsm to an ESM. r=thecount,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D199411
 2024-02-02 00:53:16 +00:00
Mike Conley
ac224ed180 Bug 1876104 - Convert ActivityStreamStorage.jsm to an ESM. r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D199406
 2024-02-02 00:53:14 +00:00
Mike Conley
bbdde4f433 Bug 1876104 - Convert ActivityStream.jsm to an ESM. r=thecount,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D199404
 2024-02-02 00:53:13 +00:00
Mike Conley
c5da337999 Bug 1877202 - Move ModalOverlay back over to browser/components/newtab. r=thecount 
This originally got moved as part of bug 1868838 because it was under
browser/components/newtab/content-src/asrouter/components - however,
pdahiya points out that this component was actually only ever used
by newtab, so it makes more sense living over there.

Differential Revision: https://phabricator.services.mozilla.com/D200391
 2024-02-01 23:35:23 +00:00
Jason Prickett
9d00173995 Bug 1873793 - Add tail fox doodle set default spotlight for existing users to onboarding messages r=omc-reviewers,fluent-reviewers,flod,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D199442
 2024-02-01 18:01:46 +00:00
Mike Conley
4e7e60308f Bug 1868838 - Add missing xpcshell.toml file for browser/components/asrouter. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D199003
 2024-01-29 18:52:30 +00:00
Mike Conley
8f99e01997 Bug 1868838 - Update ASRouter coverage expectations for ModalOverlay to match reality. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D199002
 2024-01-29 18:52:29 +00:00
Mike Conley
7004f73fa1 Bug 1868838 - Move some missed tests, and update documentation for new ASRouter pathing. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D199001
 2024-01-29 18:52:29 +00:00
Mike Conley
378c760146 Bug 1868838 - Move PanelTestProvider to browser/components/asrouter/modules. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198999
 2024-01-29 18:52:28 +00:00
Mike Conley
ab18bd7d99 Bug 1868838 - Move OnboardingMessageProvider to browser/components/asrouter/modules. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198997
 2024-01-29 18:52:28 +00:00
Mike Conley
ebad8072cd Bug 1868838 - Move import-rollouts script into browser/components/asrouter. r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D198996
 2024-01-29 18:52:28 +00:00
Mike Conley
c7eea981cf Bug 1868838 - Move ASRouter unit test constants to browser/components/asrouter. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198956
 2024-01-29 18:52:27 +00:00
Mike Conley
523d9e2457 Bug 1868838 - Move messaging schemas into browser/components/asrouter. r=pdahiya,barret 
Differential Revision: https://phabricator.services.mozilla.com/D198955
 2024-01-29 18:52:27 +00:00
Mike Conley
d7120d9f2d Bug 1868838 - Move ASRouter docs into browser/components/asrouter. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198891
 2024-01-29 18:52:25 +00:00
Mike Conley
7fc079d515 Bug 1868838 - Move template-utils into browser/components/asrouter. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198890
 2024-01-29 18:52:24 +00:00
Mike Conley
efe999860a Bug 1868838 - Move ImpressionsWrapper and ConditionalWrapper into browser/components/asrouter. r=pdahiya 
These don't appear to be used anywhere, but moving them anyways.

Differential Revision: https://phabricator.services.mozilla.com/D198889
 2024-01-29 18:52:24 +00:00
Mike Conley
ef3fd292cf Bug 1868838 - Move asrouter-utils into browser/components/asrouter. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198883
 2024-01-29 18:52:23 +00:00
Mike Conley
6dc4814bc3 Bug 1868838 - Move Button into into browser/components/asrouter. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198882
 2024-01-29 18:52:23 +00:00
Mike Conley
0ae871c74e Bug 1868838 - Move ModalOverlay into browser/components/asrouter. r=pdahiya 
Previous patches in the stack had used asroutermodules as an alias to get
at browser/components/asrouter/modules. This patch, however, required adding
an alias to get at asrouter/content-src/components, so asroutermodules was
replaced with a top-level asrouter alias.

Differential Revision: https://phabricator.services.mozilla.com/D198881
 2024-01-29 18:52:22 +00:00
Mike Conley
2d48d171fe Bug 1868838 - Move RemoteL10n into browser/components/asrouter/modules. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198880
 2024-01-29 18:52:22 +00:00