corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
890,588 Commits 1 Branch 0 Tags
34caedb5e06d01b718ee88c54aaa73e65e5596d9
Commit Graph

319 Commits

Author SHA1 Message Date
Natalia Csoregi
4bf66df843 Backed out changeset 4707e617d389 (bug 1876173) for causing newtab failures on aboutwelcome. CLOSED TREE 2024-03-14 00:38:01 +02:00
Jason Prickett
faeefc390a Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D201902
 2024-03-13 21:28:06 +00:00
Natalia Csoregi
a6b8803582 Backed out changeset d488b0a57d95 (bug 1876173) for causing fxms failures. CLOSED TREE 2024-03-13 21:17:52 +02:00
Jason Prickett
9f76e777a7 Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D201902
 2024-03-13 18:23:44 +00:00
Mark Banner
d534b7b6ee Bug 1885041 - Expand disallowing JSM based imports via ESLint to everything except for devtools. r=arai,omc-reviewers,aminomancer,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D204441
 2024-03-13 17:38:28 +00:00
Jason Prickett
d559850e2d Bug 1882662 - Add checkDefaultBrowser pref check to fox doodle message targeting r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D204268
 2024-03-11 19:42:05 +00:00
Mark Banner
afdbce2ec3 Bug 1884623 - Update more jsm references in production code and docs in browser/. r=mossop,extension-reviewers,omc-reviewers,migration-reviewers,robwu,mconley,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D204182
 2024-03-11 15:26:28 +00:00
Punam Dahiya
bda9f1263a Bug 1877210 - Remove unused asrouter components r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D204122
 2024-03-08 23:06:14 +00:00
hanna alemu
3facefbc9c Bug 1877788 - Record reach for all messaging experiment features r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D203829
 2024-03-08 16:51:20 +00:00
Shane Hughes
1a451ad5bc Bug 1775847 - Fix Glean timeout in browser_asrouter_cfr.js. r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D202078
 2024-03-07 19:03:28 +00:00
negin
e825f3bfde Bug 1878072 - Increase karma.mc branch coverage to 80 percent r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D202631
 2024-03-07 19:00:18 +00:00
Mark Banner
383e208b95 Bug 1883371 - Enable ESLint rule no-console on production code. r=mossop,webcompat-reviewers,devtools-reviewers,omc-reviewers,twisniewski,nchevobbe,aminomancer 
Allow for console.error, console.warn and console.createInstance, but fail for everything else.

Differential Revision: https://phabricator.services.mozilla.com/D203456
 2024-03-05 16:56:57 +00:00
Dave Townsend
35c104ff31 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D202950
 2024-03-03 09:09:08 +00:00
Punam Dahiya
d3035fa703 Bug 1879638 - Update Old references to asrouter and aboutwelcome files r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D203330
 2024-03-02 02:36:24 +00:00
negin
601a737f68 Bug 1877557 - Extra configurations for LinkParagraph component for about:welcome r=omc-reviewers,emcminn,pdahiya 
Adds styling for legal copy and updates above_button_config so it renders after tiles/MultiSelect but before action buttons.

Differential Revision: https://phabricator.services.mozilla.com/D200078
 2024-03-01 21:03:23 +00:00
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE 
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
 2024-03-01 18:25:05 +02:00
Dave Townsend
20b5d8c60f Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D202950
 2024-03-01 15:20:17 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE 
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
 2024-03-01 12:58:03 +02:00
Dave Townsend
d5beece355 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D202950
 2024-03-01 10:10:08 +00:00
Shane Hughes
37f30cffbd Bug 1881106 - Move ModalOverlay.test.jsx to newtab directory. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D202255
 2024-02-27 18:52:20 +00:00
Shane Hughes
9c7d018917 Bug 1879655 - Fix microsurvey group structure, a11y, and randomization. r=omc-reviewers,emcminn 
Change how microsurveys are structured. This ensures that screen readers
perceive a single logical collection, which contains all the radio
buttons and is labeled by the question, which is no longer defined by
subtitle but by tiles.label. This also changes how survey randomization
works. Instead of randomizing the entire set, we randomize specific
items. Any adjacent items with randomize will be randomized in-place. So
if there are 4 items with randomize, followed by 1 nonrandom item, the 4
will be randomized but the 5th will stay at the bottom. Finally, this
patch saves the randomized order so that it persists between back and
forward navigation on about:welcome. That should avoid some jank if we
show surveys in about:welcome.

Differential Revision: https://phabricator.services.mozilla.com/D202513
 2024-02-27 03:29:29 +00:00
Mark Banner
aefd647018 Bug 1881265 - Enable ESLint recommended rule getter-return. r=mossop,extension-reviewers,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D202318
 2024-02-26 11:35:40 +00:00
Mark Banner
1d4856edef Bug 1881901 - Update asrouter/aboutwelcome to use latest node_modules to fix issues building with node 18. r=aminomancer,omc-reviewers 
An out-of-date webpack was causing the issue, but updating generally is probably a good idea.

Differential Revision: https://phabricator.services.mozilla.com/D202656
 2024-02-24 12:21:20 +00:00
Mark Banner
d1f4ef701d Bug 1881573 - Drop use of ESLint rule max-depth from newtab/asrouter/aboutwelcome. r=pdahiya,thecount,Gijs,devtools-reviewers,omc-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D202474
 2024-02-24 10:04:46 +00:00
Mark Banner
55dda230bd Bug 1881817 - Move all asrouter/content-src/*.js files which are modules to use .mjs extensions. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D202622
 2024-02-24 10:00:59 +00:00
Mark Banner
3eb6faa5a1 Bug 1881819 - Remove now redundant inject-loader from asrouter/aboutwelcome/newtab code. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D202621
 2024-02-24 10:00:58 +00:00
Mark Banner
3f16c53851 Bug 1881818 - Remove various modules from asrouter/aboutwelcome/newtab as they are now unused. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D202620
 2024-02-24 10:00:58 +00:00
Mike Conley
a72977c483 Bug 1878783 - Retire babel-jsm-to-commonjs since browser JSMs are gone now. r=Standard8,omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D201828
 2024-02-15 21:30:05 +00:00
Nick Alexander
8de77add68 Bug 1868676 - Part 1: Allow snapshots of multiple contexts. r=barret,omc-reviewers,aminomancer 
`ASRouterTargeting` does _not_ include the experiment details that
supply `activeExperiments`, `activeRollouts`, etc.  Those are combined
from additional contexts.  This patch makes it easy to do that
combination.

N.b.: the use of `Proxy` instances makes iteration tricky, so we avoid
it entirely.

Differential Revision: https://phabricator.services.mozilla.com/D200124
 2024-02-14 21:31:19 +00:00
Jason Prickett
374892962b Bug 1879390 - Add screen ID to fox doodle r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D201750
 2024-02-14 01:13:23 +00:00
Shane Hughes
47c064fec9 Bug 1877995 - Move feature callout dismiss button so the tab order makes more sense. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D200714
 2024-02-13 23:26:16 +00:00
Mike Conley
587f39ba06 Bug 1878731 - Make it so that ResourceUriPlugin can do multiple path replacements. r=Standard8,omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D201139
 2024-02-12 18:49:38 +00:00
Mike Conley
6227d37b2c Bug 1878731 - Convert ASRouter to an ESM. r=emcminn,pip-reviewers,fxview-reviewers,omc-reviewers,sfoster,kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D201138
 2024-02-12 18:49:38 +00:00
Mike Conley
c22c73b7ab Bug 1878731 - Convert ASRouterPreferences to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201134
 2024-02-12 18:49:37 +00:00
Mike Conley
419fa8c4b8 Bug 1878731 - Convert ASRouterTargeting to an ESM. r=emcminn,application-update-reviewers,omc-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D201133
 2024-02-12 18:49:37 +00:00
Mike Conley
bac643012b Bug 1878731 - Convert ASRouterTriggerListeners to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201129
 2024-02-12 18:49:36 +00:00
Mike Conley
92d05e3eef Bug 1878731 - Convert ASRouterDefaultConfig to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201128
 2024-02-12 18:49:36 +00:00
Mike Conley
2f152b878f Bug 1878731 - Convert ASRouterParentProcessMessageHandler to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201127
 2024-02-12 18:49:36 +00:00
Mike Conley
0cd6316b40 Bug 1878731 - Convert CFRPageActions to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201126
 2024-02-12 18:49:35 +00:00
Mike Conley
d322adbf27 Bug 1878731 - Convert OnboardingMessageProvider to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201125
 2024-02-12 18:49:35 +00:00
Mike Conley
4c988cb8f1 Bug 1878731 - Convert ToolbarPanelHub to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201124
 2024-02-12 18:49:34 +00:00
Mike Conley
af147ef4b2 Bug 1878731 - Convert ToolbarBadgeHub to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201123
 2024-02-12 18:49:34 +00:00
Mike Conley
cbeae19a3b Bug 1878281 - Stub out NEWTAB_MESSAGE_REQUEST handling for legacy privileged addons. r=mkaply,omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D201094
 2024-02-09 21:29:46 +00:00
Shane Hughes
d26f937678 Bug 1879220 - Adjust feature callout surface to handle panel surveys. r=jprickett,omc-reviewers 
Fix feature callout teardown while a tour is still ongoing.
Add an option to space out the CTA buttons.
Add dynamic disabling of secondary_button.
Add randomization for the MultiSelect component, mainly for surveys.
Improve test coverage.
Add documentation for the above changes plus some missing things.

Differential Revision: https://phabricator.services.mozilla.com/D201027
 2024-02-08 22:48:27 +00:00
pstanciu
e5fa393947 Backed out changeset 7aee47be18bf (bug 1879220) for causing node newtab failures at aboutwelcome. CLOSED TREE 2024-02-08 17:55:42 +02:00
Shane Hughes
ebe66ac58f Bug 1879220 - Adjust feature callout surface to handle panel surveys. r=jprickett,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201027
 2024-02-08 12:30:25 +00:00
Mark Banner
b3b56aa2eb Bug 1878556 - Remove unused asrouter/content-src/template-utils.js. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200591
 2024-02-07 08:55:33 +00:00
Mark Banner
12a8012f22 Bug 1878556 - Move addUtmParams.js to aboutwelcome and rename to .mjs. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200590
 2024-02-07 08:55:32 +00:00
Mark Banner
cd218db908 Bug 1878554 - Remove deprecated ESLint rules from aboutwelcome/asrouter/newtab configs. r=aminomancer,omc-reviewers 
These rules are node specific and not really useful in mozilla central:
handle-callback-err, no-buffer-constructor, no-path-concat, no-process-exit
These rules are not useful as require is only used in configurations:
no-new-require, no-mixed-requires
Prettier already enforces max-statements-per-line
lines-between-class-members isn't handled separately, but if we want to do that we should decide on it globally.

Differential Revision: https://phabricator.services.mozilla.com/D200588
 2024-02-07 08:55:31 +00:00
Mark Banner
8ce0ecbf74 Bug 1878554 - Remove ESLint rule require-await for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers 
We decided not to use the rule in bug 1381030.

Differential Revision: https://phabricator.services.mozilla.com/D200587
 2024-02-07 08:55:31 +00:00