corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
976,606 Commits 1 Branch 0 Tags
1d28e315f528c5d1da29b0bae76c8ff294c75c91
Commit Graph

3662 Commits

Author SHA1 Message Date
Jeremy Swinarton
e409401215 Bug 1939719: Resolve talos sessionstore perf issue r=dao,sessionstore-reviewers 
The root cause of this turned out to be that the talos
sessionstore.js file did not have groups, but the call to load groups
during the deferred restore routine was expecting them to exist,
throwing an error. This change fixes the issue.

PerfCompare run: https://perf.compare/compare-results?baseRev=6ccc0ebc69e907e55033ea729a5ca40d0fcb22fe&newRev=5d112ab0e86f98dbb7a9c6f8d40de01564ebec7b&baseRepo=try&newRepo=try&framework=1

Differential Revision: https://phabricator.services.mozilla.com/D234347
 2025-01-15 16:52:30 +00:00
Jeremy Swinarton
a80eb49e6c Bug 1939904: Closed tab groups in history menus can be restored regardless of window they were closed in. r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234042
 2025-01-14 17:49:24 +00:00
Yazan Al Macki
4507fb96aa Bug 1925235 - Avoid updating unified search button icon if searchMode has changed. r=daleharvey,sessionstore-reviewers,dao 
Currently, multiple calls to #updateSearchIcon can run concurrently. When restarting the browser with a tab , and another tab in which a local search mode is active, the local search mode is incorrectly displayed as the default engine search mode. I believe this is due to the first #updateSearchIcon call (default engine, triggered when new tab is reopened) taking longer than the subsequent #updateSearchIcon call (triggered when the search mode is restored).

This is probably due to [[ https://searchfox.org/mozilla-central/rev/b6718bf263ae780289da471f0ea35797a09e2f05/browser/components/urlbar/SearchModeSwitcher.sys.mjs#329-334 | this ]] code taking a while to execute in comparison to [[ https://searchfox.org/mozilla-central/rev/b6718bf263ae780289da471f0ea35797a09e2f05/browser/components/urlbar/SearchModeSwitcher.sys.mjs#338-342 | this ]] code that runs for local search modes.

Ensuring that an #updateSearchIcon call terminates if search mode switches during its async processing prevents it from interfering with the next call triggered and incorrectly overriding the icon.

Differential Revision: https://phabricator.services.mozilla.com/D233036
 2025-01-14 14:34:05 +00:00
Stanca Serban
9e9507fcbb Backed out changeset d448ac7b0d9e (bug 1921060) for causing mochitests failures in browser_audioTabIcon.js. 2025-01-13 21:35:03 +02:00
Kelly Cochrane
50f355f8ec Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2025-01-13 17:55:32 +00:00
Dão Gottwald
2dcb43e95d Bug 1940231 - When restoring a session, prevent original startup tabs from moving into a restored tab group. r=tabbrowser-reviewers,jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D234022
 2025-01-13 15:59:48 +00:00
Cosmin Sabou
b1cd82afbc Bug 1787024 - Disable browser_async_remove_tab.js also on linux ASan for frequent failures. a=test-only 2025-01-11 02:48:42 +02:00
Dão Gottwald
f60b181b60 Bug 1940791 - When restoring a group, select it. r=jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D233863
 2025-01-10 16:14:38 +00:00
Sebastian Hengst
7e0528301b Bug 1775605 - disable browser_label_and_icon.js on Linux ASan for frequent failures 
Differential Revision: https://phabricator.services.mozilla.com/D233770
 2025-01-09 22:02:28 +00:00
Jonathan Sudiaman
9372222c8c Bug 1935482 - Replace legacy properties with SidebarState properties r=sidebar-reviewers,sessionstore-reviewers,nsharpley,sfoster 
- Move resize observer (setting max width) logic over to SidebarState.
- Add `command` property to SidebarState.
- Handle receiving legacy session restore data.
- Add unit tests along with mocking structures to get a better idea of state/controller coupling (which we should ultimately reduce).

Differential Revision: https://phabricator.services.mozilla.com/D232730
 2025-01-08 23:06:42 +00:00
Jeremy Swinarton
cf0ea617df Bug 1939599: Tab groups can be restored by Ctrl+Shift+T r=dao,sthompson,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D233102
 2025-01-08 22:33:13 +00:00
Joel Maher
248157ee22 Bug 1938960 - additional greening up of win11 24h2, carry forward existing annotations. r=aryx,webdriver-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,nchevobbe,dimi,whimboo,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D233026
 2025-01-07 19:51:49 +00:00
Dão Gottwald
899b3c4127 Bug 1939413 - Ensure _savedGroups isn't undefined. r=jswinarton,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D233163
 2025-01-03 16:51:08 +00:00
Goloman Adrian
359af847a8 Bug 1787024 - fix typo in manifest file. a=typo-fix 2025-01-03 18:23:54 +02:00
Goloman Adrian
6f97f31f70 Bug 1787024 - disable test browser_async_remove_tab.js for frequent failures. r=sessionstore-reviewers,dao DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D232911
 2024-12-31 17:50:55 +00:00
Jeremy Swinarton
4ded93c800 Bug 1927767: Closed tab groups from the last session appear correctly in history menus r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232879
 2024-12-30 14:56:50 +00:00
Luca Greco
775328ed67 Bug 1786601 - Tweak browser_ext_tabs_events.js to expect SessionStore onMoveToNewWindow uncaught rejection. r=dao,sessionstore-reviewers,robwu 
This patch modifies SessionStoreInternal.onMoveToNewWindow to raise a more specific error message when
no TabState is found for the tab being moved, and then allows that more specific error message
as an uncaught rejection in browser_ext_tabs_events.js through PromiseTestUtils.allowMatchingRejectionsGlobally.

These changes don't address the underlying issue hit by SessionStoreInternal, but in the short term
it will allow to prevent the high frequency intermittent failure currently hit by the
browser_ext_tabs_events.js (and to keep the existing test coverage which would be lost if we
would instead skip the entire test file to workaround the intermittency).

An inline comment added right above the call to PromiseTestUtils.allowMatchingRejectionsGlobally
includes a mention to Bug 1938594 (a new bug filed under the "Firefox :: Session Restore" bugzilla
component to track additional investigations on the SessionStore/TabStateFlusher side) as a reminder
of the underlying issue (and to remove the workaround when it may not be necessary anymore).

Differential Revision: https://phabricator.services.mozilla.com/D230528
 2024-12-22 18:06:56 +00:00
DJ
c5ab0e12ee Bug 1938589 - init savedGroups from session file. r=sthompson,dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232747
 2024-12-21 03:30:15 +00:00
Jeremy Swinarton
9561dbc00e Bug 1927768: Purging domain data handles tabs in closed groups r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232228
 2024-12-19 17:01:04 +00:00
Tom Schuster
60946c123d Bug 1937545 - Remove inline event handlers from RecentlyClosedTabsAndWindowsMenuUtils r=sessionstore-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D232618
 2024-12-19 14:01:10 +00:00
Stephen Thompson
808fb505dc Bug 1921857 - "close tabs to the left/right" changes for tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers 
1. should be available in the context menu even if there are collapsed tab groups to the left/right
2. should close collapsed tab groups when they are to the left/right
3. tab groups should be saved when they are going to be closed when using "close tabs to the left/right"

Differential Revision: https://phabricator.services.mozilla.com/D232432
 2024-12-19 10:22:24 +00:00
Stephen Thompson
f8fd5db3b5 Bug 1933813 - "close other tabs" changes for tab groups r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232430
 2024-12-19 08:54:25 +00:00
Stanca Serban
30c8718405 Backed out changeset a2a3d6bf518f (bug 1921060) as requested for causing multiple regressions. 2024-12-18 20:51:04 +02:00
Stephen Thompson
d217c2630b Bug 1921802 - save open tab groups on window close r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D231892
 2024-12-18 15:54:21 +00:00
Dão Gottwald
2ed2e383f6 Bug 1936831 - Allow searching for closed and saved tab groups in the address bar and display matching tab groups as actions. r=daleharvey,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232336
 2024-12-18 09:27:40 +00:00
Alexandru Marc
7078799556 Backed out changeset 2817415422a2 (bug 1921802) for causing bc failures @ browser_1933485_tab_groups_history.js CLOSED TREE 2024-12-18 11:34:39 +02:00
Stephen Thompson
387f34697e Bug 1921802 - save open tab groups on window close r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D231892
 2024-12-18 07:58:00 +00:00
Stanca Serban
f41de5d39a Backed out changeset 415580659e75 (bug 1927768) for causing mochitests failures in browser_394759_purge.js. CLOSED TREE 2024-12-17 14:02:52 +02:00
Jeremy Swinarton
b77759e87b Bug 1927768: Purging domain data handles tabs in closed groups r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232228
 2024-12-17 10:03:49 +00:00
Stephen Thompson
504eddfac8 Bug 1933114 - add tests for restoring tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers 
Adds/updates test cases for restoring saved tab groups, closed tab groups, and open tab groups from session state

Differential Revision: https://phabricator.services.mozilla.com/D230322
 2024-12-12 15:22:41 +00:00
Jeremy Swinarton
cf23be9260 Bug 1933485: Ensure tab groups always appear in history menus r=dao,sthompson,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D230985
 2024-12-12 14:36:08 +00:00
Joel Maher
64f299c4bd Bug 1936417 - extend windows11 skip-if conditions for marionette tests to win11 24H2 update. r=whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D231798
 2024-12-12 13:09:19 +00:00
Kelly Cochrane
93e44d9499 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2024-12-12 12:57:41 +00:00
Sam Foster
a15eb85904 Bug 1934182 - Disable the restore session infobar by default in all tests r=sessionstore-reviewers,Gijs,dao,perftest-reviewers,sparky 
- But reset the default value in the browser-mochitest-chrome session store suite.

Differential Revision: https://phabricator.services.mozilla.com/D230861
 2024-12-11 18:02:53 +00:00
Stephen Thompson
4b0b5070a8 Bug 1933574 - saved tab groups session schema change r=dao,sessionstore-reviewers,tabbrowser-reviewers 
This patch makes saved tab groups use the "closed tabs" schema for storing tab data. This makes saved tab groups consistent with closed tabs and closed tab groups. The tab/tab group restoration code is built to work with the "closed tabs" schema, so this schema change allows saved tab groups to be restored correctly.

Bug 1933114 will add and improve the tests for restoring tab groups.

Differential Revision: https://phabricator.services.mozilla.com/D231818
 2024-12-11 16:47:41 +00:00
Alexandru Marc
b15c866809 Backed out changeset 5b573c874645 (bug 1921060) for causing mda failures @ browser_mute_webAudio.js CLOSED TREE 2024-12-11 17:40:44 +02:00
Kelly Cochrane
bb2110744e Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2024-12-11 14:37:38 +00:00
Sandor Molnar
b34a0a7264 Backed out changeset e5ecd3645987 (bug 1933114) for causing bc failures @ browser_tab_groups_restore_closed_in_closed_window.js CLOSED TREE 2024-12-11 03:45:56 +02:00
Stephen Thompson
0630d8f7bc Bug 1933114 - tests and fixes for tab group restoration r=dao,sessionstore-reviewers,tabbrowser-reviewers 
Also addresses bug 1933574 by changing the schema of saved tab groups so that they look the same as closed tab groups (that is, the saved tab groups' tabs list now has the same schema as the _closedTabs list).

Differential Revision: https://phabricator.services.mozilla.com/D230322
 2024-12-10 16:37:36 +00:00
Dão Gottwald
d9a76a01e4 Bug 1935826 - Update triage rotation JSON file for Session Restore. r=sessionstore-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D231472
 2024-12-10 15:59:51 +00:00
Jonathan Sudiaman
470e392758 Bug 1930199 - Create a state-based API to manage the multiple states of the sidebar launcher and sidebar panel. r=sidebar-reviewers,sessionstore-reviewers,kcochrane,sfoster,sclements 
- Created a SidebarState API to manage reactive properties for the controller.
- Replaced usages of sidebarMain.hidden with state.launcherVisible.
- Replaced usages of sidebarMain.expanded with state.launcherExpanded.
- Removed toggleExpanded() and toggleHide(), replaced with equivalent state toggles.

Differential Revision: https://phabricator.services.mozilla.com/D229558
 2024-12-06 16:00:29 +00:00
Alexandru Marc
820db0e701 Backed out changeset 4436a8f5e82d (bug 1933114) for causing bc failures @ browser_tab_groups_restore_closed_in_closed_window.js CLOSED TREE 2024-12-06 08:56:12 +02:00
Stephen Thompson
4c2d2eea70 Bug 1933114 - tests and fixes for tab group restoration r=dao,sessionstore-reviewers,tabbrowser-reviewers 
Also addresses bug 1933574 by changing the schema of saved tab groups so that they look the same as closed tab groups (that is, the saved tab groups' tabs list now has the same schema as the _closedTabs list).

Differential Revision: https://phabricator.services.mozilla.com/D230322
 2024-12-06 05:25:26 +00:00
Sandor Molnar
594e700d37 Backed out changeset ceeaeae381df (bug 1933114) for causing bc failures @ browser_tab_groups_restore_closed_in_closed_window.js CLOSED TREE 2024-12-05 20:22:04 +02:00
Stephen Thompson
e70b247934 Bug 1933114 - tests and fixes for tab group restoration r=dao,sessionstore-reviewers,tabbrowser-reviewers 
Also addresses bug 1933574 by changing the schema of saved tab groups so that they look the same as closed tab groups (that is, the saved tab groups' tabs list now has the same schema as the _closedTabs list).

Differential Revision: https://phabricator.services.mozilla.com/D230322
 2024-12-05 15:55:10 +00:00
Adam Vandolder
2ba689d99e Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D221390
 2024-12-05 01:20:07 +00:00
Goloman Adrian
05b7d33317 Backed out changeset 4d19e4620e63 (bug 1924861) for causing bc failures @browser_stop_pending.js. CLOSED TREE 2024-12-04 09:11:45 +02:00
Adam Vandolder
87c9038ba7 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D221390
 2024-12-04 04:17:36 +00:00
Henrik Skupin
b3b89d930f Bug 1932916 - [remote] Don't retry to run a command when the browsing context was discarded. r=webdriver-reviewers,sessionstore-reviewers,jdescottes,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D230662
 2024-12-02 14:59:51 +00:00
Cosmin Sabou
82fbc8fbe4 Backed out changeset a8d030efc4ea (bug 1924861) for causing bc failures on browser_stop_pending. 2024-12-02 01:21:14 +02:00