Yazan Al Macki 4507fb96aa Bug 1925235 - Avoid updating unified search button icon if searchMode has changed. r=daleharvey,sessionstore-reviewers,dao ...

Currently, multiple calls to #updateSearchIcon can run concurrently. When restarting the browser with a tab , and another tab in which a local search mode is active, the local search mode is incorrectly displayed as the default engine search mode. I believe this is due to the first #updateSearchIcon call (default engine, triggered when new tab is reopened) taking longer than the subsequent #updateSearchIcon call (triggered when the search mode is restored).

This is probably due to [[ https://searchfox.org/mozilla-central/rev/b6718bf263ae780289da471f0ea35797a09e2f05/browser/components/urlbar/SearchModeSwitcher.sys.mjs#329-334 | this ]] code taking a while to execute in comparison to [[ https://searchfox.org/mozilla-central/rev/b6718bf263ae780289da471f0ea35797a09e2f05/browser/components/urlbar/SearchModeSwitcher.sys.mjs#338-342 | this ]] code that runs for local search modes.

Ensuring that an #updateSearchIcon call terminates if search mode switches during its async processing prevents it from interfering with the next call triggered and incorrectly overriding the icon.

Differential Revision: https://phabricator.services.mozilla.com/D233036

2025-01-14 14:34:05 +00:00

..

content

…

test

Bug 1925235 - Avoid updating unified search button icon if searchMode has changed. r=daleharvey,sessionstore-reviewers,dao

2025-01-14 14:34:05 +00:00

components.conf

…

GlobalState.sys.mjs

…

jar.mn

…

metrics.yaml

Bug 1927093 - Migrate scalars to use Glean APIs for browser.engagement.* (excluding browser.engagement.navigation.*), r=chutten,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,sfoster.

2024-11-05 13:22:58 +00:00

moz.build

Bug 1925724 - Use page wireframe for tab hover preview as a fallback when a normal thumnail is not available;r=mconley,sessionstore-reviewers,tabbrowser-reviewers,farre

2024-10-24 03:34:40 +00:00

PageWireframes.sys.mjs

Bug 1926991 - Use gray instead of black for default color in wireframes to better support dark themes r=sessionstore-reviewers,farre

2024-10-25 15:12:24 +00:00

RecentlyClosedTabsAndWindowsMenuUtils.sys.mjs

Bug 1937545 - Remove inline event handlers from RecentlyClosedTabsAndWindowsMenuUtils r=sessionstore-reviewers,dao

2024-12-19 14:01:10 +00:00

RunState.sys.mjs

…

SessionCookies.sys.mjs

Bug 1922193 - Enforce isPartitioned flag for partitioned session cookie when restoring session cookies. r=sfoster,sessionstore-reviewers

2024-11-15 11:05:27 +00:00

SessionFile.sys.mjs

Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya,willdurand

2024-10-08 20:14:42 +00:00

SessionLogger.sys.mjs

Bug 1854373 Use the loggers to capture errors and debug details during session restore.r=sessionstore-reviewers,markh,sclements

2024-05-09 20:30:15 +00:00

SessionMigration.sys.mjs

…

SessionSaver.sys.mjs

…

SessionStartup.sys.mjs

Bug 1927093 - Migrate scalars using scalarSetMaximum to Glean APIs in BrowserUsageTelemetry.sys.mjs, r=chutten,sessionstore-reviewers,sfoster.

2024-10-28 22:02:16 +00:00

SessionStore.sys.mjs

Backed out changeset d448ac7b0d9e (bug 1921060) for causing mochitests failures in browser_audioTabIcon.js.

2025-01-13 21:35:03 +02:00

SessionStoreFunctions.sys.mjs

…

SessionWriter.sys.mjs

…

StartupPerformance.sys.mjs

…

TabAttributes.sys.mjs

…

TabGroupState.sys.mjs

Bug 1921802 - save open tab groups on window close r=dao,sessionstore-reviewers

2024-12-18 15:54:21 +00:00

TabState.sys.mjs

Bug 1925516 - Convert TabStateInternal to a modern JS class. r=sthompson

2024-10-19 06:40:58 +00:00

TabStateCache.sys.mjs

Bug 1916492 - Remove some unused leftover code from GroupedSHistory. r=sessionstore-reviewers,dao

2024-09-05 13:10:18 +00:00

TabStateFlusher.sys.mjs

…

triage.json

Bug 1935826 - Update triage rotation JSON file for Session Restore. r=sessionstore-reviewers,sclements

2024-12-10 15:59:51 +00:00