Commit Graph

854484 Commits

Author SHA1 Message Date
Stephanie Cunnane
14eeeccf77 Bug 1887686 - Add shopping page property to SERP categorization event. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D205607
2024-03-25 21:31:28 +00:00
Niklas Baumgardner
fa642985ac Bug 1881506 - Handle all button clicks in screenshots overlay. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D204985
2024-03-25 20:55:13 +00:00
Cristian Tuns
a9153f0427 Backed out changeset 6461d8999f47 (bug 1881821) for causing bc failures in /browser_parsable_css.js CLOSED TREE 2024-03-25 17:00:45 -04:00
Niklas Baumgardner
fa1d4eb19d Bug 1883717 - Correctly display screenshot size in overlay. r=sfoster,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D204946
2024-03-25 20:35:03 +00:00
Emilio Cobos Álvarez
4728e53397 Bug 1877298 - Make tab color in firefox view match the browser UI on Linux and prefers-contrast modes. r=dao,kcochrane,desktop-theme-reviewers,fxview-reviewers,jules
Differential Revision: https://phabricator.services.mozilla.com/D204891
2024-03-25 20:23:33 +00:00
Mike Hommey
c6acd81baf Bug 1871883 - Update builders to rustc 1.77. r=firefox-build-system-reviewers,ahochheiden
Differential Revision: https://phabricator.services.mozilla.com/D204991
2024-03-25 20:20:30 +00:00
Noah Bond
a388cf972d Bug 1842262 - Convert CrashReportingTest to compose r=android-reviewers,rsainani,ohorvath
The diff is only a few lines between the [original implementation](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/CrashReportingTest.kt).

Diff for ease of use: https://www.diffchecker.com/dkXUxtQP/

Differential Revision: https://phabricator.services.mozilla.com/D205397
2024-03-25 20:17:52 +00:00
Mike Hommey
cfa09fad53 Bug 1887386 - Mark fields rust 1.77 thinks are dead code as being allowed. r=afranchuk
Differential Revision: https://phabricator.services.mozilla.com/D205519
2024-03-25 20:15:14 +00:00
Noah Bond
9a2148aa8d Bug 1842265 - Convert SettingsPrivateBrowsingTest to Compose r=android-reviewers,rsainani,ohorvath
[Original test](https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/SettingsPrivateBrowsingTest.kt)

[Diff](https://www.diffchecker.com/yTOjwNEi/)

Differential Revision: https://phabricator.services.mozilla.com/D205403
2024-03-25 20:13:19 +00:00
Jules Simplicio
a12cd48132 Bug 1881821 - Clean up tokens files ahead of JSON source of truth setup r=desktop-theme-reviewers,reusable-components-reviewers,hjones,dao,mstriemer
Changed
* `--color-background-*` are now part of the group of `--background-color` tokens
* `--box-background-color` is now part of the group of `--background-color` tokens as `--background-color-box`
* `--color-canvas` is now part of the group of `--background-color` tokens as `--background-color-canvas`
* `--border-interactive-*` are now part of the group of `--border-color` tokens and consequently now start with `--border-color`
* `--color-error-outline` is now an outline-specific token as `--outline-color-error`
* Comment headings were cleaned up as to follow the existing standard
* Better documentation behind the difference of "Base", "Application", and "Component" tiers in the design tokens documentation
* Tokens files are alphabetized

Removed
* `--outline-color-error` had duplicates in both high contrast mode media queries, so its value under `forced-colors` was removed
* "Base" and "Application" headings in tokens files were removed in order to lean in on the alphabetical order organization of token groups and promote a cleaner file and less confusion
* Documentation was edited down to not incude any guidance that we don't adhere to
* Remove duplicate interactive border color high contrast mode tokens in `tokens-brand.css` in favor of `tokens-shared.css`
* Remove `--button-border-color-primary` duplicate in `tokens-brand.css`
* Remove duplicate `--button-text-color` in `tokens-shared.css`

Differential Revision: https://phabricator.services.mozilla.com/D202767
2024-03-25 20:12:21 +00:00
Andrew Erickson
0ffa5871c6 No bug: mach try: include full mach try command in commit message r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D204834
2024-03-25 20:03:48 +00:00
stransky
b10c030c97 Bug 1879987 [Linux] Cache gdk_window_get_origin() window position at nsWindow::WidgetToScreenOffset() r=emilio
Depends on D204191

Differential Revision: https://phabricator.services.mozilla.com/D204509
2024-03-25 19:56:55 +00:00
Noemi Erli
89ffefa292 Backed out 3 changesets (bug 1884941, bug 1877419) for causing bustage in URLQueryStringStripper.cpp CLOSED TREE
Backed out changeset 32c74a4cd05b (bug 1877419)
Backed out changeset c2ca2f596c09 (bug 1877419)
Backed out changeset 45931e6db21e (bug 1884941)
2024-03-25 21:50:27 +02:00
Mozilla Releng Treescript
a648175393 no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD CLOSED TREE
eo -> 024c7bcd9cff740e85748fb9e2a29eb32f6c0d57
is -> 653b02da1d7d454fe1c31c45f330ab6c49619a95
lv -> 93366518403d1c1df8e175ea8fe4dadf7fab931a
tr -> a11e88709e903a347cfc317a3da08fe80dbd9ff7
zh-CN -> cbd9ef24b784872cd8ea329c35db4edbae40dc1e
2024-03-25 19:03:44 +00:00
Tom Ritter
edf49f788c Bug 1885598: Assert on a passed remoteTypeOverride to avoid footguns r=nika
Differential Revision: https://phabricator.services.mozilla.com/D204791
2024-03-25 18:57:07 +00:00
Tom Ritter
74ad46909a Bug 1885598: Add a couple of pointer comments to duplicated code r=nika
Differential Revision: https://phabricator.services.mozilla.com/D205269
2024-03-25 18:57:07 +00:00
Tom Ritter
c0a25341ad Bug 1885598: Do not pass remoteType r=mossop
Firstly, this parameter is actually named remoteTypeOverride and
secondly, it is only valid for about: urls when passed to loadURI

Differential Revision: https://phabricator.services.mozilla.com/D204788
2024-03-25 18:57:06 +00:00
Fred Chasen
0822671fd6 Bug 1883740 - Add disk size measurements for cookies, form history and sessions. data-review=jhirsch r=backup-reviewers,mconley
- Adds `CookiesBackupResource`, `FormHistoryBackupResource` and `SessionsStoreBackupResource` classes with measurement methods for those resources.
- Exports `BYTES_IN_KB` and new `bytesToFuzzyKilobytes` methods from `BackupResource`
- Fix filename for `BackupResource` tests.

Differential Revision: https://phabricator.services.mozilla.com/D205254
2024-03-25 18:45:52 +00:00
Cristian Tuns
b46caa845b Backed out 2 changesets (bug 1885361) for causing gecko desision task failures in codespell.yml CLOSED TREE
Backed out changeset 03336aa8f102 (bug 1885361)
Backed out changeset bad3f83d0484 (bug 1885361)
2024-03-25 14:48:51 -04:00
Luca Greco
544d12907f Bug 1885004 - Add to XPIProvider restrictions on installing new addons through XPI files only signed with SHA1. r=willdurand,robwu
Differential Revision: https://phabricator.services.mozilla.com/D204686
2024-03-25 18:38:17 +00:00
abhishekmadan30
2974b39c6a Bug 1834213 - Added await call for _notifyStripOnShareObservers.r=anti-tracking-reviewers,timhuang.
Differential Revision: https://phabricator.services.mozilla.com/D205247
2024-03-25 18:31:04 +00:00
abhishekmadan30
9291957602 Bug 1877419 - Part 2: Added tests for nested stripping for Strip on Share. r=pbz
Depends on D202943

Differential Revision: https://phabricator.services.mozilla.com/D203082
2024-03-25 18:30:39 +00:00
abhishekmadan30
7ac746ddf4 Bug 1877419 - Part 1: Added nested stripping of urls to copy without site tracking. r=pbz,necko-reviewers
Depends on D204914

Differential Revision: https://phabricator.services.mozilla.com/D202943
2024-03-25 18:30:38 +00:00
abhishekmadan30
d41edcad79 Bug 1884941 - Add an option to URLParams::Parse() for if it should decode the parameters or not. r=anti-tracking-reviewers,necko-reviewers,valentin,timhuang.
Differential Revision: https://phabricator.services.mozilla.com/D204914
2024-03-25 18:30:38 +00:00
Roger Yang
69ffb51539 Bug 1862107 - Enable secret setting toolbar redesign to be visible in nightly. r=skhan,android-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D205591
2024-03-25 18:29:23 +00:00
Rob Lemley
407420d605 Bug 1885361 - Convert mozlint CI jobs to use skip-unless-mozlint optimization. r=taskgraph-reviewers,ahal
Differential Revision: https://phabricator.services.mozilla.com/D204777
2024-03-25 18:09:22 +00:00
Rob Lemley
196c808ca6 Bug 1885361 - Add SkipUnlessMozlint taskgraph optimization strategy. r=taskgraph-reviewers,ahal
Optimization strategy that uses the mozlint configuration files to decide
whether or not to run a job.

In order to support Firefox and Thunderbird, when registering the strategy,
the path to mozlint config files is needed.

Differential Revision: https://phabricator.services.mozilla.com/D204685
2024-03-25 18:09:21 +00:00
Nan Jiang
f2ef64c1eb Bug 1887308 - Bump up the warning limit for contentrelevancy r=bdk
Had to increase the warning limit as I am not sure what exactly the warning was. Also, `mach lint -l rst toolkit/components/contentrelevancy` reported no issues/warnings.

Differential Revision: https://phabricator.services.mozilla.com/D205606
2024-03-25 18:06:30 +00:00
Julian Descottes
a01c06e78c Bug 1886957 - [wdspec] Add test to check network events for URL with fragment r=webdriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D205448
2024-03-25 18:05:10 +00:00
Cristian Tuns
d3eef14487 Backed out changeset 870a2b89741b (bug 1886953) for causing gtest failures in nsStringIterator.h CLOSED TREE 2024-03-25 14:23:34 -04:00
Cristian Tuns
bcb02ce8a2 Backed out changeset 35b08fcd146e (bug 1886792) for causing fenix-android failures with HomeDeepLinkIntentProcessorTest.process CLOSED TREE 2024-03-25 14:05:05 -04:00
alwu
0fb0a2cef0 Bug 1883784 - part5 : add a new CapabilitesFlag for ClearLead check. r=jolin
Differential Revision: https://phabricator.services.mozilla.com/D205277
2024-03-25 17:19:35 +00:00
alwu
931fdc5102 Bug 1883784 - part4 : no need to ask cenc again because it's the default value. r=jolin
'If value is unspecified, default value of "cenc" is used.' That means
those supported video codecs we have now already support 'cenc', so we
don't need to query 'cenc' again.

See [1].

[1] https://learn.microsoft.com/en-us/windows/win32/api/mfmediaengine/nf-mfmediaengine-imfextendeddrmtypesupport-istypesupportedex

Differential Revision: https://phabricator.services.mozilla.com/D205276
2024-03-25 17:19:34 +00:00
alwu
0563d19619 Bug 1883784 - part3 : no need to check audio for hardware decryption. r=jolin
Differential Revision: https://phabricator.services.mozilla.com/D205275
2024-03-25 17:19:34 +00:00
alwu
f0fe47aa32 Bug 1883784 - part2 : only perform HDCP check if necessary. r=jolin
"The hdcp query (item 4) has a computationally expensive first
invocation cost". See [1].

[1] https://learn.microsoft.com/en-us/windows/win32/api/mfmediaengine/nf-mfmediaengine-imfextendeddrmtypesupport-istypesupportedex

Differential Revision: https://phabricator.services.mozilla.com/D205274
2024-03-25 17:19:33 +00:00
alwu
67f9ca8f92 Bug 1883784 - part1 : reuse media engine factory to avoid unnecessary creation. r=jolin
Differential Revision: https://phabricator.services.mozilla.com/D205273
2024-03-25 17:19:33 +00:00
Nika Layzell
a599ba35bf Bug 1883457 - Part 2: Use be_memory_inline_jit_restrict_* APIs for JIT on iOS, r=jandem
This change enables the JS_USE_APPLE_FAST_WX option for iOS, but uses the
BrowserEngineKit APIs rather than the pthread_jit APIs which are available on
macOS. It is unclear to me if there are other differences with these APIs which
would need to be handled beyond what has been written so far, as this is just a
naive substitution.

Given these functions are explicitly "inline", it may be desirable at some
point to refactor the code to allow the calls to be made inline within
ProcessExecutableMemory.h, however that was left out-of-scope.

Differential Revision: https://phabricator.services.mozilla.com/D203499
2024-03-25 17:12:53 +00:00
Nika Layzell
6ff61cec2b Bug 1883457 - Part 1: Disable jit compilation within the parent process on iOS, r=jandem
This adds a pref to disable jit compilation by calling JS::DisableJitBackend in
the parent process. This will be used on iOS, where the jit entitlements are
only available for sandboxed content processes.

Differential Revision: https://phabricator.services.mozilla.com/D203498
2024-03-25 17:12:53 +00:00
Ryan VanderMeulen
a6824039fd Bug 1887675 - Update Detekt to version 1.23.6. r=android-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D205585
2024-03-25 17:08:16 +00:00
Tarek Ziadé
b50954f8b1 Bug 1886489 - Allow subfolders in filenames for the Model Hub check r=gregtatum
Depends on D205318

Differential Revision: https://phabricator.services.mozilla.com/D205328
2024-03-25 16:57:36 +00:00
Tarek Ziadé
c9a7b048ba Bug 1886495 - Make the url template a config option in ModelHub r=gregtatum
Depends on D205308

Differential Revision: https://phabricator.services.mozilla.com/D205318
2024-03-25 16:57:35 +00:00
Tarek Ziadé
7453ec7a4e Bug 1886675 - store the files as blobs r=gregtatum
Depends on D205290

Differential Revision: https://phabricator.services.mozilla.com/D205308
2024-03-25 16:57:35 +00:00
Tarek Ziadé
899851efd7 Bug 1886488 - Store Content-Type in IndexedDBCache - r=gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D205290
2024-03-25 16:57:34 +00:00
William Durand
3203b1c9a2 Bug 1846866 - Remove traces of security.content.signature.root_hash. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D205588
2024-03-25 16:54:17 +00:00
Gregory Pappas
8338ef10d5 Bug 1887230 - Remove unused child-process-shutdown message r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D205509
2024-03-25 15:46:32 +00:00
pollymce
c2cdb3efc5 Bug 1885167 - fix onward journey from completed download notification r=android-reviewers,boek,kaya
Content intent of completed DownloadNotification now uses a PendingIntent which launches an Activity directly.
Previously, we launched the Activity indirectly from a BroadcastReceiver, which is less performant and is prohibited by the OS since Android 12.
The download notification test has been modified to mock out the file opening behaviour, as this test is just checking the visuals of the notification rather than the onward journeys.

Add notification trampoline test case that fails before the fix was made & passes after, to cover this bug.

Fix a bunch of lint / detekt things - trailing commas, formatting, javadoc comments

Differential Revision: https://phabricator.services.mozilla.com/D205042
2024-03-25 15:41:17 +00:00
Andrew Creskey
98f23f49ec Bug 1861808 - Firefox incorrectly says DNS-over-HTTPS is active when disabled by parental controls r=necko-reviewers,settings-reviewers,valentin
We ensure that parental controls are tested in the UI.

Differential Revision: https://phabricator.services.mozilla.com/D203035
2024-03-25 15:38:54 +00:00
Anna Yeddi
9a07d1b3fa Bug 1854510 - Remove the fail-if notation for passing a11y-checks in Core Credentials. r=timhuang
Since the AccessibilityUtils will be able to account for a click on a label elements for radio buttons and checkboxes in the bug 1882380, we can remove the `fail-if` notation from two tests that were previously failing a11y-checks.

Depends on D205112

Differential Revision: https://phabricator.services.mozilla.com/D205116
2024-03-25 15:25:37 +00:00
Anna Yeddi
51134949e7 Bug 1882380 - Update AccessibilityUtils to ensure clicking on a label text content for a form field is not failing a11y_checks. r=Jamie
Some tests are reporting failing a11y_checks while the click is sent to a text leaf within a label of a radio button with an appropriate markup, for example when `span` is clicked in [this case](https://searchfox.org/mozilla-central/rev/9cd4ea81e27db6b767f1d9bbbcf47da238dd64fa/toolkit/components/aboutconfig/test/browser/browser_edit.js#418-424):
```
<label>
    <input type="radio" name="type" value="Boolean">
    <span data-l10n-id="about-config-pref-add-type-boolean">
        Boolean
    </span>
</label>
```

We need to add a check in the `findInteractiveAccessible()` method to allow for a label accessible to return its related form control to proceed with the a11y-checks suite, incl. the `assertLabeled` check too.

Test that is affected by this change: `toolkit/components/aboutconfig/test/browser/browser_edit.js`

Differential Revision: https://phabricator.services.mozilla.com/D205112
2024-03-25 15:25:37 +00:00
Greg Mierzwinski
c9f6950008 Bug 1878709 - Add, and update tp6-bench docs. r=kshampur,perftest-reviewers DONTBUILD
This patch adds some additional documentation about the tp6-bench test to the Raptor Browsertime docs. At the same time, the description given in the perfdocs config.yml file is updated to better reflect what the test currently does.

Differential Revision: https://phabricator.services.mozilla.com/D203821
2024-03-25 15:09:36 +00:00