Commit Graph

480 Commits

Author SHA1 Message Date
pbz
9684cdfd60 Bug 1661030 - Refactor SubDialog and TabDialogBox to support passing multiple window arguments. r=Gijs,preferences-reviewers
This also updates the behavior of the allowDuplicates check:
Instead of only checking if the top dialog is a duplicate, it will now check the whole stack and
skip the dialog open if a duplicate URL is found.
This fixes an issue where callers could alternate between dialogs to bypass the check.

Differential Revision: https://phabricator.services.mozilla.com/D88422
2020-09-02 14:24:47 +00:00
Dale Harvey
299368891b Bug 1658713 - Show internal aliases in about:preferences r=preferences-reviewers,harry,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D87922
2020-08-28 08:41:48 +00:00
Gijs Kruitbosch
701b6d99eb Bug 1651131 - fix automated test interaction with experimental feature gates to not get in the way of adding/removing experiments, r=jaws,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D87383
2020-08-18 17:16:57 +00:00
Adam Gashlin
53c0887b8f Bug 1639067 part 4 - Generalize internal handlers in the Applications list. r=Gijs,preferences-reviewers,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D86653
2020-08-17 21:24:47 +00:00
Dorel Luca
431b3e2a3a Backed out 4 changesets (bug 1639067) for XPCshell failures in tests/unit/test_getMIMEInfo_pdf.js. CLOSED TREE
Backed out changeset 1e400fafd80b (bug 1639067)
Backed out changeset 7bb3c2ec5c7a (bug 1639067)
Backed out changeset 755fd5771648 (bug 1639067)
Backed out changeset 951e10b7354f (bug 1639067)
2020-08-18 00:18:32 +03:00
Adam Gashlin
aa98afcafd Bug 1639067 part 4 - Generalize internal handlers in the Applications list. r=Gijs,preferences-reviewers,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D86653
2020-08-17 20:13:27 +00:00
pbz
29efc4cbbb Bug 1650795 - Implemented TabDialogBox to show chrome dialogs embedded on tab level. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83631
2020-08-17 10:26:22 +00:00
Bogdan Tara
2d98b068bc Backed out 7 changesets (bug 1650795, bug 1651958) for test_master_password.html failures CLOSED TREE
Backed out changeset 4812945bfaf2 (bug 1651958)
Backed out changeset a3f28fadcdf3 (bug 1651958)
Backed out changeset 70a61c971427 (bug 1651958)
Backed out changeset e7194e7e7ecc (bug 1651958)
Backed out changeset 7e66e5431ef7 (bug 1651958)
Backed out changeset a6c58935e1d8 (bug 1650795)
Backed out changeset b79f254df4cb (bug 1650795)
2020-08-14 23:29:33 +03:00
pbz
c15f35c088 Bug 1650795 - Implemented TabDialogBox to show chrome dialogs embedded on tab level. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83631
2020-08-14 11:31:04 +00:00
Csoregi Natalia
ba5782273e Backed out 7 changesets (bug 1650795, bug 1651958) for failures on test_modal_prompts.html . CLOSED TREE
Backed out changeset 505f46d2cd97 (bug 1651958)
Backed out changeset f7893f4dc092 (bug 1651958)
Backed out changeset 54ea7a160e0d (bug 1651958)
Backed out changeset c2bc9c8d2e97 (bug 1651958)
Backed out changeset 247880941893 (bug 1651958)
Backed out changeset c8945eb14177 (bug 1650795)
Backed out changeset fc4dcfaf3938 (bug 1650795)
2020-08-14 00:02:08 +03:00
pbz
45a4997b5b Bug 1650795 - Implemented TabDialogBox to show chrome dialogs embedded on tab level. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83631
2020-08-13 18:43:49 +00:00
Tim Giles
50342e1a5d Bug 1620753 - Indicate to the user when privacy.services.passwordSavingEnabled has set a new value via an extension. r=mstriemer,fluent-reviewers,preferences-reviewers,flod,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D85629
2020-08-12 18:06:30 +00:00
Jared Wein
bb5c52efa7 Bug 1582740 - Default the 'Always check' checkbox to disabled until we load the default browser state to prevent accidental user changes. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D62479
2020-08-07 22:19:06 +00:00
Jared Wein
8fc0a49fc9 Bug 1649250 - Display the experimental features in sorted alphabetical ordering. r=mstriemer,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D81649
2020-08-04 20:17:06 +00:00
Sebastian Streich
6cb146ba8c Bug 1633710 - Move uri.spec calls to nsIPrincipal r=necko-reviewers,geckoview-reviewers,preferences-reviewers,ckerschb,ntim,snorp,valentin
Differential Revision: https://phabricator.services.mozilla.com/D82911
2020-08-04 11:10:41 +00:00
Noemi Erli
b84c1e22d7 Backed out changeset 4ed7b13fb7a5 (bug 1633710) for causing failures in browser_amosigned_url.js CLOSED TREE 2020-07-29 22:34:42 +03:00
Sebastian Streich
11a5d7dd9f Bug 1633710 - Move uri.spec calls to nsIPrincipal r=necko-reviewers,geckoview-reviewers,preferences-reviewers,ckerschb,ntim,snorp,valentin
Differential Revision: https://phabricator.services.mozilla.com/D82911
2020-07-29 17:33:10 +00:00
Joel Maher
b5ff176f81 Bug 1654553 - fix browser chrome tests to support Object.is instead of ==. r=gbrown,preferences-reviewers,Gijs,rpl
fix browser chrome tests to support Object.is instead of ==

Differential Revision: https://phabricator.services.mozilla.com/D84539
2020-07-27 17:02:35 +00:00
Mark Banner
4488cd8d7d Bug 1654246 - When cloning search engines for preferences, clone the hidden property as well to ensure restore default engines works correctly. r=daleharvey,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D84520
2020-07-23 12:04:04 +00:00
Paul Bone
9e9cd5d1ba Bug 1626507 - pt 5. Remove duplicate call to openPreferences r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83872
2020-07-17 09:37:43 +00:00
Paul Bone
e893f4d432 Bug 1626507 - pt 4. Fix openPreferencesViaOpenPreferencesAPI r=preferences-reviewers,jaws
Due to changes in about:newtab somehow the preferences code is getting
initialised before the call to openPreferencesViaOpenPreferencesAPI().
Update this code to work when preferences is already initialised.

Differential Revision: https://phabricator.services.mozilla.com/D81067
2020-07-16 08:27:24 +00:00
Paul Bone
7599c1ddfd Bug 1626507 - pt 3. Rename a test to make it distinct from other tests r=preferences-reviewers,jaws
Two tests in this file had the same name, give this one a more specific name
so that console output is easier to follow.

Differential Revision: https://phabricator.services.mozilla.com/D81066
2020-07-16 05:30:46 +00:00
Sebastian Streich
9a30e9e484 Bug 1633710 - Move js uri.host to principal r=ckerschb,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D73242
2020-07-13 18:35:01 +00:00
Christoph Kerschbaumer
889819491b Bug 1651976: Update test browser_bug731866.js and browser_bug795764_cachedisabled.js to work correctly based on whether HTTPS-Only Mode preference if flipped to true of false. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83106
2020-07-10 23:08:54 +00:00
Kris Maglione
9bddbcfdd1 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Nihanth Subramanya
f863745241 Bug 1603779 - Part 5: Make browser_connection_dnsoverhttps.js properly reset DoHController state between tests. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D82127
2020-07-10 15:15:53 +00:00
pbz
6de58ad5a1 Bug 1650794 - Refactor subdialogs.js to reusable SubDialog.jsm. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D82405
2020-07-10 00:01:50 +00:00
Gijs Kruitbosch
10f16df091 Bug 1650931 - don't use hidden attribute to hide the containers category item, so switching to it works correctly, r=preferences-reviewers,mstriemer
In bug 1648222, the `gotoPref` helper that switches between different
preference panes was altered to disallow switching to hidden categories, so
that if there were no experimental pref entries, we don't show the
'Firefox experiments' category in the prefs.

Unfortunately, the containers category is always hidden, and only accessible
from the 'settings' button for containers and the URL (ie
`about:preferences#containers`), but the added requirement for categories to
not have the `hidden` attribute broke showing this category.

This patch fixes this by hiding the category using CSS instead. It also
cleans up some other use of the hidden attribute.

Note that the sync category is also hidden by default, but shown at
https://searchfox.org/mozilla-central/rev/91d82d7cbf05a71954dfa49d0e43824c7c973e62/browser/components/preferences/preferences.js#97-103

Differential Revision: https://phabricator.services.mozilla.com/D82505
2020-07-07 16:02:29 +00:00
Mike Conley
59eab37e13 Bug 1650790 - Add the about:home startup cache to the about:preferences experiments section. r=Gijs,fluent-reviewers
The cache is still disabled by default, but it would be good to collect more bugs and feedback early.

Differential Revision: https://phabricator.services.mozilla.com/D82394
2020-07-07 15:53:21 +00:00
Razvan Maries
c96b27a6b3 Backed out changeset bf22c292ae5c (bug 1650790) for bc failures on browser_search_subdialogs_within_preferences_site_data. CLOSED TREE 2020-07-07 00:49:04 +03:00
Mike Conley
d109a92380 Bug 1650790 - Add the about:home startup cache to the about:preferences experiments section. r=Gijs,fluent-reviewers
The cache is still disabled by default, but it would be good to collect more bugs and feedback early.

Differential Revision: https://phabricator.services.mozilla.com/D82394
2020-07-06 19:25:50 +00:00
Dorel Luca
a924a67d2b Backed out changeset 255d9078dd17 (bug 1633710) for Browser-chrome failures in extensions/test/xpinstall/browser_datauri.js. CLOSED TREE 2020-07-06 18:38:13 +03:00
Sebastian Streich
e62e8bee75 Bug 1633710 - Move js uri.host to principal r=ckerschb,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D73242
2020-07-06 14:00:09 +00:00
Andrea Marchesini
d2a266fc94 Bug 1649802 - Expose cookie sameSite=lax-by-default as experimental feature, r=jaws,fluent-reviewers,mconca,preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D81878
2020-07-03 14:12:13 +00:00
Dorel Luca
40dd06e506 Backed out changeset 2c46bcd325bb (bug 1633710) for Browser-chrome failures in extensions/test/xpinstall/browser_datauri.js. CLOSED TREE 2020-07-01 18:12:19 +03:00
Sebastian Streich
76d294400f Bug 1633710 - Move js uri.host to principal r=ckerschb,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D73242
2020-07-01 12:21:22 +00:00
Jared Wein
c4b54130dd Bug 1648222 - Hide the experimental features category if there are no available experimental features. r=mstriemer,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D80949
2020-06-30 19:49:46 +00:00
Jared Wein
7724320ad1 Bug 1646423 - Experimental features should only be displayed on release channels that they are intended for. r=mstriemer,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D80714
2020-06-26 06:03:06 +00:00
Dorel Luca
ca7e5f102d Backed out 4 changesets (bug 1646423, bug 1644544, bug 1646178, bug 1648223) for browser-chrome failures in browser/components/preferences/tests/browser_basic_rebuild_fonts_test.js
Backed out changeset 48790fe7990a (bug 1648223)
Backed out changeset 2d52e80dd321 (bug 1646178)
Backed out changeset 5186e66006a4 (bug 1646423)
Backed out changeset 28d0dc323af8 (bug 1644544)
2020-06-26 08:59:45 +03:00
Jared Wein
a0e218a472 Bug 1646423 - Experimental features should only be displayed on release channels that they are intended for. r=mstriemer,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D80714
2020-06-26 03:45:05 +00:00
Alexander J. Vincent
487fbace3a Bug 1646119, UpdateManager: rename _updates getter to _getUpdates(). r=bytesized,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D80143
2020-06-23 20:43:24 +00:00
Jared Wein
7e83b60e86 Bug 1644534 - Add localization capabilities to FeatureGates. r=mstriemer,fluent-reviewers
Title and Description fields in Features.toml now specify the Fluent string ID that is defined in features.ftl

Differential Revision: https://phabricator.services.mozilla.com/D79027
2020-06-22 20:53:56 +00:00
Nihanth Subramanya
c92094712e Bug 1644444 - Update NextDNS endpoint URL and migrate pref values. r=valentin,prathiksha
Differential Revision: https://phabricator.services.mozilla.com/D79627
2020-06-18 08:18:58 +00:00
Jared Wein
e9110f0467 Bug 1644537 - Use FeatureGates for templating the Experimental Features section. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D79025
2020-06-17 03:39:48 +00:00
Nihanth Subramanya
92ea0ac2ae Bug 1642078 - Include heuristics state when determining if DoH is enabled in about:preferences. r=johannh,valentin
Depends on D77579

Differential Revision: https://phabricator.services.mozilla.com/D78583
2020-06-12 00:03:28 +00:00
Razvan Maries
7131e102ae Backed out 2 changesets (bug 1642078) for perma failures on browser_policyOverride.js. CLOSED TREE
Backed out changeset c50c36be8110 (bug 1642078)
Backed out changeset da0da861012e (bug 1642078)
2020-06-12 02:37:05 +03:00
Nihanth Subramanya
a242578b7e Bug 1642078 - Include heuristics state when determining if DoH is enabled in about:preferences. r=johannh,valentin
Depends on D77579

Differential Revision: https://phabricator.services.mozilla.com/D78583
2020-06-11 19:42:51 +00:00
Liang-Heng Chen
c54d4df463 Bug 1641063 - ensure pref is restored after test; r=ewright
Differential Revision: https://phabricator.services.mozilla.com/D78024
2020-06-03 13:24:49 +00:00
Andrea Marchesini
aed7c3bd35 Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-02 13:49:27 +00:00
Csoregi Natalia
80d9cd436c Backed out 7 changesets (bug 1640405, bug 1638358) for failures on browser_webconsole_network_messages_status_code.js. CLOSED TREE
Backed out changeset ef5f7479ddf8 (bug 1640405)
Backed out changeset 286e0c83eb30 (bug 1638358)
Backed out changeset 89e396b2896e (bug 1638358)
Backed out changeset 33ad5fa05209 (bug 1638358)
Backed out changeset d213264c1379 (bug 1638358)
Backed out changeset 6bc05236afb4 (bug 1638358)
Backed out changeset 87e9d0ed3982 (bug 1638358)
2020-06-02 15:16:42 +03:00