Commit Graph

480 Commits

Author SHA1 Message Date
Barret Rennie
de446f2658 Bug 1677000 - Rename IOUtils.writeAtomic{,UTF8} to IOUtils.write{,UTF8} r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D99001
2020-12-09 05:48:46 +00:00
Razvan Maries
f4e9a01af4 Backed out 7 changesets (bug 1677000) for perma failures on test_ioutils_read_write.html. CLOSED TREE
Backed out changeset 3521334cfc38 (bug 1677000)
Backed out changeset 737f380c2cf2 (bug 1677000)
Backed out changeset 9dba15fdfe1f (bug 1677000)
Backed out changeset b2fa1a061b15 (bug 1677000)
Backed out changeset a5d7845d3c0c (bug 1677000)
Backed out changeset 8e6081b0c07d (bug 1677000)
Backed out changeset 6592577cf0fa (bug 1677000)
2020-12-09 07:34:21 +02:00
Barret Rennie
6ccd63bacf Bug 1677000 - Rename IOUtils.writeAtomic{,UTF8} to IOUtils.write{,UTF8} r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D99001
2020-12-09 04:31:40 +00:00
Christian Holler
d2b020d497 Bug 1677049 - Skip problematic mochitest-bc tests in TSan. r=Gankro,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D98365
2020-12-01 20:21:20 +00:00
Drew Willcoxon
dbb9361da2 Bug 1678770 - Have the local search shortcut rows in the preferences UI show their restriction characters as keywords. r=mak
Depends on D97376

Differential Revision: https://phabricator.services.mozilla.com/D97830
2020-11-21 10:55:28 +00:00
Drew Willcoxon
8868f343fc Bug 1657790 - Allow local search mode buttons to be toggled separately from engines. r=mak,ntim
* Add prefs for each local search shortcut
* Remove the `update2.localOneOffs` pref since it's not necessary with the three
  new prefs
* Modify preferences UI by adding a new row in the engines tree for each local
  shortcut
* Add `UrlbarUtils.LOCAL_SEARCH_MODES` so we have a single place where local
  search modes and their properties are defined
* Add a new test file for the preferences UI
* Modify browser_oneOffs.js to test the three new preferences

Differential Revision: https://phabricator.services.mozilla.com/D97376
2020-11-20 22:35:08 +00:00
Erica Wright
702fb9a86f Bug 1595858 - Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy,ahal
Differential Revision: https://phabricator.services.mozilla.com/D93584
2020-11-20 21:40:14 +00:00
Bogdan Tara
ff248efb24 sBacked out changeset 26f7d3a8b1b6 (bug 1595858) for overrides related mochitest failures CLOSED TREE 2020-11-18 01:42:59 +02:00
Erica Wright
e6b0316387 Bug 1595858 - Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D93584
2020-11-17 19:49:36 +00:00
Csoregi Natalia
62ee4a2c9f Backed out changeset ac3e7350aeed (bug 1673962) for failures on browser_experimental_features_restart_required_cancel.js. CLOSED TREE 2020-11-17 00:28:44 +02:00
Jared Wein
c4d1c18cde Bug 1673962 - Test to cover the code path of canceling the Restart Required prompt when enabling a restart-required=true experimental feature. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D95058
2020-11-16 19:19:35 +00:00
Noemi Erli
b1d3e523c4 Backed out changeset ac717cd03a6b (bug 1673962) for causing failures in browser_experimental_features_restart_required_cancel.js 2020-11-16 20:28:53 +02:00
Jared Wein
0a925d364e Bug 1673962 - Test to cover the code path of canceling the Restart Required prompt when enabling a restart-required=true experimental feature. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D95058
2020-11-16 16:05:51 +00:00
Nika Layzell
ed9e85fc9a Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.

This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.

Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-12 18:01:03 +00:00
Bogdan Tara
07d282afc6 Backed out changeset d86e4d6c2be4 (bug 1595858) for browser_ext_chrome_settings_overrides_home.js failures CLOSED TREE 2020-11-13 06:11:35 +02:00
Erica Wright
5855481ca4 Bug 1595858 - Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D93584
2020-11-13 02:02:47 +00:00
Michael Goossens
bc9df21bf8 Bug 1649603 - Replace OS.File imports on ExtensionSettingsStore.jsm r=robwu,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D96776
2020-11-12 22:07:04 +00:00
Nihanth Subramanya
e415d1b8c7 Bug 1637344 - Clean up browser_statePartitioning_strings.js. r=Gijs,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D96372
2020-11-12 11:19:59 +00:00
Nihanth Subramanya
cd88aa75ea Bug 1637344 - Show message in privacy preferences to indicate FPI is incompatible with dFPI. r=fluent-reviewers,johannh,preferences-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D96371
2020-11-12 11:18:23 +00:00
Neil Deakin
efdf2fd34a Bug 1646177, add button to reset all experimental features in preferences, r=Gijs,fluent-reviewers,preferences-reviewers,jaws
Differential Revision: https://phabricator.services.mozilla.com/D96182
2020-11-10 23:10:38 +00:00
Neil Deakin
40efc89f21 Bug 1667858, preference search filter should hide experiments that don't match the search terms, r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D95775
2020-11-10 16:36:23 +00:00
Nihanth Subramanya
b464f0aebf Bug 1672986 - Set the right cookie behavior before state partitioning MVP UI test. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D95526
2020-11-09 14:00:05 +00:00
Mihai Alexandru Michis
a75e7e7cb5 Bug 1674135 - Fix lint failure in siteData/head.js a=lint-fix
CLOSED TREE
2020-11-04 13:38:11 +02:00
Emilio Cobos Álvarez
719e59b40f Bug 1674135 - Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs,preferences-reviewers
Using `visibility` preserves frames of the content inside the dialog,
which we rely on to print the preview `<browser>` element.

This was working before bug 1662336 mostly by chance, because we were
doing an extra clone and that happened to mostly not rely on the cloned
document being rendered.

I'd rather fix it in the front-end (by not trying to print a
`display: none` <browser>) than going back to do a separate clone,
because that can get expensive (specially with fission).

It's not super-clear to me how to best test the "print from system
dialog" case, but ideas certainly welcome.

Differential Revision: https://phabricator.services.mozilla.com/D95501
2020-11-04 11:03:48 +00:00
Razvan Maries
beb7584870 Backed out 7 changesets (bug 1658084, bug 1671983) for perma failures on browser_async_remove_tab.js and browser_e10s_chrome_process.js. CLOSED TREE
Backed out changeset 2e6309c1cdbd (bug 1658084)
Backed out changeset 99aafd9304ef (bug 1671983)
Backed out changeset 80280b85280a (bug 1671983)
Backed out changeset 008db2659002 (bug 1671983)
Backed out changeset 32bd45c7fe3a (bug 1671983)
Backed out changeset 56e227e6580c (bug 1671983)
Backed out changeset a404f809f79d (bug 1671983)
2020-11-04 04:23:47 +02:00
Nika Layzell
f6849f1603 Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.

This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.

Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-04 00:55:36 +00:00
Razvan Maries
dde7490fbf Backed out changeset b5330b68ce05 (bug 1674135) for perma failures on browser_siteData2.js and browser_pdf_printer_settings.js. CLOSED TREE 2020-11-04 02:43:34 +02:00
Emilio Cobos Álvarez
e473e3b272 Bug 1674135 - Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs,preferences-reviewers
Using `visibility` preserves frames of the content inside the dialog,
which we rely on to print the preview `<browser>` element.

This was working before bug 1662336 mostly by chance, because we were
doing an extra clone and that happened to mostly not rely on the cloned
document being rendered.

I'd rather fix it in the front-end (by not trying to print a
`display: none` <browser>) than going back to do a separate clone,
because that can get expensive (specially with fission).

It's not super-clear to me how to best test the "print from system
dialog" case, but ideas certainly welcome.

Differential Revision: https://phabricator.services.mozilla.com/D95501
2020-11-03 23:36:32 +00:00
Dorel Luca
a273b913d8 Backed out changeset 3cc7771c487c (bug 1674135) for Browser-chrome failures in preferences/tests/siteData/browser_siteData.js. CLOSED TREE 2020-11-03 19:37:30 +02:00
Emilio Cobos Álvarez
67981a28a6 Bug 1674135 - Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs,preferences-reviewers
Using `visibility` preserves frames of the content inside the dialog,
which we rely on to print the preview `<browser>` element.

This was working before bug 1662336 mostly by chance, because we were
doing an extra clone and that happened to mostly not rely on the cloned
document being rendered.

I'd rather fix it in the front-end (by not trying to print a
`display: none` <browser>) than going back to do a separate clone,
because that can get expensive (specially with fission).

It's not super-clear to me how to best test the "print from system
dialog" case, but ideas certainly welcome.

Differential Revision: https://phabricator.services.mozilla.com/D95501
2020-11-03 16:35:34 +00:00
Bogdan Tara
dcfbcc52f7 Backed out changeset 57fcc7dd2219 (bug 1674135) for browser/components/preferences/ mochitest failures CLOSED TREE 2020-11-02 23:12:35 +02:00
Emilio Cobos Álvarez
51cd1c622d Bug 1674135 - Update test expectations since we changed the overlay inline style.
MANUAL PUSH: orange in a CLOSED TREE
2020-11-02 21:35:02 +01:00
Mark Banner
15c660fd7c Bug 1625963 - Remove the warning for the default search engine being 'controlled' by an extension as it isn't useful for users. r=jaws,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D94863
2020-10-29 03:18:32 +00:00
Nihanth Subramanya
477a5cbd58 Bug 1645924 - Test whether we use the right strings if the MVP UI is enabled or not. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D94406
2020-10-22 13:01:50 +00:00
julianwels
0c80a84d5b Bug 1671122 - Fixed bug where second click on HTTPS-Only Mode enable-checkbox disables it again. r=ckerschb,preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D93519
2020-10-15 19:54:31 +00:00
alwu
8ea5bd039b Bug 1667454 - part2 : add telemetry probe to record the number of times a user changes media control setting. r=preferences-reviewers,mossop,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D92872
2020-10-15 05:11:40 +00:00
alwu
7803553ce1 Bug 1667454 - part1 : add a toggle button in preference page for media control. r=preferences-reviewers,fluent-reviewers,Gijs
Add a toggle button to allow user enable/disable media control feature, and here is the UX doc [1].

[1] https://docs.google.com/document/d/1Faayu4_PnIxTDScIiOI3tu20_A5av3kryCRy26J2WyQ/edit

Differential Revision: https://phabricator.services.mozilla.com/D91871
2020-10-14 20:04:41 +00:00
Razvan Maries
1143731a3c Backed out 4 changesets (bug 1667454, bug 1668139) for perma failures on browser_media_control.js. CLOSED TREE
Backed out changeset 302032fe6d64 (bug 1668139)
Backed out changeset 859ee72e9e57 (bug 1668139)
Backed out changeset fe7de882fcbf (bug 1667454)
Backed out changeset dfd0308f5ab7 (bug 1667454)
2020-10-14 22:59:00 +03:00
alwu
aae2d6a936 Bug 1667454 - part2 : add telemetry probe to record the number of times a user changes media control setting. r=preferences-reviewers,mossop,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D92872
2020-10-14 15:27:46 +00:00
alwu
31e22f61d3 Bug 1667454 - part1 : add a toggle button in preference page for media control. r=preferences-reviewers,fluent-reviewers,Gijs
Add a toggle button to allow user enable/disable media control feature, and here is the UX doc [1].

[1] https://docs.google.com/document/d/1Faayu4_PnIxTDScIiOI3tu20_A5av3kryCRy26J2WyQ/edit

Differential Revision: https://phabricator.services.mozilla.com/D91871
2020-10-12 13:34:36 +00:00
pbz
88bc39f3be Bug 1667781 - Refactored siteDataSettings dialog to use dialog element. r=Gijs,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D92267
2020-10-07 18:42:49 +00:00
pbz
ac98c07787 Bug 1667781 - Refactored permission preferences dialog to use dialog element. r=Gijs,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D92263
2020-10-07 18:41:35 +00:00
pbz
39968c39c4 Bug 1667781 - Refactored container preferences dialog to use dialog element. r=Gijs,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D92262
2020-10-07 18:39:20 +00:00
pbz
5d73532885 Bug 1667781 - Refactored ClearSiteData dialog to use dialog element. r=Gijs,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D92261
2020-10-07 18:37:57 +00:00
Nihanth Subramanya
57e1b450bd Bug 1662430 - Allow a pref to toggle whether to clear doh-rollout.mode at shutdown. r=valentin,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D90856
2020-09-24 18:06:37 +00:00
Razvan Maries
c141744ed8 Backed out changeset bb81093f7e32 (bug 1662430) for perma failures on browser_rollback.js, browser_connection_dnsoverhttps.js and browser_policyOverride.js. CLOSED TREE 2020-09-24 20:57:28 +03:00
Nihanth Subramanya
e77ebbcea4 Bug 1662430 - Allow a pref to toggle whether to clear doh-rollout.mode at shutdown. r=valentin,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D90856
2020-09-24 12:09:52 +00:00
Dorel Luca
f6e46379cc Backed out changeset fccbbed6fc57 (bug 1662430) for Browser-chrome failures in preferences/tests/browser_connection_dnsoverhttps.js. CLOSED TREE 2020-09-24 15:04:39 +03:00
Nihanth Subramanya
2e9c8604a0 Bug 1662430 - Allow a pref to toggle whether to clear doh-rollout.mode at shutdown. r=valentin,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D90856
2020-09-24 09:10:11 +00:00
Joel Maher
daf650ac83 Bug 1664497 - Adjust test expectations for OSX with no EDID dongle. r=bc,preferences-reviewers,marionette-reviewers,whimboo,Gijs
Adjust test expectations for OSX with no EDID dongle.

Differential Revision: https://phabricator.services.mozilla.com/D89934
2020-09-12 10:12:58 +00:00