In bug 1947061, we introduced a pref to change the behavior of commitStyles to be endpoint-inclusive.
Although we introduced use counters to determine whether the change is Web-compatible in bug 1958528 and the counters will work even if the pref is disabled, we additionally make the pref enabled by default in nightly to get users to actually use it and check if any problems occur.
Differential Revision: https://phabricator.services.mozilla.com/D246393
Records counts of user interactions with tab groups:
- expand a collapsed tab group
- collapse an expanded tab group
- rename a tab group
- change a tab group's color
- save and close a tab group
- delete a tab group
- reopen a deleted tab group
- ungroup a tab group
- move a tab group to a new window
- reopen a saved and closed tab group from the list all tabs menu
- reopen a saved and closed tab group from a URL bar suggestion
- reopen a recently closed tab group from the recently closed tabs menu
Differential Revision: https://phabricator.services.mozilla.com/D246123
Current behavior on Windows: if you close a window that has open tab groups, the tab groups are automatically saved. Opening Firefox into the initial deferred restore state properly shows the tab groups as saved. However, after restoring the previous session manually, the tab groups exist both in the tab strip (correct) and in the list of saved tab groups (incorrect).
Bug 1950611 and bug 1954488 dealt with several edge cases around saved groups + session restore. In Windows, it looks like on session startup, `_prepDataForDeferredRestore` receives a state where the open tab groups from last session are stored in both `savedGroups` and `windows[].groups[]`. `_prepDataForDeferredRestore` has logic to convert the open tab groups in `windows[].groups[]` into saved groups, but it'll skip any that are already present in the list of saved groups. This was fine until the fix for bug 1954488, which unsets `removeAfterRestore` from the saved group; the `windows[].groups[]` groups get the `removeAfterRestore` flag set, but that does not get put into `savedGroups` because the group already exists in `savedGroups`.
I amended the logic so that when a group is in `windows[].groups[]` and `savedGroups`, the tab group state from `savedGroups` will get `removeAfterRestore` set back to true.
Not totally sure why I could reproduce this on Windows but not on macOS. It looks like the saved groups in `defaultState.savedGroups` still have `removeAfterRestore: true` set even after the `delete group.removeAfterRestore`. I don't understand how that would happen.
Differential Revision: https://phabricator.services.mozilla.com/D246377
Note, this wasn't a perfectly clean backout because I am not backing out Bug 1938657, but I am very confident in it because the necessary merge was simply to remove the added lines from `shared_metrics.yaml` instead of `metrics.yaml`.
Differential Revision: https://phabricator.services.mozilla.com/D246295
`_run_read_only` will add `--ignore-working-copy` to the passed
in `jj` command, then call `_run` with the altered command. This
will prevent the called command from acquiring a lock on the
`working-copy` directory.
`jj` commands that don't need to alter the repo should use this
new `_run_read_only` function. Doing so should avoid potential
concurrency issues.
Differential Revision: https://phabricator.services.mozilla.com/D246490
Adding a new test file for special or edge cases which might not be on the main workflow
(e.g cases which require toggle of a pref which is off by default )
This patch specifically adds tests for large files with the `devtools.debugger.ui.editor-wrapping` enabled.
- Test how long it takes a large wrapped file to load and get displayed.
- Test how long it takes to add a breakpoint to the file
- Test how long it takes to scroll the file
Differential Revision: https://phabricator.services.mozilla.com/D200614
The patch updates the match rule of the contentScript of the Asana
Zendesk shim. The Zendesk page navigates between pages using History
API, so it won't trigger an actual loading. So, the existing shim won't
get injected.
We update the match rule to let the shim to be injected at the very
beginning when loading a Zendesk page to solve the issue.
Differential Revision: https://phabricator.services.mozilla.com/D246420
Living under `layout` at least for now, since it lacks a lot of functionalities
that, say, `mozilla::UniquePtr` has.
This is in preparation for optimizing `AnchorResolved<T>` in bug 1960032,
which will be addressing the perf regression in bug 1959134. See comment 3
for further context.
Differential Revision: https://phabricator.services.mozilla.com/D246229
This patch introduces a performance test targeting the history using semantic search functionality. The test is designed to benchmark the efficiency and responsiveness of the history semantic search operations under various conditions. Shorter vs Longer search queries and Concurrent vs Non-concurrent inference when vector DB load happens as deferred task in the background. This captures latency, of the ML engine, end to end inference and also the semantic search for shorter and longer queries.
In addition to that it captures how much time does it take for the vector DB update process to complete for the 10000 history entries.
Differential Revision: https://phabricator.services.mozilla.com/D245087
- Remove the 'browser.urlbar.disableExtendForTests' pref codepath.
- Fix the rect filters to reflect the extent of re-paints we expect when the urlbar opens and the
results repopulate
Differential Revision: https://phabricator.services.mozilla.com/D226414
Well, how did I even manage to mess it up this much. I should really write tests for all telemetries.
Basically it was just comparing wrong URLs.
Differential Revision: https://phabricator.services.mozilla.com/D246298
Causes the thread pool to abandon the thread at shutdown (instead
of joining it) so that it won't hold up shutdown if the connection to the
agent is still taking a long time (greater than 2 seconds) processing a
request. See nsThreadPool::ShutdownWithTimeout.
Differential Revision: https://phabricator.services.mozilla.com/D246357
Since the cancel dialog is only associated with one user action ID, and a
folder check now uses different user action IDs for each file, user-cancel
needs to cancel all of the associated user action IDs. (Other cancel
reasons will not want that behavior.)
This patch adds a set of these compound actions to the service. Each entry
is the complete set of user action IDs that constitute the compound action.
The set is held until the compound action issues a response.
Differential Revision: https://phabricator.services.mozilla.com/D246160
It appears that calling UnmarkGrayStrongObservers while inside an observer can
cause crashes. This will only happen for the forget skippable cleanup, so this
patch splits out a separate cleanup method, adds a new static variable to hold
a pointer to the marker static instance, and adds a new static method to call
the cleanup method on the static instance.
There are no other uses of cycle-collector-forget-skippable so I get rid of it.
Differential Revision: https://phabricator.services.mozilla.com/D246437
To utilize this debug mixin, add `@include debug-breakpoints` to any SCSS class. It will add a simple outline color to that element and change at each defined breakpoint.
Differential Revision: https://phabricator.services.mozilla.com/D246111
