There's a lot here. The main thing is that rather than invoking
`INNER_UNMAKE_PACKAGE`, we use the new `mach artifact install
--unfiltered-project-package` flag to do that work. In automation,
this gets configured using `MOZ_ARTIFACT_TASK` and is deterministic;
locally, this is far easier to work with.
This replacement allows us to clean up a bunch of Makefile goo, some
of which is done here. More clean up is surely possible; the
`mozharness` config files are a good place to look next.
The `MOZ_PKG_MAC_*` settings previously referred to the unpacked DMG
resources. There's no need for that complication; we can always take
them from the branding resources. (The relevant `mozconfig`
entries *look* to always have Nightly branding, but merge automation
ensures that the branding is correctly set for Beta and Release.)
Differential Revision: https://phabricator.services.mozilla.com/D249448
This reverts commit ec5fa1d4c0.
Revert "Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio"
This reverts commit baa5d72bbd.
Revert "Bug 1606785 - Format browser/themes and toolkit/themes CSS files with Prettier r=desktop-theme-reviewers,pip-reviewers,tabbrowser-reviewers,places-reviewers,dao,mconley"
This reverts commit 9604b0a8ae.
Revert "Bug 1606785 - Format browser/themes/preferences CSS files with Prettier r=settings-reviewers,desktop-theme-reviewers,dao,mconley"
This reverts commit 686c1cf85f.
Revert "Bug 1606785 - Format urlbar CSS files with Prettier r=urlbar-reviewers,desktop-theme-reviewers,dao"
This reverts commit a7a4f31251.
Revert "Bug 1606785 - Format webcompat CSS files with Prettier r=webcompat-reviewers,denschub"
This reverts commit 41bc4d5237.
Revert "Bug 1606785 - Format search CSS files with Prettier r=search-reviewers,jteow"
This reverts commit 7bb7f82374.
Revert "Bug 1606785 - Format dom CSS files with Prettier r=emilio"
This reverts commit c22e910235.
Revert "Bug 1606785 - Format android CSS files with Prettier r=geckoview-reviewers,hiro"
This reverts commit c08e43fc3d.
Revert "Bug 1606785 - Format layout CSS files with Prettier r=layout-reviewers,dholbert"
This reverts commit 4f2a32d1a4.
Revert "Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers"
This reverts commit c05f675ddf.
Revert "Bug 1606785 - Format recomp CSS files with Prettier r=reusable-components-reviewers,desktop-theme-reviewers,dao,mkennedy"
This reverts commit b10c7de8d0.
Revert "Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley"
This reverts commit d32c555e37.
Revert "Bug 1606785 - Format shopping CSS files with Prettier r=shopping-reviewers,desktop-theme-reviewers,dao,rking"
This reverts commit 965887a708.
Revert "Bug 1606785 - Format profiles CSS files with Prettier r=profiles-reviewers,desktop-theme-reviewers,dao,mossop"
This reverts commit 8338860f74.
Revert "Bug 1606785 - Format genai and ml CSS files with Prettier r=firefox-ai-ml-reviewers,Mardak"
This reverts commit d66681f553.
Revert "Bug 1606785 - Format firefoxview CSS files with Prettier r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman"
This reverts commit 530b815cad.
Revert "Bug 1606785 - Format aboutlogins, megalist, and form autofill CSS files with Prettier r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao"
This reverts commit 813c864381.
There's a lot here. The main thing is that rather than invoking
`INNER_UNMAKE_PACKAGE`, we use the new `mach artifact install
--unfiltered-project-package` flag to do that work. In automation,
this gets configured using `MOZ_ARTIFACT_TASK` and is deterministic;
locally, this is far easier to work with.
This replacement allows us to clean up a bunch of Makefile goo, some
of which is done here. More clean up is surely possible; the
`mozharness` config files are a good place to look next.
The `MOZ_PKG_MAC_*` settings previously referred to the unpacked DMG
resources. There's no need for that complication; we can always take
them from the branding resources. (The relevant `mozconfig`
entries *look* to always have Nightly branding, but merge automation
ensures that the branding is correctly set for Beta and Release.)
Differential Revision: https://phabricator.services.mozilla.com/D249448
The rust compiler needs to use dlltool since the chrono upgrade because
of the use of raw-dylibs, and this requires the tool to be used from the
right location, which we already have out of configure.
Differential Revision: https://phabricator.services.mozilla.com/D247533
Back in the old days, shared libraries that linked against libxul/xpcom
were common (binary components), but those days are long gone. Even when
GeckoSharedLibrary was added, most uses were linkage=None. Nowadays, all
of them are, it's time to admit that this should be the default.
Differential Revision: https://phabricator.services.mozilla.com/D238899
Back in the old days, shared libraries that linked against libxul/xpcom
were common (binary components), but those days are long gone. Even when
GeckoSharedLibrary was added, most uses were linkage=None. Nowadays, all
of them are, it's time to admit that this should be the default.
Differential Revision: https://phabricator.services.mozilla.com/D238899
Introduce "--with-system-pipewire" option, allowing to build Firefox
against system PipeWire library and to find system PipeWire header
files.
Differential Revision: https://phabricator.services.mozilla.com/D242100
Introduce "--with-system-libdrm" option, allowing to build Firefox with
system drm library and to find system drm header files. Also unify all
drm includes to match both system and bundled paths.
Differential Revision: https://phabricator.services.mozilla.com/D242099
Introduce "--with-system-gbm" option, allowing to build Firefox against
system gbm library and to find system gbm header files. Also unify all
gbm includes to match both system and bundled paths.
Differential Revision: https://phabricator.services.mozilla.com/D242098
We could have gone with putting this under the macro but I wanted custom marker
messages for each call so decided to simply add a marker to each call site.
Differential Revision: https://phabricator.services.mozilla.com/D239786
Replace `mips_shared` with `mips64` and simplify `DEFINED_ON` to use
`PER_SHARED_ARCH` or `PER_ARCH` when possible. (This requires to add wasm32
stubs in some cases.)
Differential Revision: https://phabricator.services.mozilla.com/D238083
The change to "config/check_macroassembler_style.py" will be reverted in part 5.
It's only needed temporarily to ensure the python script doesn't report errors
while the mips32 source files are still present.
Differential Revision: https://phabricator.services.mozilla.com/D238081
This depends on bug 1945694 for all the relevant flags to make it to the
compiler, but works even before that lands, which is fortunate because
landing bug 1945694 fail without this change.
Differential Revision: https://phabricator.services.mozilla.com/D236966
Don't allow to directly include any of:
- `<windows.h>`
- `<winbase.h>`
- `<windef.h>`
Instead require to use "util/WindowsWrapper.h" which takes care to `#undef` common
function names.
`<windows.h>` includes both `<winbase.h>` and `<windef.h>` and is also the
preferred way to include Windows headers, so it's okay to always use
"util/WindowsWrapper.h".
Bug 1945305 happened because Beta builds bundle "vm/ToSource.cpp" and "vm/Time.cpp"
in the same unified cpp-file. "vm/ToSource.cpp" has a transitive dependency to
"jit/AtomicOp.h", which defines the class `jit::MemoryBarrier`. And "vm/Time.cpp"
includes `<winbase.h>` and `<windef.h>`, which define a macro named `MemoryBarrier`.
Differential Revision: https://phabricator.services.mozilla.com/D236460
