Bug 1949346 - Default Gecko shared libraries to no linkage. r=firefox-build-system-reviewers,sergesanspaille

Back in the old days, shared libraries that linked against libxul/xpcom
were common (binary components), but those days are long gone. Even when
GeckoSharedLibrary was added, most uses were linkage=None. Nowadays, all
of them are, it's time to admit that this should be the default.

Differential Revision: https://phabricator.services.mozilla.com/D238899

accessible/interfaces/msaa/moz.build

@@ -4,7 +4,7 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-GeckoSharedLibrary("AccessibleMarshal", linkage=None)
+GeckoSharedLibrary("AccessibleMarshal")
 
 # Missing here, is the notion that changes to the idl files included by
 # ISimpleDOM.idl (e.g. ISimpleDOMNode.idl) should rebuild the outputs.

build/gecko_templates.mozbuild

@@ -109,6 +109,7 @@ def GeckoSharedLibrary(name, output_category=None, **kwargs):
     SharedLibrary(name, output_category)
 
     kwargs.setdefault("mozglue", "library")
+    kwargs.setdefault("linkage", None)
 
     GeckoBinary(**kwargs)
 
@@ -123,5 +124,6 @@ def GeckoFramework(name, output_category=None, **kwargs):
     Framework(name, output_category)
 
     kwargs.setdefault("mozglue", "library")
+    kwargs.setdefault("linkage", None)
 
     GeckoBinary(**kwargs)

config/external/gkcodecs/moz.build

@@ -11,7 +11,7 @@
 # both from libxul (when decoding using the codec integration layer Gecko
 # provides) and from ffmpeg (when decoding and encoding through ffmpeg).
 
-GeckoSharedLibrary("gkcodecs", linkage=None)
+GeckoSharedLibrary("gkcodecs")
 SHARED_LIBRARY_NAME = "gkcodecs"
 SYMBOLS_FILE = "gkcodecs.symbols"
 if CONFIG["MOZ_SYSTEM_LIBVPX"]:

config/external/lgpllibs/moz.build

@@ -10,7 +10,7 @@
 #
 # Any library added here should also be reflected in the about:license page.
 
-GeckoSharedLibrary("lgpllibs", linkage=None)
+GeckoSharedLibrary("lgpllibs")
 SHARED_LIBRARY_NAME = "lgpllibs"
 
 # For some reason, mingw builds export way too many symbols.

gfx/angle/targets/libEGL/moz.build

@@ -206,4 +206,4 @@ OS_LIBS += [
 
 DEFFILE = "../../checkout/src/libEGL/libEGL_autogen.def"
 RCFILE = "../../checkout/src/libEGL/libEGL.rc"
-GeckoSharedLibrary("libEGL", linkage=None)
+GeckoSharedLibrary("libEGL")

gfx/angle/targets/libGLESv2/moz.build

@@ -425,4 +425,4 @@ OS_LIBS += [
 
 DEFFILE = "../../checkout/src/libGLESv2/libGLESv2_autogen.def"
 RCFILE = "../../checkout/src/libGLESv2/libGLESv2.rc"
-GeckoSharedLibrary("libGLESv2", linkage=None)
+GeckoSharedLibrary("libGLESv2")

gfx/angle/update-angle.py

@@ -522,7 +522,7 @@ def export_target(target_full_name) -> Set[str]:
 
     lib_type = desc["type"]
     if lib_type == "shared_library":
-        lines.append(f'GeckoSharedLibrary("{name}", linkage=None)')
+        lines.append(f'GeckoSharedLibrary("{name}")')
     elif lib_type == "static_library":
         lines.append(f'Library("{name}")')
     else:

js/src/build/moz.build

@@ -26,7 +26,7 @@ LIBRARY_DEFINES["MOZ_SUPPORT_LEAKCHECKING"] = True
 # JS shell would like to link to the static library.
 
 if CONFIG["JS_SHARED_LIBRARY"]:
-    GeckoSharedLibrary("js", linkage=None)
+    GeckoSharedLibrary("js")
     SHARED_LIBRARY_NAME = CONFIG["JS_LIBRARY_NAME"]
 
     # Ensure symbol versions of shared library on Linux do not conflict

media/gmp-clearkey/0.1/moz.build

@@ -7,7 +7,7 @@
 with Files("**"):
     BUG_COMPONENT = ("Core", "Audio/Video: GMP")
 
-GeckoSharedLibrary("clearkey", linkage=None)
+GeckoSharedLibrary("clearkey")
 
 FINAL_TARGET = "dist/bin/gmp-clearkey/0.1"
 

media/wmf-clearkey/moz.build

@@ -40,4 +40,4 @@ if CONFIG["CC_TYPE"] == "clang-cl":
         "-Wunused-result",
     ]
 
-GeckoSharedLibrary("wmfclearkey", linkage=None)
+GeckoSharedLibrary("wmfclearkey")

security/moz.build

@@ -26,7 +26,7 @@ if CONFIG["MOZ_SYSTEM_NSS"]:
 
 include("/build/gyp_base.mozbuild")
 if CONFIG["MOZ_FOLD_LIBS"]:
-    GeckoSharedLibrary("nss", linkage=None)
+    GeckoSharedLibrary("nss")
     # TODO: The library name can be changed when bug 845217 is fixed.
     SHARED_LIBRARY_NAME = "nss3"
 

toolkit/crashreporter/test/moz.build

@@ -51,7 +51,7 @@ else:
 if CONFIG["MOZ_PHC"]:
     DEFINES["MOZ_PHC"] = True
 
-GeckoSharedLibrary("testcrasher")
+GeckoSharedLibrary("testcrasher", linkage="dependent")
 
 DEFINES["SHARED_LIBRARY"] = "%s%s%s" % (
     CONFIG["DLL_PREFIX"],

toolkit/library/moz.build

@@ -19,10 +19,10 @@ def Libxul(name, output_category=None):
     if CONFIG["MOZ_WIDGET_TOOLKIT"] in ("cocoa", "uikit"):
         # This is going to be a framework named "XUL", not an ordinary library named
         # "libxul.dylib"
-        GeckoFramework(name, output_category=output_category, linkage=None)
+        GeckoFramework(name, output_category=output_category)
         SHARED_LIBRARY_NAME = "XUL"
     else:
-        GeckoSharedLibrary(name, output_category=output_category, linkage=None)
+        GeckoSharedLibrary(name, output_category=output_category)
         SHARED_LIBRARY_NAME = "xul"
 
     DELAYLOAD_DLLS += [