Bug 1019934 - don't access mRefCnt after CacheFileChunk::DispatchRelease() has been called, r=michal

2014-06-05 18:27:38 +02:00
parent eb1d05b716
commit fa06c07e10
1 changed files with 3 additions and 2 deletions
--- a/netwerk/cache2/CacheFileChunk.cpp
+++ b/netwerk/cache2/CacheFileChunk.cpp
@@ -63,13 +63,14 @@ NS_IMPL_ADDREF(CacheFileChunk)
 NS_IMETHODIMP_(MozExternalRefCountType)
 CacheFileChunk::Release()
 {
+  nsrefcnt count = mRefCnt - 1;
  if (DispatchRelease()) {
    // Redispatched to the main thread.
-    return mRefCnt - 1;
+    return count;
  }

  NS_PRECONDITION(0 != mRefCnt, "dup release");
-  nsrefcnt count = --mRefCnt;
+  count = --mRefCnt;
  NS_LOG_RELEASE(this, count, "CacheFileChunk");

  if (0 == count) {