corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1966206 - [remote] Update "browsingContext.setViewport" command to at least validate the input on Android. r=webdriver-reviewers,Sasha

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D249122
This commit is contained in:
Henrik Skupin
2025-05-14 16:03:30 +00:00
committed by hskupin@mozilla.com
parent d34d138d76
commit e5d15be83d
3 changed files with 7 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
remote/webdriver-bidi/modules/root/browsingContext.sys.mjs
View File

@@ -1429,13 +1429,6 @@ class BrowsingContextModule extends RootBiDiModule {
userContexts: userContextIds = null,
} = options;
if (lazy.AppInfo.isAndroid) {
// Bug 1840084: Add Android support for modifying the viewport.
throw new lazy.error.UnsupportedOperationError(
`Command not yet supported for ${lazy.AppInfo.name}`
);
}
const userContexts = new Set();
if (contextId !== null) {
@@ -1523,6 +1516,13 @@ class BrowsingContextModule extends RootBiDiModule {
navigables.add(navigable);
}
if (lazy.AppInfo.isAndroid) {
// Bug 1840084: Add Android support for modifying the viewport.
throw new lazy.error.UnsupportedOperationError(
`Command not yet supported for ${lazy.AppInfo.name}`
);
}
const viewportOverride = {
devicePixelRatio,
viewport,

2
testing/web-platform/meta/webdriver/tests/bidi/browsing_context/set_viewport/invalid.py.ini
View File

@@ -1,5 +1,3 @@
[invalid.py]
disabled:
if os == "android": bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1840084
expected:
if (os == "mac") and not debug: [OK, TIMEOUT]

3
testing/web-platform/mozilla/meta/webdriver/bidi/browsing_context/set_viewport/invalid.py.ini
View File

@@ -1,3 +0,0 @@
[invalid.py]
disabled:
if os == "android": bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1840084