Bug 1880914 - Move BrowserStop. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D206102

browser/base/content/browser-commands.js

@@ -196,6 +196,10 @@ var BrowserCommands = {
     }
   },
 
+  stop() {
+    gBrowser.webNavigation.stop(Ci.nsIWebNavigation.STOP_ALL);
+  },
+
   home(aEvent) {
     if (aEvent?.button == 2) {
       // right-click: do nothing

browser/base/content/browser-sets.inc

@@ -68,7 +68,7 @@
     <command id="Browser:ForwardOrForwardDuplicate" oncommand="BrowserCommands.forward(event);" disabled="true">
       <observes element="Browser:Forward" attribute="disabled"/>
     </command>
-    <command id="Browser:Stop"    oncommand="BrowserStop();" disabled="true"/>
+    <command id="Browser:Stop"    oncommand="BrowserCommands.stop();" disabled="true"/>
     <command id="Browser:Reload"  oncommand="if (event.shiftKey) BrowserCommands.reloadSkipCache(); else BrowserCommands.reload()" disabled="true"/>
     <command id="Browser:ReloadOrDuplicate" oncommand="BrowserCommands.reloadOrDuplicate(event)" disabled="true">
       <observes element="Browser:Reload" attribute="disabled"/>

browser/base/content/browser.js

@@ -2634,7 +2634,7 @@ function HandleAppCommandEvent(evt) {
       break;
     case "Stop":
       if (XULBrowserWindow.stopCommand.getAttribute("disabled") != "true") {
-        BrowserStop();
+        BrowserCommands.stop();
       }
       break;
     case "Search":
@@ -2677,10 +2677,6 @@ function HandleAppCommandEvent(evt) {
   evt.preventDefault();
 }
 
-function BrowserStop() {
-  gBrowser.webNavigation.stop(Ci.nsIWebNavigation.STOP_ALL);
-}
-
 function loadOneOrMoreURIs(aURIString, aTriggeringPrincipal, aCsp) {
   // we're not a browser window, pass the URI string to a new browser window
   if (window.location.href != AppConstants.BROWSER_CHROME_URL) {

browser/base/content/browser.js.globals

@@ -33,7 +33,6 @@
   "gBrowserInit",
   "HandleAppCommandEvent",
   "BrowserCommands",
-  "BrowserStop",
   "kSkipCacheFlags",
   "loadOneOrMoreURIs",
   "openLocation",

browser/components/urlbar/tests/browser/browser_copy_during_load.js

@@ -45,7 +45,7 @@ add_task(async function () {
       null,
       true
     );
-    BrowserStop();
+    BrowserCommands.stop();
     await browserStoppedPromise;
   });
 });

browser/components/urlbar/tests/browser/browser_stop_pending.js

@@ -125,7 +125,7 @@ add_task(async function () {
     null,
     true
   );
-  BrowserStop();
+  BrowserCommands.stop();
   await browserStoppedPromise;
 
   is(
@@ -207,7 +207,7 @@ add_task(async function () {
     null,
     true
   );
-  BrowserStop();
+  BrowserCommands.stop();
   await browserStoppedPromise;
 
   is(