corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1812819 - Update cookie banner preferences checkbox to toggle reject-only mode. r=settings-reviewers,mconley

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D168285
This commit is contained in:
Jared Hirsch
2023-01-30 18:51:58 +00:00
parent e6e7d790e7
commit e1c9146780
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
browser/components/preferences/privacy.js
View File

@@ -1993,7 +1993,7 @@ var gPrivacyPane = {
writeCookieBannerMode() {
let checkbox = document.getElementById("handleCookieBanners");
let mode = checkbox.checked
? Ci.nsICookieBannerService.MODE_REJECT_OR_ACCEPT
? Ci.nsICookieBannerService.MODE_REJECT
: Ci.nsICookieBannerService.MODE_DISABLED;
return mode;
},

8
browser/components/preferences/tests/browser_privacy_cookieBannerHandling.js
View File

@@ -77,7 +77,7 @@ add_task(async function test_checkbox_unchecked_detect_only_mode() {
await SpecialPowers.pushPrefEnv({
set: [
[FEATURE_PREF, true],
[MODE_PREF, Ci.nsICookieBannerService.MODE_REJECT_OR_ACCEPT],
[MODE_PREF, Ci.nsICookieBannerService.MODE_REJECT],
[DETECT_ONLY_PREF, true],
],
});
@@ -138,7 +138,7 @@ add_task(async function test_checkbox_modifies_mode_pref() {
await SpecialPowers.pushPrefEnv({
set: [
[FEATURE_PREF, true],
[MODE_PREF, Ci.nsICookieBannerService.MODE_REJECT_OR_ACCEPT],
[MODE_PREF, Ci.nsICookieBannerService.MODE_REJECT],
],
});
@@ -172,9 +172,9 @@ add_task(async function test_checkbox_modifies_mode_pref() {
);
Assert.ok(checkbox.checked, "checkbox should be checked");
Assert.equal(
Ci.nsICookieBannerService.MODE_REJECT_OR_ACCEPT,
Ci.nsICookieBannerService.MODE_REJECT,
Services.prefs.getIntPref(MODE_PREF),
"cookie banner handling mode should be set to REJECT_OR_ACCEPT mode after checking the checkbox"
"cookie banner handling mode should be set to REJECT mode after checking the checkbox"
);
}
);