corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1964426 - Always assign an interactionId to keydown events r=sefeng

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D247840
This commit is contained in:
Nazım Can Altınova
2025-05-06 18:45:01 +00:00
committed by canaltinova@gmail.com
parent 2abdbf6fd2
commit e1b7ee8a01
1 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
dom/performance/PerformanceInteractionMetrics.cpp
View File

@@ -90,16 +90,12 @@ Maybe<uint64_t> PerformanceInteractionMetrics::ComputeInteractionId(
auto code = keyEvent->mKeyCode;
auto entry = mPendingKeyDowns.MaybeGet(code);
if (entry) {
if (code != 229) {
uint64_t interactionId = IncreaseInteractionValueAndCount();
(*entry)->SetInteractionId(interactionId);
}
}
// This is not part of the spec yet, but it's being discussed and will be
// added to the spec soon.
// See: https://github.com/w3c/event-timing/issues/153
mPendingKeyDowns.InsertOrUpdate(code, aEventTiming);
return Nothing();
uint64_t interactionId = IncreaseInteractionValueAndCount();
return Some(interactionId);
}
// Step 8. If type is keyup:
@@ -120,12 +116,7 @@ Maybe<uint64_t> PerformanceInteractionMetrics::ComputeInteractionId(
return Some(0);
}
// Step 8.5. Increase interaction count on window.
// Step 8.6. Let interactionId be window’s user interaction value value.
uint64_t interactionId = IncreaseInteractionValueAndCount();
// Step 8.7. Set entry’s interactionId to interactionId.
(*entry)->SetInteractionId(interactionId);
uint64_t interactionId = (*entry)->InteractionId();
// Step 8.9. Remove pendingKeyDowns[code].
mPendingKeyDowns.Remove(code);