corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1846879: Stop creating multiple stack copies of this metadata object. r=mjf

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D185320
This commit is contained in:
Byron Campen
2023-08-04 12:17:22 +00:00
parent 372b985435
commit dad9b59160
1 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
dom/media/webrtc/jsapi/RTCEncodedVideoFrame.cpp
View File

@@ -48,29 +48,28 @@ RTCEncodedVideoFrame::RTCEncodedVideoFrame(
static_cast<webrtc::TransformableVideoFrameInterface&>(*mFrame));
mType = videoFrame.IsKeyFrame() ? RTCEncodedVideoFrameType::Key
: RTCEncodedVideoFrameType::Delta;
auto metadata = videoFrame.Metadata();
if (videoFrame.Metadata().GetFrameId().has_value()) {
mMetadata.mFrameId.Construct(*videoFrame.Metadata().GetFrameId());
if (metadata.GetFrameId().has_value()) {
mMetadata.mFrameId.Construct(*metadata.GetFrameId());
}
mMetadata.mDependencies.Construct();
for (const auto dep : videoFrame.Metadata().GetFrameDependencies()) {
for (const auto dep : metadata.GetFrameDependencies()) {
Unused << mMetadata.mDependencies.Value().AppendElement(
static_cast<unsigned long long>(dep), fallible);
}
mMetadata.mWidth.Construct(videoFrame.Metadata().GetWidth());
mMetadata.mHeight.Construct(videoFrame.Metadata().GetHeight());
if (videoFrame.Metadata().GetSpatialIndex() >= 0) {
mMetadata.mSpatialIndex.Construct(
videoFrame.Metadata().GetSpatialIndex());
mMetadata.mWidth.Construct(metadata.GetWidth());
mMetadata.mHeight.Construct(metadata.GetHeight());
if (metadata.GetSpatialIndex() >= 0) {
mMetadata.mSpatialIndex.Construct(metadata.GetSpatialIndex());
}
if (videoFrame.Metadata().GetTemporalIndex() >= 0) {
mMetadata.mTemporalIndex.Construct(
videoFrame.Metadata().GetTemporalIndex());
if (metadata.GetTemporalIndex() >= 0) {
mMetadata.mTemporalIndex.Construct(metadata.GetTemporalIndex());
}
mMetadata.mSynchronizationSource.Construct(videoFrame.GetSsrc());
mMetadata.mPayloadType.Construct(videoFrame.GetPayloadType());
mMetadata.mContributingSources.Construct();
for (const auto csrc : videoFrame.Metadata().GetCsrcs()) {
for (const auto csrc : metadata.GetCsrcs()) {
Unused << mMetadata.mContributingSources.Value().AppendElement(csrc,
fallible);
}