corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1272599 part.1 Rename KeyboardEvent.key value, "MozPhoneCall" to "Call" r=smaug

Browse Source 
Android's KEYCODE_CALL was temporarily named as "MozPhoneCall" since proper key name was not defined in the spec. However, now, it's defined as "Call" in the latest spec. Therefore, we should rename this key name.

Note that this isn't available on Android because the key event is never fired on applications. However, this key may be useful on B2G. Although, the key is not used by current Gaia.

MozReview-Commit-ID: GF4STYrGMig
This commit is contained in:
Masayuki Nakano
2016-05-20 21:00:20 +09:00
parent c45a7bf484
commit d3bb88d26d
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
dom/events/KeyNameList.h
View File

@@ -31,7 +31,6 @@ DEFINE_KEYNAME_WITH_SAME_NAME(Unidentified)
DEFINE_KEYNAME_INTERNAL(PrintableKey, "MozPrintableKey")
DEFINE_KEYNAME_INTERNAL(HomeScreen, "MozHomeScreen")
DEFINE_KEYNAME_INTERNAL(CameraFocusAdjust, "MozCameraFocusAdjust")
DEFINE_KEYNAME_INTERNAL(PhoneCall, "MozPhoneCall")
DEFINE_KEYNAME_INTERNAL(SoftLeft, "MozSoftLeft")
DEFINE_KEYNAME_INTERNAL(SoftRight, "MozSoftRight")

4
widget/NativeKeyToDOMKeyName.h
View File

@@ -1225,8 +1225,8 @@ KEY_MAP_QT (BrowserStop, Qt::Key_Stop)
/******************************************************************************
* Mobile Phone Keys
******************************************************************************/
// PhoneCall (should be renamed to Call)
KEY_MAP_ANDROID (PhoneCall, AKEYCODE_CALL)
// Call
KEY_MAP_ANDROID (Call, AKEYCODE_CALL)
// Camera
KEY_MAP_QT (Camera, Qt::Key_Camera)