corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1957537: use 'main' as ref for onchange l10n, to always have the latest strings r=eemeli

Browse Source 
When we migrated l10n to github in https://bugzilla.mozilla.org/show_bug.cgi?id=1900421 I switched these files away from referencing `default` (which would no longer be valid in the git world) to use a concrete ref "to avoid breaking repacks before l10n bumper runs". At this point it's unclear to me why I didn't use `main` instead, to continue taking the latest strings without the need to bump this file. I have a vague memory of thinking it was ideal to use concrete refs to make things work better on non-latest branch, but I don't think that holds water: we only have one branch in the strings repository, and as far as I know it's totally backwards compatible.

This patch switches the `onchange` files back to using a branch ref rather than a concrete rev. It would be possible to fix this issue by bumping the `onchange` files in addition to the regular ones, but unless we can find some actual benefit to doing so, using branch refs seems preferable.

Differential Revision: https://phabricator.services.mozilla.com/D243826
This commit is contained in:
Ben Hearsum
2025-04-01 17:35:46 +00:00
parent 19a47407cb
commit afa75715af
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
browser/locales/l10n-onchange-changesets.json
View File

@@ -16,7 +16,7 @@
"win64-aarch64-devedition",
"win64-devedition"
],
"revision": "ff6c9d55d4c1d558576bb6ca615179d8f9969f21"
"revision": "main"
},
"en-CA": {
"platforms": [
@@ -35,7 +35,7 @@
"win64-aarch64-devedition",
"win64-devedition"
],
"revision": "ff6c9d55d4c1d558576bb6ca615179d8f9969f21"
"revision": "main"
},
"he": {
"platforms": [
@@ -54,7 +54,7 @@
"win64-aarch64-devedition",
"win64-devedition"
],
"revision": "ff6c9d55d4c1d558576bb6ca615179d8f9969f21"
"revision": "main"
},
"it": {
"platforms": [
@@ -73,7 +73,7 @@
"win64-aarch64-devedition",
"win64-devedition"
],
"revision": "ff6c9d55d4c1d558576bb6ca615179d8f9969f21"
"revision": "main"
},
"ja": {
"platforms": [
@@ -90,13 +90,13 @@
"win64-aarch64-devedition",
"win64-devedition"
],
"revision": "ff6c9d55d4c1d558576bb6ca615179d8f9969f21"
"revision": "main"
},
"ja-JP-mac": {
"platforms": [
"macosx64",
"macosx64-devedition"
],
"revision": "ff6c9d55d4c1d558576bb6ca615179d8f9969f21"
"revision": "main"
}
}

8
mobile/locales/l10n-onchange-changesets.json
View File

@@ -5,7 +5,7 @@
"android-arm",
"android-multilocale"
],
"revision": "ff6c9d55d4c1d558576bb6ca615179d8f9969f21"
"revision": "main"
},
"he": {
"platforms": [
@@ -13,7 +13,7 @@
"android-arm",
"android-multilocale"
],
"revision": "ff6c9d55d4c1d558576bb6ca615179d8f9969f21"
"revision": "main"
},
"it": {
"platforms": [
@@ -21,7 +21,7 @@
"android-arm",
"android-multilocale"
],
"revision": "ff6c9d55d4c1d558576bb6ca615179d8f9969f21"
"revision": "main"
},
"ja": {
"platforms": [
@@ -29,6 +29,6 @@
"android-arm",
"android-multilocale"
],
"revision": "ff6c9d55d4c1d558576bb6ca615179d8f9969f21"
"revision": "main"
}
}