corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1918049 - [wpt] Fix several input events spin button and arrow key tests for broken setup and test driver usage. r=masayuki

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D221950
This commit is contained in:
Henrik Skupin
2024-09-13 10:28:00 +00:00
parent f9825575f6
commit a40830e899
9 changed files with 132 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
testing/web-platform/meta/input-events/input-events-arrow-key-on-number-input-delete-document.html.ini
View File

@@ -1,2 +0,0 @@
[input-events-arrow-key-on-number-input-delete-document.html]
expected: ERROR

1
testing/web-platform/meta/input-events/input-events-arrow-key-on-number-input-prevent-default.html.ini
View File

@@ -1,3 +1,4 @@
[input-events-arrow-key-on-number-input-prevent-default.html]
[Number input should not fire input and change event if the beforeinput event is default prevented]
bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1918254
expected: FAIL

5
testing/web-platform/meta/input-events/input-events-spin-button-click-on-number-input-delete-document.html.ini
View File

@@ -1,2 +1,5 @@
[input-events-spin-button-click-on-number-input-delete-document.html]
expected: ERROR
[Number input should not crash and not fire subsequent events when event handler removes document]
expected:
if (os == "android"): FAIL

1
testing/web-platform/meta/input-events/input-events-spin-button-click-on-number-input-prevent-default.html.ini
View File

@@ -1,3 +1,4 @@
[input-events-spin-button-click-on-number-input-prevent-default.html]
[Number input should not fire input and change event if the beforeinput event is default prevented]
bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1918254
expected: FAIL

4
testing/web-platform/meta/input-events/input-events-spin-button-click-on-number-input.html.ini
View File

@@ -1,3 +1,5 @@
[input-events-spin-button-click-on-number-input.html]
[Number input should fire beforeinput event before the input and change event]
expected: FAIL
expected:
if (os == "android"): FAIL

52
testing/web-platform/tests/input-events/input-events-arrow-key-on-number-input-delete-document.html
View File

@@ -9,29 +9,39 @@
<body>
<iframe id="iframe"></iframe>
<script>
promise_test(async function() {
const child = document.getElementById("iframe");
const childDocument = child.contentDocument;
const inputElement = childDocument.createElement('input');
inputElement.type = "number";
childDocument.body.appendChild(inputElement);
let events = [];
inputElement.addEventListener("beforeinput", () => {
child.remove();
events.push("beforeinput");
});
inputElement.addEventListener("input", () => {
evenst.push("input");
});
inputElement.addEventListener("change", () => {
events.push("change");
});
const frame = document.getElementById("iframe");
inputElement.focus();
function loadIframe(doc) {
return new Promise((resolve) => {
frame.addEventListener("load", resolve);
frame.srcdoc = doc;
});
}
await new test_driver.send_keys(inputElement, "\uE013");
assert_array_equals(events, ['beforeinput']);
}, "Number input should not crash and not fire subsequent events when event handler removes document");
promise_test(async function() {
await loadIframe("<input type='number'>");
const inputElement = frame.contentDocument.querySelector("input");
let events = [];
inputElement.addEventListener("beforeinput", () => {
events.push("beforeinput");
frame.remove();
});
inputElement.addEventListener("input", () => {
events.push("input");
});
inputElement.addEventListener("change", () => {
events.push("change");
});
inputElement.focus();
await test_driver.send_keys(inputElement, "\uE013");
assert_array_equals(events, ['beforeinput']);
assert_false(document.body.contains(frame));
}, "Number input should not crash and not fire subsequent events when event handler removes document");
</script>
</body>
</html>

70
testing/web-platform/tests/input-events/input-events-spin-button-click-on-number-input-delete-document.html
View File

@@ -4,37 +4,57 @@
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-actions.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
</head>
<body>
<iframe id="iframe"></iframe>
<script>
promise_test(async function() {
const child = document.getElementById("iframe");
const childDocument = child.contentDocument;
const inputElement = childDocument.createElement('input');
inputElement.type = "number";
childDocument.body.appendChild(inputElement);
let events = [];
inputElement.addEventListener("beforeinput", () => {
child.remove();
events.push("beforeinput");
});
inputElement.addEventListener("input", () => {
events.push("input");
});
inputElement.addEventListener("change", () => {
events.push("change");
});
const frame = document.getElementById("iframe");
inputElement.focus();
// Get the spin button up arrow key location and adjust with iframe offset to get absolute position
const x1 = (inputElement.offsetLeft + inputElement.offsetWidth - 10) + child.offsetLeft;
const y1 = (inputElement.offsetTop + inputElement.offsetHeight / 4) + child.offsetTop;
await test_driver_internal.click(inputElement,{x: x1, y: y1});
assert_array_equals(events, ['beforeinput']);
assert_false(document.body.contains(child));
}, "Number input should not crash and not fire subsequent events when event handler removes document");
function loadIframe(doc) {
return new Promise((resolve) => {
frame.addEventListener("load", resolve);
frame.srcdoc = doc;
});
}
promise_test(async function () {
await loadIframe(
"<input type='number' style='width: 100px; height: 20px'>"
);
const inputElement = frame.contentDocument.querySelector("input");
let events = [];
inputElement.addEventListener("beforeinput", () => {
frame.remove();
events.push("beforeinput");
});
inputElement.addEventListener("input", () => {
events.push("input");
});
inputElement.addEventListener("change", () => {
events.push("change");
});
// Roughly get the offset to the spin up arrow button's center point within
// the iframe's viewport. Note that this is fragile and might need specific
// coordinates for each browser and maybe platform.
const rect = inputElement.getBoundingClientRect();
const x = rect.x + rect.width - 10;
const y = rect.y + Math.round(rect.height / 4);
const actions = new test_driver.Actions()
.setContext(frame.contentWindow)
.pointerMove(x, y, { origin: "viewport" })
.pointerDown()
.pointerUp();
await actions.send();
assert_array_equals(events, ['beforeinput']);
assert_false(document.body.contains(frame));
}, "Number input should not crash and not fire subsequent events when event handler removes document");
</script>
</body>
</html>

51
testing/web-platform/tests/input-events/input-events-spin-button-click-on-number-input-prevent-default.html
View File

@@ -4,32 +4,43 @@
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-actions.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
</head>
<body>
<input type="number" id="number_input">
<script>
promise_test(async function() {
const inputElement = document.getElementById("number_input");
let events = [];
inputElement.addEventListener("beforeinput", (e) => {
e.preventDefault();
events.push("beforeinput");
});
inputElement.addEventListener("input", () => {
events.push("input");
});
inputElement.addEventListener("change", () => {
events.push("change");
});
promise_test(async function() {
const inputElement = document.getElementById("number_input");
inputElement.focus();
// Get the spin button up arrow key location
const x1 = (inputElement.offsetLeft + inputElement.offsetWidth - 10);
const y1 = (inputElement.offsetTop + inputElement.offsetHeight / 4);
await test_driver_internal.click(inputElement,{x: x1, y: y1});
assert_array_equals(events, ['beforeinput']);
}, "Number input should not fire input and change event if the beforeinput event is default prevented");
let events = [];
inputElement.addEventListener("beforeinput", (e) => {
e.preventDefault();
events.push("beforeinput");
});
inputElement.addEventListener("input", () => {
events.push("input");
});
inputElement.addEventListener("change", () => {
events.push("change");
});
// Roughly get the offset to the spin up arrow button's center point within
// the iframe's viewport. Note that this is fragile and might need specific
// coordinates for each browser and maybe platform.
const rect = inputElement.getBoundingClientRect();
const x = rect.x + rect.width - 10;
const y = rect.y + Math.round(rect.height / 4);
const actions = new test_driver.Actions()
.pointerMove(x, y, { origin: "viewport" })
.pointerDown()
.pointerUp();
await actions.send();
assert_array_equals(events, ['beforeinput']);
}, "Number input should not fire input and change event if the beforeinput event is default prevented");
</script>
</body>
</html>

21
testing/web-platform/tests/input-events/input-events-spin-button-click-on-number-input.html
View File

@@ -4,6 +4,7 @@
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-actions.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
</head>
<body>
@@ -11,7 +12,9 @@
<script>
promise_test(async function() {
const inputElement = document.getElementById("number_input");
let events = [];
inputElement.addEventListener("beforeinput", () => {
events.push("beforeinput");
});
@@ -22,11 +25,19 @@ promise_test(async function() {
events.push("change");
});
inputElement.focus();
// Get the spin button up arrow key location
const x1 = (inputElement.offsetLeft + inputElement.offsetWidth - 10);
const y1 = (inputElement.offsetTop + inputElement.offsetHeight / 4);
await test_driver_internal.click(inputElement,{x: x1, y: y1});
// Roughly get the offset to the spin up arrow button's center point within
// the iframe's viewport. Note that this is fragile and might need specific
// coordinates for each browser and maybe platform.
const rect = inputElement.getBoundingClientRect();
const x = rect.x + rect.width - 10;
const y = rect.y + Math.round(rect.height / 4);
const actions = new test_driver.Actions()
.pointerMove(x, y, { origin: "viewport" })
.pointerDown()
.pointerUp();
await actions.send();
assert_array_equals(events, ['beforeinput','input','change']);
}, "Number input should fire beforeinput event before the input and change event");
</script>