Bug 1117068 - Part c: Remove NEED_CPP_UNUSED_IMPLEMENTATIONS; r=mshal

It is only used in one place, and that place is better off with MOZ_DELETE.

configure.in

@@ -3291,20 +3291,6 @@ if test "$ac_cv_cpp_dynamic_cast_void_ptr" = yes ; then
    AC_DEFINE(HAVE_CPP_DYNAMIC_CAST_TO_VOID_PTR)
 fi
 
-dnl note that this one is reversed - if the test fails, then
-dnl we require implementations of unused virtual methods. Which
-dnl really blows because it means we'll have useless vtable
-dnl bloat.
-AC_CACHE_CHECK(whether C++ requires implementation of unused virtual methods,
-               ac_cv_cpp_unused_required,
-               [AC_TRY_LINK(class X {private: virtual void never_called();};,
-                               X x;,
-                               ac_cv_cpp_unused_required=no,
-                               ac_cv_cpp_unused_required=yes)])
-if test "$ac_cv_cpp_unused_required" = yes ; then
-   AC_DEFINE(NEED_CPP_UNUSED_IMPLEMENTATIONS)
-fi
-
 
 # try harder, when checking for __thread support, see bug 521750 comment #33 and below
 # We pass MOZ_OPTIMIZE_LDFLAGS to the linker because if dead_strip is
@@ -9024,7 +9010,6 @@ CPP_THROW_NEW
 HAVE_CPP_AMBIGUITY_RESOLVING_USING
 HAVE_CPP_DYNAMIC_CAST_TO_VOID_PTR
 HAVE_CPP_PARTIAL_SPECIALIZATION
-NEED_CPP_UNUSED_IMPLEMENTATIONS
 HAVE_GETPAGESIZE
 HAVE_ICONV
 HAVE_ICONV_WITH_CONST_INPUT

dom/xul/templates/nsTemplateMatch.cpp

@@ -6,11 +6,6 @@
 #include "nsTemplateMatch.h"
 #include "nsTemplateRule.h"
 
-#ifdef NEED_CPP_UNUSED_IMPLEMENTATIONS
-nsTemplateMatch::nsTemplateMatch(const nsTemplateMatch& aMatch) {}
-void nsTemplateMatch::operator=(const nsTemplateMatch& aMatch) {}
-#endif
-
 // static
 void
 nsTemplateMatch::Destroy(nsTemplateMatch*& aMatch, bool aRemoveResult)

dom/xul/templates/nsTemplateMatch.h

@@ -6,6 +6,7 @@
 #ifndef nsTemplateMatch_h__
 #define nsTemplateMatch_h__
 
+#include "mozilla/Attributes.h"
 #include "nsIContent.h"
 #include "nsIXULTemplateQueryProcessor.h"
 #include "nsIXULTemplateResult.h"
@@ -130,8 +131,8 @@ public:
 
 private:
 
-    nsTemplateMatch(const nsTemplateMatch& aMatch); // not to be implemented
-    void operator=(const nsTemplateMatch& aMatch); // not to be implemented
+    nsTemplateMatch(const nsTemplateMatch& aMatch) MOZ_DELETE;
+    void operator=(const nsTemplateMatch& aMatch) MOZ_DELETE;
 };
 
 #endif // nsTemplateMatch_h__

js/src/configure.in

@@ -2647,21 +2647,6 @@ if test "$ac_cv_cpp_dynamic_cast_void_ptr" = yes ; then
 fi
 
 
-dnl note that this one is reversed - if the test fails, then
-dnl we require implementations of unused virtual methods. Which
-dnl really blows because it means we'll have useless vtable
-dnl bloat.
-AC_CACHE_CHECK(whether C++ requires implementation of unused virtual methods,
-               ac_cv_cpp_unused_required,
-               [AC_TRY_LINK(class X {private: virtual void never_called();};,
-                               X x;,
-                               ac_cv_cpp_unused_required=no,
-                               ac_cv_cpp_unused_required=yes)])
-if test "$ac_cv_cpp_unused_required" = yes ; then
-   AC_DEFINE(NEED_CPP_UNUSED_IMPLEMENTATIONS)
-fi
-
-
 # try harder, when checking for __thread support, see bug 521750 comment #33 and below
 # We pass MOZ_OPTIMIZE_LDFLAGS to the linker because if dead_strip is
 # enabled, the linker in xcode 4.1 will crash. Without this it would crash when

xpcom/xpcom-config.h.in

@@ -18,11 +18,6 @@
 /* Define if a dyanmic_cast to void* gives the most derived object */
 #undef HAVE_CPP_DYNAMIC_CAST_TO_VOID_PTR
 
-/* Define if the c++ compiler requires implementations of 
- * unused virtual methods
- */
-#undef NEED_CPP_UNUSED_IMPLEMENTATIONS
-
 /* Define to either __attribute__((malloc)) or nothing */
 #undef NS_ATTR_MALLOC