corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1661534 - Remove the "Clear Cookies and Site Data" button in the site identity panel for moz-extension pages. r=prathiksha

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D111192
This commit is contained in:
Liz Krane
2021-04-15 09:11:40 +00:00
parent 3cedc659d1
commit 8befb4fcf3
3 changed files with 84 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
browser/base/content/browser-siteIdentity.js
View File

@@ -930,9 +930,10 @@ var gIdentityHandler = {
*/
refreshIdentityPopup() {
// Update cookies and site data information and show the
// "Clear Site Data" button if the site is storing local data.
// "Clear Site Data" button if the site is storing local data, and
// if the page is not controlled by a WebExtension.
this._clearSiteDataFooter.hidden = true;
if (this._uriHasHost) {
if (this._uriHasHost && !this._pageExtensionPolicy) {
SiteDataManager.hasSiteData(this._uri.asciiHost).then(hasData => {
this._clearSiteDataFooter.hidden = !hasData;
});

1
browser/base/content/test/siteIdentity/browser.ini
View File

@@ -57,6 +57,7 @@ support-files =
file_csp_block_all_mixedcontent.html
[browser_identityPopup_clearSiteData.js]
skip-if = (os == "linux" && bits == 64) # Bug 1577395
[browser_identityPopup_clearSiteData_extensions.js]
[browser_identityPopup_custom_roots.js]
[browser_identityPopup_focus.js]
[browser_identityPopup_HttpsOnlyMode.js]

80
browser/base/content/test/siteIdentity/browser_identityPopup_clearSiteData_extensions.js Normal file
View File

@@ -0,0 +1,80 @@
/* -*- Mode: indent-tabs-mode: nil; js-indent-level: 2 -*- */
/* vim: set sts=2 sw=2 et tw=80: */
/* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
/*
* Test for Bug 1661534 - Extension page: "Clear Cookies and Site Data"
* does nothing.
*
* Expected behavior: when viewing a page controlled by a WebExtension,
* the "Clear Cookies and Site Data..." button should not be visible.
*/
add_task(async function testClearSiteDataFooterHiddenForExtensions() {
// Create an extension that opens an options page
let extension = ExtensionTestUtils.loadExtension({
useAddonManager: "temporary",
manifest: {
permissions: ["tabs"],
options_ui: {
page: "options.html",
open_in_tab: true,
},
},
files: {
"options.html": `<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
</head>
<body>
<h1>This is a test options page for a WebExtension</h1>
</body>
</html>`,
},
async background() {
await browser.runtime.openOptionsPage();
browser.test.sendMessage("optionsopened");
},
});
// Run the extension and wait until its options page has finished loading
let browser = gBrowser.selectedBrowser;
let browserLoadedPromise = BrowserTestUtils.browserLoaded(browser);
await extension.startup();
await extension.awaitMessage("optionsopened");
await browserLoadedPromise;
await SpecialPowers.spawn(browser, [], () => {
ok(
content.document.documentURI.startsWith("moz-extension://"),
"Extension page has now finished loading in the browser window"
);
});
// Open the site identity popup
let { gIdentityHandler } = gBrowser.ownerGlobal;
let promisePanelOpen = BrowserTestUtils.waitForEvent(
gBrowser.ownerGlobal,
"popupshown",
true,
event => event.target == gIdentityHandler._identityPopup
);
gIdentityHandler._identityIconBox.click();
await promisePanelOpen;
let clearSiteDataFooter = document.getElementById(
"identity-popup-clear-sitedata-footer"
);
ok(
clearSiteDataFooter.hidden,
"The clear site data footer is hidden on a WebExtension page."
);
// Unload the extension
await extension.unload();
});