Bug 1913624 - Remove expired telemetry histograms IPC_SAME_PROCESS_MESSAGE_COPY_OOM_KB and IPC_SYNC_MESSAGE_MANAGER_LATENCY_MS, r=TravisLong.
Depends on D219481 Differential Revision: https://phabricator.services.mozilla.com/D219482
This commit is contained in:
@@ -541,22 +541,10 @@ void nsFrameMessageManager::SendSyncMessage(JSContext* aCx,
|
||||
|
||||
nsTArray<StructuredCloneData> retval;
|
||||
|
||||
TimeStamp start = TimeStamp::Now();
|
||||
sSendingSyncMessage = true;
|
||||
bool ok = mCallback->DoSendBlockingMessage(aMessageName, data, &retval);
|
||||
sSendingSyncMessage = false;
|
||||
|
||||
uint32_t latencyMs = round((TimeStamp::Now() - start).ToMilliseconds());
|
||||
if (latencyMs >= kMinTelemetrySyncMessageManagerLatencyMs) {
|
||||
NS_ConvertUTF16toUTF8 messageName(aMessageName);
|
||||
// NOTE: We need to strip digit characters from the message name in order to
|
||||
// avoid a large number of buckets due to generated names from addons (such
|
||||
// as "ublock:sb:{N}"). See bug 1348113 comment 10.
|
||||
messageName.StripTaggedASCII(ASCIIMask::Mask0to9());
|
||||
Telemetry::Accumulate(Telemetry::IPC_SYNC_MESSAGE_MANAGER_LATENCY_MS,
|
||||
messageName, latencyMs);
|
||||
}
|
||||
|
||||
if (!ok) {
|
||||
return;
|
||||
}
|
||||
@@ -1633,8 +1621,6 @@ nsSameProcessAsyncMessageBase::nsSameProcessAsyncMessageBase()
|
||||
nsresult nsSameProcessAsyncMessageBase::Init(const nsAString& aMessage,
|
||||
StructuredCloneData& aData) {
|
||||
if (!mData.Copy(aData)) {
|
||||
Telemetry::Accumulate(Telemetry::IPC_SAME_PROCESS_MESSAGE_COPY_OOM_KB,
|
||||
aData.DataLength());
|
||||
return NS_ERROR_OUT_OF_MEMORY;
|
||||
}
|
||||
|
||||
|
||||
@@ -61,10 +61,6 @@ namespace ipc {
|
||||
class MessageManagerCallback;
|
||||
class WritableSharedMap;
|
||||
|
||||
// Note: we round the time we spend to the nearest millisecond. So a min value
|
||||
// of 1 ms actually captures from 500us and above.
|
||||
static const uint32_t kMinTelemetrySyncMessageManagerLatencyMs = 1;
|
||||
|
||||
enum class MessageManagerFlags {
|
||||
MM_NONE = 0,
|
||||
MM_CHROME = 1,
|
||||
|
||||
@@ -9851,16 +9851,6 @@
|
||||
"kind": "boolean",
|
||||
"description": "True when an IPC transaction is canceled"
|
||||
},
|
||||
"IPC_SAME_PROCESS_MESSAGE_COPY_OOM_KB": {
|
||||
"record_in_processes": ["main", "content"],
|
||||
"products": ["firefox", "fennec"],
|
||||
"expires_in_version": "50",
|
||||
"kind": "exponential",
|
||||
"low": 100,
|
||||
"high": 10000000,
|
||||
"n_buckets": 10,
|
||||
"description": "Whenever the same-process MessageManager cannot be sent through sendAsyncMessage as it would cause an OOM, the size of the message content, in kb."
|
||||
},
|
||||
"SEARCH_COUNTS": {
|
||||
"record_in_processes": ["main", "content"],
|
||||
"products": ["firefox", "fennec"],
|
||||
@@ -14306,19 +14296,6 @@
|
||||
"bug_numbers": [1341531],
|
||||
"description": "Time (ms) for the keyboard event to dispatch, but before handlers executing."
|
||||
},
|
||||
"IPC_SYNC_MESSAGE_MANAGER_LATENCY_MS": {
|
||||
"record_in_processes": ["main", "content"],
|
||||
"products": ["firefox", "fennec"],
|
||||
"alert_emails": ["nika@thelayzells.com"],
|
||||
"bug_numbers": [1348113],
|
||||
"expires_in_version": "70",
|
||||
"kind": "exponential",
|
||||
"low": 32,
|
||||
"high": 750,
|
||||
"n_buckets": 40,
|
||||
"keyed": true,
|
||||
"description": "Measures the number of milliseconds we spend waiting for sync message manager IPC messages to finish sending, keyed by message name. Note: only messages that wait for more than 500 microseconds are included in this probe."
|
||||
},
|
||||
"TIME_TO_DOM_LOADING_MS": {
|
||||
"record_in_processes": ["content"],
|
||||
"products": ["firefox", "fennec"],
|
||||
|
||||
@@ -94,7 +94,6 @@
|
||||
"HTTP_TRANSACTION_USE_ALTSVC",
|
||||
"HTTP_TRANSACTION_USE_ALTSVC_OE",
|
||||
"INNERWINDOWS_WITH_MUTATION_LISTENERS",
|
||||
"IPC_SAME_PROCESS_MESSAGE_COPY_OOM_KB",
|
||||
"IPV4_AND_IPV6_ADDRESS_CONNECTIVITY",
|
||||
"LOCALDOMSTORAGE_PRELOAD_PENDING_ON_FIRST_ACCESS",
|
||||
"LOCALDOMSTORAGE_SHUTDOWN_DATABASE_MS",
|
||||
@@ -371,7 +370,6 @@
|
||||
"IMAGE_DECODE_SPEED_PNG",
|
||||
"IMAGE_DECODE_TIME",
|
||||
"INNERWINDOWS_WITH_MUTATION_LISTENERS",
|
||||
"IPC_SAME_PROCESS_MESSAGE_COPY_OOM_KB",
|
||||
"IPC_TRANSACTION_CANCEL",
|
||||
"IPV4_AND_IPV6_ADDRESS_CONNECTIVITY",
|
||||
"LOCALDOMSTORAGE_PRELOAD_PENDING_ON_FIRST_ACCESS",
|
||||
|
||||
Reference in New Issue
Block a user