Bug 1931874, part 2 - Change MOZ_DIAGNOSTIC_ASSERT(false) to MOZ_DIAGNOSTIC_CRASH. r=necko-reviewers,bwc,dom-worker-reviewers,gfx-reviewers,jld,aosmond,smaug,valentin

Differential Revision: https://phabricator.services.mozilla.com/D229942

dom/serviceworkers/ServiceWorkerScriptCache.cpp

@@ -1388,7 +1388,7 @@ void CompareManager::ResolvedCallback(JSContext* aCx,
       }
       return;
     default:
-      MOZ_DIAGNOSTIC_ASSERT(false);
+      MOZ_DIAGNOSTIC_CRASH("Missing case in CompareManager::ResolvedCallback");
   }
 }
 
@@ -1412,7 +1412,7 @@ void CompareManager::RejectedCallback(JSContext* aCx,
       NS_WARNING("Could not write to cache.");
       break;
     default:
-      MOZ_DIAGNOSTIC_ASSERT(false);
+      MOZ_DIAGNOSTIC_CRASH("Missing case in CompareManager::RejectedCallback");
   }
 
   Fail(NS_ERROR_FAILURE);

gfx/layers/client/TextureClient.cpp

@@ -1768,8 +1768,8 @@ already_AddRefed<TextureReadLock> TextureReadLock::Deserialize(
       return nullptr;
     }
     default: {
-      // Invalid descriptor.
-      MOZ_DIAGNOSTIC_ASSERT(false);
+      MOZ_DIAGNOSTIC_CRASH(
+          "Invalid descriptor in TextureReadLock::Deserialize");
     }
   }
   return nullptr;

netwerk/dns/TRR.cpp

@@ -352,7 +352,7 @@ nsresult TRR::SendHTTPRequest() {
         LOG(("TRR::SendHTTPRequest use conn info:%s\n",
              trrConnInfo->HashKey().get()));
       } else {
-        MOZ_DIAGNOSTIC_ASSERT(false);
+        MOZ_DIAGNOSTIC_CRASH("host not equal to trrConnInfo origin");
       }
     } else {
       TRRService::Get()->InitTRRConnectionInfo();

netwerk/ipc/ChannelEventQueue.cpp

@@ -61,7 +61,7 @@ void ChannelEventQueue::FlushQueue() {
     if (NS_WARN_IF(NS_FAILED(rv))) {
       // Simply run this event on current thread if we are not sure about it
       // in release channel, or assert in Aurora/Nightly channel.
-      MOZ_DIAGNOSTIC_ASSERT(false);
+      MOZ_DIAGNOSTIC_CRASH("IsOnCurrentThread failed");
       isCurrentThread = true;
     }
 

netwerk/sctp/datachannel/DataChannel.cpp

@@ -212,7 +212,7 @@ class DataChannelRegistry {
     MOZ_DIAGNOSTIC_ASSERT(NS_IsMainThread());
 
     if (NS_WARN_IF(!mConnections.empty())) {
-      MOZ_DIAGNOSTIC_ASSERT(false);
+      MOZ_DIAGNOSTIC_CRASH("mConnections not empty");
       mConnections.clear();
     }
 

security/sandbox/linux/launch/SandboxLaunch.cpp

@@ -688,7 +688,7 @@ void SandboxLaunch::StartChrootServer() {
   caps.Effective(CAP_SYS_CHROOT) = true;
   if (!caps.SetCurrent()) {
     SANDBOX_LOG_ERRNO("capset (chroot helper)");
-    MOZ_DIAGNOSTIC_ASSERT(false);
+    MOZ_DIAGNOSTIC_CRASH("caps.SetCurrent() failed");
   }
 
   base::CloseSuperfluousFds(this, [](void* aCtx, int aFd) {

toolkit/components/browser/nsWebBrowser.cpp

@@ -861,7 +861,7 @@ nsWebBrowser::InitWindow(nsIWidget* aParentWidget, int32_t aX, int32_t aY,
                          int32_t aCX, int32_t aCY) {
   // nsIBaseWindow::InitWindow and nsIBaseWindow::Create
   // implementations have been merged into nsWebBrowser::Create
-  MOZ_DIAGNOSTIC_ASSERT(false);
+  MOZ_DIAGNOSTIC_CRASH("Superceded by nsWebBrowser::Create()");
   return NS_ERROR_NULL_POINTER;
 }