corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1960362 - Don't print non ascii value as %c in ContainerParser.cpp. r=media-playback-reviewers,alwu

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D245431
This commit is contained in:
Paul Adenot
2025-04-14 17:41:27 +00:00
parent 205834c6de
commit 7fcedb3ad5
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
dom/media/mediasource/ContainerParser.cpp
View File

@@ -435,9 +435,19 @@ class MP4ContainerParser : public ContainerParser,
const uint8_t* typec = reader.Peek(4);
MOZ_TRY_VAR(tmp, reader.ReadU32());
AtomType type(tmp);
MSE_DEBUGVEX(&aParser, "Checking atom:'%c%c%c%c' @ %u", typec[0],
typec[1], typec[2], typec[3],
(uint32_t)reader.Offset() - 8);
// We've seen fourcc not being ASCII in the wild. In this rare case,
// print hex values instead of the ascii representation.
if (isprint(typec[0]) && isprint(typec[1]) && isprint(typec[2]) &&
isprint(typec[3])) {
MSE_DEBUGVEX(&aParser, "Checking atom:'%c%c%c%c' @ %u", typec[0],
typec[1], typec[2], typec[3],
(uint32_t)reader.Offset() - 8);
} else {
MSE_DEBUGVEX(&aParser,
"Checking atom (not ASCII):'0x%02x%02x%02x%02x' @ %u",
typec[0], typec[1], typec[2], typec[3],
(uint32_t)reader.Offset() - 8);
}
if (std::find(std::begin(validBoxes), std::end(validBoxes), type) ==
std::end(validBoxes)) {
// No valid box found, no point continuing.