Bug 1167493 - Application Reputation: disable remote lookup of zip files on Mac/Linux, r=gcp

This commit is contained in:
Francois Marier
2015-05-23 20:05:37 +12:00
parent 0734964a0c
commit 68f4f6b51c

View File

@@ -384,6 +384,10 @@ PendingLookup::IsBinaryFile()
NS_ConvertUTF16toUTF8(fileName).get(), this));
return
// From https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/safe_browsing/download_protection_util.cc&l=14
// Archives _may_ contain binaries
#ifdef XP_WIN // disable on Mac/Linux, see 1167493
StringEndsWith(fileName, NS_LITERAL_STRING(".zip")) ||
#endif
// Android extensions
StringEndsWith(fileName, NS_LITERAL_STRING(".apk")) ||
// Windows extensions
@@ -404,9 +408,7 @@ PendingLookup::IsBinaryFile()
StringEndsWith(fileName, NS_LITERAL_STRING(".app")) ||
StringEndsWith(fileName, NS_LITERAL_STRING(".dmg")) ||
StringEndsWith(fileName, NS_LITERAL_STRING(".osx")) ||
StringEndsWith(fileName, NS_LITERAL_STRING(".pkg")) ||
// Archives _may_ contain binaries
StringEndsWith(fileName, NS_LITERAL_STRING(".zip"));
StringEndsWith(fileName, NS_LITERAL_STRING(".pkg"));
}
ClientDownloadRequest::DownloadType