corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1993351 - Set selection as dirty when unbinding from frame a=pascalc

Browse Source 
Original Revision: https://phabricator.services.mozilla.com/D268527

Differential Revision: https://phabricator.services.mozilla.com/D269124
This commit is contained in:
Kagami Sascha Rosylight
2025-10-29 19:30:40 +00:00
committed by rvandermeulen@mozilla.com
parent 2c2503b6e6
commit 6055a6e562
2 changed files with 37 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
dom/html/TextControlState.cpp
View File

@@ -2488,6 +2488,12 @@ void TextControlState::UnbindFromFrame(nsTextControlFrame* aFrame) {
DebugOnly<bool> ok = SetValue(value, ValueSetterOption::ByInternalAPI);
// TODO Find something better to do if this fails...
NS_WARNING_ASSERTION(ok, "SetValue() couldn't allocate memory");
// And mark the selection as dirty to make sure the selection will be
// restored properly in RestoreSelectionState. See bug 1993351.
if (IsSelectionCached()) {
SelectionProperties& props = GetSelectionProperties();
props.SetIsDirty();
}
}
}

31
testing/web-platform/tests/html/semantics/forms/the-textarea-element/selection-after-whitespace-change.html Normal file
View File

@@ -0,0 +1,31 @@
<!DOCTYPE html>
<meta charset="utf-8">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/resources/testdriver-actions.js"></script>
<textarea id="t" style="white-space: nowrap">Hello</textarea>
<script>
promise_test(async () => {
t.focus();
if (navigator.userAgent.includes("Mac")) {
// Meta+ArrowLeft
await new test_driver.Actions()
.keyDown("\uE03D")
.keyDown("\uE058")
.keyUp("\uE058")
.keyUp("\uE03D")
.send();
} else {
// Home
await test_driver.send_keys(t, ["\uE011"]);
}
// And then Delete
await test_driver.send_keys(t, ["\uE017"]);
t.style.whiteSpace = "pre-line";
await new Promise(setTimeout);
assert_equals(t.selectionStart, 0, "selectionStart should remain 0");
assert_equals(t.selectionEnd, 0, "selectionEnd should remain 0");
}, "Changing white-space should not change selection");
</script>