Bug 1963704 - Remove unused 'uitour-tag' ping r=pdahiya,omc-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D248645
This commit is contained in:
Chris H-C
2025-05-14 15:20:04 +00:00
committed by chutten@mozilla.com
parent 1a609b15b4
commit 5d6dd3b7e6
3 changed files with 6 additions and 60 deletions

View File

@@ -16,7 +16,6 @@ ChromeUtils.defineESModuleGetters(lazy, {
PanelMultiView: "resource:///modules/PanelMultiView.sys.mjs",
ProfileAge: "resource://gre/modules/ProfileAge.sys.mjs",
ResetProfile: "resource://gre/modules/ResetProfile.sys.mjs",
TelemetryController: "resource://gre/modules/TelemetryController.sys.mjs",
UIState: "resource://services-sync/UIState.sys.mjs",
UpdateUtils: "resource://gre/modules/UpdateUtils.sys.mjs",
});
@@ -541,10 +540,6 @@ export var UITour = {
let name = data.name;
let value = data.value;
Services.prefs.setStringPref("browser.uitour.treatment." + name, value);
// The notification is only meant to be used in tests.
UITourHealthReport.recordTreatmentTag(name, value).then(() =>
this.notify("TreatmentTag:TelemetrySent")
);
break;
}
@@ -2014,26 +2009,3 @@ export var UITour = {
};
UITour.init();
/**
* UITour Health Report
*/
/**
* Public API to be called by the UITour code
*/
const UITourHealthReport = {
recordTreatmentTag(tag, value) {
return lazy.TelemetryController.submitExternalPing(
"uitour-tag",
{
version: 1,
tagName: tag,
tagValue: value,
},
{
addClientId: true,
addEnvironment: true,
}
);
},
};

View File

@@ -8,8 +8,6 @@ var gContentAPI;
ChromeUtils.defineESModuleGetters(this, {
ProfileAge: "resource://gre/modules/ProfileAge.sys.mjs",
TelemetryArchiveTesting:
"resource://testing-common/TelemetryArchiveTesting.sys.mjs",
UpdateUtils: "resource://gre/modules/UpdateUtils.sys.mjs",
CustomizableUITestUtils:
"resource://testing-common/CustomizableUITestUtils.sys.mjs",
@@ -684,33 +682,9 @@ var tests = [
);
}),
taskify(async function test_treatment_tag() {
let ac = new TelemetryArchiveTesting.Checker();
await ac.promiseInit();
await gContentAPI.setTreatmentTag("foobar", "baz");
// Wait until the treatment telemetry is sent before looking in the archive.
await BrowserTestUtils.waitForContentEvent(
gTestTab.linkedBrowser,
"mozUITourNotification",
false,
event => event.detail.event === "TreatmentTag:TelemetrySent"
);
await new Promise(resolve => {
gContentAPI.getTreatmentTag("foobar", data => {
is(data.value, "baz", "set and retrieved treatmentTag");
ac.promiseFindPing("uitour-tag", [
[["payload", "tagName"], "foobar"],
[["payload", "tagValue"], "baz"],
]).then(
found => {
ok(found, "Telemetry ping submitted for setTreatmentTag");
resolve();
},
err => {
ok(false, "Exception finding uitour telemetry ping: " + err);
resolve();
}
);
});
await gContentAPI.getTreatmentTag("foobar", data => {
is(data.value, "baz", "set and retrieved treatmentTag");
});
}),

View File

@@ -1,6 +1,8 @@
"uitour-tag" ping
=================
"uitour-tag" ping (obsolete)
============================
Removed in Firefox v140 via bug 1963704.
This ping is submitted via the UITour ``setTreatmentTag`` API. It may be used by
the tour to record what settings were made by a user or to track the result of
@@ -22,5 +24,3 @@ Structure:
tagValue: <string>
}
}
See also: :doc:`common ping fields <common-ping>`